[{"id":3670460,"web_url":"http://patchwork.ozlabs.org/comment/3670460/","msgid":"","list_archive_url":null,"date":"2026-03-27T16:56:59","subject":"Re: [PATCH v2] target/arm: Don't skip access flag fault for\n AccessType_AT","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 24 Mar 2026 at 16:04, Zenghui Yu wrote:\n>\n> As per the pseudo code from DDI0487 M.a.a (on J1-16021) AArch64.S1Walk():\n>\n> // Check descriptor AF bit\n> elsif (descriptor<10> == '0' && walkparams.ha == '0' &&\n> (!accdesc.acctype IN {AccessType_DC, AccessType_IC} ||\n> boolean IMPLEMENTATION_DEFINED \"Generate access flag fault on IC/DC operations\")) then\n> fault.statuscode = Fault_AccessFlag;\n>\n> an access flag fault should be generated for AccessType_AT, if the AF bit\n> is 0 and !param.ha.\n>\n> Besides, we should continue to not raise the access flag fault for\n> in_debug = true which is what we've been doing previously (before commit\n> efebeec13d07) for LPAE and is what intention of the debugger access\n> codepath is.\n>\n> Fixes: efebeec13d07 (\"target/arm: Skip AF and DB updates for AccessType_AT\")\n> Signed-off-by: Zenghui Yu \n> ---\n> * From v1 [1]:\n> - handles in_debug = true (Peter)\n\n\n\nApplied to target-arm.next, thanks.\n\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=n/QAz/+f;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fj6JZ0Qhwz1y1x\n\tfor ; Sat, 28 Mar 2026 03:57:34 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w6AUm-0004qf-EO; Fri, 27 Mar 2026 12:57:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w6AUl-0004qI-BK\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 12:57:15 -0400","from mail-yx1-xb133.google.com ([2607:f8b0:4864:20::b133])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w6AUj-0006bo-DA\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 12:57:14 -0400","by mail-yx1-xb133.google.com with SMTP id\n 956f58d0204a3-64e9f9226a7so2598383d50.2\n for ; Fri, 27 Mar 2026 09:57:12 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1774630632; cv=none;\n d=google.com; s=arc-20240605;\n b=ROpufOvUZa02v0NFxODBhD/mE6YkZDINxfY1Zg3g9/H2vGSe8iS0nhZ1zFoGIz5zsm\n HCOf+3/awsxnHTwflhKa3IGGNSiqXnFjwJOKJQDW6zE6secs5JKLy3XKY+YQM9OkbQfU\n ObX7aAw80KK4I+7A5pmnu5wcFttO/REgfyTCP7KzNtRdfi9cTr+WjXe3FnOO740XffmS\n NKlcVAoZpAC1lYmvbO62iFqeeVPpFc7ppsBAblHcO3B1L1k1uv7Ct7SqSDEY5fj2EyAe\n jy4hstfvX2s7lUoT2K0Fek6mtLAtN1KYfOP1trrj2yWJvObR+p8gpwChy6HS9xnOK5KL\n KEyQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=7JCGMQMhzFkGK+dxoPGks94i+If7ffYjM8LNI+e86ZE=;\n fh=DBdXKgGbYCjlI5v6YfZN5u+jD7QU7Pf5o6Muim6VRog=;\n b=f4Y1Lm+gffoSGkrgPtFITyIKulhfSb5UByIA4GzIia8GErMgRi0NFv0LyC+FErORix\n 6EZqEJ0QdBUiY7RbQvJORJ9a984KmoT+ZGle/W1L2ymbsXlrDJ5zIxKOPEwnWCgDYaQx\n qbPkTPvItpabSA/9H7RWyNzqEi5BebMvjd/nEse6nLo7mDtMa9GoN4xNwt0dnsWlQx6Q\n +lgHfguDYxbcyNDzFtmvLpTJUsPIasR4E5Ex/ltVLHfd3DVh3S4TikS4D5/VbOeIueiC\n JWh8VeXKnQizLQ3KnsODaAuGyw2d+aYeheJXd+ywZ2lrw18nrmGXQm3uCRJT9cMkYdI/\n 2oTw==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774630632; x=1775235432; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=7JCGMQMhzFkGK+dxoPGks94i+If7ffYjM8LNI+e86ZE=;\n b=n/QAz/+fNmRBiukivYdKxiQuCJSX0VTxsCzhaiLPX2xm+vy4D4m6rk9julOvOhDvjq\n ryNUKefN12nD5v3mmsYNBWt54nMT5SAQBwnmXp/D0xjOruyItwhrD8/WsrAbgp9f38Od\n UgJhwyR5qVgSLAODiiihaxKjkY1VHbC1GjhdZiLD4gxdoCQ7xydcxRZBMs8KtXja8W6T\n DC9qvMIBV3SfAR3XvLccKYl5usb4rc6NJT+z1NN7dkBhf1wJCY+yhDNA7bysOst/kLGm\n 08jiAKJIselhjgsZqNtOAPjmm89rP7XbjKSNYSIwi+8OEk4m4ObI02UFoFhWMkBk3AEk\n ptDA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774630632; x=1775235432;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7JCGMQMhzFkGK+dxoPGks94i+If7ffYjM8LNI+e86ZE=;\n b=nKZAEAaEixfHjXaggBKEHXPkCqAlpBv7HPb2AE/ZAn0BajpUF8DmC3sCZj+ac/bzU+\n 1YQyIPSh0UFwtDAdOfonPUCvAlErdtQGOy1rdUMulBobI0t5v8WAx2jBJNTZDQh9OFbJ\n jisRvYlHLw4LZN+Z4zN9waCGBB8/Qu7R2h8MqbE8v2xIM8BA+0/x3ey1JiFokmulGSyh\n sXCfYTGekrH35jTLXcsAVg6tH/Dd2q2kk/4p0bNqcPvl4GliA7DUDc/BcmYkDsXf9gHo\n aanGcQzW0WL6RCFdTFGiW0jd/7k5KW3rxh8b/QpiTJrLqeWYLsZXCa+RFCYhy7vgtCgp\n RMbg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVVzc/CZZ45AfW0Ad+XwF8BSV1W7RNwVswj3e3yZf4OK2DQ8hcoKto5DO8BbH7FBbax3Q4VoZr/0VV0@nongnu.org","X-Gm-Message-State":"AOJu0YwtKvm1fJaLMGFrMAt1Iwo37moWvps4zMUcIH2cDXM+38MAJzOo\n iO1ml6XEexceBf2KocG1/jx9Os0YIv4gl0wN3Csju8R4xR9kqLiZ76Q+oGjMUCp8t6acUXDhP5t\n +35p/v6EcBHRXFo2vpy6ZkLKL/tJb9t0EOi7P11LD7A==","X-Gm-Gg":"ATEYQzzByEU17p9IqMuAhNBbL++J8VeHVDIyIPoq9vt6fk1JRx5ymKC8td/lms0u5jx\n /dgk2eJWGxWKzVxQmWgufV0S/v7VStMzDbulssHOy8W88bgqCyZ0/lr8Cqb7mbncxUHop/kKqCv\n NGNR/jtkjCIHOHzCq0NrHnYtvUnaW5laodsuHs7F1FBNuHXsulI//acZNnKnAXvSZpDvg6mf22X\n AUgmWXYQMBXmoxT8PI/pLTb0IvK8YybS8PI6BBsqgF+czD+gnGYHJKlXF2oZrD6uKS+ez0GKkCd\n DB2PutvwSAC3E7gKXtsAZpMcOOkGYmNSkXsYzaCuU4HuBw4Tm2TMlBugEl9wmH6B6d0mvkYumDJ\n Z+Q==","X-Received":"by 2002:a05:690e:d42:b0:64e:f86e:9de5 with SMTP id\n 956f58d0204a3-64ff720aa0dmr3237265d50.23.1774630631562; Fri, 27 Mar 2026\n 09:57:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20260324160321.96347-1-zenghui.yu@linux.dev>","In-Reply-To":"<20260324160321.96347-1-zenghui.yu@linux.dev>","From":"Peter Maydell ","Date":"Fri, 27 Mar 2026 16:56:59 +0000","X-Gm-Features":"AQROBzDEQXjlEgKgzwmbPbcaIZOCJlaxBRcfJG-JhAlQBwfjFOjwC9GOzdt9F-E","Message-ID":"\n ","Subject":"Re: [PATCH v2] target/arm: Don't skip access flag fault for\n AccessType_AT","To":"Zenghui Yu ","Cc":"qemu-arm@nongnu.org, qemu-devel@nongnu.org, richard.henderson@linaro.org","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b133;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb133.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]