[{"id":3668545,"web_url":"http://patchwork.ozlabs.org/comment/3668545/","msgid":"<ee24874c-fa9f-4685-9ca9-dc2fbadb581f@molgen.mpg.de>","list_archive_url":null,"date":"2026-03-24T15:51:12","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: add 200G_AUI8 PHY\n type definitions and wire them up","submitter":{"id":70275,"url":"http://patchwork.ozlabs.org/api/people/70275/","name":"Paul Menzel","email":"pmenzel@molgen.mpg.de"},"content":"Dear Aleksandr,\n\n\nThank you for your patch.\n\nAm 24.03.26 um 16:35 schrieb Aleksandr Loktionov:\n> ice_link_mode_str_high[] lacks entries for phy_type_high bits 5-14\n> (all 200G PHY types on E825C); ice_dump_phy_type() prints nothing for\n> them when ICE_DBG_LINK is set (e.g. 'ethtool -s ethX msglvl 0x10').\n> The loop also iterates all 64 bits against a 5-entry array - undefined\n> behaviour for any matched bit beyond the end.  Add strings for bits\n> 5-14 and guard the loop with ARRAY_SIZE(), falling back to \"unknown\"\n> for unrecognised bits.\n> \n> ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC (bit 13) and 200G_AUI8 (bit 14)\n> were absent from ice_adminq_cmd.h; ICE_PHY_TYPE_HIGH_MAX_INDEX capped\n> at 12 caused ice_update_phy_type() to skip them entirely, leaving both\n> invisible to 200G speed requests.  Add the definitions and bump\n> MAX_INDEX to 14.\n> \n> Wire the two new types throughout the driver:\n> - ice_get_media_type(): handle all ten 200G phy_type_high values so\n>    E825C ports no longer return ICE_MEDIA_UNKNOWN.  AOC_ACC interfaces\n>    map to FIBER; bare AUI4/AUI8 to DA with cage, else BACKPLANE\n>    (matching existing AUI2/CAUI2 logic); CR4_PAM4 to DA; SR4/FR4/LR4/\n>    DR4 to FIBER; KR4_PAM4 to BACKPLANE.\n> - ice_get_link_speed_based_on_phy_type(): return ICE_AQ_LINK_SPEED_200GB\n>    for both new types so ice_update_phy_type() enables them correctly.\n> - phy_type_high_lkup[13,14]: AUI8 is 8-lane 25G-per-lane; no\n>    200000baseSR8/CR8 ethtool modes exist yet, so approximate with\n>    SR4_Full/CR4_Full - matching AUI4 at indices 11-12.  FIXME once\n>    those link modes land upstream.\n> - ICE_PHY_TYPE_HIGH_MASK_200G: add bits 13-14 for the minimum-speed\n>    floor in ice_mask_min_supported_speeds().\n> \n> Suggested-by: Paul Greenwalt <paul.greenwalt@intel.com>\n> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n> Cc: Simon Horman <horms@kernel.org>\n> Cc: Paul Menzel <pmenzel@molgen.mpg.de>\n> ---\n> v3 -> v4: add ARRAY_SIZE() OOB guard in ice_dump_phy_type(); cover all\n>            ten 200G phy_type_high values in ice_get_media_type(); add FIXME\n>            to lkup[13..14] for missing SR8/CR8 modes; rename subject\n>            fix subject; fix debug enable example (ethtool, not modprobe);\n>            add AUI8 speed mapping, lkup[13-14], MASK_200G bits 13-14,\n>            and AUI8->SR4/CR4 approximation comment\n> v1 -> v2: add ICE_PHY_TYPE_HIGH_MAX_INDEX update\n> ---\n>   .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  4 ++-\n>   drivers/net/ethernet/intel/ice/ice_common.c   | 31 ++++++++++++++++++-\n>   drivers/net/ethernet/intel/ice/ice_ethtool.c  |  4 ++-\n>   drivers/net/ethernet/intel/ice/ice_ethtool.h  |  8 +++++\n>   4 files changed, 44 insertions(+), 3 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n> index 859e9c6..efe985c 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n> +++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n> @@ -1044,7 +1044,9 @@ struct ice_aqc_get_phy_caps {\n>   #define ICE_PHY_TYPE_HIGH_200G_KR4_PAM4\t\tBIT_ULL(10)\n>   #define ICE_PHY_TYPE_HIGH_200G_AUI4_AOC_ACC\tBIT_ULL(11)\n>   #define ICE_PHY_TYPE_HIGH_200G_AUI4\t\tBIT_ULL(12)\n> -#define ICE_PHY_TYPE_HIGH_MAX_INDEX\t\t12\n> +#define ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC\tBIT_ULL(13)\n> +#define ICE_PHY_TYPE_HIGH_200G_AUI8\t\tBIT_ULL(14)\n> +#define ICE_PHY_TYPE_HIGH_MAX_INDEX\t\t14\n>   \n>   struct ice_aqc_get_phy_caps_data {\n>   \t__le64 phy_type_low; /* Use values from ICE_PHY_TYPE_LOW_* */\n> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\n> index ce11fea..2f3a268 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_common.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_common.c\n> @@ -84,6 +84,16 @@ static const char * const ice_link_mode_str_high[] = {\n>   \t[2] = \"100G_CAUI2\",\n>   \t[3] = \"100G_AUI2_AOC_ACC\",\n>   \t[4] = \"100G_AUI2\",\n> +\t[5] = \"200G_CR4_PAM4\",\n> +\t[6] = \"200G_SR4\",\n> +\t[7] = \"200G_FR4\",\n> +\t[8] = \"200G_LR4\",\n> +\t[9] = \"200G_DR4\",\n> +\t[10] = \"200G_KR4_PAM4\",\n> +\t[11] = \"200G_AUI4_AOC_ACC\",\n> +\t[12] = \"200G_AUI4\",\n> +\t[13] = \"200G_AUI8_AOC_ACC\",\n> +\t[14] = \"200G_AUI8\",\n>   };\n>   \n>   /**\n> @@ -107,9 +117,14 @@ ice_dump_phy_type(struct ice_hw *hw, u64 low, u64 high, const char *prefix)\n>   \tice_debug(hw, ICE_DBG_PHY, \"%s: phy_type_high: 0x%016llx\\n\", prefix, high);\n>   \n>   \tfor (u32 i = 0; i < BITS_PER_TYPE(typeof(high)); i++) {\n> -\t\tif (high & BIT_ULL(i))\n> +\t\tif (!(high & BIT_ULL(i)))\n> +\t\t\tcontinue;\n> +\t\tif (i < ARRAY_SIZE(ice_link_mode_str_high))\n>   \t\t\tice_debug(hw, ICE_DBG_PHY, \"%s:   bit(%d): %s\\n\",\n>   \t\t\t\t  prefix, i, ice_link_mode_str_high[i]);\n> +\t\telse\n> +\t\t\tice_debug(hw, ICE_DBG_PHY, \"%s:   bit(%d): unknown\\n\",\n> +\t\t\t\t  prefix, i);\n>   \t}\n>   }\n>   \n> @@ -605,13 +620,25 @@ static enum ice_media_type ice_get_media_type(struct ice_port_info *pi)\n>   \t\tswitch (hw_link_info->phy_type_high) {\n>   \t\tcase ICE_PHY_TYPE_HIGH_100G_AUI2:\n>   \t\tcase ICE_PHY_TYPE_HIGH_100G_CAUI2:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_AUI4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_AUI8:\n>   \t\t\tif (ice_is_media_cage_present(pi))\n>   \t\t\t\treturn ICE_MEDIA_DA;\n>   \t\t\tfallthrough;\n>   \t\tcase ICE_PHY_TYPE_HIGH_100GBASE_KR2_PAM4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_KR4_PAM4:\n>   \t\t\treturn ICE_MEDIA_BACKPLANE;\n>   \t\tcase ICE_PHY_TYPE_HIGH_100G_CAUI2_AOC_ACC:\n>   \t\tcase ICE_PHY_TYPE_HIGH_100G_AUI2_AOC_ACC:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_AUI4_AOC_ACC:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC:\n> +\t\t\treturn ICE_MEDIA_FIBER;\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_CR4_PAM4:\n> +\t\t\treturn ICE_MEDIA_DA;\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_SR4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_FR4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_LR4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_DR4:\n>   \t\t\treturn ICE_MEDIA_FIBER;\n>   \t\t}\n>   \t}\n> @@ -3493,6 +3520,8 @@ u16 ice_get_link_speed_based_on_phy_type(u64 phy_type_low, u64 phy_type_high)\n>   \tcase ICE_PHY_TYPE_HIGH_200G_KR4_PAM4:\n>   \tcase ICE_PHY_TYPE_HIGH_200G_AUI4_AOC_ACC:\n>   \tcase ICE_PHY_TYPE_HIGH_200G_AUI4:\n> +\tcase ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC:\n> +\tcase ICE_PHY_TYPE_HIGH_200G_AUI8:\n>   \t\tspeed_phy_type_high = ICE_AQ_LINK_SPEED_200GB;\n>   \t\tbreak;\n>   \tdefault:\n> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n> index 301947d..beb638c 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n> @@ -2057,7 +2057,9 @@ ice_get_ethtool_stats(struct net_device *netdev,\n>   \t\t\t\t\t ICE_PHY_TYPE_HIGH_200G_DR4 | \\\n>   \t\t\t\t\t ICE_PHY_TYPE_HIGH_200G_KR4_PAM4 | \\\n>   \t\t\t\t\t ICE_PHY_TYPE_HIGH_200G_AUI4_AOC_ACC | \\\n> -\t\t\t\t\t ICE_PHY_TYPE_HIGH_200G_AUI4)\n> +\t\t\t\t\t ICE_PHY_TYPE_HIGH_200G_AUI4 | \\\n> +\t\t\t\t\t ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC | \\\n> +\t\t\t\t\t ICE_PHY_TYPE_HIGH_200G_AUI8)\n>   \n>   /**\n>    * ice_mask_min_supported_speeds\n> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.h b/drivers/net/ethernet/intel/ice/ice_ethtool.h\n> index 23b2cfb..c4732a3 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.h\n> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.h\n> @@ -153,6 +153,14 @@ phy_type_high_lkup[] = {\n>   \t[10] = ICE_PHY_TYPE(200GB, 200000baseKR4_Full),\n>   \t[11] = ICE_PHY_TYPE(200GB, 200000baseSR4_Full),\n>   \t[12] = ICE_PHY_TYPE(200GB, 200000baseCR4_Full),\n> +\t/* 200G_AUI8_AOC_ACC and 200G_AUI8 are 8-lane 25G-per-lane interfaces.\n> +\t * The kernel has no 200000baseSR8/CR8 modes yet; map to the closest\n> +\t * available 4-lane equivalents so ethtool reports 200G as supported.\n> +\t * FIXME: replace with 200000baseSR8_Full / 200000baseCR8_Full once\n> +\t * those ethtool link modes are defined upstream.\n> +\t */\n> +\t[13] = ICE_PHY_TYPE(200GB, 200000baseSR4_Full),\n> +\t[14] = ICE_PHY_TYPE(200GB, 200000baseCR4_Full),\n>   };\n>   \n>   #endif /* !_ICE_ETHTOOL_H_ */\n\nReviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>\n\n\nKind regards,\n\nPaul","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=hhH6tVt2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgF062SSYz1y1g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 02:51:48 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 381FC408AF;\n\tTue, 24 Mar 2026 15:51:46 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Bgz6MM-VIb2f; Tue, 24 Mar 2026 15:51:45 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 6D42940FE6;\n\tTue, 24 Mar 2026 15:51:45 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 13D1B1D3\n for <intel-wired-lan@lists.osuosl.org>; Tue, 24 Mar 2026 15:51:44 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id ED6FF60DA4\n for <intel-wired-lan@lists.osuosl.org>; Tue, 24 Mar 2026 15:51:43 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id EBP1_FBbQJ_d for <intel-wired-lan@lists.osuosl.org>;\n Tue, 24 Mar 2026 15:51:42 +0000 (UTC)","from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 4F1A160D72\n for <intel-wired-lan@lists.osuosl.org>; Tue, 24 Mar 2026 15:51:41 +0000 (UTC)","from [141.14.220.42] (g42.guest.molgen.mpg.de [141.14.220.42])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: pmenzel)\n by mx.molgen.mpg.de (Postfix) with ESMTPSA id 4AAE94C2C37F04;\n Tue, 24 Mar 2026 16:51:13 +0100 (CET)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6D42940FE6","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4F1A160D72"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774367505;\n\tbh=IyIHHCs1gptqdva+jDdfKsXvYoOq14Vk1L+dpI9vWGk=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=hhH6tVt23t+mpP4zTktKyXhKhXuAtejAAGkL+XFvka1EYLdkbU35uUTjY8n3Z3nUv\n\t QIUTo3nq1mKJPk5138MykRkoM+LQ3qw0vLNVKUKaxMc0ZXtSGTshv8j7lizgO3PDWN\n\t UIYCsO6LTxh3L0/wgWQ/KwdLsA5EvHwnJruEWMPk8hChFVuItKzIkCT+HqGIEhA0ap\n\t Aa35GvuUibfcuXQsHXE1cLe23RUOcJ8RuOR4lmwc2dITb5Jv+tqLDEnc67PF/3lURQ\n\t 4AHn1SgJa/Yq3loBwWYnY2KJ5bDslwt2GMuVyqMQJ3GpsQ9VAt2JxjruMuhcxRQcZ3\n\t BvuC/fNSztWow==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=141.14.17.11;\n helo=mx3.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 4F1A160D72","Message-ID":"<ee24874c-fa9f-4685-9ca9-dc2fbadb581f@molgen.mpg.de>","Date":"Tue, 24 Mar 2026 16:51:12 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Aleksandr Loktionov <aleksandr.loktionov@intel.com>","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Paul Greenwalt <paul.greenwalt@intel.com>,\n Simon Horman <horms@kernel.org>","References":"<20260324153542.674859-1-aleksandr.loktionov@intel.com>","Content-Language":"en-US","From":"Paul Menzel <pmenzel@molgen.mpg.de>","In-Reply-To":"<20260324153542.674859-1-aleksandr.loktionov@intel.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Mailman-Original-Authentication-Results":"smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=molgen.mpg.de","Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: add 200G_AUI8 PHY\n type definitions and wire them up","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3670217,"web_url":"http://patchwork.ozlabs.org/comment/3670217/","msgid":"<20260327104732.GB567789@horms.kernel.org>","list_archive_url":null,"date":"2026-03-27T10:47:32","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: add 200G_AUI8 PHY\n type definitions and wire them up","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Tue, Mar 24, 2026 at 04:35:42PM +0100, Aleksandr Loktionov wrote:\n> ice_link_mode_str_high[] lacks entries for phy_type_high bits 5-14\n> (all 200G PHY types on E825C); ice_dump_phy_type() prints nothing for\n> them when ICE_DBG_LINK is set (e.g. 'ethtool -s ethX msglvl 0x10').\n> The loop also iterates all 64 bits against a 5-entry array - undefined\n> behaviour for any matched bit beyond the end.  Add strings for bits\n> 5-14 and guard the loop with ARRAY_SIZE(), falling back to \"unknown\"\n> for unrecognised bits.\n> \n> ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC (bit 13) and 200G_AUI8 (bit 14)\n> were absent from ice_adminq_cmd.h; ICE_PHY_TYPE_HIGH_MAX_INDEX capped\n> at 12 caused ice_update_phy_type() to skip them entirely, leaving both\n> invisible to 200G speed requests.  Add the definitions and bump\n> MAX_INDEX to 14.\n> \n> Wire the two new types throughout the driver:\n> - ice_get_media_type(): handle all ten 200G phy_type_high values so\n>   E825C ports no longer return ICE_MEDIA_UNKNOWN.  AOC_ACC interfaces\n>   map to FIBER; bare AUI4/AUI8 to DA with cage, else BACKPLANE\n>   (matching existing AUI2/CAUI2 logic); CR4_PAM4 to DA; SR4/FR4/LR4/\n>   DR4 to FIBER; KR4_PAM4 to BACKPLANE.\n> - ice_get_link_speed_based_on_phy_type(): return ICE_AQ_LINK_SPEED_200GB\n>   for both new types so ice_update_phy_type() enables them correctly.\n> - phy_type_high_lkup[13,14]: AUI8 is 8-lane 25G-per-lane; no\n>   200000baseSR8/CR8 ethtool modes exist yet, so approximate with\n>   SR4_Full/CR4_Full - matching AUI4 at indices 11-12.  FIXME once\n>   those link modes land upstream.\n> - ICE_PHY_TYPE_HIGH_MASK_200G: add bits 13-14 for the minimum-speed\n>   floor in ice_mask_min_supported_speeds().\n> \n> Suggested-by: Paul Greenwalt <paul.greenwalt@intel.com>\n> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n> Cc: Simon Horman <horms@kernel.org>\n> Cc: Paul Menzel <pmenzel@molgen.mpg.de>\n> ---\n> v3 -> v4: add ARRAY_SIZE() OOB guard in ice_dump_phy_type(); cover all\n>           ten 200G phy_type_high values in ice_get_media_type(); add FIXME\n>           to lkup[13..14] for missing SR8/CR8 modes; rename subject\n>           fix subject; fix debug enable example (ethtool, not modprobe);\n>           add AUI8 speed mapping, lkup[13-14], MASK_200G bits 13-14,\n>           and AUI8->SR4/CR4 approximation comment\n> v1 -> v2: add ICE_PHY_TYPE_HIGH_MAX_INDEX update\n\nThanks for the updates.\n\nReviewed-by: Simon Horman <horms@kernel.org>","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ZekP/kqk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhy5s2b2Qz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 21:47:45 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id BE59D83D17;\n\tFri, 27 Mar 2026 10:47:43 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id EzHKRHf4x21x; Fri, 27 Mar 2026 10:47:41 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9616C83D0E;\n\tFri, 27 Mar 2026 10:47:41 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 815FD2D5\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 10:47:39 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 5F0826128B\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 10:47:39 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 5k_BRgFyYX8G for <intel-wired-lan@lists.osuosl.org>;\n Fri, 27 Mar 2026 10:47:38 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n by smtp3.osuosl.org (Postfix) with ESMTPS id ADD7D6128F\n for <intel-wired-lan@lists.osuosl.org>; Fri, 27 Mar 2026 10:47:38 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 81E516132B;\n Fri, 27 Mar 2026 10:47:36 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E5D73C19423;\n Fri, 27 Mar 2026 10:47:34 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9616C83D0E","OpenDKIM Filter v2.11.0 smtp3.osuosl.org ADD7D6128F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774608461;\n\tbh=jMdsUqHfgnsQkhI2OvQD6m9n3OTU7yZcRoiz6/Uc3Aw=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=ZekP/kqk5cwgqNkXQ3JOShE0kN0dsmX+DYHKSf40Hsg2H3NKk8Je0xY4TYggZT0Xg\n\t f7f+TQlnWCwa+bb/5ooy0fziMolM1pK5gfRDRD+YPrX5Dfpyc7djCfbrauMtig2XkL\n\t 02sNMSaNF8eCqYxPD5LkXpAQMJhU2XLbCNOQ+FiQESk07ODCgMakdCM6ix4j6yqPbS\n\t afG1NID1dEG5MilX/Uh9IDS3cNtfcIajarsAKj+91Fa1jmFbuJzgH0f02Jk27Tnrla\n\t iA6uy2cqJGDfh5MzPUDQIrgXqm+fvjvbUpRnr/kOowDHrEP8e0ZzGauMwfzif3ky2N\n\t dQPRf4AoBasIA==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=horms@kernel.org; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org ADD7D6128F","Date":"Fri, 27 Mar 2026 10:47:32 +0000","From":"Simon Horman <horms@kernel.org>","To":"Aleksandr Loktionov <aleksandr.loktionov@intel.com>","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Paul Greenwalt <paul.greenwalt@intel.com>,\n Paul Menzel <pmenzel@molgen.mpg.de>","Message-ID":"<20260327104732.GB567789@horms.kernel.org>","References":"<20260324153542.674859-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260324153542.674859-1-aleksandr.loktionov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1774608456;\n bh=r8OjbGRJ6dRl5LnFR7ool+5ejKgvKJDtEWK8kYX9IKY=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=i1e2SwED2RVc9xwPFJddwd7l0aG9w8ww3zAFuC3hxAl4vGwrPcmOsoV3toopAjA/7\n E+5SR/x1Bi6ptb/m1EaVXNwOyXx/mtnR3SyJnwAfxbmpV7GOB/RUqXZOZJskYAwM8o\n bebwwg7A737E4jpYTVzge/4LqV+/e4A9dphKhsQYrGb6U2U7cWMQCVoDIimlkS89Om\n 2LTv4rKhkiNHQ9ZHpWVI/KkVAMjojTBwkwEKIqr51YbNYw6CoHqwyOWnPyBBKJfhQ4\n M8ILvVKuT++cygF5tgUmzP9rcHIwFCIRKwnKThBayO+LJG8qLo00FUi2PchnBrGlw7\n pYBAR1dQQZ+CA==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=i1e2SwED"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: add 200G_AUI8 PHY\n type definitions and wire them up","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3671933,"web_url":"http://patchwork.ozlabs.org/comment/3671933/","msgid":"<be397b6a-eb45-4709-b1ae-2eb831441945@intel.com>","list_archive_url":null,"date":"2026-03-31T20:59:37","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: add 200G_AUI8 PHY\n type definitions and wire them up","submitter":{"id":68875,"url":"http://patchwork.ozlabs.org/api/people/68875/","name":"Tony Nguyen","email":"anthony.l.nguyen@intel.com"},"content":"On 3/24/2026 8:35 AM, Aleksandr Loktionov wrote:\n> ice_link_mode_str_high[] lacks entries for phy_type_high bits 5-14\n> (all 200G PHY types on E825C); ice_dump_phy_type() prints nothing for\n> them when ICE_DBG_LINK is set (e.g. 'ethtool -s ethX msglvl 0x10').\n> The loop also iterates all 64 bits against a 5-entry array - undefined\n> behaviour for any matched bit beyond the end.  Add strings for bits\n> 5-14 and guard the loop with ARRAY_SIZE(), falling back to \"unknown\"\n> for unrecognised bits.\n> \n> ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC (bit 13) and 200G_AUI8 (bit 14)\n> were absent from ice_adminq_cmd.h; ICE_PHY_TYPE_HIGH_MAX_INDEX capped\n> at 12 caused ice_update_phy_type() to skip them entirely, leaving both\n> invisible to 200G speed requests.  Add the definitions and bump\n> MAX_INDEX to 14.\n\nI don't believe support for these two types got implemented so I don't \nthink there is need to add them.\n\n> \n> Wire the two new types throughout the driver:\n> - ice_get_media_type(): handle all ten 200G phy_type_high values so\n>    E825C ports no longer return ICE_MEDIA_UNKNOWN.  AOC_ACC interfaces\n>    map to FIBER; bare AUI4/AUI8 to DA with cage, else BACKPLANE\n>    (matching existing AUI2/CAUI2 logic); CR4_PAM4 to DA; SR4/FR4/LR4/\n>    DR4 to FIBER; KR4_PAM4 to BACKPLANE.\n> - ice_get_link_speed_based_on_phy_type(): return ICE_AQ_LINK_SPEED_200GB\n>    for both new types so ice_update_phy_type() enables them correctly.\n> - phy_type_high_lkup[13,14]: AUI8 is 8-lane 25G-per-lane; no\n>    200000baseSR8/CR8 ethtool modes exist yet, so approximate with\n>    SR4_Full/CR4_Full - matching AUI4 at indices 11-12.  FIXME once\n>    those link modes land upstream.\n> - ICE_PHY_TYPE_HIGH_MASK_200G: add bits 13-14 for the minimum-speed\n>    floor in ice_mask_min_supported_speeds().\n> \n> Suggested-by: Paul Greenwalt <paul.greenwalt@intel.com>\n> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n> Cc: Simon Horman <horms@kernel.org>\n> Cc: Paul Menzel <pmenzel@molgen.mpg.de>\n> ---\n> v3 -> v4: add ARRAY_SIZE() OOB guard in ice_dump_phy_type(); cover all\n>            ten 200G phy_type_high values in ice_get_media_type(); add FIXME\n>            to lkup[13..14] for missing SR8/CR8 modes; rename subject\n>            fix subject; fix debug enable example (ethtool, not modprobe);\n>            add AUI8 speed mapping, lkup[13-14], MASK_200G bits 13-14,\n>            and AUI8->SR4/CR4 approximation comment\n> v1 -> v2: add ICE_PHY_TYPE_HIGH_MAX_INDEX update\n> ---\n>   .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  4 ++-\n>   drivers/net/ethernet/intel/ice/ice_common.c   | 31 ++++++++++++++++++-\n>   drivers/net/ethernet/intel/ice/ice_ethtool.c  |  4 ++-\n>   drivers/net/ethernet/intel/ice/ice_ethtool.h  |  8 +++++\n>   4 files changed, 44 insertions(+), 3 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n> index 859e9c6..efe985c 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n> +++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h\n> @@ -1044,7 +1044,9 @@ struct ice_aqc_get_phy_caps {\n>   #define ICE_PHY_TYPE_HIGH_200G_KR4_PAM4\t\tBIT_ULL(10)\n>   #define ICE_PHY_TYPE_HIGH_200G_AUI4_AOC_ACC\tBIT_ULL(11)\n>   #define ICE_PHY_TYPE_HIGH_200G_AUI4\t\tBIT_ULL(12)\n> -#define ICE_PHY_TYPE_HIGH_MAX_INDEX\t\t12\n> +#define ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC\tBIT_ULL(13)\n> +#define ICE_PHY_TYPE_HIGH_200G_AUI8\t\tBIT_ULL(14)\n> +#define ICE_PHY_TYPE_HIGH_MAX_INDEX\t\t14\n>   \n>   struct ice_aqc_get_phy_caps_data {\n>   \t__le64 phy_type_low; /* Use values from ICE_PHY_TYPE_LOW_* */\n> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\n> index ce11fea..2f3a268 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_common.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_common.c\n> @@ -84,6 +84,16 @@ static const char * const ice_link_mode_str_high[] = {\n>   \t[2] = \"100G_CAUI2\",\n>   \t[3] = \"100G_AUI2_AOC_ACC\",\n>   \t[4] = \"100G_AUI2\",\n> +\t[5] = \"200G_CR4_PAM4\",\n> +\t[6] = \"200G_SR4\",\n> +\t[7] = \"200G_FR4\",\n> +\t[8] = \"200G_LR4\",\n> +\t[9] = \"200G_DR4\",\n> +\t[10] = \"200G_KR4_PAM4\",\n> +\t[11] = \"200G_AUI4_AOC_ACC\",\n> +\t[12] = \"200G_AUI4\",\n> +\t[13] = \"200G_AUI8_AOC_ACC\",\n> +\t[14] = \"200G_AUI8\",\n>   };\n>   \n>   /**\n> @@ -107,9 +117,14 @@ ice_dump_phy_type(struct ice_hw *hw, u64 low, u64 high, const char *prefix)\n>   \tice_debug(hw, ICE_DBG_PHY, \"%s: phy_type_high: 0x%016llx\\n\", prefix, high);\n>   \n>   \tfor (u32 i = 0; i < BITS_PER_TYPE(typeof(high)); i++) {\n> -\t\tif (high & BIT_ULL(i))\n> +\t\tif (!(high & BIT_ULL(i)))\n> +\t\t\tcontinue;\n> +\t\tif (i < ARRAY_SIZE(ice_link_mode_str_high))\n>   \t\t\tice_debug(hw, ICE_DBG_PHY, \"%s:   bit(%d): %s\\n\",\n>   \t\t\t\t  prefix, i, ice_link_mode_str_high[i]);\n> +\t\telse\n> +\t\t\tice_debug(hw, ICE_DBG_PHY, \"%s:   bit(%d): unknown\\n\",\n> +\t\t\t\t  prefix, i);\n>   \t}\n>   }\n>   \n> @@ -605,13 +620,25 @@ static enum ice_media_type ice_get_media_type(struct ice_port_info *pi)\n>   \t\tswitch (hw_link_info->phy_type_high) {\n>   \t\tcase ICE_PHY_TYPE_HIGH_100G_AUI2:\n>   \t\tcase ICE_PHY_TYPE_HIGH_100G_CAUI2:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_AUI4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_AUI8:\n>   \t\t\tif (ice_is_media_cage_present(pi))\n>   \t\t\t\treturn ICE_MEDIA_DA;\n>   \t\t\tfallthrough;\n>   \t\tcase ICE_PHY_TYPE_HIGH_100GBASE_KR2_PAM4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_KR4_PAM4:\n>   \t\t\treturn ICE_MEDIA_BACKPLANE;\n>   \t\tcase ICE_PHY_TYPE_HIGH_100G_CAUI2_AOC_ACC:\n>   \t\tcase ICE_PHY_TYPE_HIGH_100G_AUI2_AOC_ACC:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_AUI4_AOC_ACC:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_AUI8_AOC_ACC:\n> +\t\t\treturn ICE_MEDIA_FIBER;\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_CR4_PAM4:\n> +\t\t\treturn ICE_MEDIA_DA;\n\nAny reason we don't put this with the other DAs above...\n\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_SR4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_FR4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_LR4:\n> +\t\tcase ICE_PHY_TYPE_HIGH_200G_DR4:\n>   \t\t\treturn ICE_MEDIA_FIBER;\n\nand these with the other FIBERs?\n\nThanks,\nTony","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=qbe2Uf3t;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flgVL5nNdz1yCp\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 01 Apr 2026 07:59:54 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B478380BA3;\n\tTue, 31 Mar 2026 20:59:52 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id I2WNp_Y4THxb; Tue, 31 Mar 2026 20:59:52 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id DFAE280A79;\n\tTue, 31 Mar 2026 20:59:51 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 81F1625F\n for <intel-wired-lan@lists.osuosl.org>; Tue, 31 Mar 2026 20:59:50 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 683B740F56\n for <intel-wired-lan@lists.osuosl.org>; Tue, 31 Mar 2026 20:59:50 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Mk6BT1DndAAa for <intel-wired-lan@lists.osuosl.org>;\n Tue, 31 Mar 2026 20:59:49 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 75A9C40F6A\n for <intel-wired-lan@lists.osuosl.org>; Tue, 31 Mar 2026 20:59:49 +0000 (UTC)","from fmviesa003.fm.intel.com ([10.60.135.143])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 Mar 2026 13:59:48 -0700","from fmsmsx903.amr.corp.intel.com ([10.18.126.92])\n by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 Mar 2026 13:59:48 -0700","from FMSMSX901.amr.corp.intel.com (10.18.126.90) by\n fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 31 Mar 2026 13:59:48 -0700","from fmsedg902.ED.cps.intel.com (10.1.192.144) by\n FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 31 Mar 2026 13:59:48 -0700","from CH4PR04CU002.outbound.protection.outlook.com (40.107.201.71) by\n edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 31 Mar 2026 13:59:45 -0700","from DS0PR11MB8230.namprd11.prod.outlook.com (2603:10b6:8:158::21)\n by CH2PR11MB8779.namprd11.prod.outlook.com (2603:10b6:610:285::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.15; Tue, 31 Mar\n 2026 20:59:39 +0000","from DS0PR11MB8230.namprd11.prod.outlook.com\n ([fe80::2592:f5a9:a751:be40]) by DS0PR11MB8230.namprd11.prod.outlook.com\n ([fe80::2592:f5a9:a751:be40%4]) with mapi id 15.20.9769.015; Tue, 31 Mar 2026\n 20:59:39 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org DFAE280A79","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 75A9C40F6A"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774990791;\n\tbh=EJkytKdj3xO2CoFB9s7uX007H//WA36iG8SaZUw68OM=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=qbe2Uf3tRIVGDfgdaG0LiM6jkt3PEUwLtruPhtPN/JC4Lu46K2yurtNGv+S0gZkn1\n\t lSbuiLgXqqU9e34D0MlLjtyP1RybJpT/q0VLkd6tNnzs7YIvubvw67/HjU0Amq1PHQ\n\t 5Qtgi2pajQCxS2/2vk7gbyM+LvkL6ZniTi8v9Pt5AoC0c5JOgaOhgSzNoFroz61p1x\n\t bM9+8IKVM0j5rKMyqfWwIHk3h+doj1vuxjMFwPmRqjaB+b3XL7R8k8COiRVi7yGjmH\n\t ZNBAE99u2P3tqCXDH6jnSy+iaY+GPdk6Qv8rAAZv06Cep45SGloFImqZgQmw0orRbW\n\t tBnBfnn46egnQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.11;\n helo=mgamail.intel.com; envelope-from=anthony.l.nguyen@intel.com;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 75A9C40F6A","X-CSE-ConnectionGUID":["LgJnTVfdQl6mWiPSAFKtag==","4ycotK+ESXapKBoDARsMmA=="],"X-CSE-MsgGUID":["obRReuqbRrOfyGQMEnO2sg==","wr8iNMG3Q7exJLSNV1M/8w=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11745\"; a=\"86320525\"","E=Sophos;i=\"6.23,152,1770624000\"; d=\"scan'208\";a=\"86320525\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=O2TXd1x+t+F5FWI72jEDswPvi+/r3ObIXH6Dd7iMPu+chZVaQn/Sf5o8usQrimLSlA0tqjoera9kXjV7UzydAc8lnA9J441fGUuW3XWh93LuEEGjlEplQL70dyTzIiuWnLzRjeHRLSVnGBAh+pFjuPLk6heZsHWwE0oaEBK6AqwYUYfhwShrEFepx+jPrttGWxkTDvIy1Z1nQdMrE4qSf7s168OgfARXgcauXCt4+8bivvXilNgKFb4X/+pDc7owcWCaYJBFSWrhpPiok5trvrJer6CgS+DobaffaeuqWlyPqoU0/U/RmKWXHGJF7E8bTKS/r3HfWk2sc+cdssNu+w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=EJkytKdj3xO2CoFB9s7uX007H//WA36iG8SaZUw68OM=;\n b=L4ZOe1cfm0/H7u2Nj9vUNo4NTrj+cKwSQ5gIhsk5m0+2FxOAfxUWudx3HN4HI+SQ3kKz3KgvyIV3fUZcg9UyHxQm8Hone3zLocU05HTm90t1smpaXAQV6IRYkGVPN7XFyRX5oJWy4L7WXZmjaMAEp9GnhhMYWaTa8ZvgNKKKTEbPF4hNbz/eVrzUvOw0uj/k4Owp3+bRbUc34AOsBpqlMOxLwN5ORRhazWkOT4BQxOp/9Yz1QtVUF4vsm21Ak511zSDw5HfYbkpSaqknjS96pFs9UZtams6dKfZh/sfCELeTf9OK2sglKjgRMAL1sJ7Pwe2hbuCwRKidj8RMLT6AIQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<be397b6a-eb45-4709-b1ae-2eb831441945@intel.com>","Date":"Tue, 31 Mar 2026 13:59:37 -0700","User-Agent":"Mozilla Thunderbird","To":"Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n <intel-wired-lan@lists.osuosl.org>","CC":"<netdev@vger.kernel.org>, Paul Greenwalt <paul.greenwalt@intel.com>,\n \"Simon Horman\" <horms@kernel.org>, Paul Menzel <pmenzel@molgen.mpg.de>","References":"<20260324153542.674859-1-aleksandr.loktionov@intel.com>","Content-Language":"en-US","From":"Tony Nguyen <anthony.l.nguyen@intel.com>","In-Reply-To":"<20260324153542.674859-1-aleksandr.loktionov@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0367.namprd04.prod.outlook.com\n (2603:10b6:303:81::12) To DS0PR11MB8230.namprd11.prod.outlook.com\n (2603:10b6:8:158::21)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB8230:EE_|CH2PR11MB8779:EE_","X-MS-Office365-Filtering-Correlation-Id":"af7578e3-cde7-4f88-2475-08de8f686c73","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|366016|1800799024|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n TNI+YOhiyJ32lApvQL8r30E5jf36FhFp1RwGJ/b7fGgF34E1mw4CQcmpil+pulRe629EiClcPWPgtmQ1i3vs196bUpqC8VkzsXHqB2jKKW2JjwKNKiDcNtfKhLnTACzp1XEuJ4YcPdc2Nd/1GrBW6EGEfaWhyPY9HIrd5NZnJbFfUf06xisSjfCJfr+Db5D4USmLWU9kAq71KEo+95CPuRnR5EltSInPieeA7nR+UP6ya+hR9oi5CqzmWFtuJzztHrnTVGAJPMlh6PCXT41cZu6PM1YAfvpNJ1wHljSwlEOajdLoNeo4Y/cm0O07Ya8NOCIM2b12jCQCvxMhH9wz3CwyqqIIEbxpu9Mc+VfUYfwF/4pyyaXz95zAGooT5whgjdQGadRuVW+5e2IGIBztIJLv+947ayAMXISokYd/DDhff3wT1VREt6vT7B7BsVUBY/Y7Ex4RQEURlrgM2TrRHtS4uG5nSLKPDP9EmCRjNCDNmlTq8lNH8Crkd24TnpXygcPSSbkKK0zZ3Gj9YoVG/MLI7Vwf7mblmHNCbZ+pY6TPPIg3dpFSQ5EoCnCJ7Gf6LunpQ7hEVsGn1Mujdx3JUwsSmF7mr7MKP2M1CyXFK9Ot63+EIvmKZmAYwF3LcHpDOOy2Vskhi2SlRP+MX5kaX+c0P5o+2iwBNWkKoLepESWW1OdJoH8dxsh9ocdZ2hucMMyTvnK1B9kEcq/XqS28pi0dIKqn1w0CuNmxrMPwZi4=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB8230.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?+QgDP/W9nw+3Dd1zp031TW90YKoW?=\n\t=?utf-8?q?3Hh/VjNDcI+QLjPhrsekoHaz9/erpqv2YBCI/rDydd50CjrkIQMabnWSLzTAfgx/2?=\n\t=?utf-8?q?cHOweF+KtXgxvlgXo8gcaEX541f9slWvLhlipJhQOkijheEWvdDsYAPQKTmMJDABi?=\n\t=?utf-8?q?ldxGmy6rUEYkz0EIi7BuxlHRupt7ytSYpjjA9aOEZXn8g7m9xrjsAVZtmRmDuqLud?=\n\t=?utf-8?q?ENtxWxJYID39d//wR2MK2lDPyJlgZly7kNxSUNpe8flbWK9UkGVYPHhjjS6aQRl7S?=\n\t=?utf-8?q?5yzztostmHXLdNlFBttpFl5MF5dsOV61oh0fA+85MjFoHQwBFQ9Ef3Hvy0epbPdW3?=\n\t=?utf-8?q?c3BDF1xehGmmeLLQInZfQSrTa0242anmtxtLnqef4XWocGtPZ7NFtUtmy/Qu2FSFL?=\n\t=?utf-8?q?MKMXCntLb1ulPp05WbQEoGEX0G8PtcEgv6ZvmqSzL1XOdzzdzzT2mmx5g2QugDHvh?=\n\t=?utf-8?q?p5fUqSg/1F4HoKMszY7zZEs99G7jIqwCBcEHMxLkjdCSl64lS03cz7Gxrippm1Z5f?=\n\t=?utf-8?q?UFSYURib3QLp0Yv2+Wnsz99CBqxCJB6CYQ8VszFd8MxSAlcENOuRF9BPdGbOddIFz?=\n\t=?utf-8?q?/d+GZcXDV7v3sO98Cr8/CQtGDB+lHaa6FS58xgNE+OLoGsGfKqUVtyVEpJK8Ze6AB?=\n\t=?utf-8?q?1hSTMFvZQiFL+M98W68Yw8VzuqW3dVM8xIhLzn+NtISyr5XxLtzRch3H4bOLk9puw?=\n\t=?utf-8?q?xuspWbmVljpA8BRQcXZyz3/JsUuKSeRyKHtp+9f7lm+vfOiJS5D5lqAYg3N3VosWh?=\n\t=?utf-8?q?D/LZ8ZIHmBEZWQceQAxmABB+saMM8K1pCJq7ltCNKOXjt9RfK8jB6/rney7mX5N+6?=\n\t=?utf-8?q?uiT1eZzlW+ljHpSQyQ/6P+GCskTgSNQBke6ksuZNHz+thnoylq3+PltpTfEpaW/NK?=\n\t=?utf-8?q?us+Ppqcdu1nKVhJrPsy3pVq+KlE4MxjygtvEXKonECuj7AGvAtXtpe6KR4ErrJlK7?=\n\t=?utf-8?q?aNlOeqhJeiaoGejeMzT8ToyclG5sB5O6vrbbJVJxI3GUi2AWxWxLtq083DslILrqE?=\n\t=?utf-8?q?szojy1rmWW0SoHWcMW2dUvr6X+itnFEAmEmWuyQPT+VxD4vHmP9elRKmuwaeJ9D55?=\n\t=?utf-8?q?jY1lZZD9gAvAaWq3boUUfCr+gWgzsfiFSzPPcZR3t77m+dEl6bJH/M015LGUTZyTY?=\n\t=?utf-8?q?5Kv0eLaOPmN96jbb/81HOY1YTfKd1I30I30bzXxJ0Y8R5KRKbsZ7PbMLPTS/zuwiE?=\n\t=?utf-8?q?9l9Yrk8emmTg7zjnI3pkfWZuUWH+XuYXHYWQAGFf9YxOKqtCoLkaoKFxuPFK/vw+m?=\n\t=?utf-8?q?MNDkbK+HLEmBWSkhKKMkqE1IoX3SIAasoYYQUui+0XiCYTEiv3PgmRkA6KzpXDQij?=\n\t=?utf-8?q?vIH++/Lo6LrAV20yGG2S1BWlJm2GScLm1WBnqB7OmkLPm6fd/4eEMiRGdijGyKSyU?=\n\t=?utf-8?q?UfZzjsgq2TydX1Rvdr0ru0Tb607mCfSKYQefWHfiqyPrOamJZx90EK/zbBiKJ4CBf?=\n\t=?utf-8?q?nemSLVqJWfmUTgUDMWlUzbNKLQ6zOyFXD1FYp3aBgrE8T7PxBM3dox8J/k/9zobuw?=\n\t=?utf-8?q?CZqxXXaDB1Fa7nD3yQWArq7aHo2cS2/vrcFSKApFHWD8sZT4F9MAzC55EjHErS4Qv?=\n\t=?utf-8?q?KOlQ6GmfL8n7jMuzT7DxHx6LF5JbrOqVbu3mxgtWvEGefUop9hlyrkOSzuGu4IfEB?=\n\t=?utf-8?q?g5TeZbAOcchN+2GYZ/3+H2BsG8YBQNiTra49pQfGBswyEwQbEv61k=3D?=","X-Exchange-RoutingPolicyChecked":"\n rrEyLBknGtsVOLjCnMcXS1jAIaWk7RROWUvOEjZRCTMjMlFM0Tgllz7mgkYP5nuu+WYDlIOiq74Umf7ctQeO/QksWwv8fEk/DeGm9UgZMLRh79EeCt3LzYqu2R5uAyvHx1kaH3f5cBGFiWM5Y/9GfW8wxfHJYyffaFwat8/ji71Ar08ZIsYfELNuBjiL/DliuJiJs8UYEJ8zM1N+xp2JG0GFr+lOa+SnIc7qwg0lKvT/D4nLXiGTrtWyVuF4ioMp+Aro09cclYp4+AehBRNPT+V2L7an/mGq0ol6ygBWVZOSrP5/Lnb9NtmjDd1ILOItlj2vt2O5gzeNXe7CpjxoNg==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n af7578e3-cde7-4f88-2475-08de8f686c73","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB8230.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Mar 2026 20:59:39.3976 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n gCZJ55JWv3j5Pd2OZCelLUu4VkywGQo24BAWMr3TQ1qN7DrRYY6IZTPGQCDVsUDoBxi3noZwQtI0RvA5EQw0HUbgREDQqvcE5Mw7yFwbzU0=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH2PR11MB8779","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774990789; x=1806526789;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=iRO0+qAMoKN49lK37sJE0ncgG67+Oy+5TpwT0RWCPaA=;\n b=gSFqTEVs5AqzQv4aH+5JTCiT1COHWlMMuJvb8X6xg1+r2XaMTPCXmctW\n cNhWsYbM8tDvP5zrEHPo2om1N/+9hq9x1zlIrxXcsuIc8L58fBbu7GvxJ\n sJr5KC+l13si3T/LzonuwiCEEeq/is83o2X3ZZpUre99WX/gYS6q4jbUH\n dGpgsnM2fzNZhUmSm7syI9y4T1Rn0BL21RF8xESs7q6I3VnFVTUifNCvy\n spct+9E5tP71+QJVIa+pjIes1235tEWtgueUraN5T3gR+NY/uNJX42hOa\n fZxGA8mFaYTRdEe3wOKnt1c7EcF7DvZ6GYpe/aJCBBfLXGh4mr/0G22Wm\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=gSFqTEVs","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: add 200G_AUI8 PHY\n type definitions and wire them up","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}}]