[{"id":3668394,"web_url":"http://patchwork.ozlabs.org/comment/3668394/","msgid":"","list_archive_url":null,"date":"2026-03-24T13:02:03","subject":"Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor\n sysctl vars","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/people/1025/","name":"Florian Westphal","email":"fw@strlen.de"},"content":"Julian Anastasov wrote:\n> +\t\t\t*valp = val;\n> +\t\t\tif (rcu_dereference_protected(ipvs->conn_tab, 1))\n> +\t\t\t\tmod_delayed_work(system_unbound_wq,\n> +\t\t\t\t\t\t &ipvs->conn_resize_work, 0);\n\nCan I change this to rcu_access_pointer()?\n\nrcu_dereference_protected( ... , 1)\n\n... always looks like a bug to me, even though its fine here.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11381-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=strlen.de"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fg9RK2SfJz1y1g\n\tfor ; Wed, 25 Mar 2026 00:11:41 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id EB253304E7B7\n\tfor ; Tue, 24 Mar 2026 13:02:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 271493DFC93;\n\tTue, 24 Mar 2026 13:02:39 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BCFC23183F;\n\tTue, 24 Mar 2026 13:02:36 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 778C6605C3; Tue, 24 Mar 2026 14:02:24 +0100 (CET)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774357358; cv=none;\n b=c/kWy9fd0tClnfmmzNzV4xqAvkBur/rJ7I2PeGhkFMOAGCMBp3/hSmAV0WtqEH84/fBFr6JzdGOh6VBHKIXaeTEB6XB6Fq/aB46KQuebwHtwZuQS7//iePWCPJoEgZ6+7AGuvLuS5SXODtp4GCStXyvguCxQNzJ8Fub+XTXHtE8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774357358; c=relaxed/simple;\n\tbh=GmIUiLbuBnA3nAopsTDcD94SGgtpBgpFaWNqqszch44=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=JuNQBGV5xEF5ZeFAL9ypa9JTJXNsu4Cf5IhgnW6/XwF/ALvnwRVv2Fr3d1Z1o5fSmyMJhM2mSReFGCLDnPH0JBVFZhvbNSMNnRc4whObBgaXP6Vjl7CZzTs3oCBZ/jVv3f8ylvnOa7+9rutUG6laZwcMsK0ie2RCxGWJLcSeMMI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30","Date":"Tue, 24 Mar 2026 14:02:03 +0100","From":"Florian Westphal ","To":"Julian Anastasov ","Cc":"Simon Horman ,\n\tPablo Neira Ayuso , lvs-devel@vger.kernel.org,\n\tnetfilter-devel@vger.kernel.org,\n\tDust Li ,\n\tJiejian Wu ","Subject":"Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor\n sysctl vars","Message-ID":"","References":"<20260323162523.44964-1-ja@ssi.bg>\n <20260323162523.44964-4-ja@ssi.bg>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260323162523.44964-4-ja@ssi.bg>"}},{"id":3668812,"web_url":"http://patchwork.ozlabs.org/comment/3668812/","msgid":"<331e1dc8-ec57-0a09-bf71-686c53462cb1@ssi.bg>","list_archive_url":null,"date":"2026-03-25T04:54:42","subject":"Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl\n vars","submitter":{"id":2825,"url":"http://patchwork.ozlabs.org/api/people/2825/","name":"Julian Anastasov","email":"ja@ssi.bg"},"content":"Hello,\n\nOn Tue, 24 Mar 2026, Florian Westphal wrote:\n\n> Julian Anastasov wrote:\n> > +\t\t\t*valp = val;\n> > +\t\t\tif (rcu_dereference_protected(ipvs->conn_tab, 1))\n> > +\t\t\t\tmod_delayed_work(system_unbound_wq,\n> > +\t\t\t\t\t\t &ipvs->conn_resize_work, 0);\n> \n> Can I change this to rcu_access_pointer()?\n\n\tYes, both proc handlers should use it, thanks!\n\n> rcu_dereference_protected( ... , 1)\n> \n> ... always looks like a bug to me, even though its fine here.\n\nRegards\n\n--\nJulian Anastasov ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=ssi.bg header.i=@ssi.bg header.a=rsa-sha256\n header.s=ssi header.b=5JeObb8p;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11390-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (4096-bit key) header.d=ssi.bg header.i=@ssi.bg header.b=\"5JeObb8p\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=193.238.174.39","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=ssi.bg","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=ssi.bg"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgZNX6qlqz1xy1\n\tfor ; Wed, 25 Mar 2026 15:55:40 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 200FC303526F\n\tfor ; Wed, 25 Mar 2026 04:55:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 34E7430AAB8;\n\tWed, 25 Mar 2026 04:55:12 +0000 (UTC)","from mx.ssi.bg (mx.ssi.bg [193.238.174.39])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8320C272E6D;\n\tWed, 25 Mar 2026 04:55:07 +0000 (UTC)","from mx.ssi.bg (localhost [127.0.0.1])\n\tby mx.ssi.bg (Potsfix) with ESMTP id 1BCA9217F8;\n\tWed, 25 Mar 2026 06:54:58 +0200 (EET)","from box.ssi.bg (box.ssi.bg [193.238.174.46])\n\tby mx.ssi.bg (Potsfix) with ESMTPS;\n\tWed, 25 Mar 2026 06:54:57 +0200 (EET)","from ja.ssi.bg (unknown [213.16.62.126])\n\tby box.ssi.bg (Potsfix) with ESMTPSA id 1E7F6609D8;\n\tWed, 25 Mar 2026 06:54:56 +0200 (EET)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby ja.ssi.bg (8.18.1/8.18.1) with ESMTP id 62P4sgY5004260;\n\tWed, 25 Mar 2026 06:54:43 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774414511; cv=none;\n b=YgV/ZsCQO2GCYCRNVLx3Ga9hMeKls/ck91MdnkBuZYwuVgkQ9UYmJVNiTghD5HHLTrhxzSaeS/ogvZsBGKBfullLPu0FrBUPyWK8ZQZ8wU5dCdq7Jq1q3AcjBqcILsx0eJjTtEexePMV989rUsD6E02Mrh8sYMEs7fIg/Gw19Cw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774414511; c=relaxed/simple;\n\tbh=qdImSBPzupl5FH7oqSRosfZOz2xQbStMQCbgPZiDC9o=;\n\th=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=UXVooIgsnvivc0S059KKaeWuCKhcV1nXufatQ/VuWIDV1/C2Qqm4GmSd/yMRgGxZHzT2SE932Hc2DQm1W9GQwCMEwLOUnDFlaPrAPZv6gVMVJmTLPjkGVcEdLsYonttSDKeJsMwKFTSZqF8/Io/KnP1/9aBvb/Ta7hfJQtJ7tec=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=ssi.bg;\n spf=pass smtp.mailfrom=ssi.bg;\n dkim=pass (4096-bit key) header.d=ssi.bg header.i=@ssi.bg header.b=5JeObb8p;\n arc=none smtp.client-ip=193.238.174.39","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ssi.bg; h=cc:cc\n\t:content-type:content-type:date:from:from:in-reply-to:message-id\n\t:mime-version:references:reply-to:subject:subject:to:to; s=ssi;\n\t bh=7UnVyPtcnhUlOcLDILTbI3B1tbIPUQ62JS9Ucwi6NEY=; b=5JeObb8pWmFE\n\tvbWlGsRtlmeBiqjI9vwjW1NED5ucvi8JT3v1U0EC7SNgcDDxfbzab60u4K10yLNj\n\tKPSazQKqqOItueG3D5QVBXR39IJ7hd+z2+ZllYZ54Fr+ErVSajd2ao8vLOlS26AF\n\tyo3KQNYfpNvmSDcqRERm7WRLpVAmDbf3L7DEyGy5+MUfSQhmUkOPtNmhfPj9ib7Z\n\tilFFkzpwCfNlZEuau4U2ig7Ovwp36u1R7WwP5O2zfj8Fe8hFJ+flPZXcJ43S2Dhu\n\tJkX01PDm5ctFVhijBy//g5fAtVrC/44ae6ZVh/l28WwdAGWZ7z6/kZIQ6zrAmVIA\n\tylxdN5PQ8Qw7UPlOAUsieJsNAbpCm2ivG7DLhJ2wmBV6NCIrJUfe0Xmsxd/JG7rZ\n\tfWAHWWle5YQ/X1k/F8TlGVRD05PKBUkrobu8WS3Jh74Ld07auPBPDw4IGIcAaDWo\n\ttQv4Wnvtg3CEjpuOTvWTnMxjIsYEaU50sd0ZmDO0r8L+0Ow+DUBwACMOCnwjPB7h\n\tXawAvlcX3mBI46i9GhkNfLd0yNZdscbCasjEM6q/SSrG320HM9uGk7rDjqaZLTJH\n\tAUPDWDqsl/6CPQqA/62x+EDzF9x2K1DD+fMdir2qMzwMp8Py+ztcs+ZsTtd4JW78\n\tbghTJ97nycYlbTg1rQ8JNqdLjOchNzQ=","Date":"Wed, 25 Mar 2026 06:54:42 +0200 (EET)","From":"Julian Anastasov ","To":"Florian Westphal ","cc":"Simon Horman ,\n Pablo Neira Ayuso ,\n lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,\n Dust Li ,\n Jiejian Wu ","Subject":"Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl\n vars","In-Reply-To":"","Message-ID":"<331e1dc8-ec57-0a09-bf71-686c53462cb1@ssi.bg>","References":"<20260323162523.44964-1-ja@ssi.bg>\n <20260323162523.44964-4-ja@ssi.bg> ","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII"}}]