[{"id":3673418,"web_url":"http://patchwork.ozlabs.org/comment/3673418/","msgid":"","list_archive_url":null,"date":"2026-04-04T10:30:40","subject":"Re: [PATCH nf-next 1/3] ipvs: show the current conn_tab size to users","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/people/1025/","name":"Florian Westphal","email":"fw@strlen.de"},"content":"Julian Anastasov wrote:\n> As conn_tab is per-net, better to show the current hash table size\n> to users instead of the ip_vs_conn_tab_size (max).\n> \n> Signed-off-by: Julian Anastasov \n> ---\n> net/netfilter/ipvs/ip_vs_ctl.c | 26 ++++++++++++++++++++++----\n> 1 file changed, 22 insertions(+), 4 deletions(-)\n> \n> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c\n> index b472e564b769..3129b15dadc2 100644\n> --- a/net/netfilter/ipvs/ip_vs_ctl.c\n> +++ b/net/netfilter/ipvs/ip_vs_ctl.c\n> @@ -281,6 +281,13 @@ static void est_reload_work_handler(struct work_struct *work)\n> \tmutex_unlock(&ipvs->est_mutex);\n> }\n> \n> +static int get_conn_tab_size(struct netns_ipvs *ipvs)\n> +{\n> +\tstruct ip_vs_rht *t = rcu_dereference(ipvs->conn_tab);\n> +\n> +\treturn t? t->size : 0;\n> +}\n\nPablo suggest to make this self-contained so callers don't have to\nhandle rcu read lock:\n\nstatic int get_conn_tab_size(struct netns_ipvs *ipvs)\n{\n\tconst struct ip_vs_rht *t;\n\tint size = 0;\n\n\trcu_read_lock();\n\tt = rcu_dereference(ipvs->conn_tab);\n\tif (t)\n\t\tsize = t->size;\n\trcu_read_unlock();\n\n\treturn size;\n}","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11631-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=strlen.de"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnsLq3FQLz1yG2\n\tfor ; Sat, 04 Apr 2026 21:30:59 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 8F05F30074BD\n\tfor ; Sat, 4 Apr 2026 10:30:48 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D2AC93A9DA9;\n\tSat, 4 Apr 2026 10:30:44 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A2AEB21FF2A;\n\tSat, 4 Apr 2026 10:30:42 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid D50BE6079E; Sat, 04 Apr 2026 12:30:40 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775298644; cv=none;\n b=Ae24M4k4X5h5S6HlF40sUSXBqnTfGK2ZPGCTA+JrKG+zrcHXmv2vdAW+ljVqVqA08Ga0n9L50HPl0oTeLTvsrV2uhq7tSLP6vk4xHRMSbWkWGwDI8BL7FNnTFFk/VE+fuRNWiAgoK9w4schDhHCwR5Pr5YEyJ30QN5wgATuH2bE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775298644; c=relaxed/simple;\n\tbh=hI9dqnIJc8IQyJStY2NgLgPuQaluZvf3AGEr83Pv3zw=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=b42wosY2GwFo06bpuVM4W/h+f/6poRJREpi1y4y6fm2ViabdICLy1rJQBBE69P6R5BUZIOWfLO+Rck2MSojr0Mmz7NjS62N0/b08xjqqAkp9bAJ2O2a5VgarFOo71gohehciNBuNYS7jOzzkhrCwIQwvgbXSoWaXoazx645DNi8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30","Date":"Sat, 4 Apr 2026 12:30:40 +0200","From":"Florian Westphal ","To":"Julian Anastasov ","Cc":"Simon Horman ,\n\tPablo Neira Ayuso , lvs-devel@vger.kernel.org,\n\tnetfilter-devel@vger.kernel.org,\n\tDust Li ,\n\tJiejian Wu ","Subject":"Re: [PATCH nf-next 1/3] ipvs: show the current conn_tab size to users","Message-ID":"","References":"<20260323162523.44964-1-ja@ssi.bg>\n <20260323162523.44964-2-ja@ssi.bg>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260323162523.44964-2-ja@ssi.bg>"}},{"id":3673449,"web_url":"http://patchwork.ozlabs.org/comment/3673449/","msgid":"","list_archive_url":null,"date":"2026-04-04T14:58:26","subject":"Re: [PATCH nf-next 1/3] ipvs: show the current conn_tab size to\n users","submitter":{"id":2825,"url":"http://patchwork.ozlabs.org/api/people/2825/","name":"Julian Anastasov","email":"ja@ssi.bg"},"content":"Hello,\n\nOn Sat, 4 Apr 2026, Florian Westphal wrote:\n\n> Julian Anastasov wrote:\n> > As conn_tab is per-net, better to show the current hash table size\n> > to users instead of the ip_vs_conn_tab_size (max).\n> > \n> > Signed-off-by: Julian Anastasov \n> > ---\n> > net/netfilter/ipvs/ip_vs_ctl.c | 26 ++++++++++++++++++++++----\n> > 1 file changed, 22 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c\n> > index b472e564b769..3129b15dadc2 100644\n> > --- a/net/netfilter/ipvs/ip_vs_ctl.c\n> > +++ b/net/netfilter/ipvs/ip_vs_ctl.c\n> > @@ -281,6 +281,13 @@ static void est_reload_work_handler(struct work_struct *work)\n> > \tmutex_unlock(&ipvs->est_mutex);\n> > }\n> > \n> > +static int get_conn_tab_size(struct netns_ipvs *ipvs)\n> > +{\n> > +\tstruct ip_vs_rht *t = rcu_dereference(ipvs->conn_tab);\n> > +\n> > +\treturn t? t->size : 0;\n> > +}\n> \n> Pablo suggest to make this self-contained so callers don't have to\n> handle rcu read lock:\n\n\tI created it this way because ip_vs_info_seq_show()\nand IPVS_CMD_GET_INFO case are already under RCU lock.\nI'll report v2 soon...\n\n> static int get_conn_tab_size(struct netns_ipvs *ipvs)\n> {\n> \tconst struct ip_vs_rht *t;\n> \tint size = 0;\n> \n> \trcu_read_lock();\n> \tt = rcu_dereference(ipvs->conn_tab);\n> \tif (t)\n> \t\tsize = t->size;\n> \trcu_read_unlock();\n> \n> \treturn size;\n> }\n\nRegards\n\n--\nJulian Anastasov ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=ssi.bg header.i=@ssi.bg header.a=rsa-sha256\n header.s=ssi header.b=clB3bZ/Y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11632-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (4096-bit key) header.d=ssi.bg header.i=@ssi.bg header.b=\"clB3bZ/Y\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=193.238.174.39","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=ssi.bg","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=ssi.bg"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnzJ72Txpz1xtJ\n\tfor ; Sun, 05 Apr 2026 01:59:03 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id B95723005314\n\tfor ; Sat, 4 Apr 2026 14:58:59 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C13D327F18B;\n\tSat, 4 Apr 2026 14:58:58 +0000 (UTC)","from mx.ssi.bg (mx.ssi.bg [193.238.174.39])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 42F6C248891;\n\tSat, 4 Apr 2026 14:58:52 +0000 (UTC)","from mx.ssi.bg (localhost [127.0.0.1])\n\tby mx.ssi.bg (Potsfix) with ESMTP id 3AE2321C5D;\n\tSat, 04 Apr 2026 17:58:44 +0300 (EEST)","from box.ssi.bg (box.ssi.bg [193.238.174.46])\n\tby mx.ssi.bg (Potsfix) with ESMTPS;\n\tSat, 04 Apr 2026 17:58:42 +0300 (EEST)","from ja.ssi.bg (unknown [213.16.62.126])\n\tby box.ssi.bg (Potsfix) with ESMTPSA id A2DD560818;\n\tSat, 4 Apr 2026 17:58:40 +0300 (EEST)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby ja.ssi.bg (8.18.1/8.18.1) with ESMTP id 634EwQGD026021;\n\tSat, 4 Apr 2026 17:58:26 +0300"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775314736; cv=none;\n b=jF9kmnG/kbB0116gBpiQi1emDkus29bcOyHlOVNBnuMaxHVlKmYcdeArxkJnXXbadayBFS4MmD1pnHJjUXOVgsodPC3TYWEht9hasOhWJgVYK7hfUOZvQGxPWZ/qyxh2WZvqcqyqsWKdPqQ5xgKYaNZrGr29X8VwnBT9YlZczWA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775314736; c=relaxed/simple;\n\tbh=83+KN641MOf2ZXp6EoHxWpKBgOXhkjpqI9qlN9/qu5E=;\n\th=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=q7vzmplIZHFGLJ8LA0Ie0DFfWeq8ow/Km+42H20NeQFFGU83Vpm3uOS2U1O6+ImcQOkxA70AI7OCfZjwpDz6Uo1XMaKcG6uOl0aTjpusp7SpcFUbvee5sDPZdLLJSvTbfiiourjDMGPO3Aov8HFTChvAq+vDhTh4hP+7Ep37aTc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=ssi.bg;\n spf=pass smtp.mailfrom=ssi.bg;\n dkim=pass (4096-bit key) header.d=ssi.bg header.i=@ssi.bg header.b=clB3bZ/Y;\n arc=none smtp.client-ip=193.238.174.39","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ssi.bg; h=cc:cc\n\t:content-type:content-type:date:from:from:in-reply-to:message-id\n\t:mime-version:references:reply-to:subject:subject:to:to; s=ssi;\n\t bh=3uHzP2CP40ZTuLXW5buuDvxnd6+9ysI1WLolHX3mKY4=; b=clB3bZ/YCzV8\n\tys0ID4dR92yogt5wmn6JOWod/YANOnjX26BeRaRhLlkqea6m+JoguzYAlhRay6a2\n\tvMNWXvIBftA81ckPu44zIbBuJsvUhPK7dn5qX83fXn+Hw6JP5fUC/8PQklW7o74l\n\tQsmsof3/0s1syJRmY4ura5KiZlyK5WU36F5cStu7/C/vD0ruOwa8wuAvqxmSzTKy\n\tqUlcKT7dc+WxP21uGvVM3mhNfedQmHeKOZLlLoOXA/FytqQLoo3ZZ8UhVAOhy+4V\n\tV5+KYNZ9T3/QQI6/oJbJEAyeRuSXsJdI1rweYZlhMgVG9NoWEeLM+lA57++OBuf1\n\tmomozyyeIjiVKWlouNY+u0Rxkku51J+hlESm+Gvz8x5w+dXImRuAaY+ZaI9wdLdD\n\tkPG4qcU0xtClkhX64Lerj2YGIK9KvHufNhDDZO0LWd2/vVHM1aFdSPQkpP5DfChv\n\twOIkhONupnEBCJNdBfaPFct0nMjadpd7qvOSeC68hVQF4MZPX0+wocC0ebMaIjPk\n\tZZ++/iYI3iBOS8+LC2GEZDZ2fudEtzDC/yv5s0NYWF/uMtBr/0DGeYzIaiccUao4\n\thqkxDxLclNwKgzPUpwCYcYbt1ETobU6NhgFyAphEzXrJ5PTohmW9q85EulEvKH+J\n\tZy7c/Y/PDCcrfiNC5oqyaPZtHmi6d/I=","Date":"Sat, 4 Apr 2026 17:58:26 +0300 (EEST)","From":"Julian Anastasov ","To":"Florian Westphal ","cc":"Simon Horman ,\n Pablo Neira Ayuso ,\n lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,\n Dust Li ,\n Jiejian Wu ","Subject":"Re: [PATCH nf-next 1/3] ipvs: show the current conn_tab size to\n users","In-Reply-To":"","Message-ID":"","References":"<20260323162523.44964-1-ja@ssi.bg>\n <20260323162523.44964-2-ja@ssi.bg> ","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII"}}]