[{"id":3667317,"web_url":"http://patchwork.ozlabs.org/comment/3667317/","msgid":"<20260321152520.041dedb8@elisabeth>","list_archive_url":null,"date":"2026-03-21T14:25:20","subject":"Re: [PATCH nf-next] netfilter: nft_set_pipapo_avx2: remove\n redundant loop in lookup_slow","submitter":{"id":72032,"url":"http://patchwork.ozlabs.org/api/people/72032/","name":"Stefano Brivio","email":"sbrivio@redhat.com"},"content":"On Wed, 18 Mar 2026 14:42:12 +0100\nFlorian Westphal wrote:\n\n> nft_pipapo_avx2_lookup_slow will never be used in reality, because the\n> common sizes are handled by avx2 optimized versions.\n> \n> However, nft_pipapo_avx2_lookup_slow loops over the data just like the\n> avx2 functions. BUT _slow doesn't need to do that:\n> pipapo_and_field_buckets_() + pipapo_refill() already handle\n> everyhing for us.\n\nAh, right, indeed.\n\n> All other iterations boild down to 'x = x & x': Remove the loop.\n> \n> Signed-off-by: Florian Westphal \n\nReviewed-by: Stefano Brivio ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=eO5D31Be;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=X1xMsqlq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11364-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"eO5D31Be\";\n\tdkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"X1xMsqlq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fdMD76WM7z1y1P\n\tfor ; Sun, 22 Mar 2026 01:25:43 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5085D3014131\n\tfor ; Sat, 21 Mar 2026 14:25:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1FAB738BF6C;\n\tSat, 21 Mar 2026 14:25:28 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8636438BF92\n\tfor ; Sat, 21 Mar 2026 14:25:26 +0000 (UTC)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-388-gxnQOAa0N0iF_pZ7iAfFNQ-1; Sat, 21 Mar 2026 10:25:23 -0400","by mail-wm1-f71.google.com with SMTP id\n 5b1f17b1804b1-48542d5aa9eso15086055e9.0\n for ;\n Sat, 21 Mar 2026 07:25:23 -0700 (PDT)","from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud.\n [2a10:fc81:a806:d6a9::1])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-486fe7d6c54sm329358915e9.4.2026.03.21.07.25.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 21 Mar 2026 07:25:21 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774103127; cv=none;\n b=HiR0/S/Pi1trSF8Z6ceePL+dLzN+K/jNaUohSXK693RuYgNdpRLy6KuSm1LpF2/7FCaPVDcqfnvo/UWe+qZLkKfnnqA91PplGKLqEcQbxLx8meJiYQI6QZ9lEVFMqrpDxNw8AvlGn45gfld+yl1dzaJzaaYnj44osQMeLz0HkiM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774103127; c=relaxed/simple;\n\tbh=ZMZeqy6sIbirITTWd/6iALnbgyRhiV8SSIgLeWcYrnU=;\n\th=From:To:Cc:Subject:Message-ID:In-Reply-To:References:MIME-Version:\n\t Content-Type:Date;\n b=Pqn/Uqtx2JaA7ls4LsEryl2WqbtdGLIIoSoiOZ5CkmHvsL3YbgT9fyfx114rOKXZezyEV+vgi3opy8+Y9kFQofBlf51CbzeEu88QiXG41ImdVlFHRCwY7yBmZGho8UFVN1AWbM5s7HG0FpL3gsFqCvzNgpOB3ynmYC+mTn79Xx8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=eO5D31Be;\n dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=X1xMsqlq; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1774103125;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=KhKnnrmrFmgqQYmYoxQ0MJrYi8aeSThzMTI2uIhI0Ng=;\n\tb=eO5D31BeV9ZfS+5kjC5Kr/o+uGgC3mJ9jdX4ol7rEmlZvWsOyRLkQUUPkqizPt+wHUE4Un\n\tp5idqNGKxsHYEjbcTnebud1k1Chp0aWJmYyeJkgd/ZxhkDDBCoqNljBQSRsxOx92susVpo\n\tbLI3xyvQSiJPZuLXl+tUycToX/8crSY=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774103122; x=1774707922;\n darn=vger.kernel.org;\n h=date:content-transfer-encoding:mime-version:organization:references\n :in-reply-to:message-id:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KhKnnrmrFmgqQYmYoxQ0MJrYi8aeSThzMTI2uIhI0Ng=;\n b=X1xMsqlqK1UFuqfy2rLUfK7L60AoPCnIMPcNzMt4NN9sVqU2JUzxUbK59myFNep+u3\n GBqvEMcH6P5iwbfshSkvobMjq6rUXp8yNWdWxDdebyDfUaakFpx9ymLyHoF8Z5kpRi+V\n P+kESBVWBaCFR9G0kKm7Wh5JOwJEKK+yE0NCP4k6BpTvs1qmOwhPmGYfrzUeRN23a9w7\n 84qoncpmLObjEE02H9vvxiLL0gGpWSTh2sUAHtfLH5OrlJM4mn5Cf30Sy/dEhObUvICS\n mMyyH6zcHqxlGrHOW1k+Hhas8EnfUVteUb0cTdTBVemxAzxmi09jF8tf4d7Pbi31NEqd\n eSrQ=="],"X-MC-Unique":"gxnQOAa0N0iF_pZ7iAfFNQ-1","X-Mimecast-MFC-AGG-ID":"gxnQOAa0N0iF_pZ7iAfFNQ_1774103122","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774103122; x=1774707922;\n h=date:content-transfer-encoding:mime-version:organization:references\n :in-reply-to:message-id:subject:cc:to:from:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=KhKnnrmrFmgqQYmYoxQ0MJrYi8aeSThzMTI2uIhI0Ng=;\n b=HyO3xWVYNPBCsz3o2HduQEKzG4vl1HqObzMhxb2i2kYZZKs1+0dscLq8W7tgoLYWND\n UBhuXVpHdqem0U523AksXEFpFx4E4V1MWzrKXZLv3F14/XrX2p6Ai8i7jwNeu94lEVdv\n EE0fc+JWNqF3S/yKrLlK+NMsZS+YqpvoTsxNydQR8N7nQIfP3LDysjANkJ3A0vuY+ANV\n PWOsnGMkLIT490H/VwOzJS6UXvRewfDT5CeqP7VeefhrfyTW47Nj9eqiwawgaOP9kSF7\n wkKRSRko+kHAG0XkF46qEAy1Gs0/WpAICH778g1xnZ9+pfTWTJwxIS/b97NnHnETTuHE\n 8uRg==","X-Gm-Message-State":"AOJu0Yxi5uU9GVLJm5ib9MHAdCEM5J9F8x5xucX9XnparXWoe15ez/k7\n\tmmi7YDrJGu1mD8sSwLtuQLz4BJJf6Qy1dfd2y5ma1BsXjTVPNXc4Zk48lT7D+Vqqmgh3/+HR/2i\n\tD8Y2NyUPWxzTKAQUTluSEHb7m3apdV7fNHFfAyM1z4p7QLypcFMy2psmaA+XYoeJILiNVpA==","X-Gm-Gg":"ATEYQzwlpxnPw3zHpNBzFJY55l1849LoWAWNYoa0snKrRcPD/SaNszC9/AUK2aIb5jq\n\tMhMT70amJt3GNmuMiCIWi3HYx722+3xVimzPsASpwwJELgr4ZAicWwmE+3didaCsNkjGLVq5ZzC\n\t/ACyAplQhOaWcLicWztf2ecn8GveC/QTrWbtDgT9F6uVvTwZ+w5JkW35f/ay1TXnD8GiS6i4MbU\n\tDvAZq8mwFLICD1Gck1X3FgTnsrUOZxra6iLfBLTTODT/LwWmsUQOk7IKvmG3/bQ2bToRd1flmgU\n\tQlHDfGGvmCOqaZAWAC2FviMWKQKmB0PsSLvvGUWoZjGfxoeBxLgJrhllBe4sYYERhf3buKBvh6w\n\tpfugZhU6wOyRu0GJdwyAg8vYK8Uwg2cmc","X-Received":["by 2002:a05:600c:a4a:b0:485:5c6e:8a38 with SMTP id\n 5b1f17b1804b1-486fee0fbabmr84886805e9.17.1774103122329;\n Sat, 21 Mar 2026 07:25:22 -0700 (PDT)","by 2002:a05:600c:a4a:b0:485:5c6e:8a38 with SMTP id\n 5b1f17b1804b1-486fee0fbabmr84886615e9.17.1774103121779;\n Sat, 21 Mar 2026 07:25:21 -0700 (PDT)"],"From":"Stefano Brivio ","To":"Florian Westphal ","Cc":"","Subject":"Re: [PATCH nf-next] netfilter: nft_set_pipapo_avx2: remove\n redundant loop in lookup_slow","Message-ID":"<20260321152520.041dedb8@elisabeth>","In-Reply-To":"<20260318134217.1596-1-fw@strlen.de>","References":"<20260318134217.1596-1-fw@strlen.de>","Organization":"Red Hat","X-Mailer":"Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu)","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Date":"Sat, 21 Mar 2026 15:25:20 +0100 (CET)"}}]