[{"id":3667316,"web_url":"http://patchwork.ozlabs.org/comment/3667316/","msgid":"<20260321152515.5bc0f77f@elisabeth>","list_archive_url":null,"date":"2026-03-21T14:25:15","subject":"Re: [PATCH nf-next] netfilter: nft_set_pipapo: increment data in\n one step","submitter":{"id":72032,"url":"http://patchwork.ozlabs.org/api/people/72032/","name":"Stefano Brivio","email":"sbrivio@redhat.com"},"content":"On Wed, 18 Mar 2026 14:38:34 +0100\nFlorian Westphal wrote:\n\n> For unkown reason the C version increments the data pointer in two steps.\n\nThat's because before commit e807b13cb3e3 (\"nft_set_pipapo: Generalise\ngroup size for buckets\") pipapo_get() contained the whole lookup\nimplementation with __bitmap_and(), and 'data' was used as pointer to\nmove between bit groups, and incremented as we went through them.\n\nWith that commit, we don't need to keep 'data' updated during the\nlookup anymore, so I just replaced the initial increment, but I didn't\nnotice that 'data' isn't used at all before the second increment now,\nand that the two increments could be merged.\n\n> Switch to a single invocation of NFT_PIPAPO_GROUPS_PADDED_SIZE() helper,\n> like the avx2 implementation.\n> \n> Signed-off-by: Florian Westphal \n\nReviewed-by: Stefano Brivio ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EoEVd+n2;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=YsL3y2QE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11363-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"EoEVd+n2\";\n\tdkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"YsL3y2QE\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fdMD25PTbz1y1P\n\tfor ; Sun, 22 Mar 2026 01:25:38 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9B8483011F35\n\tfor ; Sat, 21 Mar 2026 14:25:27 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C8BD438C2A8;\n\tSat, 21 Mar 2026 14:25:26 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A07E37DE97\n\tfor ; Sat, 21 Mar 2026 14:25:21 +0000 (UTC)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-122-Fqv08JhgN-OE5-OCFF444A-1; Sat, 21 Mar 2026 10:25:18 -0400","by mail-wr1-f71.google.com with SMTP id\n ffacd0b85a97d-43b4e102d77so1762468f8f.1\n for ;\n Sat, 21 Mar 2026 07:25:18 -0700 (PDT)","from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud.\n [2a10:fc81:a806:d6a9::1])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-486fe68ec05sm220872775e9.0.2026.03.21.07.25.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 21 Mar 2026 07:25:16 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774103126; cv=none;\n b=YIVLStPQdbE2d0gteXZ3dzZqvbCmZmPaZOatQsHJtWJfdzNXcMQfsysupaiB5kCD6OMR6ai6zsxSQsU+Yu6FojpDorDo899S9aMLCDZPW9vbOARJp7Sxt/HSmysXqtyexOxqxXJccI1imi58EE1mUaFCAsA2ExKKwY7t2FCmKNA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774103126; c=relaxed/simple;\n\tbh=434EW88iCH/TnSS8Uyjyzx3nfR5Rs5u9pi4TXfGR3UY=;\n\th=From:To:Cc:Subject:Message-ID:In-Reply-To:References:MIME-Version:\n\t Content-Type:Date;\n b=bCpMNRbEVQbDdK224CKZOGun8Ev6wpRw4M1hkPLVtM2HeQ6ssM7fOKodHhko3P4ykpvVZrz4zLWdxjhXHQROiP0AhRQ899l/ffUZFVR9cj/4i8pDDcDjGJ+5HPYz/4uQorqmFGKeTx5i2m/yL4IYOafAJ7vD0NoklJkxKWG1fhs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=EoEVd+n2;\n dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=YsL3y2QE; arc=none smtp.client-ip=170.10.133.124","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1774103120;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=NuUnMQWvpUsQlUPUFGoCoFA4alw0Y3WvPnt5+U2X1nQ=;\n\tb=EoEVd+n2Y5Ng3OWwfRRwBMyKi5OqFtrPLmRivCZe0QrzRZiKk6qcFpA9tZexzkJKKe9JcH\n\tSmK0tUyfJ5xRLxzlEQL/sCTKSfvfA6nqxpWsJfhFu3i+uoKKxk0fMvGw77fHpnuYHpF5hI\n\t/sdk7bZbcRedA/EjhmF2fAnMa32zSDU=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774103117; x=1774707917;\n darn=vger.kernel.org;\n h=date:content-transfer-encoding:mime-version:organization:references\n :in-reply-to:message-id:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NuUnMQWvpUsQlUPUFGoCoFA4alw0Y3WvPnt5+U2X1nQ=;\n b=YsL3y2QENLqHcB5ZtSLhY/TEipvQDqPjZPS44m9FNQ8BoROcYarYXK38BO72cq2W8k\n 437sRQ8utjqHTSkvuIodLOGGJJYUwNy23+n9+DrWUAamIaUmUNF1qp8YboTmU3g0Zh9o\n H6SArLVm5jLjnASoCbj1HLcf4D4ty7qMmxrV+SjrkQwOA9y4PGoGdHPF/lxW9FCFkiUl\n F37SqiwFT/d92gQsZMdT5RPspU8HUiVi0RkDzgOZkDnjaYUA/71DlKed9cMSKGEheyle\n gynA3kzuvTSKDyAEQKBMBBkuUNVC0vEFpBI0YihFsoAaFkDZ6uSsn3GxQguAqYRfCW4I\n ftqw=="],"X-MC-Unique":"Fqv08JhgN-OE5-OCFF444A-1","X-Mimecast-MFC-AGG-ID":"Fqv08JhgN-OE5-OCFF444A_1774103117","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774103117; x=1774707917;\n h=date:content-transfer-encoding:mime-version:organization:references\n :in-reply-to:message-id:subject:cc:to:from:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=NuUnMQWvpUsQlUPUFGoCoFA4alw0Y3WvPnt5+U2X1nQ=;\n b=MfPWo8U3BMl1/msf348NczWhkXl9DgHGA36A7VL3siBdec/jCDTVQibbTARE0YqSvM\n IBm/o8vXjOcjYzQr2EUXZ3wOXRHiTHU/UIGxY20uIQkfMQySYiwc9xDzu9OQ3BtYnDM1\n YFqwRLcw1queRceJuxf0+8wsu9ngvEp9Cg7/DeUdAAyCZnf0/OuH21ye0v+ZDth3sC4D\n NqNYUM3k9OBCI9HQzWKdnHinava2xMEzDrUFc5z2M3Mi/5EW+CUhNmbuMrZAkzKofXEy\n Q17qXWzl0sGcAI0B0hNMJe+9wTriDm6jF9TwdHGP3FMCC2loGOA3NSpgQ87sq+0vQMCE\n STJA==","X-Gm-Message-State":"AOJu0YysjKbRhvIeCo9LwIUK5cXxwnfS0MoqqIQq1uOhHatpGGZdp6ow\n\tQZ/izutT2Nv5kdbXkFgvfQX7c0DbdBv31y1Y/Jtpg98deqU5PxesW+Vz4vVWnt/bqpyvcrmSTMr\n\tNJp/117d0D+vFATA1uDefuOJfxtgZX4pV+btvU2KkUlXWnoDMuPr7mi1SW4qV3xx+HgLVBQ==","X-Gm-Gg":"ATEYQzy2RG0jTXxjpDICsgYhHwmcTEjFlW/G4XcMVuYyNV8syuc0R6Cv4txfyMvJV9g\n\t/fYG1mOAHzp7kR5ZvZyC9t+LYk+pIyxgmokeEhsOYIuYF5l1VPuTDx477sawFnNInltRF+2ybnI\n\tftBWtKf8X24TO8rlZtnqBEhiwL6oWARAROOuwpgk+foegcxw/++ILSmhKCsK70OrbtWvnW4qEhs\n\tlSmAiuF9NzUAS0tFSB303U+NG8z9Y/+ouG+lLiFyPPguL6RcBZRqcgrQi77/Q1RIKJQNrhow3mE\n\tEh9jVX18cMI4Tv9ZZQPVbXIeVhE641oi3nucmteuFtWHSCNrWLWTRz3u/HH8vDkETHwbKOkHhf9\n\tCA0910JLeagaGKEE+CfItKzOHTuWJOAbt","X-Received":["by 2002:a05:600c:8b6e:b0:485:3949:e5c6 with SMTP id\n 5b1f17b1804b1-486febb56a2mr88528615e9.3.1774103117329;\n Sat, 21 Mar 2026 07:25:17 -0700 (PDT)","by 2002:a05:600c:8b6e:b0:485:3949:e5c6 with SMTP id\n 5b1f17b1804b1-486febb56a2mr88528365e9.3.1774103116798;\n Sat, 21 Mar 2026 07:25:16 -0700 (PDT)"],"From":"Stefano Brivio ","To":"Florian Westphal ","Cc":"","Subject":"Re: [PATCH nf-next] netfilter: nft_set_pipapo: increment data in\n one step","Message-ID":"<20260321152515.5bc0f77f@elisabeth>","In-Reply-To":"<20260318133840.1334-1-fw@strlen.de>","References":"<20260318133840.1334-1-fw@strlen.de>","Organization":"Red Hat","X-Mailer":"Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu)","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Date":"Sat, 21 Mar 2026 15:25:15 +0100 (CET)"}}]