[{"id":3669591,"web_url":"http://patchwork.ozlabs.org/comment/3669591/","msgid":"","list_archive_url":null,"date":"2026-03-26T09:49:08","subject":"Re: [v1,PATCH 1/1] i2c: mediatek: add bus regulator control for power\n saving","submitter":{"id":81844,"url":"http://patchwork.ozlabs.org/api/people/81844/","name":"Chen-Yu Tsai","email":"wenst@chromium.org"},"content":"On Wed, Mar 18, 2026 at 4:46 PM adlavinitha reddy\n wrote:\n>\n> Add conditional bus regulator enable/disable in mtk_i2c_transfer()\n> to support I2C bus power gating for platforms that require it.\n>\n> This implementation:\n> - Enables bus_regulator before clk_bulk_enable() if vbus-supply is defined\n> - Disables bus_regulator after clk_bulk_disable()\n> - Only activates when vbus-supply is provided in device tree\n> - Has no impact on platforms without vbus-supply defined\n>\n> This approach provides power savinggs for platforms with an extra I2C bus\n> regulator, while avoiding runtime PM complexity.\n>\n> TEST= Build and boot on MT8188\n>\n> Signed-off-by: adlavinitha reddy \n\nReviewed-by: Chen-Yu Tsai ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=W+Whr5MQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16796-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=\"W+Whr5MQ\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.167.51","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=chromium.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhK1Q4tqfz1y1G\n\tfor ; Thu, 26 Mar 2026 20:56:42 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 21157301991A\n\tfor ; Thu, 26 Mar 2026 09:49:34 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4BDD3399023;\n\tThu, 26 Mar 2026 09:49:32 +0000 (UTC)","from mail-lf1-f51.google.com (mail-lf1-f51.google.com\n [209.85.167.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D906396590\n\tfor ; Thu, 26 Mar 2026 09:49:21 +0000 (UTC)","by mail-lf1-f51.google.com with SMTP id\n 2adb3069b0e04-5a298acb395so1064518e87.2\n for ; Thu, 26 Mar 2026 02:49:21 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774518569; cv=pass;\n b=YtQQj6H3Of+0zwOvZNfvPIeZeG7hsoUGWO49OC/Eb9w4L5zmNI0B10oqkk8aRqmBgD7JheOB0J48Rb5IdhkvOwnQ7wFzWoPseAKEuqnvq1x10vV/WjzvT8g5dUHizRJvjx2A0AR7MoiYsLr5SJ+I+J6ylwRvymuGhJEjmJ6B8QI=","i=1; a=rsa-sha256; t=1774518560; cv=none;\n d=google.com; s=arc-20240605;\n b=e3/QHR+8bhAFIHBeIm8lCRlDiC36bxNFKakl+OYMQHqb1igpN/zHzbf3KYDxeuRXCS\n qvZfOAK6Egv6RbxDIqai6NPgHq28U7SHAiCDpRsOQ1WbvI51CMIyXzpla+IzhyJ5IiVE\n HIObjnVfRMaBFj/U/7wWTrcpqeWbQ2OIzVwgkwWms4Q2KBGETmIBY0Ywy8ZgLYXYXEP/\n XJysfGpTwYgLhhSq35NN+iXjyr2HrOxWygaJdcEziVB8QxpKklXyHRatYGQNZkpC+Y/5\n swZaWmGrAHcvZPWHmvUccnSvvGOs+IBYss/pMrhNXDj4gGOtAxV6SSw/fzLbvpsCKqEY\n vbsw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774518569; c=relaxed/simple;\n\tbh=7knoakIKaubGmtXGun6YWaShT3Bs+tTtvHK7ZAazb4A=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=hBzSJn1jQ9ySKTD6o6MfI8/0J6w5+b5eNK1FfEZ1p6TYQhzMZd/dvRDEhstPKpWBSpEa3cd0Znm7sobxFOB0qz6tOxrCUgfD2ipP4dzB7bvaQP8+K1mrsWuBUoaFRSc5CXPPCaNbdA9dCWj/Gni3OHOOPaO3oxVvkmneLAUBh9c=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=7knoakIKaubGmtXGun6YWaShT3Bs+tTtvHK7ZAazb4A=;\n fh=gEhAtBsNlets+BxVfXLQ1ZYQZr3jnQvXWs30s4FiLx0=;\n b=hfj4KnVzkfXMFXERrfJD7yse+wvClJZT6fk7qtTEhiy8sGrPA/ZtMGBTYh3Zn74sUo\n Rt0DEpd/uC3ahCeRnDSsI8QCKH7y/WpFCqAfkMf+W32Jozu6miAF2mGcxa25vSCr4zrR\n rNGbJdJO8lLCu48pfdqNDRSCLhGzaVwsYbWhblqsF5LqiVmI4SNkGqiCj0DwfihAEx5o\n mu1Lr40PrmxgW/EluArFujTmJqFc1PRfxkJ2t7SVOCSetxg5Uv1QMBjQYj/5iENQmSdJ\n NtGVgG8eafMUkfvTJah5IpRLbdbwcSnXLbAlLlpDptVo8+Q4w2Zre17Klfq/acSdNMwg\n VEuw==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org;\n spf=pass smtp.mailfrom=chromium.org;\n dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=W+Whr5MQ; arc=pass smtp.client-ip=209.85.167.51","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1774518560; x=1775123360;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7knoakIKaubGmtXGun6YWaShT3Bs+tTtvHK7ZAazb4A=;\n b=W+Whr5MQdTVsjfWAkhUplX/Lxi61m3riOa1khl4NKshyaH5ETIh0+FFlUJQb5aAFo8\n c4I4dwJe/SOXzNmPesfRgwChLAikCXMEXC2Sy43IVJNNTRAn2FsCF4ZgvL8OuBdFSxui\n 413y9IxywGBuWSg9ouggbK6iVWFNsEKGjBQ8A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774518560; x=1775123360;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7knoakIKaubGmtXGun6YWaShT3Bs+tTtvHK7ZAazb4A=;\n b=Os5saIkSBv6KDUZ0FhXlExiaC232DDFwircsSjS4hxh9TElN/Sx1uubSS4qnYm1ukW\n AVO2RsZpJUN+kUEoow5IKp53MJQcIZUk0spKvl9bE6kigP/kBRgnMDCHKNPmfJKQB2CP\n dz0Ai6vIxmTtENkgU/Da4j2jna43yCb5rnhejgiscoVckuUca5mjUxAnp+q7Bl+T6Fxa\n tyJdOq9n+FXjtpPQuYT3/yItfFOAqpkpp8VKxyCu+XC607kmedwtuWUrwWRViPVUTLWq\n bjhpIhUyK050RMnp7n3ndL1RW5x7HbN3svF7cqDH/THRoSR92tCQlWXSukdeKQllKt8R\n vV7A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVOGLda2ak1YEMoGcRQl6ybJ4A47EZZZEuknu+yrfuQ5jYAhyfXmIAYDMpfy1mAR69c3tUqWYQuxHM=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yww5Gt9o5BqKD/TJONAB4SuOC+BJviNrGuQtUWiioX4quwexQnx\n\tyoVmWJ1f+YA0I3qwDrR7kF0pN76dxQkD5JYnTULEOeOW4ktOlm1/KHvLoqOHVHP0loG1FQTvJUu\n\t6gJ7VKCahNinhRob92uPk7YZgsjyOd9XlmaQXLr4O","X-Gm-Gg":"ATEYQzzwb7ZkkUHNq/uWMKCf0XoLf1oixZWESKB7OirndxM8rLNtF/EHb24RZdfW4I9\n\tTpo20Ix0B01R86ZCh72NYdXwe6DFLntwAnvHXCpk6UiDoW1SJtsjhqQXIKI1WOnQPANjHTKx3eJ\n\t88RkNyM93UyjAK6uDrAVK241Q459/1RemNxa/kjjG4/4BuFOn4QCekfqRq52NIyv9dMXWZNSZJr\n\tqtNuuAlLQ23/eSj90HYBLa6xiLVheN9aaRPSivOm6WOsVeg2m7ys+UxELveB0HoYJHTrSjLe37L\n\tHouHWRW+AP1obDa3tNnZRDRnhX8zykyfDpqN3g==","X-Received":"by 2002:ac2:55bc:0:b0:5a2:8570:299a with SMTP id\n 2adb3069b0e04-5a29b995643mr1745645e87.34.1774518559747; Thu, 26 Mar 2026\n 02:49:19 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260318084621.4127757-1-adlavinitha.reddy@mediatek.com>\n <20260318084621.4127757-2-adlavinitha.reddy@mediatek.com>","In-Reply-To":"<20260318084621.4127757-2-adlavinitha.reddy@mediatek.com>","From":"Chen-Yu Tsai ","Date":"Thu, 26 Mar 2026 17:49:08 +0800","X-Gm-Features":"AQROBzBAalqKzp35Y91nZQL13UXSFnXuvsBfaF-bjpY0zqhQlozBnv2cKghChRQ","Message-ID":"\n ","Subject":"Re: [v1,PATCH 1/1] i2c: mediatek: add bus regulator control for power\n saving","To":"adlavinitha reddy ","Cc":"Qii Wang , Andi Shyti ,\n\tMatthias Brugger ,\n\tAngeloGioacchino Del Regno ,\n linux-i2c@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org,\n\tProject_Global_Chrome_Upstream_Group@mediatek.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3677422,"web_url":"http://patchwork.ozlabs.org/comment/3677422/","msgid":"","list_archive_url":null,"date":"2026-04-14T23:03:08","subject":"Re: [v1,PATCH 1/1] i2c: mediatek: add bus regulator control for\n power saving","submitter":{"id":85956,"url":"http://patchwork.ozlabs.org/api/people/85956/","name":"Andi Shyti","email":"andi.shyti@kernel.org"},"content":"Hi Adlavinitha,\n\nOn Wed, Mar 18, 2026 at 04:46:16PM +0800, adlavinitha reddy wrote:\n> Add conditional bus regulator enable/disable in mtk_i2c_transfer()\n> to support I2C bus power gating for platforms that require it.\n> \n> This implementation:\n> - Enables bus_regulator before clk_bulk_enable() if vbus-supply is defined\n> - Disables bus_regulator after clk_bulk_disable()\n> - Only activates when vbus-supply is provided in device tree\n> - Has no impact on platforms without vbus-supply defined\n> \n> This approach provides power savinggs for platforms with an extra I2C bus\n\nI changed /savinggs/savings/.\n\n> regulator, while avoiding runtime PM complexity.\n> \n> TEST= Build and boot on MT8188\n\n'\"TEST=...\" is a tag. There is no need to save characters in the\ncommit log. I changed it to \"Tested on MT8188.\".'\n\n> Signed-off-by: adlavinitha reddy \n\nPlease use capital letters for your name and for the committer's\nname as well. I fixed it.\n\nNow you have to explain me why you sent three times this same\npatch.\n\nNext time, please use the format '[PATCH v1 1/1]' instead of\n'[v1,PATCH 1/1]'. Normally for the first version you can omit v1.\n\nFor single patches you don't need the 0/1 cover letter. Just send\nas [PATCH].\n\nPlease read Documentation/SubmittingPatches.\n\nFor now I merged this patch in i2c/i2c-host-2.\n\nThanks,\nAndi","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qMRqA8NW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17058-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"qMRqA8NW\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwKZJ6rySz1yHc\n\tfor ; Wed, 15 Apr 2026 09:03:20 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 120683016CB4\n\tfor ; Tue, 14 Apr 2026 23:03:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 61A15396B63;\n\tTue, 14 Apr 2026 23:03:12 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FEB3346B4;\n\tTue, 14 Apr 2026 23:03:11 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 39872C19425;\n\tTue, 14 Apr 2026 23:03:11 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776207792; cv=none;\n b=EYDI8rGUgUOBneo5R5I+ELTVbQ/rpaw202xltaaPQU7a6gBAuUB99O1XWGIs4k+Cseg2TLTDQOjbCAiTVCRpEn3+vnoE3XEyX5cBQv6WCy17q8rBiuPfclkdZhgFeN2oJ+/XwWRgKCe957TXp8IfO2fwp6iIS5xVy1hFwKhf3OA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776207792; c=relaxed/simple;\n\tbh=DPMIG0JyHD8TiANVF6tKn1krzB0C2AAq7YcH8D+L2w4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=Txr+Pqe5rXwzj60RCSifVjt4BMTk4w6/0sHdKiG4OQUV/pRbmK4Ra2RKtDmbEAorPlEstqA7epSBIB/nu7UOqghHho+iCsxP+BTpxYAxDsrN3OPFUYN3Ka6CEEchj5RxHlmuJRSI10s4wK/5GrEFXXsAHf2De6H32AlScd250JI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=qMRqA8NW; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776207791;\n\tbh=DPMIG0JyHD8TiANVF6tKn1krzB0C2AAq7YcH8D+L2w4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qMRqA8NWtpwh46bcDmDtPfeFSsI7VfEvufnIj70RnhOpvKpu2H2OdtOvM28jJ/Ujj\n\t 9+jkDC1wW77PceNKP5EnwBPHQltH4H80Yk98xbMrQUK/Y2PTwlWgiTVdQfE4Bs5Pak\n\t dvLbqPBc2M65FwlOprrcEMb+9IbUaFGTtnNf7+S7d6471VxFutgK6KwJVnheiOAYHn\n\t zJLsGczmt4x0z+X26vysLjD50SGqRe9XBkrHhS5jGRbv1EniaqNwP9lFNYQD6l9URe\n\t j5f6u7Uk8ZpYlCxHTs3LgySB5fk+754sojJIaC8M290UrrYxXExY3VwZpquhJqO3Qj\n\t /AtIApwXUlJ8g==","Date":"Wed, 15 Apr 2026 01:03:08 +0200","From":"Andi Shyti ","To":"adlavinitha reddy ","Cc":"Qii Wang ,\n\tMatthias Brugger ,\n\tAngeloGioacchino Del Regno ,\n linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,\n\tProject_Global_Chrome_Upstream_Group@mediatek.com","Subject":"Re: [v1,PATCH 1/1] i2c: mediatek: add bus regulator control for\n power saving","Message-ID":"","References":"<20260318084621.4127757-1-adlavinitha.reddy@mediatek.com>\n <20260318084621.4127757-2-adlavinitha.reddy@mediatek.com>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260318084621.4127757-2-adlavinitha.reddy@mediatek.com>"}}]