[{"id":3670668,"web_url":"http://patchwork.ozlabs.org/comment/3670668/","msgid":"","date":"2026-03-28T12:44:13","subject":"Re: [PATCH] soc: fsl: qe_ports_ic: Add missing cleanup on device\n removal","submitter":{"id":92089,"url":"http://patchwork.ozlabs.org/api/people/92089/","name":"Christophe Leroy (CS GROUP)","email":"chleroy@kernel.org"},"content":"Le 09/03/2026 à 17:25, Felix Gu a écrit :\n> [Vous ne recevez pas souvent de courriers de ustc.gu@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]\n> \n> Add a devm action handler to properly clean up the irq_domain and\n> chained handler when the device is removed.\n> \n> Fixes: f0bcd784e1b7 (\"soc: fsl: qe: Add an interrupt controller for QUICC Engine Ports\")\n> Signed-off-by: Felix Gu \n> ---\n> drivers/soc/fsl/qe/qe_ports_ic.c | 21 +++++++++++++++------\n> 1 file changed, 15 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/soc/fsl/qe/qe_ports_ic.c b/drivers/soc/fsl/qe/qe_ports_ic.c\n> index 8e2107e2cde5..5e3fae19f314 100644\n> --- a/drivers/soc/fsl/qe/qe_ports_ic.c\n> +++ b/drivers/soc/fsl/qe/qe_ports_ic.c\n> @@ -17,6 +17,7 @@\n> struct qepic_data {\n> void __iomem *reg;\n> struct irq_domain *host;\n> + int irq;\n> };\n> \n> static void qepic_mask(struct irq_data *d)\n> @@ -92,11 +93,18 @@ static const struct irq_domain_ops qepic_host_ops = {\n> .map = qepic_host_map,\n> };\n> \n> +static void qepic_remove(void *res)\n> +{\n> + struct qepic_data *data = res;\n> +\n> + irq_set_chained_handler_and_data(data->irq, NULL, NULL);\n> + irq_domain_remove(data->host);\n> +}\n> +\n> static int qepic_probe(struct platform_device *pdev)\n> {\n> struct device *dev = &pdev->dev;\n> struct qepic_data *data;\n> - int irq;\n> \n> data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);\n> if (!data)\n> @@ -106,17 +114,18 @@ static int qepic_probe(struct platform_device *pdev)\n> if (IS_ERR(data->reg))\n> return PTR_ERR(data->reg);\n> \n> - irq = platform_get_irq(pdev, 0);\n> - if (irq < 0)\n> - return irq;\n> + data->irq = platform_get_irq(pdev, 0);\n> + if (data->irq < 0)\n> + return data->irq;\n> \n> data->host = irq_domain_add_linear(dev->of_node, 32, &qepic_host_ops, data);\n> if (!data->host)\n> return -ENODEV;\n> \n> - irq_set_chained_handler_and_data(irq, qepic_cascade, data);\n> + irq_set_chained_handler_and_data(data->irq, qepic_cascade, data);\n> +\n> + return devm_add_action_or_reset(dev, qepic_remove, data);\n> \n> - return 0;\n> }\n> \n> static const struct of_device_id qepic_match[] = {\n> \n> ---\n> base-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f\n> change-id: 20260310-qe_ports_ic-ca4c98bd1c4f\n> \n> Best regards,\n> --\n> Felix Gu \n> \n\nApplied, thanks.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dl1uAITd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18963-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dl1uAITd;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjcdy1RGzz1xtJ\n\tfor ; Sat, 28 Mar 2026 23:44:21 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fjcdw4Xjkz2yfS;\n\tSat, 28 Mar 2026 23:44:20 +1100 (AEDT)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fjcdv42nVz2xN8\n\tfor ; Sat, 28 Mar 2026 23:44:19 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 59C2660008;\n\tSat, 28 Mar 2026 12:44:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 91A71C4CEF7;\n\tSat, 28 Mar 2026 12:44:15 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774701860;\n\tcv=none;\n b=e6M0Oz/D+2k+mhS0rB0k8kRasValrtHHFjpNaHcRYra+TVyEJkcKguPsiQxvN9erVyty5KLvxDqXFo9o7Qtzk8i9J6sMw3YXzcpVkz44aXm2jnhA1NseyB8fGaXwuD3hE7yEXcB/qcdzUyzciY8IvAVzpq3zf1L3lZRnaboEJTBageBmosWf1bygVqBZCgjDdLyiiDYzHEstT5Nwm9+AZ5YxpBIbw9KzaLzS61iHbaalgKJErQ2DsKAEiQbgnAgJkuqBoWioldBSgUc3DvuMcKxp9Qob3MTfoGs0QVw6sLNrbAFGPbWktvVWNZKtR8St0ZyydMuX/zWjXBuV+U8B8A==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774701860; c=relaxed/relaxed;\n\tbh=95zaNxNWfOjjGIPROCR7R2FAN16Jvi3ZaPMI1gG1deM=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=AV9Eu5FJIZ1hZcQ4ZEWRau6uIPvRKl9dYrCKuzpatQfOC1HoP2nq4Y1QWufdlpAZtt/cwTKaMKmGbsYzpNNM7lve+hTsMFYVbw7q3G/FUtUrH3CdhTFeit5ZNBSFyAir1WK0rX9hbYnoX2hQfaQNAxfGypBblXM/TwfigSAQ2oMoE223X9NjaQQVx+qgO0Inei2ejMRJYDuQzY1J0eJFGPDFKRRWAQ5yb8yk06DWK/aBHY/D2aORPlpU4Vx5OuqBeWnD141xgYkZ/ErJE86OoMeAMgoKBGf9qQ2eL+acA24Tj/inN3IHAFBALsxZIfH3PO+FratpWqQ7blB7w9dQ4A==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dl1uAITd; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=chleroy@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774701857;\n\tbh=79/1UCAkXJ1fRlik+68IZw07RZgWagd69fiPAJ12N9A=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=dl1uAITdiByJc+r1+hUxJVh+hRdNG4RTjBoSTWp3vx0qwAar2zle63hTvqjpqkqmq\n\t TKmvid4fmzCREO4y2CJTWjoMX3tvvvK5pZ9eo6EFv/G2YwMn2cMTLoAm7Fy+MQt+lK\n\t YZPGr/Hwx8dmpOLdpY/Nl/Dh07scwVTxWvOO0JNl8AUJ+PyK0/kdsco58BzXlmcUwt\n\t mbIr/ejLI/yEIB4OL+bFwPLdI4PnA4KGKgiBTV7fIZgwAdcdY1xXRSzCCakoOB1wcK\n\t +oICL10lWhXTNurMEa7YLuUTiR6U2c0Fe2vtSJRLgCM1yS5I12jkwYnL1NgfGbS55O\n\t i1vuPREYTpj/Q==","Message-ID":"","Date":"Sat, 28 Mar 2026 13:44:13 +0100","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] soc: fsl: qe_ports_ic: Add missing cleanup on device\n removal","To":"Felix Gu , Qiang Zhao ","Cc":"linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,\n linux-kernel@vger.kernel.org","References":"<20260310-qe_ports_ic-v1-1-608293026561@gmail.com>","Content-Language":"fr-FR","From":"\"Christophe Leroy (CS GROUP)\" ","In-Reply-To":"<20260310-qe_ports_ic-v1-1-608293026561@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]