[{"id":3660551,"web_url":"http://patchwork.ozlabs.org/comment/3660551/","msgid":"","list_archive_url":null,"date":"2026-03-09T09:54:43","subject":"Re: [PATCH] serial: goldfish: Add DEBUG_UART support","submitter":{"id":74011,"url":"http://patchwork.ozlabs.org/api/people/74011/","name":"Daniel Palmer","email":"daniel@0x0f.com"},"content":"Hi Kuan-Wei,\n\nOn Mon, 9 Mar 2026 at 18:10, Kuan-Wei Chiu wrote:\n\n> I think we should also call debug_uart_init() in qemu-m68k.c. This way,\n> the string will be properly printed when the\n> CONFIG_DEBUG_UART_ANNOUNCE option is enabled.\n\nI looked up the other callers to debug_uart_init() and it looks like a\nlot of them are in the start.S for the arch.\nMaybe it should be added to arch/m68k/cpu/m680x0/start.S?\n\n> > + void *base = (void *)CONFIG_DEBUG_UART_BASE;\n>\n> It might be better to use CONFIG_VAL(DEBUG_UART_BASE) here to keep it\n> robust for potential future SPL/TPL builds.\n>\n> Also, since this is a mmio register, I think casting to void __iomem *\n> would be more appropriate.\n\nNoted. I'll fix that up.\n\nCheers,\n\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=0x0f.com header.i=@0x0f.com header.a=rsa-sha256\n header.s=google header.b=BcX4NImF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=0x0f.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=0x0f.com header.i=@0x0f.com header.b=\"BcX4NImF\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=0x0f.com","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fTsnc1Stqz1y04\n\tfor ; Mon, 09 Mar 2026 20:55:16 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5F2AD83A8C;\n\tMon, 9 Mar 2026 10:55:05 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 4D95083BC7; Mon, 9 Mar 2026 10:55:01 +0100 (CET)","from mail-pg1-x531.google.com (mail-pg1-x531.google.com\n [IPv6:2607:f8b0:4864:20::531])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 40058839DF\n for ; Mon, 9 Mar 2026 10:54:56 +0100 (CET)","by mail-pg1-x531.google.com with SMTP id\n 41be03b00d2f7-c70fb6aa323so4006954a12.3\n for ; Mon, 09 Mar 2026 02:54:56 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1773050094; cv=none;\n d=google.com; s=arc-20240605;\n b=h9/RIH7aZr6modN3h/hsREjagXZr2QfPjc22zDiTYyoqMUjsmEVZbxWZ0paimmlxZb\n mrOpMHi+d9Pq9xCjmy34oH4GtZysrNUHAn6ZdLibCavP1aqpU9qAeHeP4jVOB7Iqf1Hs\n 0dyRmyvXujRmfAgPXXMy67i0v5KYXIxmmDN5ErUZ80a70LxhMxDbSLAMS9vRTcz/TuCD\n C+3MCFA0VflLJzBcMhUpbDOkKWyd758viOAZwo0adiSQw1Qm83XdAIxMLuwu2HZPH8Sg\n 59NP6dRy80HGDOopt2qsmG7FxuhsCBbgwz5XQu7CgxjgQDV75D336wnbhRpvJuvKJ/FN\n hpVg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=RTTtkgvq2dsJoy8MeHZv8MiUsgS6ayEJ+4f+JUw1rs4=;\n fh=mItdqSTowDZ7egH9Xgipm2VlE7NDJH3ClzVOu+9dhEU=;\n b=IBTQHvfSX5sIvPPktYTzvqVbcyXOErvcuXwDFB0ACd4jefmoDk+GGy/k7xdJ3fW0zL\n e9jo0K0TQH3MC8tPUUSQJ+5q+QlCphcTJf9/en5BmmJV6zWivHpl0gszHt4FH84de7w8\n GUXofAt1uYh6167olB7gTEEVGxQcIHLkei+lsdzk94ORsY2Zg9Af6XykTQB11+q72EC2\n 9BvBnLfInK/RogBGK9rPS6xO5cufLpCoxoVWY9OsPhNiojthsfQoTkQZxZJxXWs30zlc\n CV8lQU3MkFIqSYNEt92fjiLE7lS/G4nC0+P2im/Alyf/UmMAJ0lgZcSTR0SWoeuowANs\n jtGg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=0x0f.com; s=google; t=1773050094; x=1773654894; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=RTTtkgvq2dsJoy8MeHZv8MiUsgS6ayEJ+4f+JUw1rs4=;\n b=BcX4NImF/9qKLyQnVLgbvxsQcQPMH5wgRruL8ySH4OcpdVMY6d9vuHce4WOO48FKqv\n Q9oa/vHv/W4/lTaHFGJoKQ0Khh4qM6MOgBPUne2bplz0VzOnVCcRiMezl1g1icW26SFd\n hmcirGlXl8+i0jjOF5k9T4C0zQdfI901+XUs4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1773050094; x=1773654894;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RTTtkgvq2dsJoy8MeHZv8MiUsgS6ayEJ+4f+JUw1rs4=;\n b=GHHqAftPSqX3cDRFB2XzHIX39ZHJOE0WjVxwZqnskaNNTXapsYiB3Cwc2caIKRDj8O\n GYOMpWXI6zoSC/YFnAB5gtIzp7+zlvRRLieByWhAvToGKop1jFBYuBkbjNCax7PcOqK/\n 4gANa6PGsNUHqtE+KScMejJLjzxxrtCUoRwdPyI4SbGaMmqgfaaPeM/dmleVCEn7BZFD\n LPu+EOS/PGHp2zOg6BbJQwl7nSYoC3Cs0Xrvgh+CZJXuR4YX4PXlNxei5iDSorG893jF\n OZlWLJI3AY3lmZl12gjc7FrwB8Cr7UV0Utj4qynBwlcgupiy9/G4InUCROLMYNu+ABLi\n +jig==","X-Gm-Message-State":"AOJu0YwfIb9Kunq6mVvuxQGAlbwuM2Q6GE02JF3p0p9wRk92yprCSP5v\n Gw7cxs619apE4eG5V5pXWyhIsV/OoNRDbVsSygUF9eQxb0xL3Ro1lPaxZV3slEuIi09OY0x0bFf\n JRxZm3RIFk7SYYIXpUtehoDWCaqBbtaHtvwDm8j2Ayg==","X-Gm-Gg":"ATEYQzxSR5JwG3LKUuJosoisbEY91JA1W6b/mYDQl0GT3n/r5B739H5aAnGIaStn5g9\n NiCb0KfOqpY/dlnEcKmFemGINtwh5plI2SeOi+fJ0CEom0aOTEEZSOuX6YnRzR0usbMRts/eM2R\n 2RimS5mSMHFC6oPXz3qc8p3BVBnfGEMBCI35Ace4CWL2ca/Rg3UnMr4/zcN4XD0grMy3N2Ct2aY\n KOEVb/ZQsfNvr0sp9bnT3Rk/7UN9PB9W+DWPV9nUigIm9Qs3XatCwzZ0hSLVGhHTxEKfpnG+cYw\n k3zfG1T7tA==","X-Received":"by 2002:a05:6a21:b89:b0:38d:f084:e349 with SMTP id\n adf61e73a8af0-398590b6252mr9523257637.54.1773050094325; Mon, 09 Mar 2026\n 02:54:54 -0700 (PDT)","MIME-Version":"1.0","References":"<20260309023234.640209-1-daniel@0x0f.com>\n ","In-Reply-To":"","From":"Daniel Palmer ","Date":"Mon, 9 Mar 2026 18:54:43 +0900","X-Gm-Features":"AaiRm52qXejG9I1m0S1JH4GVlkeoSAi7Uj4jtLy49nBDwdbNPb185SdFk3UrUfY","Message-ID":"\n ","Subject":"Re: [PATCH] serial: goldfish: Add DEBUG_UART support","To":"Kuan-Wei Chiu ","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3660671,"web_url":"http://patchwork.ozlabs.org/comment/3660671/","msgid":"","list_archive_url":null,"date":"2026-03-09T09:10:26","subject":"Re: [PATCH] serial: goldfish: Add DEBUG_UART support","submitter":{"id":87364,"url":"http://patchwork.ozlabs.org/api/people/87364/","name":"Kuan-Wei Chiu","email":"visitorckw@gmail.com"},"content":"On Mon, Mar 09, 2026 at 11:32:34AM +0900, Daniel Palmer wrote:\n> Add debug support for the goldfish tty so it can be used for\n> early debugging. This will be really useful when adding support\n> for relocation etc.\n> \n> Signed-off-by: Daniel Palmer \n> ---\n> doc/board/emulation/qemu-m68k.rst | 10 ++++++++++\n> drivers/serial/Kconfig | 8 ++++++++\n> drivers/serial/serial_goldfish.c | 18 ++++++++++++++++++\n> 3 files changed, 36 insertions(+)\n\nI think we should also call debug_uart_init() in qemu-m68k.c. This way,\nthe string will be properly printed when the\nCONFIG_DEBUG_UART_ANNOUNCE option is enabled.\n\n> \n> diff --git a/doc/board/emulation/qemu-m68k.rst b/doc/board/emulation/qemu-m68k.rst\n> index 6c4de54cf6a8..2f2e6bd6444a 100644\n> --- a/doc/board/emulation/qemu-m68k.rst\n> +++ b/doc/board/emulation/qemu-m68k.rst\n> @@ -31,6 +31,16 @@ The minimal QEMU command line to get U-Boot up and running is:\n> Note that the `-nographic` option is used to redirect the console to stdio,\n> which connects to the emulated Goldfish TTY device.\n> \n> +Debugging U-Boot\n> +----------------\n> +\n> +If you need early debugging output enable `CONFIG_DEBUG_UART_GOLDFISH`.\n> +The base address for the UART can be found by activating the QEMU monitor,\n> +running `info qtree`, and then looking for the goldfish tty device and\n> +taking the mmio address.\n> +\n> +Baud rate doesn't matter.\n> +\n> Hardware Support\n> ----------------\n> The following QEMU virt peripherals are supported in U-Boot:\n> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig\n> index b84cb9ec781d..f6a696e6c94c 100644\n> --- a/drivers/serial/Kconfig\n> +++ b/drivers/serial/Kconfig\n> @@ -510,6 +510,14 @@ config DEBUG_UART_XTENSA_SEMIHOSTING\n> \t start up driver model. The driver will be available until the real\n> \t driver model serial is running.\n> \n> +config DEBUG_UART_GOLDFISH\n> +\tbool \"Goldfish TTY\"\n> +\thelp\n> +\t Select this to enable the debug UART using the Goldfish TTY driver.\n> +\t This provides basic serial output from the console without needing to\n> +\t start up driver model. The driver will be available until the real\n> +\t driver model serial is running.\n> +\n> endchoice\n> \n> config DEBUG_UART_BASE\n> diff --git a/drivers/serial/serial_goldfish.c b/drivers/serial/serial_goldfish.c\n> index 4ac2cfb62315..58c494918786 100644\n> --- a/drivers/serial/serial_goldfish.c\n> +++ b/drivers/serial/serial_goldfish.c\n> @@ -115,3 +115,21 @@ U_BOOT_DRIVER(serial_goldfish) = {\n> \t.priv_auto = sizeof(struct goldfish_tty_priv),\n> \t.flags\t= DM_FLAG_PRE_RELOC,\n> };\n> +\n> +#ifdef CONFIG_DEBUG_UART_GOLDFISH\n> +\n> +#include \n> +\n> +static inline void _debug_uart_init(void)\n> +{\n> +}\n> +\n> +static inline void _debug_uart_putc(int ch)\n> +{\n> +\tvoid *base = (void *)CONFIG_DEBUG_UART_BASE;\n\nIt might be better to use CONFIG_VAL(DEBUG_UART_BASE) here to keep it\nrobust for potential future SPL/TPL builds.\n\nAlso, since this is a mmio register, I think casting to void __iomem *\nwould be more appropriate.\n\nRegards,\nKuan-Wei\n\n> +\n> +\t__raw_writel(ch, base + GOLDFISH_TTY_PUT_CHAR);\n> +}\n> +\n> +DEBUG_UART_FUNCS\n> +#endif\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=Tp5rY3av;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"Tp5rY3av\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=visitorckw@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fTyBf1LFwz1xwy\n\tfor ; Tue, 10 Mar 2026 00:13:46 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id AFE2F83F2A;\n\tMon, 9 Mar 2026 14:13:13 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 6A465839DF; Mon, 9 Mar 2026 10:10:34 +0100 (CET)","from mail-pl1-x631.google.com (mail-pl1-x631.google.com\n [IPv6:2607:f8b0:4864:20::631])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0AEAB83952\n for ; Mon, 9 Mar 2026 10:10:31 +0100 (CET)","by mail-pl1-x631.google.com with SMTP id\n d9443c01a7336-2ae50a33ff8so57242395ad.3\n for ; Mon, 09 Mar 2026 02:10:30 -0700 (PDT)","from google.com ([2401:fa00:95:201:b804:b819:bea6:9fa])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ae83e57af3sm144119105ad.13.2026.03.09.02.10.28\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 09 Mar 2026 02:10:28 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,T_SPF_TEMPERROR autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1773047429; x=1773652229; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=i7rjWK49TUH9ekdp1QMxyQxU55YA5sQz5Chk7nKfYVM=;\n b=Tp5rY3avFDY4h1PRjCDjDCpvogVPCE501w1hYnSSKQ6baoAdeJGdq9NnjeQttuxr1P\n 10rNk44aEYpv8qD1X8Wpc8Zq7Ar6BEAm2cOGGVjI0GLBknSz7ZHrQ7O2GdNBBjt0QrFo\n moHNNI73vmQs1PPuLL4fy5Lxhn74WJwqDQbv5JtmCB+mjb6X3b0ac1mtp0f4k9NY1J31\n BpiySMspZlqoy9ln3UyRsaoCSSqZfAdtLec2jnuNaukGsG2Z5vx1reGzjRc0B1J1GBWy\n n3weja3epf5cjhJTuAC5BeoSo3yteMjVhxxm78W6TF2q8nswLCLsiTkSlhDlF4572d19\n 7KBw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1773047429; x=1773652229;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=i7rjWK49TUH9ekdp1QMxyQxU55YA5sQz5Chk7nKfYVM=;\n b=i678ysO1/UhCd2/DhqjuWRrQfr0lasqMrAk41HJCRmdteh/d5d+F4jUeER7ddsG1kh\n rypy3MVVyx8+LbGAniqSwBynma2wbfLoSQ0ZlRN9WHsR3orEunw1ndZVeHS3zq/tt8IA\n f2uxNTkG1KNuOhAKjnxH/Dy1v0QxjCG6hmlHDTTsK7f0K+RHEgO9Ht86CbLKhJGjO9I9\n jO3LLs60h+XukJVfunLmzqq7u0g9HUHfyVHbK1Ux3FROBYNqGISsGZJEd5Zv9/y1C1R9\n giaScHzzobmIWGhL3mYTcb2gD/DbIfP5OjqNYPWMdSOmRWsxxy54YGUKIbNlQJaETBSD\n J0iQ==","X-Gm-Message-State":"AOJu0Yzii+UwX+Bkc/5CXBnZHqUsb2MGkyVYbGAlAqvQei7YImWBWfMl\n kDOBBFW60bDSQ21ouT1IQYsFE27nmjs2WYpk0wIXcHmzRpi9XAxypjfghRM18oeO","X-Gm-Gg":"ATEYQzyAxSWfq4WGGLpTBeDFXCAlQzozyTl32nxqCmv+JvnL2SRXswzaBRtLp1ZwyBJ\n NnU22kPkquCwaQhdS3mwbjb49KhhXACWk8hURKUO+IeCsW0kzATZk71uGGCAG5bItRdMcyHv+zN\n ZyR8KU3tuAREIPr6CMKIYtcPk8H1Z7A1lh7VwhTQ6VXd3TUwfxCJX6acA6X1/uCgOofNBu2EJQx\n p0KtCC2Q7t8R3h0RW/nIP/U6TyA6UbmCPT8/Ro5hex0GIewEY+PhGWrd4IQTXqzrEgXisdVrysH\n x5bOcumb4fqn1xLqalABEJqZ+N9tQQF01WKooFy+NQYfYQQ7ijwwDImnirz7A4bS7HsW79put4x\n fmhgZSrITRXZGylO25PqtTsBoQ1Og8PKO+JtW/eLsKdQhk3FwTwHWFGmFXBMIyf+622hUvwUadc\n pne+EwWM7tiaxqeMfh2/ZdQMvvM31AegOYXxcHJPbWkg==","X-Received":"by 2002:a17:902:e5c6:b0:2ae:7f84:79e3 with SMTP id\n d9443c01a7336-2ae823840ebmr109033535ad.16.1773047429308;\n Mon, 09 Mar 2026 02:10:29 -0700 (PDT)","Date":"Mon, 9 Mar 2026 17:10:26 +0800","From":"Kuan-Wei Chiu ","To":"Daniel Palmer ","Cc":"u-boot@lists.denx.de","Subject":"Re: [PATCH] serial: goldfish: Add DEBUG_UART support","Message-ID":"","References":"<20260309023234.640209-1-daniel@0x0f.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260309023234.640209-1-daniel@0x0f.com>","X-Mailman-Approved-At":"Mon, 09 Mar 2026 14:13:07 +0100","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676224,"web_url":"http://patchwork.ozlabs.org/comment/3676224/","msgid":"","list_archive_url":null,"date":"2026-04-12T01:03:05","subject":"Re: [PATCH] serial: goldfish: Add DEBUG_UART support","submitter":{"id":74011,"url":"http://patchwork.ozlabs.org/api/people/74011/","name":"Daniel Palmer","email":"daniel@0x0f.com"},"content":"Hi all,\n\nOn Mon, 9 Mar 2026 at 11:33, Daniel Palmer wrote:\n>\n> Add debug support for the goldfish tty so it can be used for\n> early debugging. This will be really useful when adding support\n> for relocation etc.\n>\n> Signed-off-by: Daniel Palmer \n> ---\n\nI think this has been reviewed and out of other comments for long\nenough now? If possible can someone merge it?\n\nThanks,\n\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=0x0f.com header.i=@0x0f.com header.a=rsa-sha256\n header.s=google header.b=lnPg4SCW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=0x0f.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=0x0f.com header.i=@0x0f.com header.b=\"lnPg4SCW\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=0x0f.com","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftXNF0r3nz1y2d\n\tfor ; Sun, 12 Apr 2026 11:03:25 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5AFF8840D8;\n\tSun, 12 Apr 2026 03:03:22 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 99F7384119; Sun, 12 Apr 2026 03:03:21 +0200 (CEST)","from mail-dl1-x1230.google.com (mail-dl1-x1230.google.com\n [IPv6:2607:f8b0:4864:20::1230])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A04DB83B99\n for ; Sun, 12 Apr 2026 03:03:18 +0200 (CEST)","by mail-dl1-x1230.google.com with SMTP id\n a92af1059eb24-1271257ae53so10715912c88.1\n for ; Sat, 11 Apr 2026 18:03:18 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775955797; cv=none;\n d=google.com; s=arc-20240605;\n b=b9kjFk52zsvwsLB5Wn95xozJusHe1776RqxUjucEDZkxfI+TD5GNjDWDfyf/l5/nP7\n LmINPmESlGFDQMbE0v0f+hhM/csvUZ9krBZPcKB7GjU45lGVis9Yzc24ecSd9tOmhFhb\n Qz9U9zTfIesDC1XjbqofHcToElrEqKtKI6r0rcPk8lCoTIQMJVg2eEt7K8DMZ/CLLFLZ\n b7OFNY1U/2m6QxMCh/MECslB658swH+ztSOu8+Vv7CYqcMdGeRvkYZoL7EmTgJFvqXNf\n KNYWIobZnrrLsfS+PcClZQIJOzNktjzH6yrTLwmH7ka8EP77Y7u05cAbQE1mloPJLGVG\n n7Og==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=pmF4IZ7ic50+s7xzF9RYEl31EVWqjW8pGMTSm8FFmVU=;\n fh=eZ6IlrSom3HSAjlBd+7yT11s6lqFz4g2SScpur249K0=;\n b=dNXWCAMX5Mv9IRD/U0eKfyT60bfOgFAkIt013YjLMyM/FQHhBOsDuiftwTfK1t19uD\n ELNqqJtHT3R3ekr2MkpLM1SPB1tCoPbWo838+nh3dFBA8uiumJ+fEeMFb6gn0LoAljho\n RaDTFAwK4oZ8bhC9xVLT2XOnHipMgOddmZAKz4vay4dAPBmu3R8jOMzf+HJtpZ8YGtHI\n xsAjws5BIX15XVXM/RUq9dzC/soBIlVbDFI3SQYEdGbbWbquyq2oDvSYwvLNWe879gY2\n pPR/aftq5DlVUBMKzrlcvNCXQzoeoyB8XN6nJ2a2W1Ep4X07WrHc1Y7vCu/mzGShlkOb\n MCkA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=0x0f.com; s=google; t=1775955797; x=1776560597; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=pmF4IZ7ic50+s7xzF9RYEl31EVWqjW8pGMTSm8FFmVU=;\n b=lnPg4SCW8MnrasPCL7qwR9Jq82olmnshuF0PCZbwjNW55qNSyz5sB1Nh8BqsaBARNC\n qo02lCc8O9B9TEi2qkUGqJQGsM21etO7VR+jfVbLwu+uDNlRGt7s5CWl3W9pzcPWd8xx\n hciuHY7c9d+f851WtPxrIjlA1ERY70nYe89gw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775955797; x=1776560597;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pmF4IZ7ic50+s7xzF9RYEl31EVWqjW8pGMTSm8FFmVU=;\n b=VEn56aT9upttdA7Tla3lx0r0T28neWcn0aO40PngDgm5x7OQnus6yaarKABWKGwef3\n kOy9cbDzd3T9kZnIvZXPAWq1OiMH/dKGZksRHfEx/z4DDhfYWgaxw7khOAWXXqXKV3rJ\n 7qNO7O1M4L3KF43KX+rGS68Og/scaRy7/HNDfl7eqyCY6TPtN09yUjP7DwOq38XVwref\n CS8o+c05iCkogm+dFwYxgvLCdCNfrehcH7k4sRnJZkbpnfpnwPFPXynMmJ897nA7ds2I\n IAVHqnwPtBDfivNq0NBRPwG680Ppdv7ZK3D/fnAeSftC5KNNVRUPTtaLfc0r2grRCbpC\n agxg==","X-Gm-Message-State":"AOJu0Yw/cSxYrrW4l+/JVpjXlCpUXuD3Z0WuByuFLBg/NHUbxmfE+sqz\n Yq9dI0X7SVSeHLytR7zbCEsT0+uR/xh457wDHpOHBoH7vEK3lDeBBXva0l+L618F/Ebjvkw8t3G\n 3ZexAwDKUeuAdl696N1c36Z8RPBknycso6ak60tOY/7pmBRuKi9hI","X-Gm-Gg":"AeBDievR+obG8oecjDDWjif4lKU7dgnsZ8d0xP+1UA3P3aWVNib6vfieBLwttNfohAq\n QIcK2jud4vVEPNdBK4JulnNxbGAuAZ8VEZ+3BA0Oygdmcz0qVvTo0FER7sLl9OYsN7RgFCaPhsE\n lqMaXzBLJMDE0dwiOKnSuP2DZxsK5mCzWf6CVq+3eQghBb3uRDP468XA1Ld46L3MnxEBfpNDxky\n r3jhhHfgm8lHI8MWyxj4eyrfSJjCqSeuXmPH3wKaYtIY64vkmmUO6t0cH83+psaNURm46WmOj2w\n Octv","X-Received":"by 2002:a05:7022:327:b0:12a:6c4b:9cf0 with SMTP id\n a92af1059eb24-12c34e68d9cmr4875442c88.3.1775955797019; Sat, 11 Apr 2026\n 18:03:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20260309023234.640209-1-daniel@0x0f.com>","In-Reply-To":"<20260309023234.640209-1-daniel@0x0f.com>","From":"Daniel Palmer ","Date":"Sun, 12 Apr 2026 10:03:05 +0900","X-Gm-Features":"AQROBzBYlDvziBOzr1miyoNTwyTVPbM6hvQJ2yknaCsP5zfxN-e-Sr7a4cLXz-M","Message-ID":"\n ","Subject":"Re: [PATCH] serial: goldfish: Add DEBUG_UART support","To":"visitorckw@gmail.com","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Angelo Dureghello ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]