[{"id":3677520,"web_url":"http://patchwork.ozlabs.org/comment/3677520/","msgid":"<a5545cd8-9a37-4793-b020-98a577598e11@altera.com>","list_archive_url":null,"date":"2026-04-15T07:47:29","subject":"Re: [PATCH] arm: socfpga: Ensure FPGA in user mode before enabling\n the bridges","submitter":{"id":90079,"url":"http://patchwork.ozlabs.org/api/people/90079/","name":"Chee, Tien Fong","email":"tien.fong.chee@altera.com"},"content":"Hi Dinesh,\n\nOn 4/3/2026 11:43 am, dinesh.maniyam@altera.com wrote:\n> From: Dinesh Maniyam <dinesh.maniyam@altera.com>\n>\n> Unexpected behavior and error can occur if FPGA is accessed in unknown\n> state.Always checking with FPGA in user mode is required to ensure\n> system stability.\n>\n> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>\n> Signed-off-by: Dinesh Maniyam <dinesh.maniyam@altera.com>\n> ---\n>   arch/arm/mach-socfpga/misc_arria10.c | 13 ++++++++++---\n>   1 file changed, 10 insertions(+), 3 deletions(-)\n>\n> diff --git a/arch/arm/mach-socfpga/misc_arria10.c b/arch/arm/mach-socfpga/misc_arria10.c\n> index 7e0f3875b7c..6b25ab917ca 100644\n> --- a/arch/arm/mach-socfpga/misc_arria10.c\n> +++ b/arch/arm/mach-socfpga/misc_arria10.c\n> @@ -13,6 +13,7 @@\n>   #include <ns16550.h>\n>   #include <spi_flash.h>\n>   #include <watchdog.h>\n> +#include <asm/arch/fpga_manager.h>\n>   #include <asm/arch/misc.h>\n>   #include <asm/arch/pinmux.h>\n>   #include <asm/arch/reset_manager.h>\n> @@ -126,10 +127,16 @@ int print_cpuinfo(void)\n>   \n>   void do_bridge_reset(int enable, unsigned int mask)\n\n\nmask is unused on Arria 10—please mark it __maybe_unused so we do not \ntrip -Wunused-parameter while keeping the shared API.\n\nExample: unsigned int mask __maybe_unused\n\n\n>   {\n> -\tif (enable)\n> -\t\tsocfpga_reset_deassert_bridges_handoff();\n> -\telse\n> +\tif (enable) {\n> +\t\tif (is_fpgamgr_user_mode()) {\n> +\t\t\tsocfpga_reset_deassert_bridges_handoff();\n> +\t\t} else {\n> +\t\t\tputs(\"Bridges: Failed to enable because FPGA is not \");\n> +\t\t\tputs(\"in user mode\\n\");\n\n\nSingle line puts is preferred\n\nExample:\n         puts(\"Bridges: failed to enable because FPGA is not \"\n                 \"in user mode\\n\");\n\nBest regards,\n\nTien Fong","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=altera.com header.i=@altera.com header.a=rsa-sha256\n header.s=selector2 header.b=cHzdVPi8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=altera.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=altera.com header.i=@altera.com header.b=\"cHzdVPi8\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=altera.com","phobos.denx.de;\n spf=pass smtp.mailfrom=tien.fong.chee@altera.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=altera.com;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwYCS6Vrsz1yHM\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 17:47:48 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2737883D8A;\n\tWed, 15 Apr 2026 09:47:46 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A1CA68407D; Wed, 15 Apr 2026 09:47:44 +0200 (CEST)","from SA9PR02CU001.outbound.protection.outlook.com\n (mail-southcentralusazlp170130001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c10c::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7450B83936\n for <u-boot@lists.denx.de>; Wed, 15 Apr 2026 09:47:42 +0200 (CEST)","from CY1PR03MB8121.namprd03.prod.outlook.com (2603:10b6:930:106::16)\n by CHXPR03MB989196.namprd03.prod.outlook.com (2603:10b6:610:2fd::5)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Wed, 15 Apr\n 2026 07:47:38 +0000","from CY1PR03MB8121.namprd03.prod.outlook.com\n ([fe80::fe3c:a06b:8724:fab0]) by CY1PR03MB8121.namprd03.prod.outlook.com\n ([fe80::fe3c:a06b:8724:fab0%6]) with mapi id 15.20.9769.046; Wed, 15 Apr 2026\n 07:47:38 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=G7+CADbtejua/OjuzRpslRPWeKEmFCD1J34CtSav7FthrBj6txGGQBc6eMBs6vcvB9KuKJLjQRiMrARFGYFWzbe9h/UbekfgMcDFNddLyKtJ1X1UdsQ+lrItrw6W3ARH12evhPRmxSaM4u3J2E6RJdyuAIfTZYdZc/w3f1c50mXUM4MuHKUAhlgZFwdN7omwse8SAKCyyKGDmhJnK+1D7flP+HdPOychWTXgTa/uPLkioAKdh/PYUF0onuMWdHymNVtOuks87ObtSnEfBF43q4LkqV4/ynWPiwIFN012kU/3z2t06pM84bQyMMBdCQlYhGGI4ENkRivAfNmxWZJbwg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Isrb7AoIyCl1rPiUU32JryKNEqxcD3TYxRH6EvEPivI=;\n b=iYNRYdpG53+FWH6okcWvBNw1uYIX3dCBzRaGGYo0CBzQjiiDrkNLab/u7pbIhOf4Xt25mhrvYaYMJ5+XabEaL7qGmZl9btd6QomLhBhWIh1pTURTOOJpoxlgoJ+c/AF0gsYnZQXYrGxrqztgIwEt9lwVH8yjtxEIhi9zh1KmW+fB8b6F2OC6K0tHc+QmGpfnSGxnJDsEHKszOtqa8fxGEIF03OoiEAKWAJZfFjo4+TseUuWTJaNX1MQ9Fl9Elo75i7SgYcbiwgDKbdm1NeLYDkreOA3SDx/VJEeodD76dvHl6htEW6PABK1i3pup+Qr4Nx3YwE9ZAM6IErnEAplPTg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com;\n dkim=pass header.d=altera.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Isrb7AoIyCl1rPiUU32JryKNEqxcD3TYxRH6EvEPivI=;\n b=cHzdVPi8d95D78BEecuVjdEWo/f/ouAEEBYa+8yYM6dbhRU8CjC7B1ySgw3G2PsGNAtJ7fER/S4Mhsc6TMSdHGuCwyB8d7FOxpGGrwSjNG37pCdCDd9v5MItx1p/UAI4UK3b65TbW4tEQi0jV6uVkhFHUU2sLcyDi3rYCw8tc9ZMuqnh2d/FyuNLtCX83HjPZgsrVQCfqyEvSLsmU0GXE+oBhuftshcVSfpW6eI9u7KCAgUKyGePeXnaipECB2UC8wMzuIvi5Q7CMCB1wZfFc7fvqXL1VCeCWSjVqIR2+cLDo4HpHiWVnDEVLuAWkDEKm4FID5ZWWU52Sj3oNvwyVg==","Message-ID":"<a5545cd8-9a37-4793-b020-98a577598e11@altera.com>","Date":"Wed, 15 Apr 2026 15:47:29 +0800","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] arm: socfpga: Ensure FPGA in user mode before enabling\n the bridges","To":"dinesh.maniyam@altera.com, u-boot@lists.denx.de","Cc":"Marek Vasut <marex@denx.de>,\n Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>,\n Tom Rini <trini@konsulko.com>, Michal Simek <michal.simek@amd.com>,\n Kok Kiang <kok.kiang.hea@altera.com>, Boon Khai <boon.khai.ng@altera.com>,\n Alif <alif.zakuan.yuslaimi@altera.com>,\n Tien Fong Chee <tien.fong.chee@intel.com>","References":"<20260304034354.2871-1-dinesh.maniyam@altera.com>","Content-Language":"en-US","From":"\"Chee, Tien Fong\" <tien.fong.chee@altera.com>","In-Reply-To":"<20260304034354.2871-1-dinesh.maniyam@altera.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"SI2P153CA0002.APCP153.PROD.OUTLOOK.COM\n (2603:1096:4:140::16) To CY1PR03MB8121.namprd03.prod.outlook.com\n (2603:10b6:930:106::16)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CY1PR03MB8121:EE_|CHXPR03MB989196:EE_","X-MS-Office365-Filtering-Correlation-Id":"70f34455-2e04-4996-c79e-08de9ac343df","X-MS-Exchange-AtpMessageProperties":"SA","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|1800799024|366016|55112099003|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n 4gC/FKY2a6HSVKTX60G1CLo9Q0hddGMDTP86o9RkNGcPZz8aB5KXWvmVr6NvhgiAbJxXvKSTkaIzrqb253sMbwz7AWQfwArfuVwgbwK8L5An2h/+1TXVrpmvXGoOGGlL2rzSerU2mVbx9O16L3c77v2PnNXI3QFdSrgpxqx9v0W0zwEjYe7ZVVQT6vjNBAl4/CIqga5aU2UAHz/WcpDF9VR3DA6tNXr+qsHJHYIVuTADmCTgBaZfP6G2OEFomXkxrm1LS9IuSPmH+VxRF1ENnWtjXYnqjLDzl4Xz6q21BxRZ+kqbWxjbK9Fith6pdryolaQNZ8RnAD2ithP617qIFugzplT5FyoyHO7pxwUEYCyrZ9oH4rgUA2L7OqGYn3m6ByTYAImfwKksOLIYmCFcuLbSvOEfEqKRRIQ/d2YX7UR10pypUAsDJMFrd4X28432kkcxpNLXPJ58J+v2niwQXlbatJhV7Ixr6aMj2ot6tIRFdTqVGJ4fLAbPmV2n4ehLGKSEeaZ4bbLcolFi9BGhrfN9B6d/ZvmMFRo5mP+Hzb6AuOcWnsUEU/aA7V2LCFSE6kU1SQLmJ1RkkRyhlsICqwmiO9U0Jkj28XwbuQbiOstXVOmDvKdk70KEegtytVZ7cX9/gsGxfEeKv4OLoaaf6SpngWFa+RMKWz9OWeIbU34iAgeFesmT23KCO18RsgtxGYrLusIrAzsnGqbaDiJXV3a0n1Q8Ox4ChrggpAhpNU8=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:CY1PR03MB8121.namprd03.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(1800799024)(366016)(55112099003)(56012099003)(22082099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?hNxrRN04qze1OyzzBZk1ZdYu0S/P?=\n\t=?utf-8?q?xnCNe5DqVTT/Y+ccTpBog7rHZO4m3yvJm+zY6Xkj8EjpUCRE9J56sGpxL5TwzuFSp?=\n\t=?utf-8?q?y5vLRV/AIkRNthWu7OMlOtliVJXdtmh7ftfqYFeeCiBvgYXleC+esfxitSU+pMxXF?=\n\t=?utf-8?q?1ylUH8Oet8PO56I1vne87Qpa8aRMxshnYY1gyJnBDKqZbyiCRZrmrUYlnHI9FPLbh?=\n\t=?utf-8?q?/MpNYI46D9eQJrJ3iU1q36DNnWVcg3WTfAfCM8myWAZgE6SXLwRZqYfCqXs58zd2T?=\n\t=?utf-8?q?E4obfof7mpa614YQ19O+hNF1Iir1bUJ9Ct0o9HhSQpw0BDwAUggfQymkQS3vIMBls?=\n\t=?utf-8?q?2USOSDewDbBjHs2yV5HEXYgVgVsyx0W7PaN2gIq5OlRt+sWzD5C3B9bDlxoReiaCM?=\n\t=?utf-8?q?CBB6r2+KA6zL3Td0yeooE3kGvC99+gBbXZegSRO4zcQRhuUf5Pf/8nHhTNSLM/vSA?=\n\t=?utf-8?q?LS7cBWhJxTu+4mOPGfAj9Ni8U7++aHfIYujXvGxrekNBciW7nEyDrZ7QeGPljhL/W?=\n\t=?utf-8?q?9/6fWkE/u4UJQIfi1sNGsSt1QD7LDRIatSBDgwSBzJ80NzVA1qOd/ur60clIc0mig?=\n\t=?utf-8?q?VJq6h6SS5kY7YlpYz6pNv5wSZmHRHdJZ/YOCIO3gw7WAupiWeQlYrcZ3rIdRz6eO6?=\n\t=?utf-8?q?SHl1kO0hfik72ZMyUHU9KmDo1l/wv7booHUlRQFtxZ4gHLMNJ2XdJD0fbFCaTkAnR?=\n\t=?utf-8?q?nKAEE18bZUsiXEPlUao5jcqHMG2DVovM4rMB4t2NPLoZgQM/fk3tmvSduZhkQtHvm?=\n\t=?utf-8?q?+2wt9EU5AoRj7rXrf9goIl7EwrjH3im9XbcrEtgYTFrNEI2TyQF+gQE5li3BXxv0S?=\n\t=?utf-8?q?RoKRw4XsmYxXr5DaB1r67LHJIMyUU9WieEKS4AYeom1zr3Ilt2wZncDCIhCalkLXj?=\n\t=?utf-8?q?w/lS5wXrY0oEd7/8GN0FDwq42GoHzssxDmplxeGu1g2NisNgz2W9+FqEbZBweqsNW?=\n\t=?utf-8?q?M8KVxO4a4A1JvozZ0p8qj0DDomrZKRcvb6je4B9Ou2MRW3T13Zi11a0+unYxLn+v7?=\n\t=?utf-8?q?9XAFag+x7Lfb9l0A/kj8cV7nzgQEM5ZkznIYSOZ921CHFyCkRGSxxmtZlvwSBuOqc?=\n\t=?utf-8?q?chVuMxURALTnV3hp9PrhYoKbNjAQa8w764vyXd7nxrISKuL54Cf9460Y/zQQ/13vN?=\n\t=?utf-8?q?R32akmq25lr1zXK+9kj9LfVhm2g7zFuVsZERgQJ+MXB3Cf8CRdPa22zz42RTyb/mk?=\n\t=?utf-8?q?UrGsbfQQqI8ilcrlPrwGcV0egnBeJlgUdZPQhs2HqCz2dHWRsWp/rKbANT8KlU5qq?=\n\t=?utf-8?q?BB2wVs1YiO/HWU2grdoEkkUvPUXjpacxWpOHSbsNnlzkqwx+3I5VVc7TSUPvvs3o/?=\n\t=?utf-8?q?LggQJZHARgTfTEx+MkL0UzflTTTAWh6HwAXP1Eda4eGHMVgQXOgNaa0d6rHghdM7j?=\n\t=?utf-8?q?GhIh5/STeM9epp+fY6B6YiqyhA865NJ+ndWNpZjqpeQ0dGI9iw1bknsEBldKH8tyC?=\n\t=?utf-8?q?FCH465w3oS5Tk2Ma9/Ze6/l10+ExsSIdguYldYvzZusWvIueRiA9f16szJlFDSwGv?=\n\t=?utf-8?q?0iyHKhNI21lhpGQoIadDE6t8XqaxShtxPsio9Q/mpidYWde7XbLPCdQNXdxkSWpkD?=\n\t=?utf-8?q?QSbXUfDP2eDqHbAD8bITqQq0mfYbG0c8lO6hXZJRInJhhF75R9vRzFfYhRKZIXwty?=\n\t=?utf-8?q?hkize1gb4HgigYplYFXFjD/AYLUw0ByBZ5XFld+VqB/rQO+Pqm04o=3D?=","X-OriginatorOrg":"altera.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 70f34455-2e04-4996-c79e-08de9ac343df","X-MS-Exchange-CrossTenant-AuthSource":"CY1PR03MB8121.namprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"15 Apr 2026 07:47:38.2790 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"fbd72e03-d4a5-4110-adce-614d51f2077a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n FmZMXErmEmz5Niux4PPMUWCZCtIJ+zp+903iE2ZYRM7s/H7tDY2JfIjQFidUOqAgBwwvbXHPm2pIVqbYr91D57D2ObtvH1dej6lzGZ8mRtA=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CHXPR03MB989196","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3677925,"web_url":"http://patchwork.ozlabs.org/comment/3677925/","msgid":"<d0931b53-54bb-4fe6-bcd1-ebd38025ac17@altera.com>","list_archive_url":null,"date":"2026-04-16T04:14:52","subject":"Re: [PATCH] arm: socfpga: Ensure FPGA in user mode before enabling\n the bridges","submitter":{"id":90303,"url":"http://patchwork.ozlabs.org/api/people/90303/","name":"Maniyam, Dinesh","email":"dinesh.maniyam@altera.com"},"content":"Hi Tien Fong,\n\nOn 15/4/2026 3:47 pm, Chee, Tien Fong wrote:\n> Hi Dinesh,\n>\n> On 4/3/2026 11:43 am, dinesh.maniyam@altera.com wrote:\n>> From: Dinesh Maniyam <dinesh.maniyam@altera.com>\n>>\n>> Unexpected behavior and error can occur if FPGA is accessed in unknown\n>> state.Always checking with FPGA in user mode is required to ensure\n>> system stability.\n>>\n>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>\n>> Signed-off-by: Dinesh Maniyam <dinesh.maniyam@altera.com>\n>> ---\n>>   arch/arm/mach-socfpga/misc_arria10.c | 13 ++++++++++---\n>>   1 file changed, 10 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/arch/arm/mach-socfpga/misc_arria10.c \n>> b/arch/arm/mach-socfpga/misc_arria10.c\n>> index 7e0f3875b7c..6b25ab917ca 100644\n>> --- a/arch/arm/mach-socfpga/misc_arria10.c\n>> +++ b/arch/arm/mach-socfpga/misc_arria10.c\n>> @@ -13,6 +13,7 @@\n>>   #include <ns16550.h>\n>>   #include <spi_flash.h>\n>>   #include <watchdog.h>\n>> +#include <asm/arch/fpga_manager.h>\n>>   #include <asm/arch/misc.h>\n>>   #include <asm/arch/pinmux.h>\n>>   #include <asm/arch/reset_manager.h>\n>> @@ -126,10 +127,16 @@ int print_cpuinfo(void)\n>>     void do_bridge_reset(int enable, unsigned int mask)\n>\n>\n> mask is unused on Arria 10—please mark it __maybe_unused so we do not \n> trip -Wunused-parameter while keeping the shared API.\n>\n> Example: unsigned int mask __maybe_unused\n>\n>\n>>   {\n>> -    if (enable)\n>> -        socfpga_reset_deassert_bridges_handoff();\n>> -    else\n>> +    if (enable) {\n>> +        if (is_fpgamgr_user_mode()) {\n>> +            socfpga_reset_deassert_bridges_handoff();\n>> +        } else {\n>> +            puts(\"Bridges: Failed to enable because FPGA is not \");\n>> +            puts(\"in user mode\\n\");\n>\n>\n> Single line puts is preferred\n>\n> Example:\n>         puts(\"Bridges: failed to enable because FPGA is not \"\n>                 \"in user mode\\n\");\n>\n> Best regards,\n>\n> Tien Fong\n>\n\nThanks for the review. I’ll update the patch to mark |mask| as \n|__maybe_unused\n|and combine the |puts()| calls as suggested.\n\nBest regards,\nDinesh","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=altera.com header.i=@altera.com header.a=rsa-sha256\n header.s=selector2 header.b=EEAPoczA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=fail (p=reject dis=none) header.from=altera.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=altera.com header.i=@altera.com header.b=\"EEAPoczA\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=altera.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dinesh.maniyam@altera.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=altera.com;"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx4Rj2F68z1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 14:15:13 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3FB7583EEF;\n\tThu, 16 Apr 2026 06:15:10 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id CA2B384105; Thu, 16 Apr 2026 06:15:07 +0200 (CEST)","from CY3PR05CU001.outbound.protection.outlook.com\n (mail-westcentralusazlp170130007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c112::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A8F0683B99\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 06:15:03 +0200 (CEST)","from PH7PR03MB6942.namprd03.prod.outlook.com (2603:10b6:510:157::18)\n by DS4PR03MB8397.namprd03.prod.outlook.com (2603:10b6:8:328::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Thu, 16 Apr\n 2026 04:15:00 +0000","from PH7PR03MB6942.namprd03.prod.outlook.com\n ([fe80::8f8a:2a94:f5a8:ea1a]) by PH7PR03MB6942.namprd03.prod.outlook.com\n ([fe80::8f8a:2a94:f5a8:ea1a%3]) with mapi id 15.20.9769.046; Thu, 16 Apr 2026\n 04:15:00 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=j3dKGuHJ1uvTkEAd/sWNILQZW7BLgqq88YXN11SZmg1AVRCVZpFA4CY5Pnnc2AwWElM981Gykkj5GTk/ItLZ7fWe7KnTN/ga4s65E6LNy1NlHm9qakLYgTszvVCSCL5fFV1lDVrvCbnsTXqpbC7krAwfVJXTJ4qYRxOdiD5PG2+3kgaiW25jMNYOoMEq5WFA13/pBqAzcTAmQXwKxGlyN6PX+fsnmjjg8kzkcDv3rejLmBz/Eo65okz2h9eeK7CD10arNByTqSoFhhE4p8OGXZINo+iwMgcprH2oquk4Xw5Ub7QMp/F9b8FSTlm7YPQg3NMaVXLMP74Gd5LzLNDWng==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=KMNgQwCTF/IVA8EcFJNaOrlML665QObQ2I4vrOLoL8s=;\n b=UXThv8XmsHVweGsBA64b4c0XMN2WsmYjAMoSIp2sv6EdL3ZnOxJMzg3RfOeftMaxf8kvA76GLX9TL9qlZG621fIjhqWApuC8OblYZ9J9mGST26UdKRjR4AXtFmqAsqvhlqEW+WPzwMICoGdldZtKW4FrxapKi5QmnxcCw6Mq3wa5OHHhrZHeRdZ8dwVpcK4Y3LYd/Ldb3bPLHiYH3hlIjbKcvQTQrpcu8tLzZNNfyh3eQmnorQbqBrQAUIUmTjETjm3ATbUXLNKDJNtbSVR43khaHMPB+9A2FoXnCObMYmoo9RL98G79iXtjgPwfU4JuE2JsN/8So6UQF8EBLJebHg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com;\n dkim=pass header.d=altera.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=KMNgQwCTF/IVA8EcFJNaOrlML665QObQ2I4vrOLoL8s=;\n b=EEAPoczAFPc0Aj/JIJjAD0mi0ON0yJ9JjJAofyZV3dbTdpxpzb6O0hwsCFClKfyg2xPxZydn6KrVzwKlP2yyovfYe+usxMGt7MiOP9eFpFjsS+koGJvOcsrbK9byV9JZ9TB7Ni/UqVL+7uSRjt/7F7Hv/AOEbAqNMp8aV4vgubcQkkvhDneUxQ32rrtbk3pZn+9EwKMBo142+WTj8NmoTJ365Zui8zPEaNKBxP+qpknb2eY4+qcDpPSxbWMHH5gUObKHZDM6IJbEpG0omuIlfKnuxMs5NcfNlwytb+4O6bdD0b3/LFYLR0DVSpl9CSxiczGwOkYQu5ahuHG++97dIw==","Message-ID":"<d0931b53-54bb-4fe6-bcd1-ebd38025ac17@altera.com>","Date":"Thu, 16 Apr 2026 12:14:52 +0800","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] arm: socfpga: Ensure FPGA in user mode before enabling\n the bridges","To":"\"Chee, Tien Fong\" <tien.fong.chee@altera.com>, u-boot@lists.denx.de","Cc":"Marek Vasut <marex@denx.de>,\n Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>,\n Tom Rini <trini@konsulko.com>, Michal Simek <michal.simek@amd.com>,\n Kok Kiang <kok.kiang.hea@altera.com>, Boon Khai <boon.khai.ng@altera.com>,\n Alif <alif.zakuan.yuslaimi@altera.com>,\n Tien Fong Chee <tien.fong.chee@intel.com>","References":"<20260304034354.2871-1-dinesh.maniyam@altera.com>\n <a5545cd8-9a37-4793-b020-98a577598e11@altera.com>","Content-Language":"en-US","From":"\"Maniyam, Dinesh\" <dinesh.maniyam@altera.com>","In-Reply-To":"<a5545cd8-9a37-4793-b020-98a577598e11@altera.com>","X-ClientProxiedBy":"SI2PR01CA0019.apcprd01.prod.exchangelabs.com\n (2603:1096:4:192::12) To PH7PR03MB6942.namprd03.prod.outlook.com\n (2603:10b6:510:157::18)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PH7PR03MB6942:EE_|DS4PR03MB8397:EE_","X-MS-Office365-Filtering-Correlation-Id":"6553c4f1-9e14-4caa-e64d-08de9b6eb9ec","X-MS-Exchange-AtpMessageProperties":"SA","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|8096899003|56012099003|18002099003|22082099003|55112099003;","X-Microsoft-Antispam-Message-Info":"\n DjpYkTyLmE+pNUnjIzhzS+M5RXVLiNA/TTNZHRTKv928qZQ6ZzpUBsMM6PxZjiGlm4oLDigFxjDylIpsrZ0Xs+hH8JfZ8627z5V2ahK1A4i8zjlw5lSyWJIuAmnyDvC1KK3Djd3VxeKuOw60TypMzgD/uEOCJoQPTcgK4V8LB7VKdU06fDxfHRNkwjswfT8Knl7765HDqJunV1tc0a1LzQ0xZOk/ps88mhk9WywcWueWK7FmfjobjL7MEj/RGcCQRImWUl09DcT7g32Ez2wIZj+VEZ6Z81pMzLr+V+rdxG84kAsu2x8kU+SzigY+6Wo+fVmbZcMVN0Y/DoNbLHvP8wxwb4HhT7ERe3YVwWGbm/vN0lpfylR6oMcxv4LwQkz0DyKBNTyqx9vTfmUWuskwBV3eO4z4mZQRQAGjDM6o8qHDxzKplj0i8H+beQjFu8dBgah1bYX4JFNIKCmcJyUHcR3lnUAkzQ3yjuE/fhw27QQBpm1WfdIO7KAG0m8mW7tphopTRUXol63qsaYIVvmKw0XHEeJdfiAyPIh9AZ8p2NSUiIVn/K4G50e0SdOnDBBNe5QdyTB8SyvJFPk2y+t27qDiYL5jGrQ1TF84W7w/gv3JYUPvtb8KpXDRMyPVJmDJCSNwMnnyFfBhMvOK55Cq33L8HCgstWCBp/BdrgFD/a5rzWlADtSCnA11+Tx9z0qT7b9sLFJjg90qn86tyzRCYcPjkmhmeVbIyLR639GZh/c=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:PH7PR03MB6942.namprd03.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(8096899003)(56012099003)(18002099003)(22082099003)(55112099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?izWyR1Gpy1/qZejltQny8ioc49H1?=\n\t=?utf-8?q?8osKNxAwXkW7mYlfbW+xkh3a7Hk9fR5vLcvjp17OqtFWC15Vw8xaBV7/4jYB5R/FT?=\n\t=?utf-8?q?GEocTb4opVWf3yrHxUk9yDuEX7SGxXOxDu69riIjytcctapQ9YX9KC69t4ayr6HF2?=\n\t=?utf-8?q?fbPr7f8y/zzTmC4KCQnZwj0l3QLQRGztN/wEQ3j9OU8VWkiAwIRZHmUF0j3PCKUgI?=\n\t=?utf-8?q?BCWWL33a5FyqDPw6bs4yj2cxXxqVI/XFT6kz3PiJB8bIBPwHE+eJYCWkiEg7M0iRP?=\n\t=?utf-8?q?Iv7CJHJ5w0wTx7KIBreRVby0FBXXqb+gETU342lnYPyXlrFFsQ00dqnNiecCGLUYS?=\n\t=?utf-8?q?23NF/3y9k4WFyO6PpBnu/2zgdFnEpGMUK8qM9CV/o0Lt7pyGOn2TXsFahq19gpFcW?=\n\t=?utf-8?q?h46sQ8kCbBQzRvmHBQ4WAmEGzcj16+rorPMqC5JeX/lHYHE9tLVX/Fn+ep4Ytf+Iq?=\n\t=?utf-8?q?eJzk4w1VzG0VTZNda45WLx/ocIMAorYEokbWT3E9FGvxkz6kXz1t5q8aaLz6q/k+I?=\n\t=?utf-8?q?JWMGYPYgXllaIynVPISzr6Xp7gM9YPYNj7B57V6V9VqYB3CNZKxt18BNFyLpHlQLk?=\n\t=?utf-8?q?JUqqMbIZ5Sf6U0ZWabEcg0irQYLP/wMESuaPBokn4B6+j7IthGpYTqAqtaWkf07ny?=\n\t=?utf-8?q?oEHPMXhtKujIQXYSdyEizqx1jXbUA4NbbLZn+cm818eeC27m5JY2FW/4Lhp3E0zuT?=\n\t=?utf-8?q?cN5fNziXC8nxVoBAy5RpDmmmNW7L9EuHkVs9dVUIabIZTyWLdkXBJeourJDjZ3fko?=\n\t=?utf-8?q?Mu27lr7yIQ+2KAyPBwwjDoZ2tN/jBweLOkJ8UF1wgNrXCXZm4ffeohfWhZFHUqT45?=\n\t=?utf-8?q?GY7XQz3iR0gai0RbKi1vYVSSTth+pj0/9mXmf2RP15IGXS5hcWHRT79lmuadBY6ZY?=\n\t=?utf-8?q?R57dW1b1d06Np7e6td4ktE5XLvpWgSqcN/6cdob3A2ZLhO5gEfCFmHruCkcWTH2rD?=\n\t=?utf-8?q?LQqbkarLlI1EXz9FLWA2CgKZEyHdHHdcFuyUOaNrz+iJAwm5xQKfLJ6WOEXpzPvMj?=\n\t=?utf-8?q?42vMo4sTK7aRNHAymIwsk7qKs+LRoPAW5+nLxU38Z1Ubauitikvv7j2sbo9UJoKX0?=\n\t=?utf-8?q?4auMuwNzSAQkntjga2WagqkHjLIs/w2mIHYnCfjclBtpo+CdKcZvx87USnUdgazYQ?=\n\t=?utf-8?q?I/CrPMzUC7bmL8MoLnfHwT7ZerMlUAyb8G00DNzW/PsqnKWuVdovM+kqios3FAN0p?=\n\t=?utf-8?q?0wWxQJ4tZy4/Agr83pHtnoV2mYF+qDE+xIUpnMI5LEldYoBfGWQZ510NhlkoWU1Fu?=\n\t=?utf-8?q?R6YRxfDBeqY9KcawlEMF2L2z2IcQLN7HxfHh1vhcaQn0MhRsTSuO9CAah6zpAamIM?=\n\t=?utf-8?q?9T0rvRnDLduHvUSqY/aq+Ka7GdEFdFvRSjJPnq/l4t3DBtLODAEpo61ZhfvPH/Rys?=\n\t=?utf-8?q?9CO62onPYik1EI/T1J9qXM02nRGKEkkT3ZjTQWE2XadRIkcQgHCFZ+D9SXDoKYkrX?=\n\t=?utf-8?q?ZlvL7q7seG6Il1bGbCkBOYaz6wjrCSNvgW33UVwGmr61gsHhN61vevhVAgC3cOiTx?=\n\t=?utf-8?q?wjHqeHSesUi5c8gRV3ERdpyH4qoMTj6rqIBX/CslNn+2k1m50PrJFqo/S2M64IFey?=\n\t=?utf-8?q?yJppqLVbxrzb21WaIwUXL9cgybWjrXXwtsn3nqaKPdhieyjfrhNhAhR37ec2xbZwt?=\n\t=?utf-8?q?8Gjv5+jBjxYPdQBL9R8gVsv6PdfQQyMaV6Ku+4CRgnLeh0CjU+FiM=3D?=","X-OriginatorOrg":"altera.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 6553c4f1-9e14-4caa-e64d-08de9b6eb9ec","X-MS-Exchange-CrossTenant-AuthSource":"PH7PR03MB6942.namprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"16 Apr 2026 04:15:00.6897 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"fbd72e03-d4a5-4110-adce-614d51f2077a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n xzagYSnMMydL5uBfW+eJrRqvpKHC2Mo9YojI7P07Js5Xfi7v0/Xe8R5K/9ONRgIOubNiwwAb7LmNZi2xw9WzWx4oIlD7egENhHXamkPpOW4=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS4PR03MB8397","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Content-Filtered-By":"Mailman/MimeDel 2.1.39","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]