[{"id":3644717,"web_url":"http://patchwork.ozlabs.org/comment/3644717/","msgid":"<cgms3ngtmgbhm6dftle6xqbezuhrjheeuiptnejf55uy2pwjil@w2vgwvm7y6hv>","list_archive_url":null,"date":"2026-02-02T16:40:45","subject":"Re: [PATCH 1/3] jbd2: use READ_ONCE for lockless jinode reads","submitter":{"id":363,"url":"http://patchwork.ozlabs.org/api/people/363/","name":"Jan Kara","email":"jack@suse.cz"},"content":"On Fri 30-01-26 11:12:30, Li Chen wrote:\n> jbd2_inode fields are updated under journal->j_list_lock, but some\n> paths read them without holding the lock (e.g. fast commit\n> helpers and the ordered truncate fast path).\n> \n> Use READ_ONCE() for these lockless reads to correct the\n> concurrency assumptions.\n> \n> Suggested-by: Jan Kara <jack@suse.com>\n> Signed-off-by: Li Chen <me@linux.beauty>\n\nJust one nit below. With that fixed feel free to add:\n\nReviewed-by: Jan Kara <jack@suse.cz>\n\n> @@ -191,12 +197,30 @@ EXPORT_SYMBOL(jbd2_submit_inode_data);\n>  \n>  int jbd2_wait_inode_data(journal_t *journal, struct jbd2_inode *jinode)\n>  {\n> -\tif (!jinode || !(jinode->i_flags & JI_WAIT_DATA) ||\n> -\t\t!jinode->i_vfs_inode || !jinode->i_vfs_inode->i_mapping)\n> +\tstruct address_space *mapping;\n> +\tstruct inode *inode;\n> +\tunsigned long flags;\n> +\tloff_t start, end;\n> +\n> +\tif (!jinode)\n> +\t\treturn 0;\n> +\n> +\tflags = READ_ONCE(jinode->i_flags);\n> +\tif (!(flags & JI_WAIT_DATA))\n> +\t\treturn 0;\n> +\n> +\tinode = READ_ONCE(jinode->i_vfs_inode);\n\ni_vfs_inode never changes so READ_ONCE is pointless here.\n\n\t\t\t\t\t\t\t\tHonza","headers":{"Return-Path":"\n <SRS0=BtIx=AG=vger.kernel.org=linux-ext4+bounces-13465-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=G+EKVc0S;\n\tdkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qoN0Xq5n;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=v6qU8fZ4;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=6z6fR6kH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=btix=ag=vger.kernel.org=linux-ext4+bounces-13465-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.105.105.114 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=suse.cz","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=G+EKVc0S;\n\tdkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qoN0Xq5n;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=v6qU8fZ4;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=6z6fR6kH;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13465-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"G+EKVc0S\";\n\tdkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"qoN0Xq5n\";\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"v6qU8fZ4\";\n\tdkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"6z6fR6kH\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.130","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=suse.cz","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.cz","smtp-out1.suse.de;\n\tdkim=pass header.d=suse.cz header.s=susede2_rsa header.b=v6qU8fZ4;\n\tdkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6z6fR6kH"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f4XXS313wz1xqk\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 03 Feb 2026 03:44:56 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4f4XXS2t32z4wCk\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 03 Feb 2026 03:44:56 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4f4XXS2lN0z4wDN; Tue, 03 Feb 2026 03:44:56 +1100 (AEDT)","from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4f4XXN5rVdz4wCk\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 03 Feb 2026 03:44:52 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id DE97C3006F30\n\tfor <patchwork-incoming@ozlabs.org>; Mon,  2 Feb 2026 16:40:54 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1C04637C109;\n\tMon,  2 Feb 2026 16:40:54 +0000 (UTC)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D562284B2F\n\tfor <linux-ext4@vger.kernel.org>; Mon,  2 Feb 2026 16:40:52 +0000 (UTC)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out1.suse.de (Postfix) with ESMTPS id 7D7C3352F7;\n\tMon,  2 Feb 2026 16:40:49 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 699843EA62;\n\tMon,  2 Feb 2026 16:40:49 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid QZzGGZHTgGmqHAAAD6G6ig\n\t(envelope-from <jack@suse.cz>); Mon, 02 Feb 2026 16:40:49 +0000","by quack3.suse.cz (Postfix, from userid 1000)\n\tid 28474A08F8; Mon,  2 Feb 2026 17:40:45 +0100 (CET)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1770050696; cv=pass;\n\tb=VBpKhCSI4qhfrtTHwwOA/6vDtwUraPwO8wasjv9exvKTeRH9THY2Iy9+5JcLURH61GS4NycTA16TR8sQXMdqTicTKlj4aQgHcz/uwlnFhT1ZO/4wwx5kL7kXQymT9XZ6MV5bzlS5zQAQRulXeESBUFZgR0/8RvnGKRn/fFtaLadcWWNkSMWy3RCik4lMGYfTTvVaeMTuvrvXGhJ62xQR7qPpY4FJ53jTWgOr6KT2meQtuYV77lvRGl2RJYn+T7h2uH9Gmyq7LAMMuQrDm/QofudPLFjSNYNZMj2jDRa/1nu8hpg2i0tuwHXlD60ag71k2NpxhaFgpW5g7iIXydRdzQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1770050453; cv=none;\n b=j6ozrm5SCtjfbEdOf4dup1rNbhapuwoSciF5M4Afi+SNiUUiRge5zrfeOrG6rsIV0sXToNmm9/6+fKlzy03N+CrhERJBHnLdCOK1ZDkqVXpgZJAZKh1I37h+SgXcJOrMKfNihS76k9MLSWqYAK+v8U0IwuVGVXN3IAbQUrJjjmU="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1770050696; c=relaxed/relaxed;\n\tbh=Ranz7Fd4J2/TisVAM4IpZpx4ifuhxfHe2LEBmbY8wMg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=lC+v+a6RV3E+NFtsybu1HgcEZQMst441opEKH6RjiyUTIpJxzx6z8Yp/zC2DvNCXFqSKNYJogjnwxxhkyyVcCRUL/5xzuEUKiw4+JHag2NKS+OtqZiMts4kwICksbvI5ev+zgkW4Ba5GAcKWhPoBKOB7vD1J3Ksek0ZFv+X66OO711jdTgUokWD79TLWnwfgmGtYaez4x/s/V8qxzDvD/sohpdkkdQ6UIEKQcN3zXCD0hR4+DCm9jXS6bQo6CV5Enu5w+euuLVuSN3aqrYh/w8oQTmoMejrOfj2R2J/Pug2c4F7B9bwO2mVZBJttqMJkFWOlIBe+taxpMYhHIZWtTA==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1770050453; c=relaxed/simple;\n\tbh=lTX92TThL4MFg30cQtqZgfgaH4ejkk/IeuTTpfkXfKU=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=MBXaxo45hcRzIqOjLC3+4EgTKNZTwnv7tUOok3l2yrGQda/ZMUsJvDlA2eh66zyKWQ58mB+9P/aSSbK7eIHZ9LNtQE4OWVmPAuZYiAaJb5vPxl0N7BZUTG/+XnBWY1gaWjGHIjmWhjAAAGDlhtQnAX8eGpTEPIwTiZOr5EsqMgw="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=suse.cz; dkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=G+EKVc0S;\n dkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=qoN0Xq5n;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=v6qU8fZ4;\n dkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=6z6fR6kH; dkim-atps=neutral;\n spf=pass (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13465-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=suse.cz;\n spf=pass smtp.mailfrom=suse.cz;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=G+EKVc0S;\n dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=qoN0Xq5n;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=v6qU8fZ4;\n dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=6z6fR6kH; arc=none smtp.client-ip=195.135.223.130"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n\tt=1770050450;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=Ranz7Fd4J2/TisVAM4IpZpx4ifuhxfHe2LEBmbY8wMg=;\n\tb=G+EKVc0SX5WH5BXwC8gkr3nAEMEi4NUl26L5XbSRD7CIsZW6U9mbYFWxLhvDSuj96uQtJj\n\tkjoW93NElC+VXHQysLCQpw51rH8yJ8QY03i6/UU6arpoCW9s360CSg1rdxzmnphWTjUeIT\n\tGDKdJ90kRbiVifpPdgtsszVIUD3qbwI=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n\ts=susede2_ed25519; t=1770050450;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=Ranz7Fd4J2/TisVAM4IpZpx4ifuhxfHe2LEBmbY8wMg=;\n\tb=qoN0Xq5nird1Urb/g/+/Z2QvUu6o7IcjRsxrsvhcaYWm+xVIpPmB2HPKbyx4UbW6iLp/XJ\n\t1gF6MDluivXKpwAA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n\tt=1770050449;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=Ranz7Fd4J2/TisVAM4IpZpx4ifuhxfHe2LEBmbY8wMg=;\n\tb=v6qU8fZ4SwVrOsFkxm5U2wN3rZu55/7dz1Y6AnC4oTIToH0WZFikOziailfoq7SDHCgxNd\n\tn7/QB9ZWuxYdS544DLIcZZEEe6AHKiW6Gwb7MZ9w2vyZ3Fger09muhEjQFOLlhAh+FmmFH\n\t2Ko2pkU9B6fXOuD6Raz0Xw5ZiSNY05g=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n\ts=susede2_ed25519; t=1770050449;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=Ranz7Fd4J2/TisVAM4IpZpx4ifuhxfHe2LEBmbY8wMg=;\n\tb=6z6fR6kHBjoFr8O9tzcfCbpP6sDfJU2t7Y2x0zii13sw1u3fkt74VVMubu+N0OWPx+14wN\n\tSIzaVCfAXxnmA6Cg=="],"Date":"Mon, 2 Feb 2026 17:40:45 +0100","From":"Jan Kara <jack@suse.cz>","To":"Li Chen <me@linux.beauty>","Cc":"Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.com>,\n\tlinux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/3] jbd2: use READ_ONCE for lockless jinode reads","Message-ID":"<cgms3ngtmgbhm6dftle6xqbezuhrjheeuiptnejf55uy2pwjil@w2vgwvm7y6hv>","References":"<20260130031232.60780-1-me@linux.beauty>\n <20260130031232.60780-2-me@linux.beauty>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260130031232.60780-2-me@linux.beauty>","X-Spam-Score":"-4.01","X-Spamd-Result":"default: False [-4.01 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tMID_RHS_NOT_FQDN(0.50)[];\n\tR_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tMX_GOOD(-0.01)[];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tARC_NA(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tTO_DN_SOME(0.00)[];\n\tSPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tMISSING_XM_UA(0.00)[];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.com:email,suse.cz:dkim,suse.cz:email];\n\tRCVD_COUNT_THREE(0.00)[3];\n\tRCPT_COUNT_FIVE(0.00)[5];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tFROM_HAS_DN(0.00)[];\n\tRECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n\tRBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tRCVD_TLS_LAST(0.00)[];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tDKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n\tDKIM_TRACE(0.00)[suse.cz:+]","X-Spam-Level":"","X-Rspamd-Action":"no action","X-Rspamd-Queue-Id":"7D7C3352F7","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_MISSING,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3644722,"web_url":"http://patchwork.ozlabs.org/comment/3644722/","msgid":"<jvo5sk46f6cvqmkgetrlybs46kryhxetsvapkmx4tocbdirk3w@ume4qfpsddco>","list_archive_url":null,"date":"2026-02-02T16:52:30","subject":"Re: [PATCH 1/3] jbd2: use READ_ONCE for lockless jinode reads","submitter":{"id":363,"url":"http://patchwork.ozlabs.org/api/people/363/","name":"Jan Kara","email":"jack@suse.cz"},"content":"On Mon 02-02-26 17:40:45, Jan Kara wrote:\n> On Fri 30-01-26 11:12:30, Li Chen wrote:\n> > jbd2_inode fields are updated under journal->j_list_lock, but some\n> > paths read them without holding the lock (e.g. fast commit\n> > helpers and the ordered truncate fast path).\n> > \n> > Use READ_ONCE() for these lockless reads to correct the\n> > concurrency assumptions.\n> > \n> > Suggested-by: Jan Kara <jack@suse.com>\n> > Signed-off-by: Li Chen <me@linux.beauty>\n> \n> Just one nit below. With that fixed feel free to add:\n> \n> Reviewed-by: Jan Kara <jack@suse.cz>\n> \n> > @@ -191,12 +197,30 @@ EXPORT_SYMBOL(jbd2_submit_inode_data);\n> >  \n> >  int jbd2_wait_inode_data(journal_t *journal, struct jbd2_inode *jinode)\n> >  {\n> > -\tif (!jinode || !(jinode->i_flags & JI_WAIT_DATA) ||\n> > -\t\t!jinode->i_vfs_inode || !jinode->i_vfs_inode->i_mapping)\n> > +\tstruct address_space *mapping;\n> > +\tstruct inode *inode;\n> > +\tunsigned long flags;\n> > +\tloff_t start, end;\n> > +\n> > +\tif (!jinode)\n> > +\t\treturn 0;\n> > +\n> > +\tflags = READ_ONCE(jinode->i_flags);\n> > +\tif (!(flags & JI_WAIT_DATA))\n> > +\t\treturn 0;\n> > +\n> > +\tinode = READ_ONCE(jinode->i_vfs_inode);\n> \n> i_vfs_inode never changes so READ_ONCE is pointless here.\n\nOne more note: I've realized that for this to work you also need to make\njbd2_journal_file_inode() use WRITE_ONCE() when updating i_dirty_start,\ni_dirty_end and i_flags.\n\n\t\t\t\t\t\t\t\tHonza","headers":{"Return-Path":"\n <SRS0=jl0/=AG=vger.kernel.org=linux-ext4+bounces-13467-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=1/CDKOvJ;\n\tdkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=SjihoiF4;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=bI/nppYE;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Yx/TCFoJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=jl0/=ag=vger.kernel.org=linux-ext4+bounces-13467-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c09:e001:a7::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=suse.cz","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=1/CDKOvJ;\n\tdkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=SjihoiF4;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=bI/nppYE;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Yx/TCFoJ;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13467-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"1/CDKOvJ\";\n\tdkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"SjihoiF4\";\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"bI/nppYE\";\n\tdkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=\"Yx/TCFoJ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.130","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=suse.cz","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.cz","smtp-out1.suse.de;\n\tdkim=pass header.d=suse.cz header.s=susede2_rsa header.b=\"bI/nppYE\";\n\tdkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=\"Yx/TCFoJ\""],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f4XjZ5lRvz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 03 Feb 2026 03:52:50 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4f4XjZ5CKxz4w9Q\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 03 Feb 2026 03:52:50 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4f4XjZ57RKz4wDN; Tue, 03 Feb 2026 03:52:50 +1100 (AEDT)","from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4f4XjW0Bwxz4w9Q\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 03 Feb 2026 03:52:46 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 6B1083006780\n\tfor <patchwork-incoming@ozlabs.org>; Mon,  2 Feb 2026 16:52:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E761F3806B5;\n\tMon,  2 Feb 2026 16:52:40 +0000 (UTC)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B8EE223705\n\tfor <linux-ext4@vger.kernel.org>; Mon,  2 Feb 2026 16:52:36 +0000 (UTC)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out1.suse.de (Postfix) with ESMTPS id D472E34FC0;\n\tMon,  2 Feb 2026 16:52:34 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BA7323EA62;\n\tMon,  2 Feb 2026 16:52:34 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid QaAQLVLWgGnmVwAAD6G6ig\n\t(envelope-from <jack@suse.cz>); Mon, 02 Feb 2026 16:52:34 +0000","by quack3.suse.cz (Postfix, from userid 1000)\n\tid 773FAA08F8; Mon,  2 Feb 2026 17:52:30 +0100 (CET)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1770051170; cv=pass;\n\tb=BlHl88jhJoqf+T0nMhDPwkXODxZ88kmCnyMkkYNkluojSYFmxLuVsNVgUOhBAuWslsNmlRlRIm35asyk2VCVF37A/NgbvdP4pJGR/IhatojbQXvZRCcpIHCFfsMKtIBW8PahGS9IfhUYanWgwjIcUoRZPxa+3usO6VAX5BZ1NJacujoxgsV8a4V4WhucHFosN363smkSLWnI6qgwccF//NRzlIe8z4XbH6WtJCKlHXIEzFT2yZpvk3zftXEduUz+UQtc8gNSmuKNC3IJjn5RExGC7VJciExwYRccpiq7VcXLamuq/0ha1+ysadbkjjhdhcqzInQc4Bz2eNYXaChE+w==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1770051159; cv=none;\n b=TdGKEqMdTvE1XeiL9LLWN96Jk8ZASruev8VBForSg2u8K6Qh2AwMuH5LwKzuuNmejqCL0qiXspNvx30OTNi+YEgRuZ8rlLEJ4RuBuhhnvsZCnXlLrN+ho1607gGkqSV6ZRd1uyYxM3qSRHZhatzLNx7wB80zW7/HR/MvFwlzWTI="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1770051170; c=relaxed/relaxed;\n\tbh=sqehyBt96vpabiRX5hSgHUbnMMsVVtLcroHKHr7pcUo=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=xae3jdCK41+B1dOCMoOPRlQQJX33ZGBxZDYnFy20wpyVk5BK4NyZyYCYB/SLV9knhMDNfv8RBCZvLCYpPS3cj0J4Omgc3zwynKT3ZPKQSH3Z8OL40p6+iagYTaES8Pv5u6qqFnjsXyLARG1mBnuYLxhaD+9PdMHVTGCQFZ4CHp2srm3tZ3lrK9DrNBEhAwI9djNYtOwgL9tzXvZrbfWoImZ9tMNCaNlnApdQMZaYz31JiMcE/WR5BK6F7dfb8fT/3GZ+N80rgcW9kad/8sm5TXTRcQBNuYo+5ue8EwcQs4ivdXLQd3iKGsCnNhDhcU8W8TxM8vLJfg2JenY0kZRFcw==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1770051159; c=relaxed/simple;\n\tbh=vGlMp69JRySKOEJPYHl/D6PgdPb64/n1QXCyToEvYw0=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=kB2RjEcqNRUNXvR7ldePd4CbcA+Up9kl1Rq4SvT4rBIr4qrlrQeXidFT+Jw/Ym0Rkp2ycsUPLrO7qtn41j7EgJw48RwUmFse2R921U5Br+FBd0DbAAr6i9SOpnD18TVG1Cs+Y6gTBcXOHXGHWXENM8MEbleGSFFtWStH+k9n3ME="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=suse.cz; dkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=1/CDKOvJ;\n dkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=SjihoiF4;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=bI/nppYE;\n dkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Yx/TCFoJ; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13467-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=suse.cz;\n spf=pass smtp.mailfrom=suse.cz;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=1/CDKOvJ;\n dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=SjihoiF4;\n dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=bI/nppYE;\n dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz\n header.b=Yx/TCFoJ; arc=none smtp.client-ip=195.135.223.130"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n\tt=1770051155;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=sqehyBt96vpabiRX5hSgHUbnMMsVVtLcroHKHr7pcUo=;\n\tb=1/CDKOvJSPXaOSbTvMVA4Cftosl3iKXzUvjJyPovDhvutGkfVutIg1aNfEEmN17Im8+o7H\n\taiMnUUWDFIXgbLCxZS1COePiJvd6VPMp+wp/1ZfXP78rTLMWqj9eRzAIPxCQIJVU510+4E\n\t1NJxmT0E7E+zwkk4E0VkWkCnn0D8Rd0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n\ts=susede2_ed25519; t=1770051155;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=sqehyBt96vpabiRX5hSgHUbnMMsVVtLcroHKHr7pcUo=;\n\tb=SjihoiF4aPIbsm/pdEdyO9wiHLRmEANvABJWSRLwbY2NIunxNSi50ARkIc1FZ2NkBOCpAn\n\tA+3KImyAhyK8qBAQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n\tt=1770051154;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=sqehyBt96vpabiRX5hSgHUbnMMsVVtLcroHKHr7pcUo=;\n\tb=bI/nppYEDkcrb02Vroxrebw3eZ4QqB6YclclkJnmAVsBJDDG90Ws+Thvnp9q3LZQaPzlw4\n\tOLnSHs4kLIYB+fc5P//PFjDr642dYmmh0oLYoKoa/n6HVmZdO4rvt7lGLK7BrV6wlfRydD\n\tDAKPjfIv1ropdsPirwZMmWFvHDf/atg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n\ts=susede2_ed25519; t=1770051154;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=sqehyBt96vpabiRX5hSgHUbnMMsVVtLcroHKHr7pcUo=;\n\tb=Yx/TCFoJk+WytBaw20v22Cs0jcKsq/pAs0CnG4y2pmGlRyt8eugDC6rX/I3bL9aof2NvHe\n\tYvSPCe76vGyNETBA=="],"Date":"Mon, 2 Feb 2026 17:52:30 +0100","From":"Jan Kara <jack@suse.cz>","To":"Li Chen <me@linux.beauty>","Cc":"Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.com>,\n\tlinux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/3] jbd2: use READ_ONCE for lockless jinode reads","Message-ID":"<jvo5sk46f6cvqmkgetrlybs46kryhxetsvapkmx4tocbdirk3w@ume4qfpsddco>","References":"<20260130031232.60780-1-me@linux.beauty>\n <20260130031232.60780-2-me@linux.beauty>\n <cgms3ngtmgbhm6dftle6xqbezuhrjheeuiptnejf55uy2pwjil@w2vgwvm7y6hv>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<cgms3ngtmgbhm6dftle6xqbezuhrjheeuiptnejf55uy2pwjil@w2vgwvm7y6hv>","X-Spamd-Result":"default: False [-4.01 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tMID_RHS_NOT_FQDN(0.50)[];\n\tR_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tMX_GOOD(-0.01)[];\n\tMIME_TRACE(0.00)[0:+];\n\tRCVD_COUNT_THREE(0.00)[3];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tSPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tRBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tTO_DN_SOME(0.00)[];\n\tARC_NA(0.00)[];\n\tDKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n\tFROM_HAS_DN(0.00)[];\n\tRCVD_TLS_LAST(0.00)[];\n\tRECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tRCPT_COUNT_FIVE(0.00)[5];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tDKIM_TRACE(0.00)[suse.cz:+];\n\tMISSING_XM_UA(0.00)[];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email,suse.cz:dkim,suse.cz:email]","X-Spam-Score":"-4.01","X-Rspamd-Queue-Id":"D472E34FC0","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spam-Level":"","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_MISSING,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]