[{"id":3641238,"web_url":"http://patchwork.ozlabs.org/comment/3641238/","msgid":"<5ebab91a-8510-40be-a77e-da17dca83e45@gmail.com>","list_archive_url":null,"date":"2026-01-24T08:07:10","subject":"Re: [PATCH] ext4: remove tl argument from\n ext4_fc_replay_{add,del}_range","submitter":{"id":90700,"url":"http://patchwork.ozlabs.org/api/people/90700/","name":"Zhang Yi","email":"yizhang089@gmail.com"},"content":"On 1/21/2026 2:38 PM, Guoqing Jiang wrote:\n> Since commit a7ba36bc94f2 (\"ext4: fix fast commit alignment issues\"),\n> both ext4_fc_replay_add_range and ext4_fc_replay_del_range get\n> ex based on 'val' instead of 'tl'.\n> \n> Signed-off-by: Guoqing Jiang \n\nThank you for the cleanup, it looks good to me.\n\nReviewed-by: Zhang Yi \n\n> ---\n> fs/ext4/fast_commit.c | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n> \n> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c\n> index fa66b08de999..8474ae52f8dd 100644\n> --- a/fs/ext4/fast_commit.c\n> +++ b/fs/ext4/fast_commit.c\n> @@ -1751,8 +1751,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,\n> }\n> \n> /* Replay add range tag */\n> -static int ext4_fc_replay_add_range(struct super_block *sb,\n> -\t\t\t\t struct ext4_fc_tl_mem *tl, u8 *val)\n> +static int ext4_fc_replay_add_range(struct super_block *sb, u8 *val)\n> {\n> \tstruct ext4_fc_add_range fc_add_ex;\n> \tstruct ext4_extent newex, *ex;\n> @@ -1872,8 +1871,7 @@ static int ext4_fc_replay_add_range(struct super_block *sb,\n> \n> /* Replay DEL_RANGE tag */\n> static int\n> -ext4_fc_replay_del_range(struct super_block *sb,\n> -\t\t\t struct ext4_fc_tl_mem *tl, u8 *val)\n> +ext4_fc_replay_del_range(struct super_block *sb, u8 *val)\n> {\n> \tstruct inode *inode;\n> \tstruct ext4_fc_del_range lrange;\n> @@ -2243,13 +2241,13 @@ static int ext4_fc_replay(journal_t *journal, struct buffer_head *bh,\n> \t\t\tret = ext4_fc_replay_unlink(sb, &tl, val);\n> \t\t\tbreak;\n> \t\tcase EXT4_FC_TAG_ADD_RANGE:\n> -\t\t\tret = ext4_fc_replay_add_range(sb, &tl, val);\n> +\t\t\tret = ext4_fc_replay_add_range(sb, val);\n> \t\t\tbreak;\n> \t\tcase EXT4_FC_TAG_CREAT:\n> \t\t\tret = ext4_fc_replay_create(sb, &tl, val);\n> \t\t\tbreak;\n> \t\tcase EXT4_FC_TAG_DEL_RANGE:\n> -\t\t\tret = ext4_fc_replay_del_range(sb, &tl, val);\n> +\t\t\tret = ext4_fc_replay_del_range(sb, val);\n> \t\t\tbreak;\n> \t\tcase EXT4_FC_TAG_INODE:\n> \t\t\tret = ext4_fc_replay_inode(sb, &tl, val);","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=cg5noWxm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=tx2y=75=vger.kernel.org=linux-ext4+bounces-13286-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c15:e001:75::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=cg5noWxm;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13286-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"cg5noWxm\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.180","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dynTV2WdZz1xqf\n\tfor ; Sat, 24 Jan 2026 19:07:24 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4dynTS49s6z4w0H\n\tfor ; Sat, 24 Jan 2026 19:07:24 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4dynTS3pCwz4wCR; Sat, 24 Jan 2026 19:07:24 +1100 (AEDT)","from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4dynTP0qtzz4w0H\n\tfor ; Sat, 24 Jan 2026 19:07:21 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 0EAAA3002B4A\n\tfor ; Sat, 24 Jan 2026 08:07:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B160D223DCE;\n\tSat, 24 Jan 2026 08:07:16 +0000 (UTC)","from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AC2B84039\n\tfor ; Sat, 24 Jan 2026 08:07:14 +0000 (UTC)","by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-29f102b013fso27193955ad.2\n for ;\n Sat, 24 Jan 2026 00:07:14 -0800 (PST)","from ?IPV6:240e:390:a84:ae11:f96c:3476:2936:720f?\n ([240e:390:a84:ae11:f96c:3476:2936:720f])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2a802daa994sm37976755ad.6.2026.01.24.00.07.11\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 24 Jan 2026 00:07:13 -0800 (PST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1769242044; cv=pass;\n\tb=fA03ZtTtYv1f312kVfwqQnPNeZZEGhO5zA+aoxYD7RYaO0Dlp9VzyLXUKmzZpltvWqjGGA2LlYr4OS6zehR4p8+d0xB4zU+rOoQ4ysZWIrhSJK5YizWvgrLqzUfRmfVqg+QVj1VPRX7Yg3Ni9byXWvwaYIgxwL9aK6TksJ+7EoyfrdEBKiFMkYTVUFVegQ7mEPjbR37FpQ7KvCP72JPfa8wcFWmdRQa8UjR0DK3d2UIYg5y4dyK5Wd7IsoS3kD4Ln2QnRq26DrE7wGEBlt/KocQ7LkJN4FHtPejeHz2EgUaoHSwtkAzCdFaR794TEPCip+fgppXb3BIgMive+3Z5JQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1769242036; cv=none;\n b=B8BIybnG5pKPtjT11ihMJVjsBZCIdHPesSCSFP45WSVTdoZXk7kCNHo8DLio1VG2gMAkzxh4iLvg8Gc0B+HRP4xP/gxEx4TziTMIV0aWhDbEw78qOJbuH+F6F6SqW7jfGKcP+kY4RZs/6204qFwjArsOoE5zRNk8AJ/THwajlAY="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1769242044; c=relaxed/relaxed;\n\tbh=bmNq0+UsLIk5q/c1rFFe2Tb3EQ8fjZ0k3OENU3nF5bk=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=L2ojKeUyQ+qS+JD5nwpjO4aI/UM5L1wUwUSE4gitiK+b2kTjbVS3vzebxXZ4BH/aJX9U9ZmU4qGbO70nVtwVWbixj14aIF2PIKFYe2fv77rJyVoWQ/vbHMnJq6dn7XYru4EmYiCLUDz2nplK7ubdfhoiV4c18ZW2jGCcWCB8hNY0CZD9abvLq9rupEw9PxgUIEvqflfGj0f2+rK+oSCbtTDZ27UzjLMo/8KqyiS0si3kHCpkswVGOiYV3ySDAJb97VgUjNfmRl0G4PF/9g9el+POlWcdqPImEj+bbC2c0Xi6pA4SqqrdRB+q8Dzb3cM9iA1Fhzy6MeEshRwtEgp45Q==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1769242036; c=relaxed/simple;\n\tbh=eCFcNa/HY19GOkFMltoj4bjlltVQaLp2EvzjmyJCuQo=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=ZaUj7GEx95RDYqhuaUy0YPdmZJ+FZtqmfrsrU2j+KGIEbYONssmON4u0e1Ml3QWFwS8UP8XVPi3yJtNK1e2Q6FsafYQjb7T/rEORNTgaWMA6k5G5o3DVOGt1B3pMTkQVqP8VtMP78sqUD0IiIq+UhU5gRWJmqpK8bgUXQbJXhAM="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=cg5noWxm; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13286-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=cg5noWxm; arc=none smtp.client-ip=209.85.214.180"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1769242034; x=1769846834;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=bmNq0+UsLIk5q/c1rFFe2Tb3EQ8fjZ0k3OENU3nF5bk=;\n b=cg5noWxmyl/gwOmLB29J+44fe2xGgxpx4kqI9ab8I32SHqGYxhh4jUumSkJak68YPg\n VIhcMvzk+vE0KmJnPElSjpXtVis3zwoyGJT8fFem0lsdJGNE8exsQoeNjClgnRIry1Pb\n C8pkT0Js55bISdHuWKqNVwusvVtU+tH8VSWJKu02Tk77BB3wTyvvwOmKl/WavjKDJ4bW\n tqCkUIQfxi/R4SWtjdfSurD9Y/xUThpjpnI7eAjVPqiXuoA6LIy7cgneB7fvvoNkY1M3\n P/DPMOPd7+0AKHBJDApxzjNCSOANTopxLAQuO0lh3fO9Wlnm9+oEZsc2nkuIn3LGPCql\n xpRw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1769242034; x=1769846834;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=bmNq0+UsLIk5q/c1rFFe2Tb3EQ8fjZ0k3OENU3nF5bk=;\n b=Y7tH9HzMp/fTZFAia6aLgOSq2y2J3MfFJ7kIBEPGud6AHy3kmLSLsG+ry+pQOJDCCo\n pDxFoEwUNIDak5pg7NvPkH/8ejn1pa43GCsZLbsxO1lqpYuc5hi9uH3fFrQXxIC39c8H\n mlnbXF5g84a+z6QGv74zcnCSK9cbN8tBiBZ0M2CVkealOM2ahl9tpLrFCLWEm6qZCEej\n pjy4Fj03ZAAlM8+z1E6f0WZl+VxujvocSzC1CFN19iZyIbcimejxdezSowTnjaXUvHjY\n gSCNAet4zaYPM5KeYkVejqvl92MrCNM4YrqaX8Gx9vUFDgrmKDFg8V33oBWE9Y58rhGo\n UjWQ==","X-Gm-Message-State":"AOJu0Yynp6PBT+FD/71ZprcoYbVYfrbg5fctgLKzyrNd/XEz1Xz/jmSa\n\tU/IrPiALoZUDg2bsZseFRwQzTnmzepezZTcpZrM3pvJrD/G5xDFj8LEpttvxY8ZfqEk=","X-Gm-Gg":"AZuq6aJeHifQYucv7UWXTJzM1fxTxeyVAouOyLuJULjNpMWMol2ksIuuYn2k7WqN6Rx\n\tcDtlIVj8YEmxFJGVaxxqoryR+k4XScEJ3ikZFVl3k5BJoFIh4v2o5NirSu4LDL3xM9juE5TLcAv\n\tDU5Zo8FaJsZVHE/RTo6F2Yfiev1HXZlcsaMlPrszq+R0jc2wcXFNhrDcEvt8xPyUkphKvZTknOU\n\tZ8q6kmG8BqCnIKB3GByChgOT3BKVTOr8DunFSSmaYmfB80wUqnYLzffo2FvEX6PtRPc8j/a5UOb\n\tG/pZmCcufhJ3IUL3eAqjcMNX3FN/j3HEsU9tEt46fy5wynGhq1qmMEAQxr7S02e+ORMLvk2m2ex\n\trAWP2K9GF5utRmiT9eMzQ/Rc8CM9DFyvrHSZO4huClaFEIQrsF3KPn+Q2V+Dj6Mq86ZeDU2OLnB\n\tokHcvTYcA1U1S+qoslRBOCfJg2BzgApEh5NKoItXtUOIEiNbJRuJuoENU3pqATcQ==","X-Received":"by 2002:a17:902:c94b:b0:2a7:683c:afb8 with SMTP id\n d9443c01a7336-2a7fe55ecf5mr61272995ad.16.1769242034386;\n Sat, 24 Jan 2026 00:07:14 -0800 (PST)","Message-ID":"<5ebab91a-8510-40be-a77e-da17dca83e45@gmail.com>","Date":"Sat, 24 Jan 2026 16:07:10 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ext4: remove tl argument from\n ext4_fc_replay_{add,del}_range","To":"Guoqing Jiang , tytso@mit.edu,\n adilger.kernel@dilger.ca","Cc":"linux-ext4@vger.kernel.org","References":"<20260121063805.19863-1-guoqing.jiang@linux.dev>","Content-Language":"en-US","From":"Zhang Yi ","In-Reply-To":"<20260121063805.19863-1-guoqing.jiang@linux.dev>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]