[{"id":3641242,"web_url":"http://patchwork.ozlabs.org/comment/3641242/","msgid":"","list_archive_url":null,"date":"2026-01-24T08:18:47","subject":"Re: [PATCH] ext4: remove unused i_fc_wait","submitter":{"id":90700,"url":"http://patchwork.ozlabs.org/api/people/90700/","name":"Zhang Yi","email":"yizhang089@gmail.com"},"content":"On 1/20/2026 8:19 PM, Li Chen wrote:\n> i_fc_wait is only initialized in ext4_fc_init_inode() and never used for\n> waiting or wakeups. Drop it.\n> \n> Signed-off-by: Li Chen \n\nThank you for the cleanup, it looks good to me.\n\nReviewed-by: Zhang Yi \n\n> ---\n> fs/ext4/ext4.h | 4 ----\n> fs/ext4/fast_commit.c | 2 +-\n> 2 files changed, 1 insertion(+), 5 deletions(-)\n> \n> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\n> index 56112f201cac..dc3a5a926eff 100644\n> --- a/fs/ext4/ext4.h\n> +++ b/fs/ext4/ext4.h\n> @@ -28,7 +28,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> @@ -1091,9 +1090,6 @@ struct ext4_inode_info {\n> \n> \tspinlock_t i_raw_lock;\t/* protects updates to the raw inode */\n> \n> -\t/* Fast commit wait queue for this inode */\n> -\twait_queue_head_t i_fc_wait;\n> -\n> \t/*\n> \t * Protect concurrent accesses on i_fc_lblk_start, i_fc_lblk_len\n> \t * and inode's EXT4_FC_STATE_COMMITTING state bit.\n> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c\n> index fa66b08de999..86789989b3f4 100644\n> --- a/fs/ext4/fast_commit.c\n> +++ b/fs/ext4/fast_commit.c\n> @@ -13,6 +13,7 @@\n> #include \"mballoc.h\"\n> \n> #include \n> +#include \n> /*\n> * Ext4 Fast Commits\n> * -----------------\n> @@ -215,7 +216,6 @@ void ext4_fc_init_inode(struct inode *inode)\n> \text4_clear_inode_state(inode, EXT4_STATE_FC_COMMITTING);\n> \tINIT_LIST_HEAD(&ei->i_fc_list);\n> \tINIT_LIST_HEAD(&ei->i_fc_dilist);\n> -\tinit_waitqueue_head(&ei->i_fc_wait);\n> }\n> \n> static bool ext4_fc_disabled(struct super_block *sb)","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=cJCNC3wM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=mhy8=75=vger.kernel.org=linux-ext4+bounces-13287-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c09:e001:a7::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=cJCNC3wM;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13287-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"cJCNC3wM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.176","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dynkv0wSQz1xsN\n\tfor ; Sat, 24 Jan 2026 19:19:03 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4dynkv0PtBz4w0H\n\tfor ; Sat, 24 Jan 2026 19:19:03 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4dynkv0L7Jz4wCY; Sat, 24 Jan 2026 19:19:03 +1100 (AEDT)","from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4dynkq2knkz4w0H\n\tfor ; Sat, 24 Jan 2026 19:18:59 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id A2E5D300461F\n\tfor ; Sat, 24 Jan 2026 08:18:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4CCBF2749D2;\n\tSat, 24 Jan 2026 08:18:53 +0000 (UTC)","from mail-pl1-f176.google.com (mail-pl1-f176.google.com\n [209.85.214.176])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E38281F875A\n\tfor ; Sat, 24 Jan 2026 08:18:51 +0000 (UTC)","by mail-pl1-f176.google.com with SMTP id\n d9443c01a7336-2a0834769f0so19744665ad.2\n for ;\n Sat, 24 Jan 2026 00:18:51 -0800 (PST)","from ?IPV6:240e:390:a84:ae11:f96c:3476:2936:720f?\n ([240e:390:a84:ae11:f96c:3476:2936:720f])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2a802fdd715sm38380625ad.102.2026.01.24.00.18.48\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 24 Jan 2026 00:18:50 -0800 (PST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1769242743; cv=pass;\n\tb=ejaBdVbdvKYWxWxlYHbo0Q6uvmVNIoj3V+qJaKaSNVIWa49TG3OZNtikoSPCZNEpsni/IWvnLLoZ/ZSCBZe1/NCXl5mpyXvued4nDKNislhomVF1rP2qStyLNlVYymb0RHPgWsU7Yzkjum5ILnnfgmwRSNo7dBae0RgBz0ghP2MlWKTx+E42kaxELN7EeFuQ8YHxoZox8nCIVpwiBebDBytQHrSETJO6A4Yavb6TxBrHUwmw89zr3JKP4jTxeIqRy0CcBszUsMmwT1ukjZ++RJ5tHBI1HLq3zhCOHeph2oveJrRvwoEyt8b2dxIUqrkhPfdTPw+RedCRyJg2OW5jrg==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1769242733; cv=none;\n b=loEoZp+6aamF3OxMmlpMVAkRvHAMhqlXDlwzo4c4v2rrG4GQiGdYEfb0E3ou011UB5FACQo7NQevtaZLQACP5iejkK0EKlSsMCyjmKwI+HQUSdMJeR3uARe4YewAB7USe4Apn+o8DJ/NGXEs4uRHkbxYga4V6LtcfPH/QzfwhaY="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1769242743; c=relaxed/relaxed;\n\tbh=rMKou0lTGiCd2raLCB3aWAc1kprvOo5pfAG7zCR/gfQ=;\n\th=Message-ID:Date:MIME-Version:Subject:To:References:From:\n\t In-Reply-To:Content-Type;\n b=XDKGobAkorU+U656wOlGddFRzv9FNLUW1MIHPhs/RrN13+S0mJ04PQNrKuUP5sT4Yt9v6WXS5h6DKzZhLzUlPeNFm9O7soH6LZXVvMJRvJ4BvfB0HQpoQ4Ux+TI+s63KOkbmjKVQk9QKpR9FpAPTeqhAdwBioIy/YbRpJUTGZLqMkWqhePMMr8vyg3LPpVlJSIcKAps7Fn1YvUMkmo2XMX9X/mer1oerGuBKwQU7uqk1kgbulpXnA1CrQthudfwdQO47ARV5sZ9ZNxJQuWhXMaY1yd3d8oBkEGHT7MTvjRPcAOvpZySu0YwvNm/MG3sLIW12eqfKNikjRwVEVMoyUQ==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1769242733; c=relaxed/simple;\n\tbh=OVAeomsh6Mj11icHu9KqyNRZ2jyJuFcGOWKABatdc74=;\n\th=Message-ID:Date:MIME-Version:Subject:To:References:From:\n\t In-Reply-To:Content-Type;\n b=rq6GkiS4apYzNPYcBcEBKfets8KjLWJBxDIr7N/Wuz8rmpBwy7ZhK8hL7+YIVpzbIt8Ztz9SQhis4fc/bXssW8D/S86UF079xfRvjiX9gYCocxCyEoTOrMGoplYXnQb3wtftiXHgWs0s0CRgvk9esI2On2zeWkcOhaldt5qqjrk="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=cJCNC3wM; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13287-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=cJCNC3wM; arc=none smtp.client-ip=209.85.214.176"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1769242731; x=1769847531;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=rMKou0lTGiCd2raLCB3aWAc1kprvOo5pfAG7zCR/gfQ=;\n b=cJCNC3wMIdSCUP3A+WXQel43PbHp4gdbtNfDzydUmwOTnxSSvBbbrh3DHalVMio/qe\n 4xQbrep03hIWESh8L4DkhJRDOET+aAjL5YNBDHPdEBqbqkEs61ZDIG8GSuGAi3Lq6roH\n 5jeJSKg5AnZql8mp5vgTS97V8Q2fHUvLMxZgSIEwbuj9awcwoyzbCK2c6Ul7uJ5ZU7jM\n bhAG1XhoPhICRqEc9XBMfPkwImlNdqvDzX51y6jKYCLkScLdbz9ciRBI+GAXuz3twbWh\n 1VkobbCVkfsTqdTSZl/2rV8rfrvyr+CLliVzWAPpb4kUXx98sXUdXReMm8m6fevTwn9P\n U9WQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1769242731; x=1769847531;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=rMKou0lTGiCd2raLCB3aWAc1kprvOo5pfAG7zCR/gfQ=;\n b=H2bMyvg+zgIKO99Fg2qodvDpM+QZn8Ur6Omjv6WrYGV+Pp1TBNhLgZM384gqFN9jUT\n m1LtG46q4p5KA+v5RFkt+xqoVa60ID2gA8FdXKEUrD17UEg2y4UGEsxQQruizLFb83Ml\n qZSaIlOOnUsbVcDXkGA2kyXwhnROFgCUTxp00rEqloYp0vI52watJ7GFSpu7rWuJin7q\n RVKapEoWI+wqP6xrsx1kDFUk5JqBeu5z73frPW9YZ3q6JKK/e5inc6QGO6031FlBVR62\n 2LiEgi+nIc3/sZ+IiAF13CT9EN2u12Nvx4G4c12uwULSyPLnfJfPG2lv2yunfNd62z/j\n YsEA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUk5xBR02orS9qdHFtjf87bCcv/6FnDsukwYxNW1lbIDZxxANpmThUTQAyrehCEi0HmiiplNpASXAWT@vger.kernel.org","X-Gm-Message-State":"AOJu0Yz8vknAGbN42eTQUygJl5RddEn5wAw8XgHllYqxQiq7F2mkHKoN\n\tIkBqZtlQhjcVqsTYFVt7QWYHnvKpSdFEVTqC5iWOHJLhViwifKPDpz8T","X-Gm-Gg":"AZuq6aKTUUY+i8Yh7NEPIGG4D7OrHu3JC4seYtmk7qia4Od14s3+iXcOi1z00Yh20NJ\n\tLVgx4tUpOlbAguMIc0rM9A1lp9qsb4449rQegIuP3KGTZJlbVECo4U0K5RCw7GFS0dkvoD6juWD\n\trKU3hiZoQxoUpa1ZVduxcrUQ7D/qqNPYp0eH0sRl11122ZV8ywSRzK4LZikafY1XxjyDtOTlxid\n\tEFmvq+gfNmzJ7LXiuSr53AWOIKDeCxb+tFA+SAPD7czSkvpqtn9qYWLtcTwDDnGCYEON1uHZA1+\n\tgVV1RBS4PYeYbOE8cuilvX6BaFWsFSbhTi+gGcXdnWhWOvo4XOkcaM0SYCCM5u8Mgj6V9Mhmhmm\n\tKs8/EMJNRuqEZxMNAvooyW/JlZhZy42cbUaQHvcBj2slsCMt+PXs3kO49IfPc4IVxyDdfEQzT+J\n\tc+1VlyJqVR6pmT8d++z2RJzKfjpVUyWYcO5nfnCTLVO3FljRFhAC3UsznoozTemg==","X-Received":"by 2002:a17:902:f652:b0:2a7:a22c:90f7 with SMTP id\n d9443c01a7336-2a7fe756185mr49731635ad.51.1769242731079;\n Sat, 24 Jan 2026 00:18:51 -0800 (PST)","Message-ID":"","Date":"Sat, 24 Jan 2026 16:18:47 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ext4: remove unused i_fc_wait","To":"Li Chen , Theodore Ts'o ,\n Andreas Dilger , linux-ext4@vger.kernel.org,\n linux-kernel@vger.kernel.org","References":"<20260120121941.144192-1-me@linux.beauty>","Content-Language":"en-US","From":"Zhang Yi ","In-Reply-To":"<20260120121941.144192-1-me@linux.beauty>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]