[{"id":3637024,"web_url":"http://patchwork.ozlabs.org/comment/3637024/","msgid":"<03ba58e6-0eaf-4970-8d27-ffe29bc9a7bf@linux.ibm.com>","date":"2026-01-15T22:00:12","subject":"Re: [PATCH v2 15/35] lib/crypto: s390/aes: Migrate optimized code\n into library","submitter":{"id":84509,"url":"http://patchwork.ozlabs.org/api/people/84509/","name":"Holger Dengler","email":"dengler@linux.ibm.com"},"content":"On 12/01/2026 20:20, Eric Biggers wrote:\n> Implement aes_preparekey_arch(), aes_encrypt_arch(), and\n> aes_decrypt_arch() using the CPACF AES instructions.\n> \n> Then, remove the superseded \"aes-s390\" crypto_cipher.\n> \n> The result is that both the AES library and crypto_cipher APIs use the\n> CPACF AES instructions, whereas previously only crypto_cipher did (and\n> it wasn't enabled by default, which this commit fixes as well).\n> \n> Note that this preserves the optimization where the AES key is stored in\n> raw form rather than expanded form. CPACF just takes the raw key.\n> \n> Acked-by: Ard Biesheuvel \n> Signed-off-by: Eric Biggers \n\nThanks!\n\nTested-by: Holger Dengler \nReviewed-by: Holger Dengler ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=UhWJ1/AD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15872-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=UhWJ1/AD;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=dengler@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dscNy4rnNz1xsq\n\tfor ; Fri, 16 Jan 2026 09:00:34 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dscNq6SrWz2yFY;\n\tFri, 16 Jan 2026 09:00:27 +1100 (AEDT)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dscNp2WZLz2xnj\n\tfor ; Fri, 16 Jan 2026 09:00:25 +1100 (AEDT)","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n 60FHEjlW023973;\n\tThu, 15 Jan 2026 22:00:16 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4bkd6egeye-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 15 Jan 2026 22:00:16 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 60FKkCfH014255;\n\tThu, 15 Jan 2026 22:00:15 GMT","from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])\n\tby ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bm1fyjsh3-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 15 Jan 2026 22:00:15 +0000","from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com\n [10.20.54.106])\n\tby smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 60FM0DTZ60162344\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tThu, 15 Jan 2026 22:00:13 GMT","from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 37DDF20040;\n\tThu, 15 Jan 2026 22:00:13 +0000 (GMT)","from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D33902004B;\n\tThu, 15 Jan 2026 22:00:12 +0000 (GMT)","from [9.111.195.181] (unknown [9.111.195.181])\n\tby smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tThu, 15 Jan 2026 22:00:12 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768514427;\n\tcv=none;\n b=mj+aIP75U+QLHeLEITzOq6KsmcTr1o/JgaDbNMpXEqaCDqW1KbXlqIr6VtJ7qWa2f1k3A5YQxmDgFq6ITB3kcfgCuYVvEQExJ/sKqDPOIkDgfH6IO/tNEjZloClH540I6QDtt/DgGzjRv8I0s3JSraTST37LpiK+gPshq155O8iR28zQrQ84fowtcmCvZvviY2zQRW0WUWsADeRNpWaF4EsGAyIwYT5CgSsYOoZ3gFVcQswd+AN8fms4QLX2zMCdtmRZwtGY9RzGUr5kbF+ks3rBBCsRWGERYRakinhZhrj0xouKE9i6s89Y9o9uBxGt3GxKzQja5r6eYFDsIhO3AQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768514427; c=relaxed/relaxed;\n\tbh=fn2sWs9rsdbV0vxeRVrjmzY9BmEC+XTCv1XXSHerLL8=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=YG3Rr/Z4RPFTkyboUlSRiGCtap6x+k2qtVcLBCpA4Ptbk+CKZDNs7OUPBBejJX8Aa4EPPqGMUFCzn2muPZE5RaBrr3XHx0wgG58gyeC7qtGE/l4FyYPZBseFH4ylKsY2iRfWpBnsWUKGVAqCWn3WiWo1cDFM+uhZh/MXMfgo2X4xmccC64leXorrAjwZjRow7JDPIft9iTlth6mdlsGkhl23tweqlXPEzjvDmPONN7NOa7lLHpnViLL5ryr6IMqeUvGre+TWghg4v+tn0WauMSa3GRed4wEAtjT2KHmfkjRPuxtI/B7q41i4GxN2RaDOCnoUBZsF6S8Pq3NmouNgUA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=UhWJ1/AD; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=dengler@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=fn2sWs\n\t9rsdbV0vxeRVrjmzY9BmEC+XTCv1XXSHerLL8=; b=UhWJ1/AD1XNfi2W0E653MX\n\trWZ+eYl1wyhuYHNXvRBwfqnQcJBJKmgA74Jf0/kUgkcmeHe/8SH7NJyLR8QZTf5d\n\taOOI1LZEJrl6W61v8hK+vC/CK7c0e2LMKgEU9Ofk0672o5Dpv9Vakg9XGuol6vgO\n\teARfjFasmy52XTIeOhomSw6z8EYo6++NggXM8w1EXcectmP+2Rlr5b1Xk+Fj8/nU\n\tpO7pK8Jl2szqf/da1q4WNVGbwL6Jk0mNl/sCr3e1np+rimYa7OBQGJxvLx6X93cg\n\tiK7o+oUuDtt+GjO1TLdfqg1ufeFKqdeYkot8h9G+F+JjU4cU87CpInckkGyjhN3Q\n\t==","Message-ID":"<03ba58e6-0eaf-4970-8d27-ffe29bc9a7bf@linux.ibm.com>","Date":"Thu, 15 Jan 2026 23:00:12 +0100","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 15/35] lib/crypto: s390/aes: Migrate optimized code\n into library","To":"Eric Biggers ","Cc":"linux-kernel@vger.kernel.org, Ard Biesheuvel ,\n \"Jason A . Donenfeld\" ,\n Herbert Xu ,\n linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,\n linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,\n sparclinux@vger.kernel.org, x86@kernel.org,\n Harald Freudenberger ,\n linux-crypto@vger.kernel.org","References":"<20260112192035.10427-1-ebiggers@kernel.org>\n <20260112192035.10427-16-ebiggers@kernel.org>","From":"Holger Dengler ","Content-Language":"de-DE","In-Reply-To":"<20260112192035.10427-16-ebiggers@kernel.org>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-GUID":"6p5z8nBCPsT3_rpKVRy3lnJhFN25wKw4","X-Authority-Analysis":"v=2.4 cv=LLxrgZW9 c=1 sm=1 tr=0 ts=69696370 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=w4HzK-rsqA_2YikTyBoA:9 a=3ZKOabzyN94A:10\n a=QEXdDO2ut3YA:10 a=0lgtpPvCYYIA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMTE1MDE3MSBTYWx0ZWRfXz5BoL5J7pcUU\n EZ3HWHibhHjFOAoKQCeCAZQZFMw/rVxT3IT4w9ASJsDdLE0sXatur5m8WX/gRMd2Mvjk9EaFY5D\n C/Y4bvVEpB3VqE2+10CoQfUpEs64m3duyFEDGkeNQ4xeUUr2AEUG0ynVzNXFgKzknUbAS2y45W1\n dA34Ek0N1Un5SPKN09kDdU7nbue+a4UqMMJjlQn3bIyoNUk9mRpfFnYqdetqw7Nw1y7ntYTzKNI\n BcddjFCun4THIVcuAjbj91UfZX3GenM7j++LCuimK57ylm2xCH1S4KQzxPnj6RsL9R2HbSYujVK\n uvRKRDYg4HGrPP/KnsIX8bLXU6I40Het/QKY/mhLxoOshgIjE4/phJIiOKwt/3Rw7wNztuDmfZT\n 1Lr8WlCzPTGKSsXxJT+I/p/uJbjtxbpFvRqsk4x7QlvgLbabrSlm0K6nh/BMNn3NUmYgv/OZiLz\n uZY40rcvNmYBRee4FVw==","X-Proofpoint-ORIG-GUID":"6p5z8nBCPsT3_rpKVRy3lnJhFN25wKw4","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49\n definitions=2026-01-15_06,2026-01-15_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 suspectscore=0 clxscore=1015 spamscore=0 impostorscore=0\n malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601150171","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]