[{"id":3629431,"web_url":"http://patchwork.ozlabs.org/comment/3629431/","msgid":"","list_archive_url":null,"date":"2025-12-29T15:33:46","subject":"Re: [RFC PATCH 03/25] migration/tls: Remove unused parameter","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Fri, Dec 26, 2025 at 06:19:05PM -0300, Fabiano Rosas wrote:\n> MigrationState is not used at migration_tls_channel_process_incoming().\n> \n> The last usage was removed by commit 3f461a0c0b (\"migration: Drop\n> unused parameter for migration_tls_get_creds()\")\n> \n> Signed-off-by: Fabiano Rosas \n\nReviewed-by: Peter Xu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hvEjQwHR;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=h66SW2Io;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dg0cz6Nm3z1xpZ\n\tfor ; Tue, 30 Dec 2025 02:34:11 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vaFFq-0007HQ-Lv; Mon, 29 Dec 2025 10:33:54 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vaFFp-0007Fz-7q\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 10:33:53 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vaFFn-0006VW-Rc\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 10:33:53 -0500","from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-572-mZhaTlIxOlywBxJ0yj0sVg-1; Mon, 29 Dec 2025 10:33:48 -0500","by mail-qk1-f200.google.com with SMTP id\n af79cd13be357-8b2ea3d12fcso1159629785a.0\n for ; Mon, 29 Dec 2025 07:33:48 -0800 (PST)","from x1.local ([142.188.210.156]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8c0973f4647sm2434746785a.46.2025.12.29.07.33.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 29 Dec 2025 07:33:46 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1767022431;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=d9kfIwKGSeaqCiK6IqvZcvesuHOHu0bMSWBfcHegt5w=;\n b=hvEjQwHRbjeWH833pGzcbuYeTpYPH7oHFy/zf0fyzLBOB0LWb7wlVAyuzUY+lcz5/yHU1P\n wlZQzwNt/DfLCZGwGIC+57bCxA34Mk/Ayshq0G3nWeg62GQkzO6ZyDJ4Qv/wMp1m/0S+9+\n YeizIPopfqXWCW9wVhCHsx5yeIZQ0bo=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1767022428; x=1767627228; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=d9kfIwKGSeaqCiK6IqvZcvesuHOHu0bMSWBfcHegt5w=;\n b=h66SW2IoS8kitBZsWNQ1FoJ4wtNAs3tFYAiFBp1A+dtdFavjjePcdGlw+0uorQYiAl\n ioKiCAp7PLdYcWwfCwNuTEgrLbKqC9rQyr/Lf+06AqFsOEgy/GU0gny4pOOK4x2xjlzb\n PEx3H2v8zTmBXIU8mIDRTNQD7O1O67LN0Qzke3sLbRLe2O2B9kvFJQpJr3VHOQdJI+Ef\n ikSauQVQWXxrP4peQMwzj2BbN3T9P4VLKbp/DoE/Me8OfDk0SVoQJER/5CM/ItlaGHhJ\n zF1X3Svi0bmRwzUvVFSbIwB2Oo96YKb7AfM2RGKIn5fUdx/YWDj/adxoLRWstYVIMGMO\n ANvQ=="],"X-MC-Unique":"mZhaTlIxOlywBxJ0yj0sVg-1","X-Mimecast-MFC-AGG-ID":"mZhaTlIxOlywBxJ0yj0sVg_1767022428","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1767022428; x=1767627228;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=d9kfIwKGSeaqCiK6IqvZcvesuHOHu0bMSWBfcHegt5w=;\n b=nGxshzj+P29naRXsqFQz4YLTmmKb/dpeSZ+GdXjBSa3tmJ0rsq0tkl6asB/WuRbbAY\n CF4u3X21xrJGdYQGI7onKQQLpqDoWmsgo7824MD7slaXy4YvNXT7TrWWzD4Jb7VpBd+g\n 1IY7u7fVKZA74kN4BTXyslOR3aQQ8H+9EVF5VLB8icvaQPr16iz8FDPJvKAS2bTvGadB\n TyzOHJDxQid3yhKKWv7qqoaKuQgyR+5CZbMRbjlNJEnqireFn8AIq/n3BTz95sEeYK00\n IY0f81KRXPpBgkFfmUeta309li++aEvxvZNvcFWHvPFYaIqID4g1s3HXcnF5dV+3II8o\n ukAQ==","X-Gm-Message-State":"AOJu0YyTcAaZe0RWpN4xD0+8YJuB4SyqUB14nut5rkLi5M1RH5hJFAKa\n 4kMuvPJ3sVlspDeb2DLQ2nrCU2UexDx8rmUTd6NMgAxqyLUbTkcqu3cS/RMksZSVHbgNZvZ2lM2\n QdRvcjS7akj7a4sTBBxMUhUuSc5EZCGDd2qjD7kLwLFBk6VnmdHlayFeCyiHOxdw7","X-Gm-Gg":"AY/fxX66rEw4fTuZzgm4YxOXE8w3MHdWomyKfPzNvQdQtz/GMHeYHYAS5trqyZuqM2u\n wwTdHNWfWbfm1se8ya1ugQVwpdTjXWu6cGrY+xxftl9NIYOVb7cCDEep+b0xRlc4AVz2nC4iyvd\n pq4hnzMVnbbwxXznfDvXPpct5A8DikwC2dCYK1qN0LjOkx3wiBuemF+rROqXozmh6fb6B1znvSI\n ALYUMTjHZZDiLIwS8yEvbiUhdZ6oyoyliCLO2e3CII764rTLyUldoJNjJqXNLR6QcHBjxWnDTqp\n 4XgK+TPHOT2lTMgji2SQBTTaFLYuehDMr0LHDrITR2HTo8DRDNGojfW9OXP9Y24xxWsyKXyXZ/B\n AK1M=","X-Received":["by 2002:a05:620a:44d5:b0:8b2:db27:4268 with SMTP id\n af79cd13be357-8c09011f7abmr4658693485a.53.1767022427735;\n Mon, 29 Dec 2025 07:33:47 -0800 (PST)","by 2002:a05:620a:44d5:b0:8b2:db27:4268 with SMTP id\n af79cd13be357-8c09011f7abmr4658689585a.53.1767022427336;\n Mon, 29 Dec 2025 07:33:47 -0800 (PST)"],"X-Google-Smtp-Source":"\n AGHT+IGygY/V4xZZIY1+c2XYgBvJ1Bt4maIQFUgIOBbinA/runYKOcP8ZJyun22BK6vgBBOWUgvCCQ==","Date":"Mon, 29 Dec 2025 10:33:46 -0500","From":"Peter Xu ","To":"Fabiano Rosas ","Cc":"qemu-devel@nongnu.org","Subject":"Re: [RFC PATCH 03/25] migration/tls: Remove unused parameter","Message-ID":"","References":"<20251226211930.27565-1-farosas@suse.de>\n <20251226211930.27565-4-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251226211930.27565-4-farosas@suse.de>","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]