[{"id":3629456,"web_url":"http://patchwork.ozlabs.org/comment/3629456/","msgid":"","list_archive_url":null,"date":"2025-12-29T17:17:10","subject":"Re: [RFC PATCH 11/25] migration: yank: Move register instance earlier","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Fri, Dec 26, 2025 at 06:19:13PM -0300, Fabiano Rosas wrote:\n> Move the register_instance call to migrate_prepare() so it can be\n> paired with the unregister_instance at migration_cleanup(). Otherwise,\n> the cleanup cannot be run when cpr_state_save() fails because the\n> instance is registered only after it.\n> \n> When resuming from a paused postcopy migration, migrate_prepare()\n> returns early, but migration_cleanup() doesn't run, so the yank will\n> remain paired.\n> \n> Signed-off-by: Fabiano Rosas \n\nReviewed-by: Peter Xu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fbh7q30E;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=czHvyy25;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dg2wg6dQZz1xpV\n\tfor ; Tue, 30 Dec 2025 04:17:55 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vaGs1-0003Fj-3V; Mon, 29 Dec 2025 12:17:25 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vaGrz-0003FK-EU\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 12:17:23 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vaGry-0006mn-1C\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 12:17:23 -0500","from mail-qt1-f198.google.com (mail-qt1-f198.google.com\n [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-501-U1MxAtJ9ML6nrjmvJpu9Gg-1; Mon, 29 Dec 2025 12:17:15 -0500","by mail-qt1-f198.google.com with SMTP id\n d75a77b69052e-4ed6855557aso216017281cf.1\n for ; Mon, 29 Dec 2025 09:17:15 -0800 (PST)","from x1.local ([142.188.210.156]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-4f4ac62f973sm232849301cf.18.2025.12.29.09.17.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 29 Dec 2025 09:17:13 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1767028640;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=iTJ5nzZuYxlGkcNPYCY4Oxn1ZDw2jiK/T3uoGI0wVcA=;\n b=fbh7q30EIBtUoU2ZORK9VUh4tgDRbwSfW94IubnPJ2vcvApw7zswVwqnRWMh13OplYzL6i\n bXOFyHTZL3CvTpQg6oFrCct1AQKmLOsWCQhOzNEIHTSve6lpbhFUuFZ9ybWRCSvybaJLGq\n p2W8wJMKM/bLIRgaiyRlAeOs1q4OYFg=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1767028634; x=1767633434; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=iTJ5nzZuYxlGkcNPYCY4Oxn1ZDw2jiK/T3uoGI0wVcA=;\n b=czHvyy25WaCjVbPQyYG1zP5121TR8vxfc/pKGL19wZ+NW9n/Wga7I+hgCunKSjEBsz\n sR1sMkpa948RdJI9jSKjPgq+q3WZVnOnUrlJaYN0jsgJ53Qa2yu2O3+ugPHss0W/vd4f\n pyfyVyKhU+jp+Ay/SdBVW4JWeuv8WAHLjQLOQyqF5zppzAVB3fc+dCVlAgDPbyWdH5bk\n Zx+KvAm8yG+1Qdh3yksjjbg2E77GJ0Y3J/AwEZsFsf2TwPdsoYOR/4+YADX69EUldHDr\n gt9ni1V8o0Sj/65LP4iXmLBmCzS/jYQviDPI6XYAGhfsfcu3zfOvGagnLK66dp5tdl/N\n p24A=="],"X-MC-Unique":"U1MxAtJ9ML6nrjmvJpu9Gg-1","X-Mimecast-MFC-AGG-ID":"U1MxAtJ9ML6nrjmvJpu9Gg_1767028634","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1767028634; x=1767633434;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=iTJ5nzZuYxlGkcNPYCY4Oxn1ZDw2jiK/T3uoGI0wVcA=;\n b=xDAE3fihvrTTrLbckqmi+6onfu/WYLOatS9UU9u76AAtsB/3E/8azv3jL/UzT0WXzT\n 3XMoXM2O1Rf1+wIbdQuKNm6GyCGk0FBMW7c0U+6UKsOXeK/N6hw9kQEpsjD9cuGCozSm\n EHKkWsAYuHm7SQ2YPRMZoLnH8eS46gQanDlxkmy/p37iN78dsRh9XLLJk+ezDQLniyQb\n IcEZHGjJbGltfiCWDrjiK0q0y2Qz/LLUHD+1NyjOSd2fLcKqOEZHyw36O4TYg0jYmDQS\n nczCHXB7vHcP0T/Qg5Gl0w9rfS9cO61jP6tI5K2PvITuCnQVuDtgB9aBat+NaRfTX7ZH\n 75CQ==","X-Gm-Message-State":"AOJu0YywvsROvpt/a67f+n3dsO58FbT0ci5UqClLg5KoshORwqMVJvhf\n ea0Rr/ysc76y5nhzbyKVU65I7x58MiFGyPxQk1qtXyv85SwIz71oeuR6h1xSKcDAe8MlvGTlixE\n Lek3cOxNwsrYAQt3hvqDueSAVXO91qiD4CbfRHrl5eCG+7Xy6LS+GCqi+","X-Gm-Gg":"AY/fxX7PbRFdBbpUczdrM6EvW3S/hkVZqvxUVWNqAyX+BsalrtT+4VLL78lMZ9bC/BN\n xuVSkHgcU7gW5F1t4v3595QA9ssStm79CK03geWDEQkveM4QSZO9MbQXrZUDA5BSvRtDiRnrGuW\n jok6uO8mn9QngxzwwTmDm3XteYzjsUVXZzX1TPm6hXLPg+OfgGbDlP9SeQqYsda/RTBMpLwPzC6\n Yt00tNAkaqZCffY95tRr/r35U9EfMm/Je4F7eOnc2qTxF56q3zEi0zT8gRqJd6lUxFjRDMhS3vg\n lD9BihXkabrnkv+GccrP9FXwKzkA+pby5lb2Ol8G8DlkpPqV9Pmkjyy3SRQ+XwzOdgQiKcR8gCF\n +bXY=","X-Received":["by 2002:a05:622a:15d6:b0:4ed:bc0a:88c3 with SMTP id\n d75a77b69052e-4f4aadb1032mr544278361cf.33.1767028634441;\n Mon, 29 Dec 2025 09:17:14 -0800 (PST)","by 2002:a05:622a:15d6:b0:4ed:bc0a:88c3 with SMTP id\n d75a77b69052e-4f4aadb1032mr544277961cf.33.1767028633974;\n Mon, 29 Dec 2025 09:17:13 -0800 (PST)"],"X-Google-Smtp-Source":"\n AGHT+IF3YYx255VsEDOKutgFZMPAt3mKudwn+ZzKsvER10q0H8Bg4FF5M2AUofPOSGEEGChrHLXI6w==","Date":"Mon, 29 Dec 2025 12:17:10 -0500","From":"Peter Xu ","To":"Fabiano Rosas ","Cc":"qemu-devel@nongnu.org","Subject":"Re: [RFC PATCH 11/25] migration: yank: Move register instance earlier","Message-ID":"","References":"<20251226211930.27565-1-farosas@suse.de>\n <20251226211930.27565-12-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251226211930.27565-12-farosas@suse.de>","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]