[{"id":3629434,"web_url":"http://patchwork.ozlabs.org/comment/3629434/","msgid":"<aVKjZyDWVH5ouvdV@x1.local>","list_archive_url":null,"date":"2025-12-29T15:51:03","subject":"Re: [RFC PATCH 04/25] migration: Move multifd_recv_setup call","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Fri, Dec 26, 2025 at 06:19:06PM -0300, Fabiano Rosas wrote:\n> The multifd_recv_setup() call is currently in a place where it will be\n> called for every channel that appears. That doesn't make much\n> sense.\n> \n> It seems it was moved when the channel discovery mechanism was added\n> back at commit 6720c2b327 (migration: check magic value for deciding\n> the mapping of channels, 2022-12-20). The original place was\n> migration_incoming_setup() which would run for just the main channel,\n> but it was discovered that the main channel might arrive after a\n> multifd channel.\n> \n> Move the call back to a place where it will be called only once.\n> \n> With respect to cleanup, this new location at\n> qemu_start_incoming_migration() has the same issue as the previous\n> callsite at migration_ioc_process_incoming(): no cleanup ever happens.\n> \n> The error message goes from being emitted via error_report_err(), to\n> being returned to the qmp_migrate_incoming() incoming command, which\n> is arguably better, since this is setup code.\n\nThis is not the only and real reason that you moved it, right?\n\nNeither should it be the reason that you want it to be called only exactly\nonce; after all the function will be no-op in the 2nd+ calls.\n\nI'll keep reading.. I'm guessing I'll find it later, but IMHO it'll always\nbe good to mention the real motivation in the commit log.\n\n> \n> Signed-off-by: Fabiano Rosas <farosas@suse.de>\n> ---\n>  migration/migration.c | 8 ++++----\n>  1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/migration/migration.c b/migration/migration.c\n> index 71efe945f6..974313944c 100644\n> --- a/migration/migration.c\n> +++ b/migration/migration.c\n> @@ -786,6 +786,10 @@ static void qemu_start_incoming_migration(const char *uri, bool has_channels,\n>          return;\n>      }\n>  \n> +    if (multifd_recv_setup(errp) != 0) {\n> +        return;\n> +    }\n> +\n>      if (addr->transport == MIGRATION_ADDRESS_TYPE_SOCKET) {\n>          SocketAddress *saddr = &addr->u.socket;\n>          if (saddr->type == SOCKET_ADDRESS_TYPE_INET ||\n> @@ -1065,10 +1069,6 @@ void migration_ioc_process_incoming(QIOChannel *ioc, Error **errp)\n>          channel = CH_POSTCOPY;\n>      }\n>  \n> -    if (multifd_recv_setup(errp) != 0) {\n> -        return;\n> -    }\n> -\n>      if (channel == CH_MAIN) {\n>          f = qemu_file_new_input(ioc);\n>          migration_incoming_setup(f);\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=an037FNk;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=QvUfYwbx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dg11j0LlBz1xvd\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 30 Dec 2025 02:52:07 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vaFWc-0001gP-Ti; Mon, 29 Dec 2025 10:51:14 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1vaFWa-0001fR-Gz\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 10:51:12 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1vaFWY-0008ST-71\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 10:51:12 -0500","from mail-qv1-f70.google.com (mail-qv1-f70.google.com\n [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-78-mCyUoGxCPWuUOYjUUllrEA-1; Mon, 29 Dec 2025 10:51:06 -0500","by mail-qv1-f70.google.com with SMTP id\n 6a1803df08f44-88a43d4cd2bso115610486d6.1\n for <qemu-devel@nongnu.org>; Mon, 29 Dec 2025 07:51:05 -0800 (PST)","from x1.local ([142.188.210.156]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-88d997addd5sm235401026d6.33.2025.12.29.07.51.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 29 Dec 2025 07:51:04 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1767023468;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=r5GB/jPnI0makKKh4NsjhAB7cxSNMwihLyQggccSU74=;\n b=an037FNk0QyS8uYNseaYlpJLDEfC2qEkoi41dG5uwf6RDb+UXFavmgnkgWqIeNcXK5g3DE\n dCnb7GP2rQ1HMw/lEUuPRe6tIP8dXw1U3jTdFtoOheR+s6qtJsExHFyKMHJl2ysbqmBLob\n YDedXR+eZcpn5dsBp+JeMs+syrq/AsU=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1767023465; x=1767628265; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=r5GB/jPnI0makKKh4NsjhAB7cxSNMwihLyQggccSU74=;\n b=QvUfYwbxD3Sp7tm+zHU+fRtj7HycduXMyQNU5VSv6XpKfpH28B8bgQ6ZbThZp3AACX\n j8uUDU87rzauY7l5sGLFLDhfyoARZUsVtP42NY4r9BUi8b4VFa9w8V8WaXuY2hndwo1R\n +2nmgC1Afx4zdOyISNmC7bJE7CbrNd74cZoQF1R1gHWp6jdkTnPhotYxWesGA5B7muEM\n ByAOYbaw1F5yDIaKbt0+/C8m5fYiOMeH4KYuApzDSh2BCOpJSHCgpD7eGmPVqifPWaXI\n rp7RpqUtDih0H0ctBG6KvzMJOhzy+9RJI40oDsXYc62B1Bf3+U/p4U2KlRuvI3rT2UaO\n qK8g=="],"X-MC-Unique":"mCyUoGxCPWuUOYjUUllrEA-1","X-Mimecast-MFC-AGG-ID":"mCyUoGxCPWuUOYjUUllrEA_1767023465","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1767023465; x=1767628265;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=r5GB/jPnI0makKKh4NsjhAB7cxSNMwihLyQggccSU74=;\n b=qobDjtS5bzAn7smQEBZgr+vNoeLJTwb1TfSvCpslapawya4b0XmgCFBBTWO5lOvWZ8\n Fgq7AkvafsrR+85l5ah2TLdj9zvjwsfgov8ETstXBA7488S+gqsiUgtGirMi5GM644o9\n pr0ZdCJa8wke+8lDlbATFDGib8VmAizlfEHF/aetMVwjbgqfuxB8BkGD2FJLF0wI0Q4L\n ZKHmgqr42XgB0g9P8RPHVqeFcRGHC3sxmszVIkXDRddjB0bQjpNk6pgCnD2ueyvsvWYx\n IP9n2823jeXaaQFSQs3SYSLGcl+0qPqybqnu+3tFs37de9bFZXRcsbArLh6BUnPdwq1N\n hjEQ==","X-Gm-Message-State":"AOJu0YwCs7r0vgKp3D6yfp7DX8THnMqAZLxpVpvg0umwWb3djG7iWAJN\n yxjMTR8TWse2f1EyRHalDGRinryhO8RFX6RyIPdrkA+pfZThJ9N74q+v9Gw2IGCgdacS4r966Ns\n MqA9LXvf2uo5rThDd7yvPrB03MVHuxaGsRM6heVCtn/K5P2KGmDEIcv6G","X-Gm-Gg":"AY/fxX4lGYoxwJOLxtIQ8WTYmJUSRfE57FF4U4/wQZSU0LteWevxhgG7qx2+GM9YlQh\n z2Z5w0pkw8NYPXNuJ226HxU34Ftx/jXmh7+sBHJ/r001UO/TpFuxNpkT6mIASFdO8hI1lMq5W6R\n sQAzgsN3Xuyj2soqiGqA632e7KK5Xi3PjV+VwQcAX7sCoiJ23aRoV5JCPCQsH2CO6P6JcL3KBLJ\n 8+DiKYQ4rwjXGUGWdB9DT7wXowDbYR5LjQFVJl03MIY3EBSH8IzEqLpbIZVuXhHmEb/kJ7WLTZD\n xyzpYwxAn3gB0yrL1j4RawQjuJB3QHBSFYFMh/DZFcaWl1+j1FHbg7fxU3m65EH3/C3A5I1cSUM\n p+TI=","X-Received":["by 2002:ad4:5d64:0:b0:88a:2d3d:7c30 with SMTP id\n 6a1803df08f44-88d83f573ecmr448259896d6.55.1767023465330;\n Mon, 29 Dec 2025 07:51:05 -0800 (PST)","by 2002:ad4:5d64:0:b0:88a:2d3d:7c30 with SMTP id\n 6a1803df08f44-88d83f573ecmr448259466d6.55.1767023464786;\n Mon, 29 Dec 2025 07:51:04 -0800 (PST)"],"X-Google-Smtp-Source":"\n AGHT+IFjat2F31F6zyk/9akSEMxfRbcbwlzM315gEG/2pdygHd5ANFTQv6d8Kb5ul9poQQCJisQdmA==","Date":"Mon, 29 Dec 2025 10:51:03 -0500","From":"Peter Xu <peterx@redhat.com>","To":"Fabiano Rosas <farosas@suse.de>","Cc":"qemu-devel@nongnu.org","Subject":"Re: [RFC PATCH 04/25] migration: Move multifd_recv_setup call","Message-ID":"<aVKjZyDWVH5ouvdV@x1.local>","References":"<20251226211930.27565-1-farosas@suse.de>\n <20251226211930.27565-5-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251226211930.27565-5-farosas@suse.de>","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3629508,"web_url":"http://patchwork.ozlabs.org/comment/3629508/","msgid":"<87o6nh8564.fsf@suse.de>","list_archive_url":null,"date":"2025-12-29T19:21:55","subject":"Re: [RFC PATCH 04/25] migration: Move multifd_recv_setup call","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/","name":"Fabiano Rosas","email":"farosas@suse.de"},"content":"Peter Xu <peterx@redhat.com> writes:\n\n> On Fri, Dec 26, 2025 at 06:19:06PM -0300, Fabiano Rosas wrote:\n>> The multifd_recv_setup() call is currently in a place where it will be\n>> called for every channel that appears. That doesn't make much\n>> sense.\n>> \n>> It seems it was moved when the channel discovery mechanism was added\n>> back at commit 6720c2b327 (migration: check magic value for deciding\n>> the mapping of channels, 2022-12-20). The original place was\n>> migration_incoming_setup() which would run for just the main channel,\n>> but it was discovered that the main channel might arrive after a\n>> multifd channel.\n>> \n>> Move the call back to a place where it will be called only once.\n>> \n>> With respect to cleanup, this new location at\n>> qemu_start_incoming_migration() has the same issue as the previous\n>> callsite at migration_ioc_process_incoming(): no cleanup ever happens.\n>> \n>> The error message goes from being emitted via error_report_err(), to\n>> being returned to the qmp_migrate_incoming() incoming command, which\n>> is arguably better, since this is setup code.\n>\n> This is not the only and real reason that you moved it, right?\n>\n\nIt was odd where it was and I just moved it. It could probably remain\nthere even after the rest of the series, I didn't check.\n\nI think it would then need to move to channel.c which would make that\nfile access multifd code, so maybe it's a layering argument.\n\n> Neither should it be the reason that you want it to be called only exactly\n> once; after all the function will be no-op in the 2nd+ calls.\n>\n\nIt's not a no-op. But yes, it returns early on subsequent calls.\n\n> I'll keep reading.. I'm guessing I'll find it later, but IMHO it'll always\n> be good to mention the real motivation in the commit log.\n>\n>> \n>> Signed-off-by: Fabiano Rosas <farosas@suse.de>\n>> ---\n>>  migration/migration.c | 8 ++++----\n>>  1 file changed, 4 insertions(+), 4 deletions(-)\n>> \n>> diff --git a/migration/migration.c b/migration/migration.c\n>> index 71efe945f6..974313944c 100644\n>> --- a/migration/migration.c\n>> +++ b/migration/migration.c\n>> @@ -786,6 +786,10 @@ static void qemu_start_incoming_migration(const char *uri, bool has_channels,\n>>          return;\n>>      }\n>>  \n>> +    if (multifd_recv_setup(errp) != 0) {\n>> +        return;\n>> +    }\n>> +\n>>      if (addr->transport == MIGRATION_ADDRESS_TYPE_SOCKET) {\n>>          SocketAddress *saddr = &addr->u.socket;\n>>          if (saddr->type == SOCKET_ADDRESS_TYPE_INET ||\n>> @@ -1065,10 +1069,6 @@ void migration_ioc_process_incoming(QIOChannel *ioc, Error **errp)\n>>          channel = CH_POSTCOPY;\n>>      }\n>>  \n>> -    if (multifd_recv_setup(errp) != 0) {\n>> -        return;\n>> -    }\n>> -\n>>      if (channel == CH_MAIN) {\n>>          f = qemu_file_new_input(ioc);\n>>          migration_incoming_setup(f);\n>> -- \n>> 2.51.0\n>>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=QJWK98Cj;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=nopEY0cr;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=0zlflq9/;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Oy9gYS2i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dg5j45l9nz1xpZ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 30 Dec 2025 06:23:04 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vaIou-0004KK-6M; Mon, 29 Dec 2025 14:22:26 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vaIog-0004IL-Km\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 14:22:06 -0500","from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vaIof-0004oG-0T\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 14:22:06 -0500","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id E61945BCDB;\n Mon, 29 Dec 2025 19:21:58 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 60775137C3;\n Mon, 29 Dec 2025 19:21:58 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id lHSnCNbUUmlqVAAAD6G6ig\n (envelope-from <farosas@suse.de>); Mon, 29 Dec 2025 19:21:58 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1767036120;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=6djY2jfljzQRf2HoHkrlxfJJF7md7+vJQfG4ZLiJF5Y=;\n b=QJWK98CjNzhqG/dJF5Al3g5o4funCgFYwHhAwT4bAy/3dC3cbtzfsLQGf7wzay/9Sy/+Jg\n Pm02XiuMkbhoUSgaVe6ulHZjOtAKtK0aAItvhK+n9mn9830Mwnjzs+Qh7MwZRr12z17l/T\n YN+cRrVLZWdGwnVOC3/08NrcgmbfkRA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1767036120;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=6djY2jfljzQRf2HoHkrlxfJJF7md7+vJQfG4ZLiJF5Y=;\n b=nopEY0cr7rUYkk5xOHPeZ4QyQLbcSd4JH9jiGRlRqwHCT4pmR1rjvKsqfdEdikp1AnRk8F\n GYf8ihNikWzmQSAg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1767036118;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=6djY2jfljzQRf2HoHkrlxfJJF7md7+vJQfG4ZLiJF5Y=;\n b=0zlflq9/aOxWcZRrTrLdrjYc9+4aixi87z11AxBGt/a+KaKuyMnnjXfikV/wDqL6cUh8/m\n gLjWmT4qqf9XyEq0nlI4pMsTwpilv18+udGmfP2Ln06mBRbQ79+dyhI4lffjOLJkIK/xqE\n sFx7+5AxLDGb4mTppKTqtqF8Dxpabk0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1767036118;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=6djY2jfljzQRf2HoHkrlxfJJF7md7+vJQfG4ZLiJF5Y=;\n b=Oy9gYS2iBux3pb9e7RXUDlcmr07Y4csSiwlEPnugvIoG998oCf3t0YflGYEamH2IcbzASu\n Xr7eLYFRUgCi9aDw=="],"From":"Fabiano Rosas <farosas@suse.de>","To":"Peter Xu <peterx@redhat.com>","Cc":"qemu-devel@nongnu.org","Subject":"Re: [RFC PATCH 04/25] migration: Move multifd_recv_setup call","In-Reply-To":"<aVKjZyDWVH5ouvdV@x1.local>","References":"<20251226211930.27565-1-farosas@suse.de>\n <20251226211930.27565-5-farosas@suse.de> <aVKjZyDWVH5ouvdV@x1.local>","Date":"Mon, 29 Dec 2025 16:21:55 -0300","Message-ID":"<87o6nh8564.fsf@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain","X-Spam-Score":"-4.30","X-Spamd-Result":"default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-0.989]; MIME_GOOD(-0.10)[text/plain];\n RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n RCVD_TLS_ALL(0.00)[]; MISSING_XM_UA(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+];\n MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[];\n FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email, suse.de:mid,\n imap1.dmz-prg2.suse.org:helo]","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]