[{"id":3629430,"web_url":"http://patchwork.ozlabs.org/comment/3629430/","msgid":"","list_archive_url":null,"date":"2025-12-29T15:32:44","subject":"Re: [RFC PATCH 02/25] migration: Fix state change at\n migration_channel_process_incoming","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Fri, Dec 26, 2025 at 06:19:04PM -0300, Fabiano Rosas wrote:\n> When the incoming migration fails during the channel connection phase,\n> the state transition to FAILED is currently being done in the\n> MigrationState->state, but the MigrationIncomingState->state is the\n> one that should be used.\n> \n> Signed-off-by: Fabiano Rosas \n\nReviewed-by: Peter Xu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cDi467C5;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Yt1To+HL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dg0cY2h5Yz1xpZ\n\tfor ; Tue, 30 Dec 2025 02:33:49 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vaFEu-0006oP-Q8; Mon, 29 Dec 2025 10:32:56 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vaFEq-0006nn-Nr\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 10:32:53 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vaFEn-0006L3-Q2\n for qemu-devel@nongnu.org; Mon, 29 Dec 2025 10:32:52 -0500","from mail-qk1-f198.google.com (mail-qk1-f198.google.com\n [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-672-eRvgrC8TMzanJLdBPuPcIA-1; Mon, 29 Dec 2025 10:32:46 -0500","by mail-qk1-f198.google.com with SMTP id\n af79cd13be357-8b1d8f56e24so2334575885a.2\n for ; Mon, 29 Dec 2025 07:32:46 -0800 (PST)","from x1.local ([142.188.210.156]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8c0973ef171sm2405566385a.44.2025.12.29.07.32.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 29 Dec 2025 07:32:44 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1767022368;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=ErFOgyrhj1ex57WiraNv3/JOI6hxTmjlkQIEGJZGy3k=;\n b=cDi467C5xhrBCsVcjJpu0Z2RkSaND8C8PMlSGMWn6BCtylHiCPXVWppy4qq3/z39C4Qy4+\n foL8Vja01KFpl3ljT0R4IVTnil5HLFgrV1Jl9LlqlEpU+ngJ41RyAdlRKTc4ndI8BdL+XH\n sE6oYj1A0q2lu/zEVfkwB4IDh1OBarg=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1767022366; x=1767627166; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=ErFOgyrhj1ex57WiraNv3/JOI6hxTmjlkQIEGJZGy3k=;\n b=Yt1To+HLoLXrlco2LUy4JpGTLvGGbSThJrwQhOQEc6N/5z/LyHXBOW8FPfxuBel4AC\n aD2ks2oAGFxbKKThI3GyGMf+4OxfbsnojtmF3hZ1O6g0nIoC+K2y8T3PNlcIQu/BV4uk\n X6+QwXOck5NcGhZ6ooMiR1TcFu/3fCTKZwP9vLh+99CI0N5c/cb/eX7Zpgc2oJfxcUtK\n oLQSARhweYzVxDYOYen/GQGOxBdy9TkhgvNk0OVW85i6J35ofsigyJtn08Pwik4705d7\n WtLZ6XACFMqC2jCii1S4MLy0fFpUZEHWYbpG7lTQwtPk4oXfBZ9+qRVVuX5MAWoM6+H7\n uWng=="],"X-MC-Unique":"eRvgrC8TMzanJLdBPuPcIA-1","X-Mimecast-MFC-AGG-ID":"eRvgrC8TMzanJLdBPuPcIA_1767022366","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1767022366; x=1767627166;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ErFOgyrhj1ex57WiraNv3/JOI6hxTmjlkQIEGJZGy3k=;\n b=wiFOEFS9I1UvyhfWJsZ06E0nNV7C8v9Yn/DF/HPxaclQv71xzwxzxEUh8BV+8HCZQ8\n Ib7V0Z85khS8gzdFxCHpVdx5FvnwqKBnfGYNxCSQE9AMtAjO2Da1VNoC++KTkDZkedBJ\n VIuqupMEmjA0RTZJJ54z4eldArz2KV1RNdNcNzyYaH/ZVK443HC8kEjk+nOg0zmKR7eT\n NlqpmqoDAEDtHUgFinoOzPG26N15/f9Xahrh7Htp3Vr/9CgYPL5AXs+F9aeDAEJy4sD4\n q4Gf0AtgN0nvzSLHaUugSHljGJeQ4Gwl6Q2UAVZ4T781RuocHJGWCxC7P75hZAXHGckh\n peCg==","X-Gm-Message-State":"AOJu0YzJIjZbc6UgpDcN7H4zTw2FuJoccBQFs4taQzOw4ZHQ6osfDr+Y\n pt4PCiati3V4622mSEHw/8A/hkQ2WVvK1xetJsZaRBXrRBErSTflx7n2wiz5dVB9zjFDTrJ9IlL\n IuWB0ZJ7Yy0xrRTiVwSJhvesVn53msuF+g8NGVySPI59+aLu+inN8S1Mx","X-Gm-Gg":"AY/fxX7NqfGcatbeDNlHl5gY5kfABxaEP5YN++4ekhaMhR+BjwD+gLJQVvO6TGMta1o\n 4INRgeDpNKTPwM2n7/KVXnBkUiwoyReqygaJDnFf2Rm39KW4Slp6nW0itvMk6SaOtodG9JtEcnU\n gTktkGlGXWUpI9SrwVon78YPQXh6PCT+37XhiGD0uKidw5xsn4H5E1bq/wuJbHcEtZlVp1Nqf4m\n IY8ilhVswKRANNuqfR+qlJhLJSVfEctxjZzLH1C6uMgt6TRQ+CK0YzW5J96sVQf2UZUQLk85QAV\n R/NY3/X0702oDljP0L18vZURj+4QJFlcE6Q++9FMm8PuT8X7penZYnEHpT9xhXZXYtOTQRplGEW\n OyWI=","X-Received":["by 2002:a05:620a:4108:b0:8b2:71dd:587a with SMTP id\n af79cd13be357-8c08f6550bbmr4402001385a.15.1767022365990;\n Mon, 29 Dec 2025 07:32:45 -0800 (PST)","by 2002:a05:620a:4108:b0:8b2:71dd:587a with SMTP id\n af79cd13be357-8c08f6550bbmr4401996785a.15.1767022365420;\n Mon, 29 Dec 2025 07:32:45 -0800 (PST)"],"X-Google-Smtp-Source":"\n AGHT+IEBSXqyX3rZxM5d5eOq3IgazLHR4zrRgy9X4elPuJD0DZ5AC99qGnRNTQaH8IsFZy/PxZ9UmA==","Date":"Mon, 29 Dec 2025 10:32:44 -0500","From":"Peter Xu ","To":"Fabiano Rosas ","Cc":"qemu-devel@nongnu.org","Subject":"Re: [RFC PATCH 02/25] migration: Fix state change at\n migration_channel_process_incoming","Message-ID":"","References":"<20251226211930.27565-1-farosas@suse.de>\n <20251226211930.27565-3-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251226211930.27565-3-farosas@suse.de>","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]