{"id":2175585,"url":"http://patchwork.ozlabs.org/api/patches/2175585/","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/tencent_B8E83CC583AFADFF59F633C39B50F419F807@qq.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2025-12-18T14:27:57","name":"[ovs-dev,v7] bridge: Enhancement of the validation for controller parameters.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4259a82e607f1a02e69c13ff840cd03644a6d3cd","submitter":{"id":70723,"url":"http://patchwork.ozlabs.org/api/people/70723/","name":"patchwork-bot+netdevbpf--- via dev","email":"ovs-dev@openvswitch.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/tencent_B8E83CC583AFADFF59F633C39B50F419F807@qq.com/mbox/","series":[{"id":485863,"url":"http://patchwork.ozlabs.org/api/series/485863/","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=485863","date":"2025-12-18T14:27:57","name":"[ovs-dev,v7] bridge: Enhancement of the validation for controller parameters.","version":7,"mbox":"http://patchwork.ozlabs.org/series/485863/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2175585/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2175585/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=qq.com header.i=@qq.com header.a=rsa-sha256\n header.s=s201512 header.b=zj031Rsv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp2.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key,\n unprotected) header.d=qq.com header.i=@qq.com header.a=rsa-sha256\n header.s=s201512 header.b=zj031Rsv","smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none) header.from=qq.com","smtp1.osuosl.org; dkim=pass (1024-bit key,\n unprotected) header.d=qq.com header.i=@qq.com header.a=rsa-sha256\n header.s=s201512 header.b=zj031Rsv"],"Received":["from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dXChB1pY0z1y2f\n\tfor ; Fri, 19 Dec 2025 01:28:26 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id 85AF040C35;\n\tThu, 18 Dec 2025 14:28:24 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 6xG82hchtEun; Thu, 18 Dec 2025 14:28:23 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 3FC0840C23;\n\tThu, 18 Dec 2025 14:28:23 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 04031C063E;\n\tThu, 18 Dec 2025 14:28:23 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists.linuxfoundation.org (Postfix) with UTF8SMTP id 1EECCC063D\n for ; Thu, 18 Dec 2025 14:28:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with UTF8SMTP id 05D1180C4B\n for ; Thu, 18 Dec 2025 14:28:21 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024)\n with UTF8SMTP id CTk53tp_n8v1 for ;\n Thu, 18 Dec 2025 14:28:20 +0000 (UTC)","from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com\n [162.62.57.64])\n by smtp1.osuosl.org (Postfix) with UTF8SMTPS id 2828080B52\n for ; Thu, 18 Dec 2025 14:28:17 +0000 (UTC)","from localhost.localdomain ([36.170.56.130])\n by newxmesmtplogicsvrszb43-0.qq.com (NewEsmtp) with SMTP\n id 70791A7F; Thu, 18 Dec 2025 22:28:07 +0800"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3FC0840C23","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2828080B52"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=162.62.57.64;\n helo=out162-62-57-64.mail.qq.com; envelope-from=543981924@qq.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 2828080B52","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;\n t=1766068089; bh=+Ea/Z5DKG15SBeWSoVx7TnEux17F5EmlWXWtl7a2iHg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=zj031RsvxyoV8aheIUpgbUfb14uK1HpwM2ckfz+1V+84XuEX5ZobAjVDqi2SeERYD\n 4lFvdUK8iL5leJKHkY8wwXcP0mBLYTtAr8+UAK2FJ7BXcK6tRK0cEW7tUKL/bUb4Ta\n vDT6udOjESHyVKfrV5FIymPvzBfAwbn4MO8hagTM=","X-QQ-mid":"xmsmtpt1766068087t90039yx5","Message-ID":"","X-QQ-XMAILINFO":"OATpkVjS499uAYCkE9dSz2HyyZYUHqmXus8hb7Xt+XT7JW6W0F4J+cgJH/oQLt\n aT7007h/b4+MXczbOIC9HQGViW11Wjay5ulhBn+6FxPfenh8Em+9/ddJjCaW9Ue2YAcl1Fn5DQGS\n y/J58kPl3/H73/qweh81ARfjDJTRzDrSql4lEVlqwyLlN3yBNeImDP5lViA4RoGBUefZTWVjqaaJ\n 5IEolI5zlPowyMxMWjPabFdQ1qDuhgxaipzCb9I5lz28AIV8T7k31z5ty3euPGNcYUIbLyDh2B60\n WWdonZK2lwYHJX04DLu/fM7cv5qPChbhhd6djUoyVhDf8vWHOXH+KwbKojTQlknLOSgaks8KP92R\n UoveoyXNiT2WH96Jg8QqncUYIx+iIWxXw1KtbwmGULLdu9/dkloRm4Ld2xHB/YcVh1Euf9E2Q3Dp\n zZUYTOtgAYPVFiysvdhNq2TDi1KlPyu3DMI00CnoQPuKe/JMA6kzgHus+hIHtHQrIzCRwBmVKd0u\n r7f1xO1/49ZjOLgoA6N/w8sw8JTn2ovkjoVzV4Ux9nowpwZaTjlhVCAlvK3D4CMJJRWNQno2qv4a\n dFVhIHewSq6xOEl+wsx42bseItgivGWbY21WQfu27aW4Jv2lLuSm5OUIi2wLvra3nAKTnR5l5951\n V7qKzaPCxj1r1ZboE4piuxB8Wrv02muVW/oLlF7JtJs5PscEvUkWl4pbGnGa6RKV/l4mxmgwW1OP\n oEYEIDd/Q8CMKruGmWJUrnpY3dSYHQaP87OWXJbD+ofb36wHGbyPVEJdewaCrCLC3xycFsd7Ypwn\n 5QywFNlLTKX3T+APeRehLkdA+OUyQy62VvhFOv3iHI4mFF3xEpjh426p5TlyEFt2uWwbQuBGAljD\n XQkWMnXmB+c8KiAk4EeNgkBc9Z3MHDQCUpjJdT19Kc2UQgB8j5PEAPQ1hJTH05i/dcGMni4cMevJ\n vc8TKg6P/J7enyfGiyAZtO2hl8b6cz92MxeNO0tzYOVea8SH3ueQ22TjYCiIrnUz7q5xWjLNXNDh\n ieP+s6eIZKC2hqKHqF","X-QQ-XMRINFO":"NI4Ajvh11aEj8Xl/2s1/T8w=","To":"dev@openvswitch.org","Cc":"yaolingfei <543981924@qq.com>","Date":"Thu, 18 Dec 2025 22:27:57 +0800","X-OQ-MSGID":"<20251218142757.2093-1-543981924@qq.com>","X-Mailer":"git-send-email 2.40.1.windows.1","In-Reply-To":"","References":"","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH v7] bridge: Enhancement of the validation for\n controller parameters.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"543981924--- via dev ","Reply-To":"543981924@qq.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"From: yaolingfei <543981924@qq.com>\n\nCheck for duplicate controller parameters. Duplicate parameters\nwill be skipped, not added to the \"ocs\" structure, and a warm\nmessage will be output to the log.\n\nIf there are duplicate controller parameters, although\n\"ofservice_create\" will not be called for duplicate creation\nin \"connmgr_set_controllers\", and there will be no memory leakage,\nthere will be xmalloc duplicate \"ofproto_controller\" structure in\n\"bridge_configure_remotes\", which incurs unnecessary memory\noverhead. And users will not perceive it.\n\n 7d674866d2c9 (ofproto: Add support for remote \"service controllers\")\n\nSigned-off-by: yaolingfei <543981924@qq.com>\n---\n vswitchd/bridge.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c\nindex 475eefefa..9962c5821 100644\n--- a/vswitchd/bridge.c\n+++ b/vswitchd/bridge.c\n@@ -4063,6 +4063,13 @@ bridge_configure_remotes(struct bridge *br,\n free(allowed);\n }\n \n+ if (shash_find(&ocs, c->target)) {\n+ static struct vlog_rate_limit rl2 = VLOG_RATE_LIMIT_INIT(1, 5);\n+ VLOG_WARN_RL(&rl2, \"bridge %s: Duplicate controllers \\\"%s\\\".\", \n+ br->name, c->target);\n+ continue;\n+ }\n+\n bridge_configure_local_iface_netdev(br, c);\n \n int dscp = smap_get_int(&c->other_config, \"dscp\", DSCP_DEFAULT);\n","prefixes":["ovs-dev","v7"]}