[{"id":3625700,"web_url":"http://patchwork.ozlabs.org/comment/3625700/","msgid":"<176579498664.1749225.5193965875803198793.robh@kernel.org>","list_archive_url":null,"date":"2025-12-15T10:36:26","subject":"Re: [PATCH v6 1/7] dt-bindings: hwmon: Add Apple System Management\n Controller hwmon schema","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Mon, 15 Dec 2025 19:37:45 +1000, James Calligeros wrote:\n> Apple Silicon devices integrate a vast array of sensors, monitoring\n> current, power, temperature, and voltage across almost every part of\n> the system. The sensors themselves are all connected to the System\n> Management Controller (SMC). The SMC firmware exposes the data\n> reported by these sensors via its standard FourCC-based key-value\n> API. The SMC is also responsible for monitoring and controlling any\n> fans connected to the system, exposing them in the same way.\n> \n> For reasons known only to Apple, each device exposes its sensors with\n> an almost totally unique set of keys. This is true even for devices\n> which share an SoC. An M1 Mac mini, for example, will report its core\n> temperatures on different keys to an M1 MacBook Pro. Worse still, the\n> SMC does not provide a way to enumerate the available keys at runtime,\n> nor do the keys follow any sort of reasonable or consistent naming\n> rules that could be used to deduce their purpose. We must therefore\n> know which keys are present on any given device, and which function\n> they serve, ahead of time.\n> \n> Add a schema so that we can describe the available sensors for a given\n> Apple Silicon device in the Devicetree.\n> \n> Reviewed-by: Neal Gompa \n> Reviewed-by: Rob Herring (Arm) \n> Signed-off-by: James Calligeros \n> ---\n> .../bindings/hwmon/apple,smc-hwmon.yaml | 86 +++++++++++++++++++++++++\n> .../bindings/mfd/apple,smc.yaml | 36 +++++++++++\n> MAINTAINERS | 1 +\n> 3 files changed, 123 insertions(+)\n> \n\nMy bot found errors running 'make dt_binding_check' on your patch:\n\nyamllint warnings/errors:\n./Documentation/devicetree/bindings/hwmon/apple,smc-hwmon.yaml:73:1: [warning] too many blank lines (2 > 1) (empty-lines)\n\ndtschema/dtc warnings/errors:\n\ndoc reference errors (make refcheckdocs):\n\nSee https://patchwork.kernel.org/project/devicetree/patch/20251215-macsmc-subdevs-v6-1-0518cb5f28ae@gmail.com\n\nThe base for the series is generally the latest rc1. A different dependency\nshould be noted in *this* patch.\n\nIf you already ran 'make dt_binding_check' and didn't see the above\nerror(s), then make sure 'yamllint' is installed and dt-schema is up to\ndate:\n\npip3 install dtschema --upgrade\n\nPlease check and re-submit after running the above command yourself. Note\nthat DT_SCHEMA_FILES can be set to your schema file to speed up checking\nyour schema. However, it must be unset to test all examples with your schema.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ULVZ/usP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-5547-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ULVZ/usP\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dVGhd3B2pz1xyL\n\tfor ; Mon, 15 Dec 2025 21:37:05 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 1C76B3012BF8\n\tfor ; Mon, 15 Dec 2025 10:36:31 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D5C503164C8;\n\tMon, 15 Dec 2025 10:36:29 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 94A232882C5;\n\tMon, 15 Dec 2025 10:36:29 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3A4F1C4CEF5;\n\tMon, 15 Dec 2025 10:36:29 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1765794989; cv=none;\n b=eJLXbhqoXmIRIN2+PSwJG2jdtm7BPSFgaxDWWBRslN74PLnV1UEcu1ifxgV6PnoyFgGFJV7V/VfW8+gHn8ry4m06sLzfZC4veh4O/sdAuN6YpFzlmrvx2Trwc9XkGQY4vfBciHaa8C6fBoL2wzV+gexNduEeY+0sZa5GbEr/qEE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1765794989; c=relaxed/simple;\n\tbh=VnZ9AI+OcSYjRRCKYpKhQNADkzDfaUzJNzcsasS8Vos=;\n\th=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References:\n\t Message-Id:Subject;\n b=heMDI9xb77UFtxkdb3R6rfd/nZlnyXI243hUtGSueVFzhcYhf7eITP/F3B1pzJW3pQ5PvJpuOc/eJfqac7N9vO8DDM4M7/fOwzR/itPqK9rxkhsdXyvddirFUcXEy95yJwRxHF2eqEvYyTMLHMC2xgyW4dpM5NRTSUsvntO3e0A=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ULVZ/usP; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1765794989;\n\tbh=VnZ9AI+OcSYjRRCKYpKhQNADkzDfaUzJNzcsasS8Vos=;\n\th=Date:From:Cc:To:In-Reply-To:References:Subject:From;\n\tb=ULVZ/usPznXq3DhQThXZBO4aMJjHoKA+pwX75G7MAXzBw0Wn1zC2vrBwOvcFA41xC\n\t ULin4X7tqnkgmW26HZnJ3w0CgFKGu1o842V2AKsmaCVLYtjRr8deodkKtvtpbLAB1l\n\t BEPLvuLrRahuZ8yZ4hhFQJOueLxi+TpJys7JJD1MzdspYT/rdSbN/T7Hm8dPlfWAUc\n\t 7uiTH4lWg2NjaobkqgPiCeIXHfXmqCW+JXsiareBFSVyW/48VNkWqhb5YB0qL1QL/H\n\t Mq5xrxiRn9uudLeKLrKnWbi4tz7L+Tpcplc9ihm39Uuu8R93Hk4JoreYdKqSS22u5/\n\t 8gzm6RHv/C0/Q==","Date":"Mon, 15 Dec 2025 04:36:26 -0600","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","From":"\"Rob Herring (Arm)\" ","Cc":"Dmitry Torokhov ,\n Jonathan Corbet , linux-hwmon@vger.kernel.org,\n Conor Dooley , Sven Peter ,\n Alyssa Rosenzweig , asahi@lists.linux.dev,\n Lee Jones , linux-input@vger.kernel.org,\n linux-kernel@vger.kernel.org, Jean Delvare ,\n linux-arm-kernel@lists.infradead.org,\n Alexandre Belloni ,\n Guenter Roeck , linux-rtc@vger.kernel.org,\n devicetree@vger.kernel.org, linux-doc@vger.kernel.org,\n Janne Grunau , Neal Gompa ,\n Krzysztof Kozlowski ","To":"James Calligeros ","In-Reply-To":"<20251215-macsmc-subdevs-v6-1-0518cb5f28ae@gmail.com>","References":"<20251215-macsmc-subdevs-v6-0-0518cb5f28ae@gmail.com>\n <20251215-macsmc-subdevs-v6-1-0518cb5f28ae@gmail.com>","Message-Id":"<176579498664.1749225.5193965875803198793.robh@kernel.org>","Subject":"Re: [PATCH v6 1/7] dt-bindings: hwmon: Add Apple System Management\n Controller hwmon schema"}}]