[{"id":3625789,"web_url":"http://patchwork.ozlabs.org/comment/3625789/","msgid":"<48619d1c-6ed1-4857-a0b3-13abdb1ac7fc@ovn.org>","list_archive_url":null,"date":"2025-12-15T14:28:32","subject":"Re: [ovs-dev] [PATCH] tests: Fix QoS tests for tc rounding behavior\n change.","submitter":{"id":76798,"url":"http://patchwork.ozlabs.org/api/people/76798/","name":"Ilya Maximets","email":"i.maximets@ovn.org"},"content":"On 12/15/25 10:34 AM, Frode Nordahl wrote:\n> The tc command from iproute2 changed its rounding behavior in commit\n> d947f365602b (\"tc: Fix rounding in tc_calc_xmittime and tc_calc_xmitsize.\").\n> This caused QoS tests to be fragile because they were matching exact burst\n> and cburst values in tc output.\n> \n> The rounding fix means that burst and cburst values may differ slightly\n> from previous versions. For example, values that were previously 620000\n> might now be 618750 or similar variations.\n> \n> To maintain compatibility with both old and new versions of tc, the test\n> assertions now use pattern matching that:\n> - Matches the most significant digit(s) of the value\n> - Ensures all characters are numeric\n> - Maintains the correct total number of digits\n> - Preserves the unit suffix (e.g., 'b' for bytes)\n> \n> For example, '375000b' now matches '3[0-9][0-9][0-9][0-9][0-9]b' which\n> accepts any 6-digit value starting with 3, allowing for rounding\n> differences while still validating the general magnitude is correct.\n> \n> This follows the same approach as the related OVN patch:\n> https://patchwork.ozlabs.org/project/ovn/patch/20251213233200.5574-1-fnordahl@ubuntu.com/\n\nThanks, Frode! I'm marking this as changes-requested for now, as the same\nreview comments from the OVN patch should apply here.\n\nBest regards, Ilya Maximets.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n dmarc=none (p=none dis=none) header.from=ovn.org"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dVMqt6yH5z1xxv\n\tfor ; Tue, 16 Dec 2025 01:28:42 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 6CC1181589;\n\tMon, 15 Dec 2025 14:28:41 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id x2Vsy0_HWTnz; Mon, 15 Dec 2025 14:28:38 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id C8EB081549;\n\tMon, 15 Dec 2025 14:28:38 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id B3A22C063E;\n\tMon, 15 Dec 2025 14:28:38 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 00E71C063D\n for ; Mon, 15 Dec 2025 14:28:37 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id E5169814C0\n for ; Mon, 15 Dec 2025 14:28:36 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id v4iRxnVKLW2j for ;\n Mon, 15 Dec 2025 14:28:36 +0000 (UTC)","from mail-wr1-f68.google.com (mail-wr1-f68.google.com\n [209.85.221.68])\n by smtp1.osuosl.org (Postfix) with ESMTPS id B747D814C7\n for ; Mon, 15 Dec 2025 14:28:35 +0000 (UTC)","by mail-wr1-f68.google.com with SMTP id\n ffacd0b85a97d-42fed090e5fso1057205f8f.1\n for ; Mon, 15 Dec 2025 06:28:35 -0800 (PST)","from [192.168.88.248] (78-80-26-45.customers.tmcz.cz. [78.80.26.45])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-430fc36c83fsm8239112f8f.19.2025.12.15.06.28.33\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 15 Dec 2025 06:28:33 -0800 (PST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org C8EB081549","OpenDKIM Filter v2.11.0 smtp1.osuosl.org B747D814C7"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=209.85.221.68;\n helo=mail-wr1-f68.google.com; envelope-from=i.maximets.ovn@gmail.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org B747D814C7","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765808914; x=1766413714;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:to:subject:cc:user-agent:mime-version\n :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=r1y53rCzd8tXYcGoGxQMixaHLzU4qiwL3814ZRJ/vwQ=;\n b=BxvvRaFlR603M/m2SaNjYCQGJVNHNgT0eNzvbldBmj5ln86z3sGnC+en31rJcYOxLu\n WKcGiM+HopdnJzE5w9198DwaN+bBV2oFspbW8umc6Hs1qgnekeT/a9pxF+izoNNQ3dUn\n Jc0YRqgdVDK9ZoFsZ7tzhCrFxvLLKQRDnEi8aZ3S+nIWB07XgrTic4vJBKTa37jEhg7O\n YOaxxXkuY1+AIoJI9btCVzoZ10HmAbCcEI/7d90ATrPsSCI7XjHHfQbqFxwWWPW1wOas\n YdEwwLVNE+4wCDrrNgL8YHIXWvfXY5LKIJ0m4U80M2o71ujfA9tZgrwXByBT2ncxo7CD\n F9kA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWzBuszT78pTWkQnHlRpAMo295rVTSyQEiZlvKbfopa8AwXGc5ZhfCEXqD8MIxQF/ugo6g=@openvswitch.org","X-Gm-Message-State":"AOJu0Yzafn1U6XZs/FMdw1sFbGq0xPqkrrJPOlZE6K4rL6w08NAWWXEA\n ubyfkyvgxRd8vkYtM+l4yJPkNU4vA+vLYVHG0yXUJpEJyTOc0UQAp0zCD+p1AzuI","X-Gm-Gg":"AY/fxX5V6j8sUeoRyjSPeC3Vy4jImHjN+73YuNQvV7CkVQsue1HgaIbPZv1XsvMKzVE\n rag2Z8PcyXbtmb6Y94fHNqt8RuTEPmY9CsseRY6UHl/fY1Y5WEG+oFyuKFl+NiDjArlJoSa8U2z\n yz/rYKSmSTRlK7Z75ewSRtu+MxR5/0PrBEQQAxrZCUJu6zRCkjmSyuFA8Q806hI6ECLIEERRBsx\n oqabgpUpuX3qg7ISGm7sNe41c8cMNV9l3vt5TyP4z1N9grxOLJokhFvfChFXS1e1PWJAB85a8ea\n 76bEAP7h0Y8l7kBBdOJqbpoTGg9O1qZyvC+f+7Epn5GuKE14LEJEBb06tt5lB/dplQv+gTowIdK\n cQnfCEDOdKKrU8le+n2avud2VetvKGOEvfhtmJ/uwuO83V36GjefEOSNpUV8uPlvsuNBzvD/Ryy\n H5SDHqFaDRPZugRMlvToSB+vDrT3tlfEYn2QsW43AfiuQ=","X-Google-Smtp-Source":"\n AGHT+IHJ81OQtbARBWVby9Y5eR2Hv7Jj6tJWUro2hdzAjPzuqwbAv+/I2I8gWHQBpEYo6uXYW7Yy8A==","X-Received":"by 2002:a5d:64e7:0:b0:430:fdc8:8be3 with SMTP id\n ffacd0b85a97d-430fdc88fbamr3686023f8f.29.1765808913635;\n Mon, 15 Dec 2025 06:28:33 -0800 (PST)","Message-ID":"<48619d1c-6ed1-4857-a0b3-13abdb1ac7fc@ovn.org>","Date":"Mon, 15 Dec 2025 15:28:32 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Cc":"i.maximets@ovn.org","To":"Frode Nordahl , dev@openvswitch.org","References":"<20251215093450.4049-1-fnordahl@ubuntu.com>","Content-Language":"en-US","From":"Ilya Maximets ","Autocrypt":"addr=i.maximets@ovn.org; keydata=\n xsFNBF77bOMBEADVZQ4iajIECGfH3hpQMQjhIQlyKX4hIB3OccKl5XvB/JqVPJWuZQRuqNQG\n /B70MP6km95KnWLZ4H1/5YOJK2l7VN7nO+tyF+I+srcKq8Ai6S3vyiP9zPCrZkYvhqChNOCF\n pNqdWBEmTvLZeVPmfdrjmzCLXVLi5De9HpIZQFg/Ztgj1AZENNQjYjtDdObMHuJQNJ6ubPIW\n cvOOn4WBr8NsP4a2OuHSTdVyAJwcDhu+WrS/Bj3KlQXIdPv3Zm5x9u/56NmCn1tSkLrEgi0i\n /nJNeH5QhPdYGtNzPixKgPmCKz54/LDxU61AmBvyRve+U80ukS+5vWk8zvnCGvL0ms7kx5sA\n tETpbKEV3d7CB3sQEym8B8gl0Ux9KzGp5lbhxxO995KWzZWWokVUcevGBKsAx4a/C0wTVOpP\n FbQsq6xEpTKBZwlCpxyJi3/PbZQJ95T8Uw6tlJkPmNx8CasiqNy2872gD1nN/WOP8m+cIQNu\n o6NOiz6VzNcowhEihE8Nkw9V+zfCxC8SzSBuYCiVX6FpgKzY/Tx+v2uO4f/8FoZj2trzXdLk\n BaIiyqnE0mtmTQE8jRa29qdh+s5DNArYAchJdeKuLQYnxy+9U1SMMzJoNUX5uRy6/3KrMoC/\n 7zhn44x77gSoe7XVM6mr/mK+ViVB7v9JfqlZuiHDkJnS3yxKPwARAQABzSJJbHlhIE1heGlt\n ZXRzIDxpLm1heGltZXRzQG92bi5vcmc+wsGUBBMBCAA+AhsDBQsJCAcCBhUKCQgLAgQWAgMB\n Ah4BAheAFiEEh+ma1RKWrHCY821auffsd8gpv5YFAmfB9JAFCQyI7q0ACgkQuffsd8gpv5YQ\n og/8DXt1UOznvjdXRHVydbU6Ws+1iUrxlwnFH4WckoFgH4jAabt25yTa1Z4YX8Vz0mbRhTPX\n M/j1uORyObLem3of4YCd4ymh7nSu++KdKnNsZVHxMcoiic9ILPIaWYa8kTvyIDT2AEVfn9M+\n vskM0yDbKa6TAHgr/0jCxbS+mvN0ZzDuR/LHTgy3e58097SWJohj0h3Dpu+XfuNiZCLCZ1/G\n AbBCPMw+r7baH/0evkX33RCBZwvh6tKu+rCatVGk72qRYNLCwF0YcGuNBsJiN9Aa/7ipkrA7\n Xp7YvY3Y1OrKnQfdjp3mSXmknqPtwqnWzXvdfkWkZKShu0xSk+AjdFWCV3NOzQaH3CJ67NXm\n aPjJCIykoTOoQ7eEP6+m3WcgpRVkn9bGK9ng03MLSymTPmdINhC5pjOqBP7hLqYi89GN0MIT\n Ly2zD4m/8T8wPV9yo7GRk4kkwD0yN05PV2IzJECdOXSSStsf5JWObTwzhKyXJxQE+Kb67Wwa\n LYJgltFjpByF5GEO4Xe7iYTjwEoSSOfaR0kokUVM9pxIkZlzG1mwiytPadBt+VcmPQWcO5pi\n WxUI7biRYt4aLriuKeRpk94ai9+52KAk7Lz3KUWoyRwdZINqkI/aDZL6meWmcrOJWCUMW73e\n 4cMqK5XFnGqolhK4RQu+8IHkSXtmWui7LUeEvO/OwU0EXvts4wEQANCXyDOic0j2QKeyj/ga\n OD1oKl44JQfOgcyLVDZGYyEnyl6b/tV1mNb57y/YQYr33fwMS1hMj9eqY6tlMTNz+ciGZZWV\n YkPNHA+aFuPTzCLrapLiz829M5LctB2448bsgxFq0TPrr5KYx6AkuWzOVq/X5wYEM6djbWLc\n VWgJ3o0QBOI4/uB89xTf7mgcIcbwEf6yb/86Cs+jaHcUtJcLsVuzW5RVMVf9F+Sf/b98Lzrr\n 2/mIB7clOXZJSgtV79Alxym4H0cEZabwiXnigjjsLsp4ojhGgakgCwftLkhAnQT3oBLH/6ix\n 87ahawG3qlyIB8ZZKHsvTxbWte6c6xE5dmmLIDN44SajAdmjt1i7SbAwFIFjuFJGpsnfdQv1\n OiIVzJ44kdRJG8kQWPPua/k+AtwJt/gjCxv5p8sKVXTNtIP/sd3EMs2xwbF8McebLE9JCDQ1\n RXVHceAmPWVCq3WrFuX9dSlgf3RWTqNiWZC0a8Hn6fNDp26TzLbdo9mnxbU4I/3BbcAJZI9p\n 9ELaE9rw3LU8esKqRIfaZqPtrdm1C+e5gZa2gkmEzG+WEsS0MKtJyOFnuglGl1ZBxR1uFvbU\n VXhewCNoviXxkkPk/DanIgYB1nUtkPC+BHkJJYCyf9Kfl33s/bai34aaxkGXqpKv+CInARg3\n fCikcHzYYWKaXS6HABEBAAHCwXwEGAEIACYCGwwWIQSH6ZrVEpascJjzbVq59+x3yCm/lgUC\n Z8H0qQUJDIjuxgAKCRC59+x3yCm/loAdD/wJCOhPp9711J18B9c4f+eNAk5vrC9Cj3RyOusH\n Hebb9HtSFm155Zz3xiizw70MSyOVikjbTocFAJo5VhkyuN0QJIP678SWzriwym+EG0B5P97h\n FSLBlRsTi4KD8f1Ll3OT03lD3o/5Qt37zFgD4mCD6OxAShPxhI3gkVHBuA0GxF01MadJEjMu\n jWgZoj75rCLG9sC6L4r28GEGqUFlTKjseYehLw0s3iR53LxS7HfJVHcFBX3rUcKFJBhuO6Ha\n /GggRvTbn3PXxR5UIgiBMjUlqxzYH4fe7pYR7z1m4nQcaFWW+JhY/BYHJyMGLfnqTn1FsIwP\n dbhEjYbFnJE9Vzvf+RJcRQVyLDn/TfWbETf0bLGHeF2GUPvNXYEu7oKddvnUvJK5U/BuwQXy\n TRFbae4Ie96QMcPBL9ZLX8M2K4XUydZBeHw+9lP1J6NJrQiX7MzexpkKNy4ukDzPrRE/ruui\n yWOKeCw9bCZX4a/uFw77TZMEq3upjeq21oi6NMTwvvWWMYuEKNi0340yZRrBdcDhbXkl9x/o\n skB2IbnvSB8iikbPng1ihCTXpA2yxioUQ96Akb+WEGopPWzlxTTK+T03G2ljOtspjZXKuywV\n Wu/eHyqHMyTu8UVcMRR44ki8wam0LMs+fH4dRxw5ck69AkV+JsYQVfI7tdOu7+r465LUfg==","In-Reply-To":"<20251215093450.4049-1-fnordahl@ubuntu.com>","Subject":"Re: [ovs-dev] [PATCH] tests: Fix QoS tests for tc rounding behavior\n change.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]