[{"id":3626437,"web_url":"http://patchwork.ozlabs.org/comment/3626437/","msgid":"","list_archive_url":null,"date":"2025-12-17T03:42:25","subject":"Re: [PATCH 05/11] rust: only link the Rust part of the code into\n devices","submitter":{"id":86545,"url":"http://patchwork.ozlabs.org/api/people/86545/","name":"Zhao Liu","email":"zhao1.liu@intel.com"},"content":"On Mon, Dec 15, 2025 at 08:49:54AM +0100, Paolo Bonzini wrote:\n> Date: Mon, 15 Dec 2025 08:49:54 +0100\n> From: Paolo Bonzini \n> Subject: [PATCH 05/11] rust: only link the Rust part of the code into\n> devices\n> X-Mailer: git-send-email 2.52.0\n> \n> Do not include libqemuutil in the device crates for the same\n> reason as in the previous commit. Static libraries like qemuutil\n> are sensitive to their position on the command line and rustc does not\n> always get it right.\n> \n> If rustc places the library too early on the command line, the stubs\n> are included in the final link product, which results in duplicate\n> symbols.\n> \n> Signed-off-by: Paolo Bonzini \n> ---\n> rust/hw/char/pl011/meson.build | 18 ++++++++++--------\n> rust/hw/timer/hpet/meson.build | 18 +++++++++---------\n> 2 files changed, 19 insertions(+), 17 deletions(-)\n\nReviewed-by: Zhao Liu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=NUD3vkb5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dWJsB4H5pz1y0P\n\tfor ; Wed, 17 Dec 2025 14:18:06 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vVi2w-0006fs-VC; Tue, 16 Dec 2025 22:17:50 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vVi2o-0006bR-GO; Tue, 16 Dec 2025 22:17:42 -0500","from mgamail.intel.com ([192.198.163.17])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vVi2m-0006Eo-5D; Tue, 16 Dec 2025 22:17:42 -0500","from orviesa002.jf.intel.com ([10.64.159.142])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Dec 2025 19:17:38 -0800","from liuzhao-optiplex-7080.sh.intel.com (HELO localhost)\n ([10.239.160.39])\n by orviesa002.jf.intel.com with ESMTP; 16 Dec 2025 19:17:37 -0800"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1765941460; x=1797477460;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=zBJgc/hbE6t3nLugzcJb+1vjT990b/mKDeAY5TEz314=;\n b=NUD3vkb5vriCLc0PfCiGTd5oRpJtBTs62Vbi5jmHFw9tSctdtlcNE/gE\n bEP4S4IT+cB4KwGu7NHCBGcafzpCSNs9XOtVWHYJmmyVtYM3rOhY+vwFt\n ncB3tn2HHYXYrP/ruMs9Zrp5KsNV3WkAlcvO37u+JKMGUhvKZ6fLT2S4X\n mcuDbUgHF6C7w9kkv/doc2boOwHzhRxPzWZUlSGyc+zAKFiNrC0STpN9A\n plzx+iQWQlcpOdbsVw0Ne4t2zjKxneyBpxgU/pyVn5KkQ7vN8e6j6dDm4\n 38EwIbqoQRvg9IO9JVSk0xgpRShh2OamDU0WTxjPTd2JIm7WzS0cpFf8M A==;","X-CSE-ConnectionGUID":["oHd8HqKiSWeMTdCCxyiMIg==","GWbUW4UpRmajI6fMMM86RQ=="],"X-CSE-MsgGUID":["2kllHh2tS9+QHXZG6w/RoA==","szWdfd8WTM2h9FH9P17U/w=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11644\"; a=\"67757184\"","E=Sophos;i=\"6.21,154,1763452800\"; d=\"scan'208\";a=\"67757184\"","E=Sophos;i=\"6.21,154,1763452800\"; d=\"scan'208\";a=\"228882837\""],"X-ExtLoop1":"1","Date":"Wed, 17 Dec 2025 11:42:25 +0800","From":"Zhao Liu ","To":"Paolo Bonzini ","Cc":"qemu-devel@nongnu.org, qemu-rust@nongnu.org,\n\tmarcandre.lureau@redhat.com","Subject":"Re: [PATCH 05/11] rust: only link the Rust part of the code into\n devices","Message-ID":"","References":"<20251215075000.335043-1-pbonzini@redhat.com>\n <20251215075000.335043-6-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20251215075000.335043-6-pbonzini@redhat.com>","Received-SPF":"pass client-ip=192.198.163.17;\n envelope-from=zhao1.liu@intel.com;\n helo=mgamail.intel.com","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]