{"id":2174030,"url":"http://patchwork.ozlabs.org/api/patches/2174030/","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/tencent_4FFF9BB21F18F285D2CD2044E728CA7CFD0A@qq.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2025-12-14T09:49:50","name":"[ovs-dev,v6] bridge: Check controller parameters.","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"3167a96b798e0f2072832fab8cf16e0a964292db","submitter":{"id":70723,"url":"http://patchwork.ozlabs.org/api/people/70723/","name":"patchwork-bot+netdevbpf--- via dev","email":"ovs-dev@openvswitch.org"},"delegate":{"id":57772,"url":"http://patchwork.ozlabs.org/api/users/57772/","username":"imaximets","first_name":"Ilya","last_name":"Maximets","email":"i.maximets@samsung.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/tencent_4FFF9BB21F18F285D2CD2044E728CA7CFD0A@qq.com/mbox/","series":[{"id":485314,"url":"http://patchwork.ozlabs.org/api/series/485314/","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=485314","date":"2025-12-14T09:49:50","name":"[ovs-dev,v6] bridge: Check controller parameters.","version":6,"mbox":"http://patchwork.ozlabs.org/series/485314/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2174030/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2174030/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=qq.com header.i=@qq.com header.a=rsa-sha256\n header.s=s201512 header.b=fLHB5EHy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=qq.com header.i=@qq.com header.a=rsa-sha256 header.s=s201512\n header.b=fLHB5EHy","smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none) header.from=qq.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.a=rsa-sha256\n header.s=s201512 header.b=fLHB5EHy"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dTdj41nv4z1y0r\n\tfor ; Sun, 14 Dec 2025 20:50:14 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 4644860C27;\n\tSun, 14 Dec 2025 09:50:12 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id lqKDseO-AtmU; Sun, 14 Dec 2025 09:50:10 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 3CF2260ACE;\n\tSun, 14 Dec 2025 09:50:10 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 21939C063E;\n\tSun, 14 Dec 2025 09:50:10 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists.linuxfoundation.org (Postfix) with UTF8SMTP id E4679C063D\n for ; Sun, 14 Dec 2025 09:50:08 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with UTF8SMTP id CAE664021A\n for ; Sun, 14 Dec 2025 09:50:08 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024)\n with UTF8SMTP id 37plu-XAMavr for ;\n Sun, 14 Dec 2025 09:50:08 +0000 (UTC)","from out203-205-221-239.mail.qq.com (out203-205-221-239.mail.qq.com\n [203.205.221.239])\n by smtp2.osuosl.org (Postfix) with UTF8SMTPS id 64C454002C\n for ; Sun, 14 Dec 2025 09:50:06 +0000 (UTC)","from localhost.localdomain ([183.223.222.209])\n by newxmesmtplogicsvrszc43-0.qq.com (NewEsmtp) with SMTP\n id C8028832; Sun, 14 Dec 2025 17:50:00 +0800"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3CF2260ACE","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 64C454002C"],"X-Greylist":"delayed 1081 seconds by postgrey-1.37 at util1.osuosl.org;\n Sun, 14 Dec 2025 09:50:06 UTC","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 64C454002C","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=203.205.221.239;\n helo=out203-205-221-239.mail.qq.com; envelope-from=543981924@qq.com;\n receiver=","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;\n t=1765705803; bh=UABJWenTi6H/2gqTLJpaPtZY2wsh3J9YAKT5nxoM/+A=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=fLHB5EHyCso3hYPaSaqdaOt5wXX2vNMg9KL56jkZM/MSQcJ8r0Ka4av7y0ah1GrqK\n 8oyafl3gs+EPQiV7weiD6aqWk4B0bTW3u6Jwi9OIfTUgQ+0P/cXx17CdHN4CG346sn\n wKDsAwrIiBmHxn4N3pqW1dY263jm8fkKWZZZkiMY=","X-QQ-mid":"xmsmtpt1765705800tkzl00m5u","Message-ID":"","X-QQ-XMAILINFO":"OATpkVjS499uHYgXCzYYdYNUKwO5+3npqgm4Mz3TxkWcysED3uK7lkhEjfD96K\n 5qiFNRze9n95Bi1JQno+rvrphgmmoEttZyqLAgXwI2ZJVQ1ABqVCzfp/p9F5pO6FE59UGB48iXkG\n jxzKJ1pBfj6B92pd7VIdjlXuiXXLVmQd1FaRAjDKZZxAihGgaiqp1oUQjzxqMHm2mZ0TPq8ML8IR\n WaRB4ROZWJkIyXU+N/ADAs23e+psJ614JinoyvbW7gcBKFulKUNgrW748/S2Oy4DnDNK1h1MpBSx\n ktW35jPp1xj0VtXwlEY86xwUGg6pBt1zoNS0ZpytH9lvipI3we+XStnlnPdxA7CvTyT3ALlVv1Jr\n VwEeynPyXrIxsC6QgYfEayDhFAxlGxa5Lu96w1tHlKS18gFaGNK5K6ZI8ldnLX80+UeL5weWOneW\n JpHseTUmX6ZkvOTwNmvccKVB7gvIcroj3K2NeXSQTAsec8B+GX0SaSY2+nOEeEDuXU0Xv1yr6h20\n POwgj96q+Nwr/bgEqnWkzqJl1+SSAtbFc57xyEoeyWFMKItXCV1qP14mOikvs97/YfNqtKJHhn3U\n nGwVCNrmRb39Pq6PC4XifG9I1G2H8xAgYMwPTkbJK+yQEzCJT2bK+Zlnl/dmwpJd9fQG49baqy6K\n 0mZF1KTsbqxKo4JvmHSp8UqEKlkCjyVSx6UILfSplujWPk41Gw7/5VA1hYNw/qDNlg8CthfhNGRO\n DVBMh+3pK5gLD2xMnL6xgqLSHAD3FJ01GRiKQ48W+V7vGmY8BA5Q3sJlIoOCha63r/nTHVnPRUab\n 0ZkbRi28bFwxd0sKrvxOUsAWBcMaNHNi6npWRfQZQAJcVbthCk9mQK3FTI5FGw0u00Rw6VyzAnGp\n gw5wXpQh2bzoaz0f6R+5yHD2GdhVs4J16dPn/UpBwyaNySb2LoRLqRsKHF9uUCXE/WkD2d4h+o7t\n j0QzluBpjjqOB/v+D7Fc7L/xwNcrlRi/BZwjArakTC+ilPTsT0l9xCumoHyj62QGPJ1OU4ZK7z0B\n 0AAU3zSJ+9NjrsZqFkVTzTYCcfItJrdQVaWy3rEHkflsHyrNL8nX996YsCD7wQpDc+gyfzVw==","X-QQ-XMRINFO":"MPJ6Tf5t3I/ycC2BItcBVIA=","To":"dev@openvswitch.org","Cc":"i.maximets@ovn.org,\n\tyaolingfei <543981924@qq.com>","Date":"Sun, 14 Dec 2025 17:49:50 +0800","X-OQ-MSGID":"<20251214094950.2092-1-543981924@qq.com>","X-Mailer":"git-send-email 2.40.1.windows.1","In-Reply-To":"","References":"","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH v6] bridge: Check controller parameters.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"543981924--- via dev ","Reply-To":"543981924@qq.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"From: yaolingfei <543981924@qq.com>\n\nSigned-off-by: yaolingfei <543981924@qq.com>\n---\n vswitchd/bridge.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c\nindex 475eefefa..dd7b78089 100644\n--- a/vswitchd/bridge.c\n+++ b/vswitchd/bridge.c\n@@ -4015,10 +4015,10 @@ bridge_configure_remotes(struct bridge *br,\n \n for (size_t i = 0; i < n_controllers; i++) {\n struct ovsrec_controller *c = controllers[i];\n+ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(2, 5);\n if (daemon_should_self_confine()\n && (!strncmp(c->target, \"punix:\", 6)\n || !strncmp(c->target, \"unix:\", 5))) {\n- static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);\n char *allowed;\n \n if (!strncmp(c->target, \"unix:\", 5)) {\n@@ -4063,6 +4063,11 @@ bridge_configure_remotes(struct bridge *br,\n free(allowed);\n }\n \n+ if (shash_find(&ocs, c->target)) {\n+ VLOG_WARN_RL(&rl, \"bridge %s: Duplicate controllers \\\"%s\\\"\", br->name, c->target);\n+ continue;\n+ }\n+\n bridge_configure_local_iface_netdev(br, c);\n \n int dscp = smap_get_int(&c->other_config, \"dscp\", DSCP_DEFAULT);\n","prefixes":["ovs-dev","v6"]}