[{"id":3613881,"web_url":"http://patchwork.ozlabs.org/comment/3613881/","msgid":"<20251111-heroism-greasily-fb01345ae609@spud>","list_archive_url":null,"date":"2025-11-11T18:03:43","subject":"Re: [PATCH v7 8/9] arm64: dts: mediatek: update rtc properties for\n MT6359","submitter":{"id":84372,"url":"http://patchwork.ozlabs.org/api/people/84372/","name":"Conor Dooley","email":"conor@kernel.org"},"content":"On Tue, Nov 11, 2025 at 02:59:22PM +0800, Jack Hsu wrote:\n> Update properties of rtc for mt6359 PMIC\n> \n> Signed-off-by: Jack Hsu \n> \n> ---\n> Changs in v7:\n> - remove mt635x-auadc.h\n> - remove fg nodes\n> \n> ---\n> arch/arm64/boot/dts/mediatek/mt6359.dtsi | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi\n> index 467d8a4c2aa7..fe737254c091 100644\n> --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi\n> +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi\n> @@ -302,6 +302,9 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {\n> \n> \t\tmt6359rtc: rtc {\n> \t\t\tcompatible = \"mediatek,mt6358-rtc\";\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <1>;\n> +\t\t\tstatus = \"disabled\";\n\nOkay, this looks a lot better now. Still missing an explanation of why\nit has been moved to disabled though, especially since you just go and\nre-enable it (without adding child devices that use the address/size\ncells).\npw-bot: changes-requested\n\n> \t\t};\n> \t};\n> };\n> -- \n> 2.45.2\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=UoxZ2qIT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=213.196.21.55; helo=ams.mirrors.kernel.org;\n envelope-from=linux-pwm+bounces-7619-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"UoxZ2qIT\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from ams.mirrors.kernel.org (ams.mirrors.kernel.org [213.196.21.55])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4d5ZCz19xVz1yJP\n\tfor ; Wed, 12 Nov 2025 05:03:59 +1100 (AEDT)","from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ams.mirrors.kernel.org (Postfix) with ESMTPS id 02B233418DE\n\tfor ; Tue, 11 Nov 2025 18:03:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F1C4728468D;\n\tTue, 11 Nov 2025 18:03:52 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B7FBD2798F8;\n\tTue, 11 Nov 2025 18:03:52 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 21B8BC4CEF5;\n\tTue, 11 Nov 2025 18:03:45 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1762884232; cv=none;\n b=X2h1omWYUQsJt8X+MInld4L6Co7W7xU5uLq8LDpKMZ1ZEz0OsvHO7d/OXv7gRbhtjibccO9QdXskIG2PdwU0db8A12Nm4aM5LgghNfSwCIWgYQQtkTKpCTVLa5cj1BPlkmX1jeqv5woWu7npms1ET42suYvxh43VziTEsFK30OQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1762884232; c=relaxed/simple;\n\tbh=mirE0FVC1aFCsQq2eMehFBIBONouR+WUmeEdSPLLXaU=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=F4pbBvf6LnY9krM64BcUDBtxo/7m7TkG1kiVB0J4q8Nb5UTXwC5Kqd0t8fipX4KH8rARN6Xk3qno/CABi4mnsrT3i4cLgzfyc3OAbj6ZDvsGbiuwPbagfMyCbEX9b/NCdXTKFkdhhChuLtrZzcVC/1D3nlFYulHwLaeq7ZTL2cg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=UoxZ2qIT; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1762884232;\n\tbh=mirE0FVC1aFCsQq2eMehFBIBONouR+WUmeEdSPLLXaU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UoxZ2qITmDCIv3Aw71Gtor6BXmxZ1wnoHiUP/IBntzbdAFxQ9XxovK8QSj2aDPfZf\n\t 8IqPCAlCuq0F29Cbyszl60cwbOySqlX8Rj5fwBoLkDonymsRi7FtTTer6S+8EI4kqM\n\t /ut0BcYpYH4KdK4sZNYt0ARyTafsLbJsT2J1vKYwJE48dIlDpf49nt492SCsRajbeb\n\t N7w7bHAXlZp2gWqVuLabvi9TMqJAmHGuMrDDhb1WkFwSw2R9+XPQRX4y7EiAn/1Y0P\n\t pkrI36WZ83pDlW7P7nW0wY6+KaIUsVMglj8ztkQuZyvx7fRB8f45cARtGA3HLG7lmq\n\t XpVhTSucBjALg==","Date":"Tue, 11 Nov 2025 18:03:43 +0000","From":"Conor Dooley ","To":"Jack Hsu ","Cc":"robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,\n\tjic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,\n\tandy@kernel.org, matthias.bgg@gmail.com,\n\tangelogioacchino.delregno@collabora.com, srini@kernel.org,\n\tukleinek@kernel.org, gregkh@linuxfoundation.org,\n\tjirislaby@kernel.org, daniel.lezcano@linaro.org, tglx@linutronix.de,\n\tchunfeng.yun@mediatek.com, wim@linux-watchdog.org,\n\tlinux@roeck-us.net, sean.wang@mediatek.com,\n\tzhiyong.tao@mediatek.com, andrew-ct.chen@mediatek.com,\n\tlala.lin@mediatek.com, jitao.shi@mediatek.com,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-pwm@vger.kernel.org,\n\tlinux-serial@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-watchdog@vger.kernel.org,\n\tProject_Global_Chrome_Upstream_Group@mediatek.com","Subject":"Re: [PATCH v7 8/9] arm64: dts: mediatek: update rtc properties for\n MT6359","Message-ID":"<20251111-heroism-greasily-fb01345ae609@spud>","References":"<20251111070031.305281-1-jh.hsu@mediatek.com>\n <20251111070031.305281-9-jh.hsu@mediatek.com>","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"wFCZWHo1MJf80ONG\"","Content-Disposition":"inline","In-Reply-To":"<20251111070031.305281-9-jh.hsu@mediatek.com>"}}]