[{"id":3585228,"web_url":"http://patchwork.ozlabs.org/comment/3585228/","msgid":"<20250922160040.GA92842-robh@kernel.org>","list_archive_url":null,"date":"2025-09-22T16:00:40","subject":"Re: [PATCH v3 03/11] dt-bindings: memory: Document Tegra114 Memory\n Controller","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Sep 15, 2025 at 11:01:49AM +0300, Svyatoslav Ryhel wrote:\n> Add Tegra114 support into existing Tegra124 MC schema with the most\n> notable difference in the amount of EMEM timings.\n> \n> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>\n> ---\n>  .../nvidia,tegra124-mc.yaml                   | 97 ++++++++++++++-----\n>  1 file changed, 74 insertions(+), 23 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> index 7b18b4d11e0a..9cc9360d3bd0 100644\n> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> @@ -19,7 +19,9 @@ description: |\n>  \n>  properties:\n>    compatible:\n> -    const: nvidia,tegra124-mc\n> +    enum:\n> +      - nvidia,tegra114-mc\n> +      - nvidia,tegra124-mc\n>  \n>    reg:\n>      maxItems: 1\n> @@ -64,29 +66,10 @@ patternProperties:\n>  \n>            nvidia,emem-configuration:\n>              $ref: /schemas/types.yaml#/definitions/uint32-array\n> -            description: |\n> +            description:\n>                Values to be written to the EMEM register block. See section\n> -              \"15.6.1 MC Registers\" in the TRM.\n> -            items:\n> -              - description: MC_EMEM_ARB_CFG\n> -              - description: MC_EMEM_ARB_OUTSTANDING_REQ\n> -              - description: MC_EMEM_ARB_TIMING_RCD\n> -              - description: MC_EMEM_ARB_TIMING_RP\n> -              - description: MC_EMEM_ARB_TIMING_RC\n> -              - description: MC_EMEM_ARB_TIMING_RAS\n> -              - description: MC_EMEM_ARB_TIMING_FAW\n> -              - description: MC_EMEM_ARB_TIMING_RRD\n> -              - description: MC_EMEM_ARB_TIMING_RAP2PRE\n> -              - description: MC_EMEM_ARB_TIMING_WAP2PRE\n> -              - description: MC_EMEM_ARB_TIMING_R2R\n> -              - description: MC_EMEM_ARB_TIMING_W2W\n> -              - description: MC_EMEM_ARB_TIMING_R2W\n> -              - description: MC_EMEM_ARB_TIMING_W2R\n> -              - description: MC_EMEM_ARB_DA_TURNS\n> -              - description: MC_EMEM_ARB_DA_COVERS\n> -              - description: MC_EMEM_ARB_MISC0\n> -              - description: MC_EMEM_ARB_MISC1\n> -              - description: MC_EMEM_ARB_RING1_THROTTLE\n> +              \"20.11.1 MC Registers\" in the Tegea114 TRM or\n> +              \"15.6.1 MC Registers\" in the Tegra124 TRM.\n>  \n>          required:\n>            - clock-frequency\n> @@ -109,6 +92,74 @@ required:\n>    - \"#iommu-cells\"\n>    - \"#interconnect-cells\"\n>  \n> +allOf:\n> +  - if:\n> +      properties:\n> +        compatible:\n> +          contains:\n> +            enum:\n> +              - nvidia,tegra114-mc\n> +    then:\n> +      patternProperties:\n> +        \"^emc-timings-[0-9]+$\":\n> +          patternProperties:\n> +            \"^timing-[0-9]+$\":\n> +              properties:\n> +                nvidia,emem-configuration:\n> +                  items:\n> +                    - description: MC_EMEM_ARB_CFG\n> +                    - description: MC_EMEM_ARB_OUTSTANDING_REQ\n> +                    - description: MC_EMEM_ARB_TIMING_RCD\n> +                    - description: MC_EMEM_ARB_TIMING_RP\n> +                    - description: MC_EMEM_ARB_TIMING_RC\n> +                    - description: MC_EMEM_ARB_TIMING_RAS\n> +                    - description: MC_EMEM_ARB_TIMING_FAW\n> +                    - description: MC_EMEM_ARB_TIMING_RRD\n> +                    - description: MC_EMEM_ARB_TIMING_RAP2PRE\n> +                    - description: MC_EMEM_ARB_TIMING_WAP2PRE\n> +                    - description: MC_EMEM_ARB_TIMING_R2R\n> +                    - description: MC_EMEM_ARB_TIMING_W2W\n> +                    - description: MC_EMEM_ARB_TIMING_R2W\n> +                    - description: MC_EMEM_ARB_TIMING_W2R\n> +                    - description: MC_EMEM_ARB_DA_TURNS\n> +                    - description: MC_EMEM_ARB_DA_COVERS\n> +                    - description: MC_EMEM_ARB_MISC0\n> +                    - description: MC_EMEM_ARB_RING1_THROTTLE\n\nLike I said before, I don't think it is worth enumerating the list of \nregisters for every variant. If you want to define the length \n(minItems/maxItems), then that is fine.\n\nRob","headers":{"Return-Path":"\n <linux-tegra+bounces-9413-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=W59gmQgd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org;\n envelope-from=linux-tegra+bounces-9413-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"W59gmQgd\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from ny.mirrors.kernel.org (ny.mirrors.kernel.org\n [IPv6:2604:1380:45d1:ec00::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cVnrv3Fnjz1yCt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Sep 2025 02:00:47 +1000 (AEST)","from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ny.mirrors.kernel.org (Postfix) with ESMTPS id 31597174716\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 22 Sep 2025 16:00:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 954723101D5;\n\tMon, 22 Sep 2025 16:00:42 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 40BBEEEC0;\n\tMon, 22 Sep 2025 16:00:41 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9312AC4CEF0;\n\tMon, 22 Sep 2025 16:00:41 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1758556842; cv=none;\n b=AIZ2Twy7mX9OonUwN+0jFUW1thnaZD1nPNEp3UWCfonmIKl0B1OtGkJlM6neEzHeSyF76GuzsUKUEAMTx9jbcprE6YIvvwy+hNB2NmQIbTal4u9sNVEgCj1kB3AxvnUnFjqoaiV3KhhWnaaofJBfut36hb+Pkj2Hymsb9AN/+t4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1758556842; c=relaxed/simple;\n\tbh=gurdba/DTsv3U8QqRqFzecsKxs5zCX7qM3Ox+fJp8HQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=H9O8i0M1XgZQJ3dHgAVlIeBe+ihdoVNDWiNdnnDKgewTJQJXbNsQ+iKwoB9SV9qgNa3AREVUEnWt7/KNwDLOOvK0gdGUlcafjMafpd/Zitm9PI+c2G/vG4+77ecgt7Pkb31mQmNHhB40tSLS4mbvWarauct1hZgK9QM8AaxbELk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=W59gmQgd; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1758556841;\n\tbh=gurdba/DTsv3U8QqRqFzecsKxs5zCX7qM3Ox+fJp8HQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W59gmQgdPctUTyG45puWTxq4a/dcWAgxGUxdASo4fqk9kIAuo1Rt7L2MuotxNYoXc\n\t d2mdX20+NU+uYrvBRpOP35HueZEPXa7tm1Nh9WfiRXsINRqceeJtjKa0unyUJxZeal\n\t 8AH3YVieOZfp9JNU/+2eoIghAA+oVyl9J6DwjrWAO+fiBAlfrReDQFyj9BxJwWfHzH\n\t gQiHTxe7IW8YqgfHN/OKpw4Cy8Cgyi+3TO8Im/87UNo1FTzHY3ZTs86UA914UbJu89\n\t 8brQy3zw1JZG/eoAXFcyfTDGpQMvPswjmFwBazEjpPUfF6Zcoo2qk4Vn6Xbi4r/H0u\n\t P/912Bgy/W3Nw==","Date":"Mon, 22 Sep 2025 11:00:40 -0500","From":"Rob Herring <robh@kernel.org>","To":"Svyatoslav Ryhel <clamor95@gmail.com>","Cc":"Krzysztof Kozlowski <krzk@kernel.org>,\n\tConor Dooley <conor+dt@kernel.org>,\n\tThierry Reding <treding@nvidia.com>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tJonathan Hunter <jonathanh@nvidia.com>,\n\tPrashant Gaikwad <pgaikwad@nvidia.com>,\n\tMikko Perttunen <mperttunen@nvidia.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@kernel.org>, Dmitry Osipenko <digetx@gmail.com>,\n\tMyungJoo Ham <myungjoo.ham@samsung.com>,\n\tKyungmin Park <kyungmin.park@samsung.com>,\n\tChanwoo Choi <cw00.choi@samsung.com>, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-clk@vger.kernel.org, linux-pm@vger.kernel.org","Subject":"Re: [PATCH v3 03/11] dt-bindings: memory: Document Tegra114 Memory\n Controller","Message-ID":"<20250922160040.GA92842-robh@kernel.org>","References":"<20250915080157.28195-1-clamor95@gmail.com>\n <20250915080157.28195-4-clamor95@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250915080157.28195-4-clamor95@gmail.com>"}},{"id":3585253,"web_url":"http://patchwork.ozlabs.org/comment/3585253/","msgid":"<CAPVz0n3cmFC1PdFnLJ0Vf60i3c6pDO9Lvi8dmAHzBgwgsrPXnA@mail.gmail.com>","list_archive_url":null,"date":"2025-09-22T16:18:00","subject":"Re: [PATCH v3 03/11] dt-bindings: memory: Document Tegra114 Memory\n Controller","submitter":{"id":84146,"url":"http://patchwork.ozlabs.org/api/people/84146/","name":"Svyatoslav Ryhel","email":"clamor95@gmail.com"},"content":"пн, 22 вер. 2025 р. о 19:00 Rob Herring <robh@kernel.org> пише:\n>\n> On Mon, Sep 15, 2025 at 11:01:49AM +0300, Svyatoslav Ryhel wrote:\n> > Add Tegra114 support into existing Tegra124 MC schema with the most\n> > notable difference in the amount of EMEM timings.\n> >\n> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>\n> > ---\n> >  .../nvidia,tegra124-mc.yaml                   | 97 ++++++++++++++-----\n> >  1 file changed, 74 insertions(+), 23 deletions(-)\n> >\n> > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > index 7b18b4d11e0a..9cc9360d3bd0 100644\n> > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > @@ -19,7 +19,9 @@ description: |\n> >\n> >  properties:\n> >    compatible:\n> > -    const: nvidia,tegra124-mc\n> > +    enum:\n> > +      - nvidia,tegra114-mc\n> > +      - nvidia,tegra124-mc\n> >\n> >    reg:\n> >      maxItems: 1\n> > @@ -64,29 +66,10 @@ patternProperties:\n> >\n> >            nvidia,emem-configuration:\n> >              $ref: /schemas/types.yaml#/definitions/uint32-array\n> > -            description: |\n> > +            description:\n> >                Values to be written to the EMEM register block. See section\n> > -              \"15.6.1 MC Registers\" in the TRM.\n> > -            items:\n> > -              - description: MC_EMEM_ARB_CFG\n> > -              - description: MC_EMEM_ARB_OUTSTANDING_REQ\n> > -              - description: MC_EMEM_ARB_TIMING_RCD\n> > -              - description: MC_EMEM_ARB_TIMING_RP\n> > -              - description: MC_EMEM_ARB_TIMING_RC\n> > -              - description: MC_EMEM_ARB_TIMING_RAS\n> > -              - description: MC_EMEM_ARB_TIMING_FAW\n> > -              - description: MC_EMEM_ARB_TIMING_RRD\n> > -              - description: MC_EMEM_ARB_TIMING_RAP2PRE\n> > -              - description: MC_EMEM_ARB_TIMING_WAP2PRE\n> > -              - description: MC_EMEM_ARB_TIMING_R2R\n> > -              - description: MC_EMEM_ARB_TIMING_W2W\n> > -              - description: MC_EMEM_ARB_TIMING_R2W\n> > -              - description: MC_EMEM_ARB_TIMING_W2R\n> > -              - description: MC_EMEM_ARB_DA_TURNS\n> > -              - description: MC_EMEM_ARB_DA_COVERS\n> > -              - description: MC_EMEM_ARB_MISC0\n> > -              - description: MC_EMEM_ARB_MISC1\n> > -              - description: MC_EMEM_ARB_RING1_THROTTLE\n> > +              \"20.11.1 MC Registers\" in the Tegea114 TRM or\n> > +              \"15.6.1 MC Registers\" in the Tegra124 TRM.\n> >\n> >          required:\n> >            - clock-frequency\n> > @@ -109,6 +92,74 @@ required:\n> >    - \"#iommu-cells\"\n> >    - \"#interconnect-cells\"\n> >\n> > +allOf:\n> > +  - if:\n> > +      properties:\n> > +        compatible:\n> > +          contains:\n> > +            enum:\n> > +              - nvidia,tegra114-mc\n> > +    then:\n> > +      patternProperties:\n> > +        \"^emc-timings-[0-9]+$\":\n> > +          patternProperties:\n> > +            \"^timing-[0-9]+$\":\n> > +              properties:\n> > +                nvidia,emem-configuration:\n> > +                  items:\n> > +                    - description: MC_EMEM_ARB_CFG\n> > +                    - description: MC_EMEM_ARB_OUTSTANDING_REQ\n> > +                    - description: MC_EMEM_ARB_TIMING_RCD\n> > +                    - description: MC_EMEM_ARB_TIMING_RP\n> > +                    - description: MC_EMEM_ARB_TIMING_RC\n> > +                    - description: MC_EMEM_ARB_TIMING_RAS\n> > +                    - description: MC_EMEM_ARB_TIMING_FAW\n> > +                    - description: MC_EMEM_ARB_TIMING_RRD\n> > +                    - description: MC_EMEM_ARB_TIMING_RAP2PRE\n> > +                    - description: MC_EMEM_ARB_TIMING_WAP2PRE\n> > +                    - description: MC_EMEM_ARB_TIMING_R2R\n> > +                    - description: MC_EMEM_ARB_TIMING_W2W\n> > +                    - description: MC_EMEM_ARB_TIMING_R2W\n> > +                    - description: MC_EMEM_ARB_TIMING_W2R\n> > +                    - description: MC_EMEM_ARB_DA_TURNS\n> > +                    - description: MC_EMEM_ARB_DA_COVERS\n> > +                    - description: MC_EMEM_ARB_MISC0\n> > +                    - description: MC_EMEM_ARB_RING1_THROTTLE\n>\n> Like I said before, I don't think it is worth enumerating the list of\n> registers for every variant. If you want to define the length\n> (minItems/maxItems), then that is fine.\n>\n\nIt worth because position of value matters when reading and list above\nprovides a reference to the order in which register values should be\ngrouped.\n\n> Rob","headers":{"Return-Path":"\n <linux-tegra+bounces-9414-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=CqfXrAFB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org;\n envelope-from=linux-tegra+bounces-9414-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"CqfXrAFB\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.53","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from am.mirrors.kernel.org (am.mirrors.kernel.org\n [IPv6:2604:1380:4601:e00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cVpF82MrCz1yCt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 23 Sep 2025 02:18:20 +1000 (AEST)","from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby am.mirrors.kernel.org (Postfix) with ESMTPS id 40B7519033CA\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 22 Sep 2025 16:18:40 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 755C03115B5;\n\tMon, 22 Sep 2025 16:18:16 +0000 (UTC)","from mail-wr1-f53.google.com (mail-wr1-f53.google.com\n [209.85.221.53])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 202232FE566\n\tfor <linux-tegra@vger.kernel.org>; Mon, 22 Sep 2025 16:18:13 +0000 (UTC)","by mail-wr1-f53.google.com with SMTP id\n ffacd0b85a97d-3f44000626bso1407324f8f.3\n        for <linux-tegra@vger.kernel.org>;\n Mon, 22 Sep 2025 09:18:13 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1758557896; cv=none;\n b=h2F3vdrKIy6DBygQ3bmJpGrE3zVNLz+WT9+QeM6qzANSmSS0rko+4R3KtcadDZtl1lRDptIZq8bxdqgxK1r7UiXOFPy3lAgrjatJt5jSjouccQZ6v00FkL0OIHSNN8aAH1D7Ea1NW4zHxs5WA30Kh4p4SkmeiSTTngkz+PnnF3s=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1758557896; c=relaxed/simple;\n\tbh=YDDPtDS5PpaBUTtBuBODfZ787hS7fpBN2ZOWG34B3t4=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=RSgpeYIGhzs6pMmCpkg6kQMNLf1b0V3lLtJo3V7X6UWZi7DBa4wLAuVOfwOmnQjYk8QmS6fiDJAQPMPNXZaA5Bu+1UG6/7v88jvPptXYKtizhxl0S+EpNdiMUzrtni857Q/aP3HXaBUkwlL4VY7X/Cp3q+s3jCaR3lbLF1dWB8Q=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=CqfXrAFB; arc=none smtp.client-ip=209.85.221.53","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20230601; t=1758557892; x=1759162692;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=YRWvsgj06ryKBVe+hXMBpBLtxOsCv8UUnSD06Qt2wRU=;\n        b=CqfXrAFB3hpXtjltSFqS7U6yh8OPdIcytYtO+2v4cHcW69eTMI5BnhQmrBf+1IIw4Q\n         IID1bSZoGHnL4v588s3YGOuAGbVzGOw0o7pgrPDi63hmSveYEkihfxdDTgW+n270NlN2\n         LJbMA/mKTtKOssOevs7q6B6tIhp0YnNjYLN24g9v+egwin1Y6IlnOAK6i9JZljyVAH1y\n         ZINb/LS8wei0A7ua7viogfFRLNy0Usco69ELWIbWmqaUPHRBhC6MuJ5KOLac/ZXhQFtE\n         Rv+QaGbBWhK2acjR+b8/5tX+EE8jWNP9Yfpl0N8oBfAx0Z0O7LtWmBvy/osCcJp/GW1Y\n         Ca+Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20230601; t=1758557892; x=1759162692;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n         :subject:date:message-id:reply-to;\n        bh=YRWvsgj06ryKBVe+hXMBpBLtxOsCv8UUnSD06Qt2wRU=;\n        b=d/XnwvwYC9Xd6F8DWyo8SZl1LZF3KrDPp0kNxglfp4/b1EWlE6gp9FJ7e0Lq3spK1d\n         8dPL4Czf9Ypu67TvOEcimWa1g4N2x/3NYVB6EgHzPOHBHj3JmeeK1rZ4zeJugC4IHTRM\n         UOtNhrdJ3UK5XFm8MvpOmLB7XebeE5OrHrw8xT0ocRtDisO+olDkjPY95JC6iTySLVLf\n         5sKm/kk+aj4N5IRIDBxxSiZi/JDQFKqOQlrmj4NpEOVVamIeEyupCnfKhc8LsrAOqKCp\n         c6IEMOT2qBqZ+CitykjyAtwEclx8cWVrv9W/xFmhmpgSCfmOtBCcQf/ybwjpw66ssX+1\n         CvZg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVyUvvjA6SSAJFz3eH7Oro6ekzZAFkat6i5sGRxl1YU9xoCQMvZD+AjdfOjxj+F25NDXkscRLVkhaaRZQ==@vger.kernel.org","X-Gm-Message-State":"AOJu0YxnPYpxoNw6xRMfYPtuVrAayj7Md0DPAN2dB+QGcv9fK/gUhJ4w\n\tcpVomL0UGbyEtlq76FHmjLbsaLI7GbXECFX8uxpDq2h6K78wNihmC/UOpYQw1385RJ2XSojqcwz\n\tT+DIFQLji/aQEikjJZiyBhds3SAMr3gU=","X-Gm-Gg":"ASbGncul0Tgkr1UzQLF3pS4Trg63xnAWlS0FisvQ3CAc6pndUeP8rImhdtyzYDxFyQ1\n\tkl21PX1L/1KVV5GYVAYS0fhFm6Jyc0v/MiEvIqPRuMXoDHQ5tUm8lpTzMIWITqBQF1pDODfZtWQ\n\t8G9SfnHlzrBHW/OpkeJJInewn03BdWqYXZwXIKrDAAg5qjbydPF0hF0MZAnoxoTRTrdfs4rUprz\n\tsYxGpVE","X-Google-Smtp-Source":"\n AGHT+IF1OW4Uuo/M1UxtfnKg6qFJMuGj8u/gBh+HyDuVE8SlDhk6/kPaC4q40fTL9VF7L9Z5AE3joelyQN0VbpKBDt0=","X-Received":"by 2002:a05:6000:610:b0:3e7:471c:1de3 with SMTP id\n ffacd0b85a97d-3ee7db4c459mr10915387f8f.14.1758557892173; Mon, 22 Sep 2025\n 09:18:12 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"<20250915080157.28195-1-clamor95@gmail.com>\n <20250915080157.28195-4-clamor95@gmail.com>\n <20250922160040.GA92842-robh@kernel.org>","In-Reply-To":"<20250922160040.GA92842-robh@kernel.org>","From":"Svyatoslav Ryhel <clamor95@gmail.com>","Date":"Mon, 22 Sep 2025 19:18:00 +0300","X-Gm-Features":"AS18NWDpKyD99LSDk4cdtlBB0rRoc7O4fFn4mETqSbvXEWtojMeCyyIIccv8Y9w","Message-ID":"\n <CAPVz0n3cmFC1PdFnLJ0Vf60i3c6pDO9Lvi8dmAHzBgwgsrPXnA@mail.gmail.com>","Subject":"Re: [PATCH v3 03/11] dt-bindings: memory: Document Tegra114 Memory\n Controller","To":"Rob Herring <robh@kernel.org>","Cc":"Krzysztof Kozlowski <krzk@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n\tThierry Reding <treding@nvidia.com>,\n Thierry Reding <thierry.reding@gmail.com>,\n\tJonathan Hunter <jonathanh@nvidia.com>,\n Prashant Gaikwad <pgaikwad@nvidia.com>,\n\tMikko Perttunen <mperttunen@nvidia.com>,\n Michael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@kernel.org>, Dmitry Osipenko <digetx@gmail.com>,\n\tMyungJoo Ham <myungjoo.ham@samsung.com>,\n Kyungmin Park <kyungmin.park@samsung.com>,\n\tChanwoo Choi <cw00.choi@samsung.com>, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-clk@vger.kernel.org, linux-pm@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3586617,"web_url":"http://patchwork.ozlabs.org/comment/3586617/","msgid":"<20250924152430.GA1735105-robh@kernel.org>","list_archive_url":null,"date":"2025-09-24T15:24:30","subject":"Re: [PATCH v3 03/11] dt-bindings: memory: Document Tegra114 Memory\n Controller","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Sep 22, 2025 at 07:18:00PM +0300, Svyatoslav Ryhel wrote:\n> пн, 22 вер. 2025 р. о 19:00 Rob Herring <robh@kernel.org> пише:\n> >\n> > On Mon, Sep 15, 2025 at 11:01:49AM +0300, Svyatoslav Ryhel wrote:\n> > > Add Tegra114 support into existing Tegra124 MC schema with the most\n> > > notable difference in the amount of EMEM timings.\n> > >\n> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>\n> > > ---\n> > >  .../nvidia,tegra124-mc.yaml                   | 97 ++++++++++++++-----\n> > >  1 file changed, 74 insertions(+), 23 deletions(-)\n> > >\n> > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > > index 7b18b4d11e0a..9cc9360d3bd0 100644\n> > > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > > @@ -19,7 +19,9 @@ description: |\n> > >\n> > >  properties:\n> > >    compatible:\n> > > -    const: nvidia,tegra124-mc\n> > > +    enum:\n> > > +      - nvidia,tegra114-mc\n> > > +      - nvidia,tegra124-mc\n> > >\n> > >    reg:\n> > >      maxItems: 1\n> > > @@ -64,29 +66,10 @@ patternProperties:\n> > >\n> > >            nvidia,emem-configuration:\n> > >              $ref: /schemas/types.yaml#/definitions/uint32-array\n> > > -            description: |\n> > > +            description:\n> > >                Values to be written to the EMEM register block. See section\n> > > -              \"15.6.1 MC Registers\" in the TRM.\n> > > -            items:\n> > > -              - description: MC_EMEM_ARB_CFG\n> > > -              - description: MC_EMEM_ARB_OUTSTANDING_REQ\n> > > -              - description: MC_EMEM_ARB_TIMING_RCD\n> > > -              - description: MC_EMEM_ARB_TIMING_RP\n> > > -              - description: MC_EMEM_ARB_TIMING_RC\n> > > -              - description: MC_EMEM_ARB_TIMING_RAS\n> > > -              - description: MC_EMEM_ARB_TIMING_FAW\n> > > -              - description: MC_EMEM_ARB_TIMING_RRD\n> > > -              - description: MC_EMEM_ARB_TIMING_RAP2PRE\n> > > -              - description: MC_EMEM_ARB_TIMING_WAP2PRE\n> > > -              - description: MC_EMEM_ARB_TIMING_R2R\n> > > -              - description: MC_EMEM_ARB_TIMING_W2W\n> > > -              - description: MC_EMEM_ARB_TIMING_R2W\n> > > -              - description: MC_EMEM_ARB_TIMING_W2R\n> > > -              - description: MC_EMEM_ARB_DA_TURNS\n> > > -              - description: MC_EMEM_ARB_DA_COVERS\n> > > -              - description: MC_EMEM_ARB_MISC0\n> > > -              - description: MC_EMEM_ARB_MISC1\n> > > -              - description: MC_EMEM_ARB_RING1_THROTTLE\n> > > +              \"20.11.1 MC Registers\" in the Tegea114 TRM or\n> > > +              \"15.6.1 MC Registers\" in the Tegra124 TRM.\n> > >\n> > >          required:\n> > >            - clock-frequency\n> > > @@ -109,6 +92,74 @@ required:\n> > >    - \"#iommu-cells\"\n> > >    - \"#interconnect-cells\"\n> > >\n> > > +allOf:\n> > > +  - if:\n> > > +      properties:\n> > > +        compatible:\n> > > +          contains:\n> > > +            enum:\n> > > +              - nvidia,tegra114-mc\n> > > +    then:\n> > > +      patternProperties:\n> > > +        \"^emc-timings-[0-9]+$\":\n> > > +          patternProperties:\n> > > +            \"^timing-[0-9]+$\":\n> > > +              properties:\n> > > +                nvidia,emem-configuration:\n> > > +                  items:\n> > > +                    - description: MC_EMEM_ARB_CFG\n> > > +                    - description: MC_EMEM_ARB_OUTSTANDING_REQ\n> > > +                    - description: MC_EMEM_ARB_TIMING_RCD\n> > > +                    - description: MC_EMEM_ARB_TIMING_RP\n> > > +                    - description: MC_EMEM_ARB_TIMING_RC\n> > > +                    - description: MC_EMEM_ARB_TIMING_RAS\n> > > +                    - description: MC_EMEM_ARB_TIMING_FAW\n> > > +                    - description: MC_EMEM_ARB_TIMING_RRD\n> > > +                    - description: MC_EMEM_ARB_TIMING_RAP2PRE\n> > > +                    - description: MC_EMEM_ARB_TIMING_WAP2PRE\n> > > +                    - description: MC_EMEM_ARB_TIMING_R2R\n> > > +                    - description: MC_EMEM_ARB_TIMING_W2W\n> > > +                    - description: MC_EMEM_ARB_TIMING_R2W\n> > > +                    - description: MC_EMEM_ARB_TIMING_W2R\n> > > +                    - description: MC_EMEM_ARB_DA_TURNS\n> > > +                    - description: MC_EMEM_ARB_DA_COVERS\n> > > +                    - description: MC_EMEM_ARB_MISC0\n> > > +                    - description: MC_EMEM_ARB_RING1_THROTTLE\n> >\n> > Like I said before, I don't think it is worth enumerating the list of\n> > registers for every variant. If you want to define the length\n> > (minItems/maxItems), then that is fine.\n> >\n> \n> It worth because position of value matters when reading and list above\n> provides a reference to the order in which register values should be\n> grouped.\n\nThe schema does nothing to validate that. The only thing that gets \nvalidated is the length. It is just an opaque blob of data. I'm sure you \nhave to define the order in the driver as well. One place is enough.\n\nRob","headers":{"Return-Path":"\n <linux-tegra+bounces-9455-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hTKD+yL+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org;\n envelope-from=linux-tegra+bounces-9455-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"hTKD+yL+\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from am.mirrors.kernel.org (am.mirrors.kernel.org\n [IPv6:2604:1380:4601:e00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cX0yH4yRHz1yFv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 25 Sep 2025 01:24:39 +1000 (AEST)","from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby am.mirrors.kernel.org (Postfix) with ESMTPS id 74CFD1B27B5C\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Sep 2025 15:24:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 78F7231159E;\n\tWed, 24 Sep 2025 15:24:32 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A8CD30F94E;\n\tWed, 24 Sep 2025 15:24:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 56621C116C6;\n\tWed, 24 Sep 2025 15:24:31 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1758727472; cv=none;\n b=cChClYc4YsznVYxApEZ/8eJgyJryFWQZ0iHQWPliZCcLuEDyvzeSwkWVJRvdTbJGPc4/186J7blCMALr0evRI1zpe3Phi5Esw9tYa2BM7HSuP6a3Fv0c4Yrm3v5FkfddOaEw7kT4ISQhkJfjbey2ye6GhnwVgKYocF6JXgxsoqk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1758727472; c=relaxed/simple;\n\tbh=z51gCKwdpZxvFwIfuZnWgQntDhqg+DSi+OiQMo4cKjg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=VvC7baTeNgRnCGRrSBYaG5JtTGEVuaogQXTKvZoCVTxoAIKbvdKFtdohFeoy8lkJoanjpithD5trTqxs1Mk1Jhy+8acZDt83NWUKZRaHFmY3i8D+bZpSUP3bdGoXvOscCSg9m9f9lkjm2dipB53lmI3bBlLI9DCWX+Kc37UxR+Y=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=hTKD+yL+; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1758727471;\n\tbh=z51gCKwdpZxvFwIfuZnWgQntDhqg+DSi+OiQMo4cKjg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hTKD+yL+GM8Kz5Or9C/Wek6gEMENBW4MdyX9Ax1rFpv/bBkEsP7hfvoUKChVFadcC\n\t 6mXioAhDdbIudVwAi5iG/xnJZc9uY2LJOALLbBKzTu41T7dD7OZ9a8LxeDBtQ4Jruf\n\t 7xZ3g/n/wjVAVfOp2xsAsJjEBw3NuYnF+I8S+cYnjEsJOstA76m1FGE5TKOXEjD2xO\n\t GouWKyViuajmRXaN1PkKYPVsGX9NvfgBfRHHJJpCFKs4BX2JVu9Q/f25pikW4NzY0a\n\t epWZT7lSa4Zr2wk9X+yxim4nKfvFKo8D65Hl7O4/Nxm0ldcji//TyKCvixzRM9UHvP\n\t vwEXLBdyG121Q==","Date":"Wed, 24 Sep 2025 10:24:30 -0500","From":"Rob Herring <robh@kernel.org>","To":"Svyatoslav Ryhel <clamor95@gmail.com>","Cc":"Krzysztof Kozlowski <krzk@kernel.org>,\n\tConor Dooley <conor+dt@kernel.org>,\n\tThierry Reding <treding@nvidia.com>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tJonathan Hunter <jonathanh@nvidia.com>,\n\tPrashant Gaikwad <pgaikwad@nvidia.com>,\n\tMikko Perttunen <mperttunen@nvidia.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@kernel.org>, Dmitry Osipenko <digetx@gmail.com>,\n\tMyungJoo Ham <myungjoo.ham@samsung.com>,\n\tKyungmin Park <kyungmin.park@samsung.com>,\n\tChanwoo Choi <cw00.choi@samsung.com>, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-clk@vger.kernel.org, linux-pm@vger.kernel.org","Subject":"Re: [PATCH v3 03/11] dt-bindings: memory: Document Tegra114 Memory\n Controller","Message-ID":"<20250924152430.GA1735105-robh@kernel.org>","References":"<20250915080157.28195-1-clamor95@gmail.com>\n <20250915080157.28195-4-clamor95@gmail.com>\n <20250922160040.GA92842-robh@kernel.org>\n <CAPVz0n3cmFC1PdFnLJ0Vf60i3c6pDO9Lvi8dmAHzBgwgsrPXnA@mail.gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"\n <CAPVz0n3cmFC1PdFnLJ0Vf60i3c6pDO9Lvi8dmAHzBgwgsrPXnA@mail.gmail.com>"}},{"id":3621432,"web_url":"http://patchwork.ozlabs.org/comment/3621432/","msgid":"<v6adntm5a3wxxxsmufd54t6pgmoj4njp63q362orkbeew6t3ef@7pfiz6ou7w77>","list_archive_url":null,"date":"2025-12-01T14:18:48","subject":"Re: [PATCH v3 03/11] dt-bindings: memory: Document Tegra114 Memory\n Controller","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"content":"On Wed, Sep 24, 2025 at 10:24:30AM -0500, Rob Herring wrote:\n> On Mon, Sep 22, 2025 at 07:18:00PM +0300, Svyatoslav Ryhel wrote:\n> > пн, 22 вер. 2025 р. о 19:00 Rob Herring <robh@kernel.org> пише:\n> > >\n> > > On Mon, Sep 15, 2025 at 11:01:49AM +0300, Svyatoslav Ryhel wrote:\n> > > > Add Tegra114 support into existing Tegra124 MC schema with the most\n> > > > notable difference in the amount of EMEM timings.\n> > > >\n> > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>\n> > > > ---\n> > > >  .../nvidia,tegra124-mc.yaml                   | 97 ++++++++++++++-----\n> > > >  1 file changed, 74 insertions(+), 23 deletions(-)\n> > > >\n> > > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > > > index 7b18b4d11e0a..9cc9360d3bd0 100644\n> > > > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > > > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-mc.yaml\n> > > > @@ -19,7 +19,9 @@ description: |\n> > > >\n> > > >  properties:\n> > > >    compatible:\n> > > > -    const: nvidia,tegra124-mc\n> > > > +    enum:\n> > > > +      - nvidia,tegra114-mc\n> > > > +      - nvidia,tegra124-mc\n> > > >\n> > > >    reg:\n> > > >      maxItems: 1\n> > > > @@ -64,29 +66,10 @@ patternProperties:\n> > > >\n> > > >            nvidia,emem-configuration:\n> > > >              $ref: /schemas/types.yaml#/definitions/uint32-array\n> > > > -            description: |\n> > > > +            description:\n> > > >                Values to be written to the EMEM register block. See section\n> > > > -              \"15.6.1 MC Registers\" in the TRM.\n> > > > -            items:\n> > > > -              - description: MC_EMEM_ARB_CFG\n> > > > -              - description: MC_EMEM_ARB_OUTSTANDING_REQ\n> > > > -              - description: MC_EMEM_ARB_TIMING_RCD\n> > > > -              - description: MC_EMEM_ARB_TIMING_RP\n> > > > -              - description: MC_EMEM_ARB_TIMING_RC\n> > > > -              - description: MC_EMEM_ARB_TIMING_RAS\n> > > > -              - description: MC_EMEM_ARB_TIMING_FAW\n> > > > -              - description: MC_EMEM_ARB_TIMING_RRD\n> > > > -              - description: MC_EMEM_ARB_TIMING_RAP2PRE\n> > > > -              - description: MC_EMEM_ARB_TIMING_WAP2PRE\n> > > > -              - description: MC_EMEM_ARB_TIMING_R2R\n> > > > -              - description: MC_EMEM_ARB_TIMING_W2W\n> > > > -              - description: MC_EMEM_ARB_TIMING_R2W\n> > > > -              - description: MC_EMEM_ARB_TIMING_W2R\n> > > > -              - description: MC_EMEM_ARB_DA_TURNS\n> > > > -              - description: MC_EMEM_ARB_DA_COVERS\n> > > > -              - description: MC_EMEM_ARB_MISC0\n> > > > -              - description: MC_EMEM_ARB_MISC1\n> > > > -              - description: MC_EMEM_ARB_RING1_THROTTLE\n> > > > +              \"20.11.1 MC Registers\" in the Tegea114 TRM or\n> > > > +              \"15.6.1 MC Registers\" in the Tegra124 TRM.\n> > > >\n> > > >          required:\n> > > >            - clock-frequency\n> > > > @@ -109,6 +92,74 @@ required:\n> > > >    - \"#iommu-cells\"\n> > > >    - \"#interconnect-cells\"\n> > > >\n> > > > +allOf:\n> > > > +  - if:\n> > > > +      properties:\n> > > > +        compatible:\n> > > > +          contains:\n> > > > +            enum:\n> > > > +              - nvidia,tegra114-mc\n> > > > +    then:\n> > > > +      patternProperties:\n> > > > +        \"^emc-timings-[0-9]+$\":\n> > > > +          patternProperties:\n> > > > +            \"^timing-[0-9]+$\":\n> > > > +              properties:\n> > > > +                nvidia,emem-configuration:\n> > > > +                  items:\n> > > > +                    - description: MC_EMEM_ARB_CFG\n> > > > +                    - description: MC_EMEM_ARB_OUTSTANDING_REQ\n> > > > +                    - description: MC_EMEM_ARB_TIMING_RCD\n> > > > +                    - description: MC_EMEM_ARB_TIMING_RP\n> > > > +                    - description: MC_EMEM_ARB_TIMING_RC\n> > > > +                    - description: MC_EMEM_ARB_TIMING_RAS\n> > > > +                    - description: MC_EMEM_ARB_TIMING_FAW\n> > > > +                    - description: MC_EMEM_ARB_TIMING_RRD\n> > > > +                    - description: MC_EMEM_ARB_TIMING_RAP2PRE\n> > > > +                    - description: MC_EMEM_ARB_TIMING_WAP2PRE\n> > > > +                    - description: MC_EMEM_ARB_TIMING_R2R\n> > > > +                    - description: MC_EMEM_ARB_TIMING_W2W\n> > > > +                    - description: MC_EMEM_ARB_TIMING_R2W\n> > > > +                    - description: MC_EMEM_ARB_TIMING_W2R\n> > > > +                    - description: MC_EMEM_ARB_DA_TURNS\n> > > > +                    - description: MC_EMEM_ARB_DA_COVERS\n> > > > +                    - description: MC_EMEM_ARB_MISC0\n> > > > +                    - description: MC_EMEM_ARB_RING1_THROTTLE\n> > >\n> > > Like I said before, I don't think it is worth enumerating the list of\n> > > registers for every variant. If you want to define the length\n> > > (minItems/maxItems), then that is fine.\n> > >\n> > \n> > It worth because position of value matters when reading and list above\n> > provides a reference to the order in which register values should be\n> > grouped.\n> \n> The schema does nothing to validate that. The only thing that gets \n> validated is the length. It is just an opaque blob of data. I'm sure you \n> have to define the order in the driver as well. One place is enough.\n\nHi Rob,\n\nSorry for being so late on this, but I just noticed that v4 had dropped\nthese items descriptions and then saw that you had suggested this. I\nhave always found the explicit mention useful because it allows DT\nwriters to know what to put into the properties without having to look\nup a specific implementation.\n\nIf the DT bindings don't specify the order, then how do we guarantee\nthat all implementations agree on the order? While it's true that no\nvalidation is done via the schema, the schema is the only specification\nthat we have for this. Without it there is no reason for an\nimplementation to pick one order over another.\n\nThierry","headers":{"Return-Path":"\n <linux-tegra+bounces-10672-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=Lfhlw4OD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=142.0.200.124; helo=dfw.mirrors.kernel.org;\n envelope-from=linux-tegra+bounces-10672-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"Lfhlw4OD\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.50","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from dfw.mirrors.kernel.org (dfw.mirrors.kernel.org [142.0.200.124])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dKmH66dJXz1yDq\n\tfor <incoming@patchwork.ozlabs.org>; Tue,  2 Dec 2025 01:18:58 +1100 (AEDT)","from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby dfw.mirrors.kernel.org (Postfix) with ESMTPS id 08CFF4E02F7\n\tfor <incoming@patchwork.ozlabs.org>; Mon,  1 Dec 2025 14:18:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 57AC43B186;\n\tMon,  1 Dec 2025 14:18:56 +0000 (UTC)","from mail-wm1-f50.google.com (mail-wm1-f50.google.com\n [209.85.128.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 19BC1290DBB\n\tfor <linux-tegra@vger.kernel.org>; Mon,  1 Dec 2025 14:18:53 +0000 (UTC)","by mail-wm1-f50.google.com with SMTP id\n 5b1f17b1804b1-477a219dbcaso38065355e9.3\n        for <linux-tegra@vger.kernel.org>;\n Mon, 01 Dec 2025 06:18:53 -0800 (PST)","from orome (p200300e41f07e000f22f74fffe1f3a53.dip0.t-ipconnect.de.\n [2003:e4:1f07:e000:f22f:74ff:fe1f:3a53])\n        by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4790ade13ddsm303266005e9.8.2025.12.01.06.18.50\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Mon, 01 Dec 2025 06:18:50 -0800 (PST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1764598736; cv=none;\n b=eLr/dta5zhy6ymtGH2ii2udGp69UieV9SXA42+UPLomulgWvERfvsdGe1CRTe8vAaozxb1OvhTAS6ceWSH+nstjXRL3tIK0YrqrdURdpddWUtxW2iS+uJhORYzUp62EKfAUuMIwTuGAdbWVtiVZRpgfR0VIEsabnHbpU+9qgyhU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1764598736; c=relaxed/simple;\n\tbh=53LkXaYFrn3GVJ1cIaB3BFaBBqn6BqjYqqHvmEyC6b0=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=jpiJeKSMgW8gAaTCquaKxqp7UJth5qGfImO7Ndby1UDJ1TjR1p7SFnEYXUT1T+9IHKhGwNzbd9cAiH5oQXEL5cVU6qc4BVAPO93ttViK/bYGPEkVdD2lGgcr0Dt0XSLgJOQPnG2ZN5jWY/pXZDXWjjiIkdrootoU/q6Ij4qTYt8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=Lfhlw4OD; arc=none smtp.client-ip=209.85.128.50","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20230601; t=1764598732; x=1765203532;\n darn=vger.kernel.org;\n        h=in-reply-to:content-disposition:mime-version:references:message-id\n         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n        bh=zrU/m1NsQKsXrrOPLuPzfw00NgfNm1183Aja3qoirBc=;\n        b=Lfhlw4ODPByC4VhVMdASHQgH5s6JHY0SqbFAues7tvOzCm/T2iq8JVOeiHUbrgtA1D\n         flVHHpZ8ENDR1gxKYRXdSh/rUpgEfbsC1rRtegOy+6amgR9WhMojA/uKMb/r7Lpun1RD\n         rJL1ZfGxGcnDCPdqVNc4kTxjcagVnPGWfTbRQOVwnwUaCQKLaZ2jlvxxNpTJfhndxx89\n         UU1dQefxusE/lo1KCFheOT8b9ElBJCV7hUCMlGJNQ7jySA7bUYB4+gX6HS+0audNe8/f\n         lHvrL8gpbOK3piY4EWsVmga/RoSS3CrrEvQZLmxC06B5hFrOALvT9T4FSvItWbBE3D1h\n         9gdQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20230601; t=1764598732; x=1765203532;\n        h=in-reply-to:content-disposition:mime-version:references:message-id\n         :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n         :subject:date:message-id:reply-to;\n        bh=zrU/m1NsQKsXrrOPLuPzfw00NgfNm1183Aja3qoirBc=;\n        b=G3yE3JEcn10B4om95mjZecMy/Ep74Qt2Z8ihuFE3CgNPv6p5Vk4DgEKWrrM4Jm/bPV\n         H/ohJnljiZNO1bCPxbEsljXLBOxICvTBOY/FXMDLQUtQE4VtqME0s9vBkJeAQAb3Kw2i\n         g32NNX8YIiUiJVKeIgYszUwmi5OYGKTg5JeuMOQTK31q6sqAsHIQYAbdAcbv3Zj66wBb\n         xXarhDkG4Utqpo84Vd1skpeEeZ/MET98E9gJvx2ft3QOz5nm5ji893RV2KWTOsCE68G6\n         9m9Cu3K4Rn2C+cGc12+tRIV2YjH8VjiNcTatFQQJm6FjYsiaUwvslrkZL7mFkwg2G499\n         xEjA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWoDtI4DluZj7RxJj2syqM1l4XzmoXnGnGMEiqdygAaxd+KUsH4ZBPztNRmuH4b4lwYqy63SqQ42FfH3g==@vger.kernel.org","X-Gm-Message-State":"AOJu0YyJ0d5c1ovftRres6GZ1vcEQApJmkQq8c2MoTxlr+IdA5JSt85w\n\tceMLqrHVGZNFPWovnnOr8oKI1yK7IvcZJ5kafL7op/MwFfTaQWgoukGb","X-Gm-Gg":"ASbGnct7T0ODEqjQChcpoDmwlKwIqSejMU1c4jhSfSizgN/Sfv/7yzuXa49Hw5CllIa\n\tCD48+S1QxGLV8HJ9+zr2J4Q3xhxrpLcxZcV9L83Qg/9FuiYh74tlhMFBf67uR5VB+CtjAFAnPru\n\tUTpY7WVIqRfVX6sLrhSqgV0rI744i9EhuqKhT+khJ1uHi7FUJrygZ44eKclMjT0FpVFaWmaf6b4\n\ti4jRHZ2lEniHeNSWa9/8vGyFc8YWTasu8fwx5D2mhMtlXxhBuNNl1D08iP1nKjg924h7SbqUhUo\n\tOnGPmehJZJFnthtOu6rPIXjhLtTTa5a9+dqT5+SuvELYBUnD8h8Mw25HkKeyND786CH9H0mnw7Z\n\tZ6yo8dYY7qmhc1/5nCWAlpx/OuvbDD772Tju9gDj2hgiGZyFkKZzwV0Drf/YkpfXDhDHsop4F6Q\n\tuCtuunBKUqej9V0SzLIm4JNtcHI7HpV7F/sQugb6v6j18wkahs+6SY9ltGoQ9D76PsblBgc7zT3\n\tA==","X-Google-Smtp-Source":"\n AGHT+IEWJAy9TFAQ+VOIZ162KEF2lzriCvlTOGHOqCcNNfqx4TM96iV2z0z1mnsWDrSD2qljqTJPoQ==","X-Received":"by 2002:a05:600c:46c3:b0:477:6d96:b3ca with SMTP id\n 5b1f17b1804b1-477c01743e2mr375540815e9.5.1764598732075;\n        Mon, 01 Dec 2025 06:18:52 -0800 (PST)","Date":"Mon, 1 Dec 2025 15:18:48 +0100","From":"Thierry Reding <thierry.reding@gmail.com>","To":"Rob Herring <robh@kernel.org>","Cc":"Svyatoslav Ryhel <clamor95@gmail.com>,\n\tKrzysztof Kozlowski <krzk@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n\tThierry Reding <treding@nvidia.com>, Jonathan Hunter <jonathanh@nvidia.com>,\n\tPrashant Gaikwad <pgaikwad@nvidia.com>,\n Mikko Perttunen <mperttunen@nvidia.com>,\n\tMichael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>,\n\tDmitry Osipenko <digetx@gmail.com>, MyungJoo Ham <myungjoo.ham@samsung.com>,\n\tKyungmin Park <kyungmin.park@samsung.com>,\n Chanwoo Choi <cw00.choi@samsung.com>,\n\tlinux-kernel@vger.kernel.org, devicetree@vger.kernel.org,\n linux-tegra@vger.kernel.org,\n\tlinux-clk@vger.kernel.org, linux-pm@vger.kernel.org","Subject":"Re: [PATCH v3 03/11] dt-bindings: memory: Document Tegra114 Memory\n Controller","Message-ID":"<v6adntm5a3wxxxsmufd54t6pgmoj4njp63q362orkbeew6t3ef@7pfiz6ou7w77>","References":"<20250915080157.28195-1-clamor95@gmail.com>\n <20250915080157.28195-4-clamor95@gmail.com>\n <20250922160040.GA92842-robh@kernel.org>\n <CAPVz0n3cmFC1PdFnLJ0Vf60i3c6pDO9Lvi8dmAHzBgwgsrPXnA@mail.gmail.com>\n <20250924152430.GA1735105-robh@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"cmjgfgew7ig24nkq\"","Content-Disposition":"inline","In-Reply-To":"<20250924152430.GA1735105-robh@kernel.org>"}}]