[{"id":3499581,"web_url":"http://patchwork.ozlabs.org/comment/3499581/","msgid":"<214e3bef-09cd-426b-aa7a-65ee540f7cab@linaro.org>","list_archive_url":null,"date":"2025-04-22T06:43:55","subject":"Re: [PATCH v2 13/20] block: Fix type confict of the copy_file_range\n stub","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 22/4/25 07:27, Kohei Tokunaga wrote:\n> Emscripten doesn't provide copy_file_range implementation but it declares\n> this function in its headers. Meson correctly detects the missing\n> implementation and unsets HAVE_COPY_FILE_RANGE. However, the stub defined in\n> file-posix.c causes a type conflict with the declaration from Emscripten\n> during compilation.\n> \n> To fix this error, this commit updates the stub implementation in\n> file-posix.c to exactly match the declaration in Emscripten's headers. The\n> manpage also aligns with this signature.\n> \n> Signed-off-by: Kohei Tokunaga \n> ---\n> block/file-posix.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=xvnhPhHa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhXlF09HYz1yMm\n\tfor ; Tue, 22 Apr 2025 16:44:09 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u77MW-0004C4-5o; Tue, 22 Apr 2025 02:44:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1u77MR-00046z-Am\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:44:04 -0400","from mail-wr1-x431.google.com ([2a00:1450:4864:20::431])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1u77MO-0007yq-Gy\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:44:02 -0400","by mail-wr1-x431.google.com with SMTP id\n ffacd0b85a97d-39c30d9085aso3462317f8f.1\n for ; Mon, 21 Apr 2025 23:43:58 -0700 (PDT)","from [192.168.69.169] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-39efa43be53sm13882739f8f.41.2025.04.21.23.43.55\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 21 Apr 2025 23:43:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1745304237; x=1745909037; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=+9UB07EjzDEhXxVE2VMd7KxrceRog099DGJ5fspr6Kg=;\n b=xvnhPhHa7xhbQ+1q+EsyYhcfLOhdMDV3YWXFcwcaILG6P7w2Yga3WYUqu1L/Zhuofd\n 9X0hBZvmLilwHhDKjG+FZa3tNWGJYK0NtMVuflPu1ENO0uJjYRYXJxXzN8Z2quvVOxV6\n iXyvqb3mL8yWQXA6mU5Z0N8MoidGSO8lXkR55G36tci9xqHM1EoFBIKc5YMfZC2JqUQS\n Yh2FFEfoMQe+s5MeMBJ2QjBsmNTGC1YzJ+uSDYwj3cf7oSnxNdJTeeIIDABgUa4iPY2m\n 6q4P4gssJR/fceYAD+Y3iSDnHF9lQUStp973asMIkRfSU89rVNnC2m7sx7YF/tOMofLR\n rGaQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745304237; x=1745909037;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=+9UB07EjzDEhXxVE2VMd7KxrceRog099DGJ5fspr6Kg=;\n b=Xf3GAtaPtfMzsOkC+QUjVbNJo8qMN8tKyD1OVVRpvssdJL751IqeWEkOCMvhbkDKd2\n xGQyOfkETpt2SXpQhgxQfh8VmDrJMyX9ttbcdglOQ6gW6EnAvuBGujfqm/h15bGawFmK\n Yk5IsL2l64j/m9gU0H2Jsht1lqoZSs5iWgHh4GjJDtldR500aau9o8RsL7ULd7Yw3nuA\n nLqTIBbkhvqiPkgl/87Qqq6Sn/ABfAp8aIhKInGK110mV1B2WGRJEycf4BaLOfnXAtgS\n BW4R8FH5nJUl070edCUbGwGpE+5R1j5/AgX+u380J4yof6M1MyLQZwJjmpdMGx6JB3UB\n 3UNQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWES5joFk0XT9D5PNA3fNROEDYpRPqq6o+u3I05rT5suESkBw08zj1DjW9vgJdig76kNl+RDkl6sRvx@nongnu.org","X-Gm-Message-State":"AOJu0Yw0DzyXKSeHpvbbYep9oiY0vaVyvZJptSSgGaTmTHfTZpt2Q/wI\n GO6YwnYWFqTdz0udAbeEN2P038571Tm8/bjYC2k7B02T8qMtKrnsIn49QKYVgXY=","X-Gm-Gg":"ASbGncuwiTtraBWloln5AbvpEPvFHD4OphnXGvpNbe96SONfDEfCkmZaiv5DST69+7G\n QHAnmFtoz2G+y/Q7XnKqHHvEsWoPCYP1Q+s157JjGyTbUunJUYFPptaDZzLKMu4NZjIA1S0RO7P\n 2TtUuZl+jcBXOxOFx9cC0fApqMoJm11Jn8dod9eRHpO+SzDRS8Y3heXXAL3x7M16EbsYkoDKHwo\n yObzMrz1n1Cx7v0L6rNCoUf2s5RbfzZQQ81j8PPKBohphfz+XhIslZlh/NRJ31qF4EFE3/DK+HQ\n lLY91ALDyTIG35u2pkEdvyt4Sp02B+avFGGCQPY0ctW5D0HgValuYvGl+g5WfdIlZDN0GqBKwru\n nhD6gU/sCtRXZXD0osZg=","X-Google-Smtp-Source":"\n AGHT+IGicNEOGGWG9Ql2/GtKu2hXalYv3ESAo9JoC/qmXK6F5zqhCTj6Dxi2AfDm2j2sZt9xm6esSQ==","X-Received":"by 2002:a5d:47cb:0:b0:39e:f89b:85dc with SMTP id\n ffacd0b85a97d-39efba52f5cmr10905880f8f.17.1745304237341;\n Mon, 21 Apr 2025 23:43:57 -0700 (PDT)","Message-ID":"<214e3bef-09cd-426b-aa7a-65ee540f7cab@linaro.org>","Date":"Tue, 22 Apr 2025 08:43:55 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 13/20] block: Fix type confict of the copy_file_range\n stub","To":"Kohei Tokunaga , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Paolo Bonzini ,\n Alexandre Iooss , Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","References":"\n ","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::431;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3499966,"web_url":"http://patchwork.ozlabs.org/comment/3499966/","msgid":"<20250422140155.GC301197@fedora>","list_archive_url":null,"date":"2025-04-22T14:01:55","subject":"Re: [PATCH v2 13/20] block: Fix type confict of the copy_file_range\n stub","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Tue, Apr 22, 2025 at 02:27:17PM +0900, Kohei Tokunaga wrote:\n> Emscripten doesn't provide copy_file_range implementation but it declares\n> this function in its headers. Meson correctly detects the missing\n> implementation and unsets HAVE_COPY_FILE_RANGE. However, the stub defined in\n> file-posix.c causes a type conflict with the declaration from Emscripten\n> during compilation.\n> \n> To fix this error, this commit updates the stub implementation in\n> file-posix.c to exactly match the declaration in Emscripten's headers. The\n> manpage also aligns with this signature.\n> \n> Signed-off-by: Kohei Tokunaga \n> ---\n> block/file-posix.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> V2:\n> - Removed the Emscripten-specific stub of copy_file_range in\n> stubs/emscripten.c. Instead, updated the type of the existing\n> copy_file_range stub in block/file-posix.c to match the declaration in the\n> Emscripten headers and avoid a compilation error.\n\nReviewed-by: Stefan Hajnoczi ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ClZ2E7W3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhkT023PSz1yMy\n\tfor ; Wed, 23 Apr 2025 00:02:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u7ECX-0008Ds-VV; Tue, 22 Apr 2025 10:02:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1u7ECR-00081W-Bb\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 10:02:13 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1u7ECN-0006hR-7y\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 10:02:10 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-lKdadMvSOC--cVrGngmKBQ-1; Tue,\n 22 Apr 2025 10:02:02 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id F189519560BC; Tue, 22 Apr 2025 14:01:58 +0000 (UTC)","from localhost (unknown [10.2.16.110])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1C639195608D; Tue, 22 Apr 2025 14:01:56 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1745330525;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=7oUOK46QlawTR7PzRa1h2tAuDsOpWCOm7vEMBMH4LoM=;\n b=ClZ2E7W34Ft4Ry6bycfxH7nPNbsmuDk3fnzH5P0Y53tHfjbLxvJuli9zFoMK20cbkCv506\n 6FQhksZsA0TLYLYjGwDznYP3e1+cok23X0ogZMwGsgRDarz6rRe0iw7Z3xqCkCLlkOddFh\n ZGmGA3nYx5jLYMhb/GmirCnK+AEzYd8=","X-MC-Unique":"lKdadMvSOC--cVrGngmKBQ-1","X-Mimecast-MFC-AGG-ID":"lKdadMvSOC--cVrGngmKBQ_1745330519","Date":"Tue, 22 Apr 2025 10:01:55 -0400","From":"Stefan Hajnoczi ","To":"Kohei Tokunaga ","Cc":"qemu-devel@nongnu.org,\n Alex =?iso-8859-1?q?Benn=E9e?= , Philippe\n\t=?iso-8859-1?q?Mathieu-Daud=E9?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Paolo Bonzini ,\n Alexandre Iooss , Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?iso-8859-1?q?Marc-Andr=E9?= Lureau , Daniel P\n\t=?iso-8859-1?q?=2E_Berrang=E9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , qemu-block@nongnu.org,\n qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org","Subject":"Re: [PATCH v2 13/20] block: Fix type confict of the copy_file_range\n stub","Message-ID":"<20250422140155.GC301197@fedora>","References":"\n ","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"BVTxInpCVWgS3hFa\"","Content-Disposition":"inline","In-Reply-To":"\n ","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.411,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]