[{"id":3499575,"web_url":"http://patchwork.ozlabs.org/comment/3499575/","msgid":"<415b113f-000a-4744-8ace-49ed0974d1fd@linaro.org>","list_archive_url":null,"date":"2025-04-22T06:41:13","subject":"Re: [PATCH v2 03/20] system/vl.c: Fix type conflict of GLib function\n pointers","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 22/4/25 07:27, Kohei Tokunaga wrote:\n> On Emscripten, function pointer casts can result in runtime failures due to\n> strict function signature checks. This affects the use of g_list_sort and\n> g_slist_sort, which internally perform function pointer casts that are not\n> supported by Emscripten. To avoid these issues, g_list_sort_with_data and\n> g_slist_sort_with_data should be used instead, as they do not rely on\n> function pointer casting.\n> \n> Signed-off-by: Kohei Tokunaga \n> ---\n> system/vl.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=suK22W2M;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhXj76FBLz1yMm\n\tfor ; Tue, 22 Apr 2025 16:42:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u77Jt-0000Y9-BV; Tue, 22 Apr 2025 02:41:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1u77Jq-0000WZ-FQ\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:41:23 -0400","from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1u77Jn-0007nv-Ak\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:41:21 -0400","by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-43cf05f0c3eso34463605e9.0\n for ; Mon, 21 Apr 2025 23:41:17 -0700 (PDT)","from [192.168.69.169] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4408c80174dsm7224665e9.0.2025.04.21.23.41.14\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 21 Apr 2025 23:41:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1745304076; x=1745908876; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=9rNr4hys0zfLgUPvngT1iGKY6bsdEbk77gsdKeXGZdI=;\n b=suK22W2M2L3XmauKYScc/TvLpC8f0ywiM6NlDtHg0QmMv4AfXPA1QijP6wmGOdLCBW\n fvj3qJlfeT1AmM3317/pBHF5FaennUZi4wVtlpoeaUIXIL7rSPoa5l5EA+3REYTS7Jdz\n BW8JlnfcKSJkI0ay4P//nXp4n2J3iiyrOqT4eaQhW8njcNAO1AWDV7XIE1XORcZhR6pp\n AE/sD0SeJ90xyTnBRo0L7DD7jeSnfm2wkuANKRik5d7w/RT3rD8LGv3YVxSt2bRIr3fQ\n i0CwbJBvxBeRS9u/IPtNlz+WyIvI6mgna3ll/fx8FegNmpwpK/ndj69GKur5EZ3/8pXx\n GyAA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745304076; x=1745908876;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=9rNr4hys0zfLgUPvngT1iGKY6bsdEbk77gsdKeXGZdI=;\n b=E8TUgN1+AW5krDcnwJn6rcCY+FEaqTktKC5FHn9JvM1Zvb9Zo6lIWleEjSCx1p55WA\n o8f6SqAUyjmZCFlSp3sW2y2AZgXHd/mOH740g5tjAtUy58jAMMANSyj09hazIEH7Mndb\n /u+kEJpLpIA6rrCwFia4S+5DsbddvvS1kouL6THzb82vzruoFjfTKiGBPFo5DMIOG864\n TZnULHOElxqJD5kBCehepWGuLVr4xGXpV7EBMhDO7d+kbL1ZDx5FoT5xMq0D6LPFS87Q\n T4xPoYl/1e34wA9jXszQgVpwjVgR9LV9BuW+TSlhlOLPx1ZoLdJXoEtVwt6Ux1jYUXj2\n 73gA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUe4kbQ6Uv8CfDTDL0XwKRQIgSTZ+aDtVx7/iCsS+8QBLMlhGF8sN3Gunh1Q5vkLCznd83ItU6tmnVL@nongnu.org","X-Gm-Message-State":"AOJu0YxQQxL80Xet+SAVffWHukIz+IosjDppbnMqgQ5g+6uBwjiw0x2o\n qt6uVaW+g9GXIizgXtRlMtMW6ZrIX0FCNi+zyoVkcslcbgkSMavqP+baKacyF/c=","X-Gm-Gg":"ASbGnctUH3T0S0Wfp/8+qNElbomrzPRcRABb1Nm/o1memL4GmFb7QzDUupj8s0L7XQv\n SyoyfFsFG/Oq4KY2mHFPcpikZ7JlbX5TSCQowdRXHz36eI7Trcv6pu2dMRrTWPgzDAutPX2SAzN\n Hgs3ymjDMOPSYaIZP0LspU/Bsys5x0spuHGVSTCSYOc/cfls49pYHddW1dt9psggErY1e57b/fH\n O72apgUD8D4AO3gtrwuTLSKeVsl3vAjlqhOBFin1OPAstbFVEwmCjDl4SZEIMgIlIWHGtUio88O\n /G3eUbCKGBv04W4NjWSd04ESF5sJtL+XQswsQ5efW690eqKAeFaKrZmWGSWgqhXQOKP/Zrne8bJ\n 2k12PaoQn5KN6yPw+1hM=","X-Google-Smtp-Source":"\n AGHT+IG4ZtK+iwu9U6jyXYYM80D4F6KIt2i04bTCGsufr5gmlfhiFb1M0CVJcFRT/FLpc9QsD6nv2A==","X-Received":"by 2002:a05:600c:3485:b0:43d:abd:ad1c with SMTP id\n 5b1f17b1804b1-4406ab7b67bmr113462525e9.6.1745304075976;\n Mon, 21 Apr 2025 23:41:15 -0700 (PDT)","Message-ID":"<415b113f-000a-4744-8ace-49ed0974d1fd@linaro.org>","Date":"Tue, 22 Apr 2025 08:41:13 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 03/20] system/vl.c: Fix type conflict of GLib function\n pointers","To":"Kohei Tokunaga , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Paolo Bonzini ,\n Alexandre Iooss , Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","References":"\n ","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::335;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]