[{"id":3499577,"web_url":"http://patchwork.ozlabs.org/comment/3499577/","msgid":"<7907635a-7486-4bd1-b040-5c5208495452@linaro.org>","list_archive_url":null,"date":"2025-04-22T06:41:30","subject":"Re: [PATCH v2 01/20] hw/core/loader.c: Fix type conflict of GLib\n function pointers","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 22/4/25 07:27, Kohei Tokunaga wrote:\n> On Emscripten, function pointer casts can result in runtime failures due to\n> strict function signature checks. This affects the use of g_list_sort and\n> g_slist_sort, which internally perform function pointer casts that are not\n> supported by Emscripten. To avoid these issues, g_list_sort_with_data and\n> g_slist_sort_with_data should be used instead, as they do not rely on\n> function pointer casting.\n> \n> Signed-off-by: Kohei Tokunaga \n> ---\n> hw/core/loader.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ow9MxQ0c;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhXjY0VxJz1yMm\n\tfor ; Tue, 22 Apr 2025 16:42:41 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u77KP-0000zb-LL; Tue, 22 Apr 2025 02:41:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1u77KD-0000p8-PC\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:41:50 -0400","from mail-wr1-x432.google.com ([2a00:1450:4864:20::432])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1u77K2-0007p0-Ix\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:41:41 -0400","by mail-wr1-x432.google.com with SMTP id\n ffacd0b85a97d-3995ff6b066so2458679f8f.3\n for ; Mon, 21 Apr 2025 23:41:33 -0700 (PDT)","from [192.168.69.169] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4406d5acca9sm161223325e9.12.2025.04.21.23.41.30\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 21 Apr 2025 23:41:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1745304093; x=1745908893; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=YweAujch6X+IzetnIcpOjGXiSDNATL6ECW1Z8embAd8=;\n b=ow9MxQ0cROdSHPeFPh5PPSPtA+0Q4i6LstUVqGIginKDVRWiskOehL4ODNs3iqW6JQ\n ySRaWa5gUYxlmkQ1ool8TrjJ2EQx8fD0YSG+G/qWsbF2/iojsjSsNtxwaZf6DrmGRoMw\n 7GMIaoawu81ctOhHBaCqV1YGGr822jEExWfMd3/Vz5UBu5+glOUDs8I9DL6vH1IOSMR3\n CxOBmHjnVUx5p7o2raAiz3/ym2TU0MjId+2JMpej4W8tSv9DvDmCVlUqY+5T1l/B6VW2\n MEDMRImdv91KtDao5VGj0u1CCns2pa1B8AsmZrrOIAHGUEhTok92mqkDgklnzu+3Yu3P\n Fibg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745304093; x=1745908893;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=YweAujch6X+IzetnIcpOjGXiSDNATL6ECW1Z8embAd8=;\n b=Q4OeLyiLRiDM7mNfvs5HPzKWnN+tFR/NyO7+XdT5Mgq1Q4pRVO8S5YhuETdKJ4fx+N\n MVCT9bVM34Vav9//WEy0kSJbUubmanKwvWyTCkl2iUl2FLp+4yUXVDiJVTlSONcCBkWc\n 3q+IMvLqYLt2I7I0QOzvzs2Yh22mbAhKJpsO93xBxMBbWWR1GFmxYoU1WyxbzrTTBGZL\n 8kZ6IebWP8QdgWx2rMu5xxRdBIo2t3M9YHxSQcON88X7h57uaA62zeuDR6BMj6pF1P9D\n 3zPTHq7WKIBbB9wH48rizrKF2z1Z1x4mvKsQwpOIqhiId5bOBEyctICS/InYwEQVVLB+\n dOag==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWmrH6FXq/Hv9dqjKx1RNX3rTD3OzD7bhuThMqHwGmcih09rd8tdywDA9CniGhyk6wWlx/XQYxCGe3/@nongnu.org","X-Gm-Message-State":"AOJu0Yw82LysEhjYy0jmccNoKtjo8I8nlGjiUL5oy+X8G11m5Xr6P1k6\n qqTbVRY5JPM5QRk1YDXmpCpDEE0BSpX7KNfe173wr09UW9qqF8cMmsS2QeBJnM4=","X-Gm-Gg":"ASbGncusUBsrwFimtDvD/Cp4r2c0sE/NO4ZzHuZN4fR59UYQWqm6Esr8CehkuX61GQE\n QyMriom2LF+1E3Xltm+Wqlf0aTjw9Lgt9BbTlLGsVCtSXYiBI4zpEGXXMS8D0VutJVMpfKqZdOl\n TqNru6WvbAVzAX/CdctqeH75tIhpZIC3wH3Kjo32Bgg7cKbH92DKdzRAJjYFElel454A4d9+JAL\n 7zd5qO28c3IDT5YPW0B+J1C5/0v2Qw/jBQ5BfFqX2Cu2/XnLsgnAP0D+F6zxjw6HQ/9ZJMVISIC\n RevkMui7Xt3/m8AjLMDKw+ZVvaTHlXAKLRlLbggdPEfjo+qWLadtKuET95OjXLaEbkU5osR57yQ\n nWzjtWCVt","X-Google-Smtp-Source":"\n AGHT+IHzjEl+8lPmhKSabXC0zUI9tf5BnCeJoTQo1HR1FIk+Do0DmX0vATxLBq/9dEodEtSs6ecG7w==","X-Received":"by 2002:a5d:6da5:0:b0:391:3aaf:1d5f with SMTP id\n ffacd0b85a97d-39efbb09d5bmr11235926f8f.52.1745304092791;\n Mon, 21 Apr 2025 23:41:32 -0700 (PDT)","Message-ID":"<7907635a-7486-4bd1-b040-5c5208495452@linaro.org>","Date":"Tue, 22 Apr 2025 08:41:30 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 01/20] hw/core/loader.c: Fix type conflict of GLib\n function pointers","To":"Kohei Tokunaga , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Paolo Bonzini ,\n Alexandre Iooss , Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","References":"\n <26dfe9191154ca65dca6ef51ce768ad2a0c30d5f.1745295397.git.ktokunaga.mail@gmail.com>","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"\n <26dfe9191154ca65dca6ef51ce768ad2a0c30d5f.1745295397.git.ktokunaga.mail@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::432;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]