[{"id":3499587,"web_url":"http://patchwork.ozlabs.org/comment/3499587/","msgid":"<47fd711e-7d73-45e8-9956-e0f91d513f0a@linaro.org>","list_archive_url":null,"date":"2025-04-22T06:52:22","subject":"Re: [PATCH v2 12/20] block: Add including of ioctl header for\n Emscripten build","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 22/4/25 07:27, Kohei Tokunaga wrote:\n> Including <sys/ioctl.h> is still required on Emscripten, just like on other\n> platforms, to make the ioctl function available.\n> \n> Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>\n> ---\n>   block/file-posix.c | 4 ++++\n>   1 file changed, 4 insertions(+)\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Ew+luM4d;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhXxs2q8Yz1yJW\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 22 Apr 2025 16:53:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u77Uf-0000J9-OE; Tue, 22 Apr 2025 02:52:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1u77Ue-0000Hi-9S\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:52:32 -0400","from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1u77Ua-0000Tf-85\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:52:31 -0400","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-43690d4605dso38144345e9.0\n for <qemu-devel@nongnu.org>; Mon, 21 Apr 2025 23:52:26 -0700 (PDT)","from [192.168.69.169] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4408c8b0ea0sm5702765e9.2.2025.04.21.23.52.23\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 21 Apr 2025 23:52:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1745304745; x=1745909545; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=SjiQWxPOlSNVbGc7W9J3JEzK5NR3eJEU8fykCh1e2f4=;\n b=Ew+luM4dohmyhqylk0S11UeD2PJSGPXLijcrzRF6LqXtuD2QcMfuv4vJPmb6kqlmpv\n XFbm/RsOZsuRthIXb42Tp9a11L3jr+KVPr1Q326Zhj24C9ZeR/WiQ5lgmngOIRbhNBhc\n VmsCZyhApW9K0RRvZqrksgiBsaE+UmWoF/05XJTH582RlGR3fQQSbARq1YnNQgmoVOxx\n beqtjxnw62o6BSLUNOdMvFOsl35VUiB4O7P8OurxyZvU53mXXyNP0gMDJgMvnwrzkKhk\n sWrQzJExFVrFwD5Vh3TlTIjY45BM7koi6PnTZvx3+1mw3M48SIeERxeGtJI48Xu9VEty\n eiXg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745304745; x=1745909545;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=SjiQWxPOlSNVbGc7W9J3JEzK5NR3eJEU8fykCh1e2f4=;\n b=gEFZGTxhNkto02QMbCq+3Yq7pnZB81pP1SJOyOBh8JL0evpn7ooQ0oLWhAzXp4Atbs\n A283a5+mxlVGeR0GHQTufXhwsKh68pSuSqUy/3DCUfF9Ia38JBO/CiR8RRq+AqhF5OQk\n WCD7YlI/2WM9/p5+pvNQ82F705aONXpXDfBCwrhSjK2hUWKaBl9eEZGOX/g29LqJpUvn\n Ign3os8h4z4vljOzragHw7ytDUA8ncRB0C1YYenlKyp8gwmXUG7tndyqAtAI0CzvI/66\n XGGsGnuUgV4Zb5DecFXHlHSHqzj2hliD7PpnWJdxriUt6t8O5S8LdsxiUKQg5D0+k0Q/\n WaVg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX8hdJm1K9By1mZRSgNkxiSrxUCw54ATWxHGPrXmiDPKsHeSDx5UZRNSL7AaGQJPiT3TS3Sacun5Hwq@nongnu.org","X-Gm-Message-State":"AOJu0YwydykzVQg3ybA3iVtkD+bYGgSPuWuT3FMDa9NRc2VcFF+6IWi0\n jonUzBx3ttU/R7fveobgdm/WDeya3OPEQbjcrOUlPKAhAS4TMd8GElnD+lRKjRg=","X-Gm-Gg":"ASbGncuTjcvKrM81heqpp/Fw2k3PmTu+mGjGsK2IppRbk44BQm0v2mSBubn4IcJNj0P\n 6gcjMcxLicvGaCYMjPpp5DuB4nBwDQiw+Fa8mJWbijKbebppnZd+topNMRbNSl4Co6iELIIMe8Z\n GvJZ0D+9lSe5IDrXyT7r67hafV9yiG10yii1K5bUc0HYFCfB78WdN9ty2DkF3xIyS1qyUgQhTk/\n muYSj/phjkf25fpietrV80rxKah722CH/vkeATUkeeJIfiiAm1hiALVOdaTEC4qK0XbDim8giqk\n QxHZ/P1INSrwfqzF8JqTC3DPdYO3+wBsiiWE+fzyR1cW6UjLEeHkPVC+uCJfVwSZ3E9SnrmPUsv\n YSihWDvK5","X-Google-Smtp-Source":"\n AGHT+IHt3h54M4vtwl7DRF5h65UdgoH4/u8sgi1vZYRuQtRMbNcoheUDjjhNNRdhtzIUU+XdW7CFxA==","X-Received":"by 2002:a05:600c:1d95:b0:43d:b3:fb1 with SMTP id\n 5b1f17b1804b1-4406ac270f7mr123517835e9.27.1745304745084;\n Mon, 21 Apr 2025 23:52:25 -0700 (PDT)","Message-ID":"<47fd711e-7d73-45e8-9956-e0f91d513f0a@linaro.org>","Date":"Tue, 22 Apr 2025 08:52:22 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 12/20] block: Add including of ioctl header for\n Emscripten build","To":"Kohei Tokunaga <ktokunaga.mail@gmail.com>, qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Pavel Pisa <pisa@cmp.felk.cvut.cz>,\n Francisco Iglesias <francisco.iglesias@amd.com>,\n Vikram Garhwal <vikram.garhwal@bytedance.com>,\n Jason Wang <jasowang@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Peter Xu <peterx@redhat.com>,\n David Hildenbrand <david@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Daniel Henrique Barboza <danielhb413@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Ilya Leoshkevich <iii@linux.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","References":"<cover.1745295397.git.ktokunaga.mail@gmail.com>\n <1821e79d3977c3645aa79128b823748aa9a63800.1745295397.git.ktokunaga.mail@gmail.com>","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"\n <1821e79d3977c3645aa79128b823748aa9a63800.1745295397.git.ktokunaga.mail@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3499969,"web_url":"http://patchwork.ozlabs.org/comment/3499969/","msgid":"<20250422140230.GD301197@fedora>","list_archive_url":null,"date":"2025-04-22T14:02:30","subject":"Re: [PATCH v2 12/20] block: Add including of ioctl header for\n Emscripten build","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Tue, Apr 22, 2025 at 02:27:16PM +0900, Kohei Tokunaga wrote:\n> Including <sys/ioctl.h> is still required on Emscripten, just like on other\n> platforms, to make the ioctl function available.\n> \n> Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>\n> ---\n>  block/file-posix.c | 4 ++++\n>  1 file changed, 4 insertions(+)\n> \n> V2:\n> - Split this from the previous 12th patch into a separate commit and revised\n>   the commit message to clarify the purpose of the patch.\n\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ND2B2hqn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhkVD27XJz1yMy\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 23 Apr 2025 00:03:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u7EDH-0000Rm-Sg; Tue, 22 Apr 2025 10:03:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanha@redhat.com>)\n id 1u7ED4-0000Bv-DH\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 10:02:56 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <stefanha@redhat.com>)\n id 1u7ECy-0006q0-9Z\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 10:02:49 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-PnD7k094PV-TO6F3HJ0EnQ-1; Tue,\n 22 Apr 2025 10:02:36 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5D93D1800374; Tue, 22 Apr 2025 14:02:33 +0000 (UTC)","from localhost (unknown [10.2.16.110])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7D55719560A3; Tue, 22 Apr 2025 14:02:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1745330562;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=gPFJrHA5M71c3UwbrJYytVj0SGR0ASd/LIoDZp8msTA=;\n b=ND2B2hqnYzW6dXBBCdjXBjjCTG8lqXxqS3ByjQquz0swjE+YnqMREUeSWc+BjuXLV+nif9\n ufHo6k3rMmmoaJquYHmFHezthQA2nMywwoE8Q7MgOvfNBxJl7C823BrM8CzGLgX4PU+ah3\n z0jou0+yoZwAn68/bYZw+lyfyivFnVs=","X-MC-Unique":"PnD7k094PV-TO6F3HJ0EnQ-1","X-Mimecast-MFC-AGG-ID":"PnD7k094PV-TO6F3HJ0EnQ_1745330553","Date":"Tue, 22 Apr 2025 10:02:30 -0400","From":"Stefan Hajnoczi <stefanha@redhat.com>","To":"Kohei Tokunaga <ktokunaga.mail@gmail.com>","Cc":"qemu-devel@nongnu.org,\n Alex =?iso-8859-1?q?Benn=E9e?= <alex.bennee@linaro.org>, Philippe\n\t=?iso-8859-1?q?Mathieu-Daud=E9?= <philmd@linaro.org>,\n Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Pavel Pisa <pisa@cmp.felk.cvut.cz>,\n Francisco Iglesias <francisco.iglesias@amd.com>,\n Vikram Garhwal <vikram.garhwal@bytedance.com>,\n Jason Wang <jasowang@redhat.com>,\n =?iso-8859-1?q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>, Daniel P\n\t=?iso-8859-1?q?=2E_Berrang=E9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Peter Xu <peterx@redhat.com>,\n David Hildenbrand <david@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Daniel Henrique Barboza <danielhb413@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Ilya Leoshkevich <iii@linux.ibm.com>, qemu-block@nongnu.org,\n qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org","Subject":"Re: [PATCH v2 12/20] block: Add including of ioctl header for\n Emscripten build","Message-ID":"<20250422140230.GD301197@fedora>","References":"<cover.1745295397.git.ktokunaga.mail@gmail.com>\n <1821e79d3977c3645aa79128b823748aa9a63800.1745295397.git.ktokunaga.mail@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"SuP7/mi/IM/vqmX4\"","Content-Disposition":"inline","In-Reply-To":"\n <1821e79d3977c3645aa79128b823748aa9a63800.1745295397.git.ktokunaga.mail@gmail.com>","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.411,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]