[{"id":3499574,"web_url":"http://patchwork.ozlabs.org/comment/3499574/","msgid":"<370fdc99-1b95-41a3-bc41-3956f5b3040b@linaro.org>","list_archive_url":null,"date":"2025-04-22T06:40:55","subject":"Re: [PATCH v2 06/20] contrib/plugins: Fix type conflict of GLib\n function pointers","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 22/4/25 07:27, Kohei Tokunaga wrote:\n> On Emscripten, function pointer casts can result in runtime failures due to\n> strict function signature checks. This affects the use of g_list_sort and\n> g_slist_sort, which internally perform function pointer casts that are not\n> supported by Emscripten. To avoid these issues, g_list_sort_with_data and\n> g_slist_sort_with_data should be used instead, as they do not rely on\n> function pointer casting.\n> \n> Signed-off-by: Kohei Tokunaga \n> ---\n> contrib/plugins/cache.c | 12 ++++++------\n> contrib/plugins/cflow.c | 10 +++++-----\n> contrib/plugins/hotblocks.c | 4 ++--\n> contrib/plugins/hotpages.c | 4 ++--\n> contrib/plugins/howvec.c | 4 ++--\n> contrib/plugins/hwprofile.c | 8 ++++----\n> tests/tcg/plugins/mem.c | 4 ++--\n> tests/tcg/plugins/syscall.c | 4 ++--\n> 8 files changed, 25 insertions(+), 25 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=zaOXcXfJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZhXhn6qnmz1yMm\n\tfor ; Tue, 22 Apr 2025 16:42:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u77Jd-0000RD-Fm; Tue, 22 Apr 2025 02:41:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1u77JX-0000PY-58\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:41:03 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1u77JU-0007mC-Te\n for qemu-devel@nongnu.org; Tue, 22 Apr 2025 02:41:02 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-43d2d952eb1so34937095e9.1\n for ; Mon, 21 Apr 2025 23:40:59 -0700 (PDT)","from [192.168.69.169] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4406d5acdd4sm159563065e9.14.2025.04.21.23.40.56\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 21 Apr 2025 23:40:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1745304058; x=1745908858; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=nKJFeLlUbpZe7YuWGal+rk0qK1HvBE9EVeqOrPjomVI=;\n b=zaOXcXfJBAZ9s2tMQVfc/YCpTeuSyXPFfotEY5BFKVUIUm3Q7j4NkzqTylvIROko9r\n TaG29wiDfFf4KDsiWvoSmVwc8HY32ccN87zrGMwRGmWxMRCVp/ut3d61ojeqSFfU+Ngz\n XlKcHzP6cr1uruD2W2WnwIdBXTPgk2fPoTQG+W5VQIn7bIa4Ahcy2GP1arCOXKxUBC7p\n hkEYOpXDZ7hHkguOtPBTZfaH4+mfrlxNCYqcdq42tIAP8hAGKB3oRnprhismVWcXLLUW\n 0nV8qi9xtrcOwtUDVm/v9jushzT3ndE4OGJ20WBHraTnhfbqlA48cpX22LKl5KDUHB4N\n B+hA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745304058; x=1745908858;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=nKJFeLlUbpZe7YuWGal+rk0qK1HvBE9EVeqOrPjomVI=;\n b=gjMq5vL15wQ7C9n5qjXul7xcrZIq+Y8BYh5PDmOpwkXiE+aP3DKBmjSTJzQa0OsQv9\n KY0sOL5qobSZ8F2u9zj5Z0iusuIdel0A8RVRIjNJLntqtz31d/mKvAAnz5nwDcjUtZZ3\n 1/Q0+9Vavyk/lzPiPNXJUyGIoNLfHuIF8Y71wIOLZqkWjNUr+ly0uhE0SKkUhgMcRR5E\n 5Whrde7iQ+63PKGD5mZcXp5WUxMomfp0RVMYmbYPOsXXILAwnAuszUYKdHhJ8WICD2P5\n xcegZcMCN9y1PJGHOafa0pS0QR7HJWDZXIB28OWyLY4p5wkXJTPCJ+ydDHBuxrmESmFF\n 1e1A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCV1mCt1aTiuB7b+5zVHD/NTstAb38jXVOtzA8HS6sAT0v/9122Org4Lorw2pd3hoPOjuPGplTCHA9LC@nongnu.org","X-Gm-Message-State":"AOJu0YwAp36D2oz3LHAYQvq19nsNceXDcg09iO7qNT7J+lQZJebqWMzR\n /R4L6BI364ecWGSdiIqr6PiwDdP5qEy7xqx8hgiZ95fVrSdD8evOkdhTqO+VoKA=","X-Gm-Gg":"ASbGncsnEHFPPy8TpCtayBNiYWQi82hBvVL+oE4a/5PgBV9aqlU2C2QWzisZZxaw6um\n MdgSr9AKHf8UAY64XeEVAR+IVxm7/bAkkPH4ZUssZce2j1SuOYjJgNkwuUXBSuBaJAsohtf43Cf\n JVBMvqJSayKGow1hrscQAy5w1WN4cqhmYVjFiufC80gkkpa2qiiTMKkYtBM7t1I81zlLaEU4X+V\n n4TJUxQi+GYo7YI2TuYV/vRs2JOLgsJfSW8RbChWGlPQGE5Au7XQqhrSPC3bArGoDnH6QU6dVhD\n Ixvyv5xdgQQ7fmN6peJTKvssqTjMVD6O8kqoRBjJygtQqiOyIViTC6gXOZ4g1tSVJtU8lf7tL2w\n mtKLl6GnK","X-Google-Smtp-Source":"\n AGHT+IHcsH8adNlZwrRlN7mr+Ppudxls9pRBnErGa7/Mp6qPgu/+F0y8fjs6Hnt0hcPXdfZIWPFqYA==","X-Received":"by 2002:a05:600c:3acf:b0:43d:209:21fd with SMTP id\n 5b1f17b1804b1-4406ac2040dmr126725005e9.30.1745304058402;\n Mon, 21 Apr 2025 23:40:58 -0700 (PDT)","Message-ID":"<370fdc99-1b95-41a3-bc41-3956f5b3040b@linaro.org>","Date":"Tue, 22 Apr 2025 08:40:55 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 06/20] contrib/plugins: Fix type conflict of GLib\n function pointers","To":"Kohei Tokunaga , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Paolo Bonzini ,\n Alexandre Iooss , Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","References":"\n <0fcddfca16ca8da2bdaa7b2c114476f5b73d032b.1745295397.git.ktokunaga.mail@gmail.com>","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"\n <0fcddfca16ca8da2bdaa7b2c114476f5b73d032b.1745295397.git.ktokunaga.mail@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]