[{"id":3502342,"web_url":"http://patchwork.ozlabs.org/comment/3502342/","msgid":"<c22b4b2c-aac4-4e67-a026-1739ff10addd@linaro.org>","list_archive_url":null,"date":"2025-04-25T14:51:47","subject":"Re: [PATCH v2 07/20] hw/net/can: Fix type conflict of GLib function\n pointers","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 22/4/25 07:27, Kohei Tokunaga wrote:\n> On Emscripten, function pointer casts can result in runtime failures due to\n> strict function signature checks. This affects the use of g_list_sort and\n> g_slist_sort, which internally perform function pointer casts that are not\n> supported by Emscripten. To avoid these issues, g_list_sort_with_data and\n> g_slist_sort_with_data should be used instead, as they do not rely on\n> function pointer casting.\n> \n> Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>\n> ---\n>   hw/net/can/xlnx-versal-canfd.c | 4 ++--\n>   1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sAqTxqc3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZkbRh5J22z1yMm\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 26 Apr 2025 00:52:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u8KPF-0002Lf-8W; Fri, 25 Apr 2025 10:51:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1u8KPC-0002L2-Qj\n for qemu-devel@nongnu.org; Fri, 25 Apr 2025 10:51:54 -0400","from mail-wr1-x436.google.com ([2a00:1450:4864:20::436])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1u8KPA-0007jx-RH\n for qemu-devel@nongnu.org; Fri, 25 Apr 2025 10:51:54 -0400","by mail-wr1-x436.google.com with SMTP id\n ffacd0b85a97d-39c30d9085aso1727652f8f.1\n for <qemu-devel@nongnu.org>; Fri, 25 Apr 2025 07:51:52 -0700 (PDT)","from [192.168.69.226] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3a073ccf44csm2624994f8f.60.2025.04.25.07.51.48\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 25 Apr 2025 07:51:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1745592711; x=1746197511; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=CGE6UG+OVqd3GaSBfL9qpLMTvgMRYgEqf87pGEIjybA=;\n b=sAqTxqc3OwaODtt9ziI4Yo9cFr41H+J9D48D8VaPhVPXlF8mZCJVr3zz0jdt2CM1UN\n 9xtne6sH0FHTSkFL8sert7bj4Btf+lxb6BUYh1fQi/+XYyIOKJi/0PP3XheJV4Jy3bOq\n 7PzHHxBPPCJayD1ZVax1hwUvYsRqbhFRizkW4FUIpJWKwdnsuxwbBIWPqC6QzVKn1oxh\n T/Oe9dgC7FxpN8XraxMv+6hFkYI+Bsmr3Q0f1qNUEhES8UmPhCMeZ7VNKszDdgZ4cgfw\n XW0EpC/OWiYc34KH21AKJRF8KRgGlmTr9a+IeaESl9GaX8YxWWixsO3VSR8h7mJdr0+1\n kt5A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745592711; x=1746197511;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=CGE6UG+OVqd3GaSBfL9qpLMTvgMRYgEqf87pGEIjybA=;\n b=rJeugV0qHW5LKqOwLym6EVRkAMOvp5tzLK/vMDQJg6MHTSwAo9/d1zn5lOZIZrmQ7O\n 6Zkvg5ka5P681euR7YLrGQY71eTPoA9E/jTdfskwBxyvBqu+8M0Af76VLZ15Ayn4n0Mf\n CtnsWxJTMJFL9k/e5P6MotuRlOZX1f2qinezfoi+Dxzgdb7QK5ke3lkeBxBIjn7dij31\n ukWbeuqU+qylJy6muZBcjUY3nVTXIuGFBTBSmw/i2Z+xJV+l9a2f8KRMMAcCc9R6LgL5\n vfHc43ijBn2pX1jIhQAadl+W05i6fuI8lsewHItibJ1mj9Lh+kol05cfPIKgystjnEZ8\n MDQw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVdYjVFDfL+mveZYLesrw7XevGw0zviBWE415aGC+vmehSmE7JjSfxWjBI4/xZoVNqDF6Ej6tRiuwob@nongnu.org","X-Gm-Message-State":"AOJu0YzmCrpOwW3MBDu3+EjCznpfwcvcDpDejYurENtp0maqeAnF0j92\n HjTGZzrm8vcG6+d1fYrPvCQxnCmKVwqLoQwSFzXHwUxluvl72fwovvwPJkKH2AP3/ly2EZ2dYM4\n 2","X-Gm-Gg":"ASbGncs+HayhIk+i7mcaP4N5rfCAH3/0xGNKLHSBbO5kGHShecLu5hJ7ksMSERpFHxn\n AQz+KoVfhrq8buBPrvYsWR4UGtrbKP2AbmQxMX1qGLDKc9CQSKi/fbaX5MBuMEf+mt21NXwAv0M\n FUZu1LTbMKGYyQSIK87gaGabvdNAzrIxi8sQeacEjOpfWwOET0IPWePoeMUTVaIOnh4QRuyeV94\n My0Hzg8VGli6lkHTgbDyMhdYvxW5DKJ0Wq0l8S2NZmI9PvL5fzOPYUm4OAb1y/wAD/6qqPPPCWy\n 3mmfcbSZr8mRHTHQs/4nu+DM+f2FjA27Y0xuXFjvCxv5JCONdxlKCCTBwfiAD5Fkdni6hWB7dZE\n EZwC8wcsR","X-Google-Smtp-Source":"\n AGHT+IFSc1UFfFshkZOlDunJCHlH6dSK2nCeOkmDpatGTQV6+ofkvOfND9JWvvMrYs6wH8CXB5J4Dg==","X-Received":"by 2002:a05:6000:2283:b0:391:2f71:bbb3 with SMTP id\n ffacd0b85a97d-3a074f3a0a3mr2286228f8f.46.1745592710663;\n Fri, 25 Apr 2025 07:51:50 -0700 (PDT)","Message-ID":"<c22b4b2c-aac4-4e67-a026-1739ff10addd@linaro.org>","Date":"Fri, 25 Apr 2025 16:51:47 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 07/20] hw/net/can: Fix type conflict of GLib function\n pointers","To":"Kohei Tokunaga <ktokunaga.mail@gmail.com>, qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Pavel Pisa <pisa@cmp.felk.cvut.cz>,\n Francisco Iglesias <francisco.iglesias@amd.com>,\n Vikram Garhwal <vikram.garhwal@bytedance.com>,\n Jason Wang <jasowang@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Peter Xu <peterx@redhat.com>,\n David Hildenbrand <david@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Daniel Henrique Barboza <danielhb413@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Ilya Leoshkevich <iii@linux.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","References":"<cover.1745295397.git.ktokunaga.mail@gmail.com>\n <4d47a75c5768c9a6dc5d8b3504e78837577ad70d.1745295397.git.ktokunaga.mail@gmail.com>","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"\n <4d47a75c5768c9a6dc5d8b3504e78837577ad70d.1745295397.git.ktokunaga.mail@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::436;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3502350,"web_url":"http://patchwork.ozlabs.org/comment/3502350/","msgid":"<aAukWsGgmQS5NZ1w@xse-figlesia-l2.amd.com>","list_archive_url":null,"date":"2025-04-25T15:03:54","subject":"Re: [PATCH v2 07/20] hw/net/can: Fix type conflict of GLib function\n pointers","submitter":{"id":85826,"url":"http://patchwork.ozlabs.org/api/people/85826/","name":"Francisco Iglesias","email":"francisco.iglesias@amd.com"},"content":"On Tue, Apr 22, 2025 at 02:27:11PM +0900, Kohei Tokunaga wrote:\n> On Emscripten, function pointer casts can result in runtime failures due to\n> strict function signature checks. This affects the use of g_list_sort and\n> g_slist_sort, which internally perform function pointer casts that are not\n> supported by Emscripten. To avoid these issues, g_list_sort_with_data and\n> g_slist_sort_with_data should be used instead, as they do not rely on\n> function pointer casting.\n> \n> Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>\n\nAcked-by: Francisco Iglesias <francisco.iglesias@amd.com>\n\n> ---\n>  hw/net/can/xlnx-versal-canfd.c | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> V2:\n> - Updated the commit message to explicitly explain that function pointer\n>   casts are performed internally by GLib.\n> \n> diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c\n> index dc242e9215..013ebc10dc 100644\n> --- a/hw/net/can/xlnx-versal-canfd.c\n> +++ b/hw/net/can/xlnx-versal-canfd.c\n> @@ -1278,7 +1278,7 @@ static void tx_fifo_stamp(XlnxVersalCANFDState *s, uint32_t tb0_regid)\n>      }\n>  }\n>  \n> -static gint g_cmp_ids(gconstpointer data1, gconstpointer data2)\n> +static gint g_cmp_ids(gconstpointer data1, gconstpointer data2, gpointer d)\n>  {\n>      tx_ready_reg_info *tx_reg_1 = (tx_ready_reg_info *) data1;\n>      tx_ready_reg_info *tx_reg_2 = (tx_ready_reg_info *) data2;\n> @@ -1318,7 +1318,7 @@ static GSList *prepare_tx_data(XlnxVersalCANFDState *s)\n>              temp->can_id = s->regs[reg_num];\n>              temp->reg_num = reg_num;\n>              list = g_slist_prepend(list, temp);\n> -            list = g_slist_sort(list, g_cmp_ids);\n> +            list = g_slist_sort_with_data(list, g_cmp_ids, NULL);\n>          }\n>  \n>          reg_ready >>= 1;\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256\n header.s=selector1 header.b=38lgTa1P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=amd.com;"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZkbjX1LL1z1yN2\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 26 Apr 2025 01:04:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1u8KbH-00025s-ET; Fri, 25 Apr 2025 11:04:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <francisco.iglesias@amd.com>)\n id 1u8KbE-00023u-Ue; Fri, 25 Apr 2025 11:04:20 -0400","from mail-dm6nam11on20605.outbound.protection.outlook.com\n ([2a01:111:f403:2415::605]\n helo=NAM11-DM6-obe.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <francisco.iglesias@amd.com>)\n id 1u8KbC-0000W8-HU; Fri, 25 Apr 2025 11:04:20 -0400","from SJ2PR12MB8739.namprd12.prod.outlook.com (2603:10b6:a03:549::10)\n by MN2PR12MB4078.namprd12.prod.outlook.com (2603:10b6:208:1de::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.27; Fri, 25 Apr\n 2025 15:04:09 +0000","from SJ2PR12MB8739.namprd12.prod.outlook.com\n ([fe80::29bb:9aa:2a72:df1b]) by SJ2PR12MB8739.namprd12.prod.outlook.com\n ([fe80::29bb:9aa:2a72:df1b%3]) with mapi id 15.20.8678.025; Fri, 25 Apr 2025\n 15:04:09 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=jkJzqIr9eoTIlWR/pMUPjVqhg/wLksoaUHc3VKcgJfYyKN8Yh8O99RUyBk+/pWcRMTJ/nOFWuHqoawrhCiWBkKNLfvqQtWZ/TNDHS5QSMoySokrKmfV11WgssWuVZAWlni2KzJYHVOd/EqXqiRx29h8vgLRSYhE43u+SDTzcVV3c2FwUb1EI/xy6b1+nDres2eL8mF8HyS7E2XIqoQIjtZGAtAdA9tZ5q7d0+2rYfh8z/JqBHJwODI0VUkI3q+jx6V4xryiZIJXtKzOehznIrM+eGpTgQ+nmnDrMBuOv8h1+XjTfOdWt8AclHe3iqXvqRWZYBpIX9OVZeW3hmvdDFQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=IoOlwyvVb/E1l6h8O1Gd24WKSEZL4zzANdt/LeszLe0=;\n b=ef6eKWEcw5x/qmguQnojir282HnSBoTIGp4dYDSQ7WcNVHmqXnOhCXD43+eZKkkynnnAzNSrxaAN0+hrFNGXUiObmtvE9ZBsN2y6liC/LKEv3FDoUlcwNpD27tMKe8ITnVG3tvGtSmWiDBzO3cahfk0PGjG7S9reHlLhnz4TkVpv4uIaTs8fydLv3u/o3WzPN/SsOJe4z0RzcVbiiir2yykucdVIT9qSv5WbaKTWgd7Y9ET5CJtkmtw/DslTIVmammOCJRKdZ2XTqkI+YjILNHSxqF/WSJ2LCU5D8eFD9rd3tc/XYB3DPg+LIbzi/a2iz6V+/pHwWmdkzFKq3le6KA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass\n header.d=amd.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=IoOlwyvVb/E1l6h8O1Gd24WKSEZL4zzANdt/LeszLe0=;\n b=38lgTa1PXJBXKuioOGXRryTv++ZWnEUtPHKLAy/mV8+bXn9u7L2yyrY1Whbd6M4WcOCjes2MtO+asD+ZtM855FQLF3I5lmvpTuv78k8PYaZxOA3aUnvPytWwUs/c8JG6PheZLLeYifxb44CBf2m0FHcyaV13ZtbioikFNZ7/CTM=","Date":"Fri, 25 Apr 2025 17:03:54 +0200","From":"Francisco Iglesias <francisco.iglesias@amd.com>","To":"Kohei Tokunaga <ktokunaga.mail@gmail.com>","Cc":"qemu-devel@nongnu.org,\n Alex =?utf-8?q?Benn=C3=A9e?= <alex.bennee@linaro.org>, Philippe =?utf-8?q?M?=\n\t=?utf-8?q?athieu-Daud=C3=A9?= <philmd@linaro.org>,\n Thomas Huth <thuth@redhat.com>, Kevin Wolf <kwolf@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Pavel Pisa <pisa@cmp.felk.cvut.cz>,\n Vikram Garhwal <vikram.garhwal@bytedance.com>,\n Jason Wang <jasowang@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, Daniel P\n\t=?utf-8?b?LiBCZXJyYW5nw6k=?= <berrange@redhat.com>,\n Eduardo Habkost <eduardo@habkost.net>, Peter Xu <peterx@redhat.com>,\n David Hildenbrand <david@redhat.com>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Nicholas Piggin <npiggin@gmail.com>,\n Daniel Henrique Barboza <danielhb413@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Ilya Leoshkevich <iii@linux.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","Subject":"Re: [PATCH v2 07/20] hw/net/can: Fix type conflict of GLib function\n pointers","Message-ID":"<aAukWsGgmQS5NZ1w@xse-figlesia-l2.amd.com>","References":"<cover.1745295397.git.ktokunaga.mail@gmail.com>\n <4d47a75c5768c9a6dc5d8b3504e78837577ad70d.1745295397.git.ktokunaga.mail@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"\n <4d47a75c5768c9a6dc5d8b3504e78837577ad70d.1745295397.git.ktokunaga.mail@gmail.com>","X-ClientProxiedBy":"LO2P265CA0078.GBRP265.PROD.OUTLOOK.COM\n (2603:10a6:600:8::18) To SJ2PR12MB8739.namprd12.prod.outlook.com\n (2603:10b6:a03:549::10)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ2PR12MB8739:EE_|MN2PR12MB4078:EE_","X-MS-Office365-Filtering-Correlation-Id":"29ee9a65-2667-47a2-16cc-08dd840a6e68","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|7416014|7053199007;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?7JnDumJeqxVZH9eyZelpbdmE4W9yV2O?=\n\t=?utf-8?q?baiLwliZstFEVrTjku13EPrzDs0C5pgMfGkq3yjC6Zhp8aqduDAPmx98L32xLWuoH?=\n\t=?utf-8?q?4AkG+4ew23C+wsHz6hlsO13bXA4tDvxorbP9Paos82gMxr5UrqmdRDcOPaSEseZtC?=\n\t=?utf-8?q?TFUvsM079WfXTMiGks5swTjp9MoL0bp2IbRK/CpRYb07nHL6w1JmWCwUB+pL5xhv8?=\n\t=?utf-8?q?DxpmLtb8rqPKMJtGidPpkn88lvZljqBBX1oTROyEHDWkGPCbyt6OsyypCk7YGpD6w?=\n\t=?utf-8?q?QOxEUGLoGNuxYN/9UO+oN0DB6ANM/GjjijJR3Ee13+MJQ1X6oiAAfvm2MTpqBmRkA?=\n\t=?utf-8?q?LDw4bsY0pJefHitR1gxjLIVZhwIvxsxrBZdYRF1ThgabdVK0g7pWGgb2dxfuTVkZW?=\n\t=?utf-8?q?1cC/3imze2yLBtpCwChEtikJzSlb6m/Mdvbzs0Adw1l496xWfteiK50+QNSNyqCdR?=\n\t=?utf-8?q?NTIbLTDnALgec60tvD/bx84s67EA4KIHixGkWPlt2FJSg9efIfYZaKMH2Ss1sba+B?=\n\t=?utf-8?q?eCbGykGsY77RFIAv8uYz842XkLfEYdMsF8NDTtpW8uM8r6RvrK3qIFjej36jtciyz?=\n\t=?utf-8?q?Fa4/hOdPtQbSVKBGFTYUxbJw3eNEaKAl8G2F+ZfYc3TGOnwtFqdZlRwSM6hpdfDCV?=\n\t=?utf-8?q?t0aE0Rr9uzMKTTy2HR01iggaXNrMEZ4N3TNNnk/ThSagoZJLFaWnzjsJhl39owdKb?=\n\t=?utf-8?q?ePsIIMmZyFawPIT/eIM2z5z037ijisR2D87If/pRlT8QmYf+NzonzVULXpElJlr5N?=\n\t=?utf-8?q?AoT5x/+fMpd3QpCdUuHX2AQa3PzEge721qUByQmu/+Kd/LSGwpbo9WZbBfwB7aX1O?=\n\t=?utf-8?q?AKe5z/RsRx0WuQd3k3z07cMAaJk6T6xUr0SYmp03LnRHTbSb3PvO/EXCW99cc1MvE?=\n\t=?utf-8?q?GiFh9AnoHOJYeG1zmBnN/pIy+pYTUM7adWfjJddUX/Gr1tHeSOxOmp/vwIjpoc4Vw?=\n\t=?utf-8?q?+xYC7V2u6KKuuK6LvKWMhjzZDuor2LI+MVarR/8KLpIeRrrjdHhhAFcs6iyN1iGnU?=\n\t=?utf-8?q?ZgoZ/AvNnI2eSaMLKOhsIvxIY0jGq33vSPZAkcBDeNOftawbGo6UiMuN+EVkm34xw?=\n\t=?utf-8?q?5LuRb0QDkYYlTpHou+C92QKWqbAjZYWKf9FHW8s1sE/ONp2PSRg123DCggvvKOdPm?=\n\t=?utf-8?q?f5WBRFOa/jLfc8wOP0Lq2V/1cazqzaS+BIk46nfc8Olh9JZjNqaO7L4P2c8ejZ2/A?=\n\t=?utf-8?q?Z6B+Kz9V978hh2RJ3sVXLiKyx6RF9/8rVhWvYTJ70qt9Yc+/x1kqq+tUhePbZPfgc?=\n\t=?utf-8?q?Y5eJINlnMHUwcNM5wKTcVyL/h0hpTkgTfwlTwXnQmAMx9iiQ9SeqlcSDN/r2FmYq4?=\n\t=?utf-8?q?/GI8OWWTlj/Y4hwRoARQyi+CE3h6grBfTmDXyb8fXSYNTDHZ6lixnrI=3D?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ2PR12MB8739.namprd12.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(7416014)(7053199007); DIR:OUT;\n SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?Sgqo2cuqv1iauqmcx7vrTWzEMySI?=\n\t=?utf-8?q?hc98F4lvJ7G39HLTG+kxwiWdQ1Oc/ycKo7mSeRHdgd6Eze/33Hi6AHPI2vGy5cwYy?=\n\t=?utf-8?q?C1N6NwOondN/97OVAnbR9PaM7tEmJi8gVpp0ZY+yuEAhZeL9BcT2pKdfC9PZiCoUn?=\n\t=?utf-8?q?c13B02mTyqKNxZTLDJnGaoYIf+3l3cbz/Szop64yv0jnsb/to5vCZRWOt/lOsyynj?=\n\t=?utf-8?q?RXEMVbL/T+NlwNFh3HlMhpRmpMhcxQH65vS2TRXw68HPGiQXy/sBfqr9cOlPaGfPn?=\n\t=?utf-8?q?M/nTO+jZnRoyMOmmrbsK50bGChiqpGr5fvZ47ZgUQYKLIblv0oKPPQgEbxXkxGG6h?=\n\t=?utf-8?q?fX8aUt3frTJIs9PK7g0P3ib0k2C991FgvQPQvFhHjwy5/GotPKnvV3La4kyGy5lMS?=\n\t=?utf-8?q?EJlb8Q/4PQmPDgOUVsaFOGL2NSs3Fq6orjr1VGlyDxpumFcdRsmw84c7wpmnnZOxH?=\n\t=?utf-8?q?adNqlfiJ8Fo2Wu+aGWyKPqMlwXU4uG5plT9lUtoE7GN/AJcS8Yo27PJoP01oXcKyA?=\n\t=?utf-8?q?0af3bFe0ZUFt7Ih7HgIvX2aD9vDgNnE1aAI6gYVUjgycGOyioMebVNyc/LJT0xrSR?=\n\t=?utf-8?q?sv9IKu7vKrj1gQsvVT7IHhOXsycbaX9TndzDk3KCAPgUAyTvJEtn3B5dG+chUYFRq?=\n\t=?utf-8?q?X1T4q4MC9ukFAp1sHY3BUZFGQQSn4ICobqXLywt7sk4rvCH/+szA8nC1YN6O+t2Qe?=\n\t=?utf-8?q?HOmpO8gmOomCMDtOQlN5Bn/IETh1hhbt5xDfgd+xBQnaECKx6GupZIwnndeYjYxXc?=\n\t=?utf-8?q?+SKEO+bNM0r6SdvWXir73KyR0Lfe+6U2iuQxLqErVSVjR5X9CQwHgSLz7ay5j9LDi?=\n\t=?utf-8?q?7GmXwDtLZfrHnL6QFQeQjnBFF1Jwyt9lQyMVo7ygcSLws8Th+1kpRrm4d0wBopHl4?=\n\t=?utf-8?q?qGD42rvo+Q4chN2H2iSAbv9NeMdscwaXMd/ietGVqi/y1EsV7PksOJLJX02qcz3F7?=\n\t=?utf-8?q?jkFcHC+eg2kAGVHvNFWnN0e7dUcuclzjUqYmcR2SIna5QtXIviNjeSVhQS9/KJKYV?=\n\t=?utf-8?q?ZdymkZP0v12Ye7Rcz0+5zgpcTZDkR89tFaJ/KUV8HWwIXIx4RxCqzfwS0P5mVFVSN?=\n\t=?utf-8?q?SiW5+UbfSCeIC6ub+MxkR3R7kS+gc8M8wKvrG3/O72d9JDCD5x4sGPhCQs7yAY/Nh?=\n\t=?utf-8?q?LdHQFc3tXi+BSPWDR9f9sv8/Sxl5UfweERIEEQAvF8w52zAO5gAsr0U57DA4r3byY?=\n\t=?utf-8?q?S/zp+lHQeHFYpFWHN1YXMFmNnde8ztPY2H9jkC0fSL+5NyWKHRni827G5f6S/STGB?=\n\t=?utf-8?q?i0bap2yTEgtXs1Wtj3zqAonYs9USyRMH3Qym6OuI3a1QV8NBW7nhZileoSj5/eDQ6?=\n\t=?utf-8?q?/Gk2YLA+yov272qSQkxE+elgSM63TP0koMw0/o19l2grhtjprbGCQg0t6LbQu7CM2?=\n\t=?utf-8?q?9gEGToI3+B3tTqoKf85s54RT2ydOJe6zs5eCOacyCGb5Wklbb4tXcbnAUQyacvPfw?=\n\t=?utf-8?q?hBwyHsXPaYwlq9oB6m7YG2q0gvVjKeIJbEuCDydFMNnOuLfTIcOHpdukLnzewpRo2?=\n\t=?utf-8?q?+x4seauKO5CJ?=","X-OriginatorOrg":"amd.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 29ee9a65-2667-47a2-16cc-08dd840a6e68","X-MS-Exchange-CrossTenant-AuthSource":"SJ2PR12MB8739.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"25 Apr 2025 15:04:09.6270 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"3dd8961f-e488-4e60-8e11-a82d994e183d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 4BhB9Ddq6KIyr0OELyonMjbbvUeaBuuBWzhA0jfEZqV38rn37VojTUd1WzIYsRhOIDNpTkcn51SWKEhIuGMR9Q==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MN2PR12MB4078","Received-SPF":"permerror client-ip=2a01:111:f403:2415::605;\n envelope-from=francisco.iglesias@amd.com;\n helo=NAM11-DM6-obe.outbound.protection.outlook.com","X-Spam_score_int":"-23","X-Spam_score":"-2.4","X-Spam_bar":"--","X-Spam_report":"(-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.314,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]