[{"id":3502343,"web_url":"http://patchwork.ozlabs.org/comment/3502343/","msgid":"<5b7afc3e-d5d3-4485-96ab-a1b212644607@linaro.org>","list_archive_url":null,"date":"2025-04-25T14:53:04","subject":"Re: [PATCH v2 04/20] target/arm/helper.c: Fix type conflict of GLib\n function pointers","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"Hi Kohei,\n\nOn 22/4/25 07:27, Kohei Tokunaga wrote:\n> On Emscripten, function pointer casts can result in runtime failures due to\n> strict function signature checks. This affects the use of g_list_sort and\n> g_slist_sort, which internally perform function pointer casts that are not\n> supported by Emscripten. To avoid these issues, g_list_sort_with_data and\n> g_slist_sort_with_data should be used instead, as they do not rely on\n> function pointer casting.\n> \n> Signed-off-by: Kohei Tokunaga \n> ---\n> target/arm/helper.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> V2:\n> - Updated the commit message to explicitly explain that function pointer\n> casts are performed internally by GLib.\n> \n> diff --git a/target/arm/helper.c b/target/arm/helper.c\n> index bb445e30cd..05793a6c97 100644\n> --- a/target/arm/helper.c\n> +++ b/target/arm/helper.c\n> @@ -220,7 +220,7 @@ static void count_cpreg(gpointer key, gpointer opaque)\n> }\n> }\n> \n> -static gint cpreg_key_compare(gconstpointer a, gconstpointer b)\n> +static gint cpreg_key_compare(gconstpointer a, gconstpointer b, void *d)\n\nWhy not use a gpointer for @d like in other patches?\n\n> {\n> uint64_t aidx = cpreg_to_kvm_id((uintptr_t)a);\n> uint64_t bidx = cpreg_to_kvm_id((uintptr_t)b);\n> @@ -244,7 +244,7 @@ void init_cpreg_list(ARMCPU *cpu)\n> int arraylen;\n> \n> keys = g_hash_table_get_keys(cpu->cp_regs);\n> - keys = g_list_sort(keys, cpreg_key_compare);\n> + keys = g_list_sort_with_data(keys, cpreg_key_compare, NULL);\n> \n> cpu->cpreg_array_len = 0;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=fgvd5pBx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZkbRz1D6Dz1yMm\n\tfor ; Sat, 26 Apr 2025 00:53:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u8KQU-0003DX-Bx; Fri, 25 Apr 2025 10:53:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1u8KQR-00039W-Dr\n for qemu-devel@nongnu.org; Fri, 25 Apr 2025 10:53:11 -0400","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1u8KQP-0007nx-31\n for qemu-devel@nongnu.org; Fri, 25 Apr 2025 10:53:10 -0400","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-43ea40a6e98so22270435e9.1\n for ; Fri, 25 Apr 2025 07:53:08 -0700 (PDT)","from [192.168.69.226] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-440a5303c15sm27051805e9.11.2025.04.25.07.53.05\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 25 Apr 2025 07:53:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1745592787; x=1746197587; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=dUNdomSLMAMAzzETVkOXhBvDhET6oTmnmbhrlDPxTkc=;\n b=fgvd5pBxYHg8Jl3fiRLumnOxokV5UvbeEthQUdzVRPoTghllNPJgV15leGU7OywQz/\n ECpWWALu+s3GEUfL0CIV+2brhBNbYmZvZqU2S8+qB/4wAOozOtXSuSKZyT7qRo8N+9r2\n LVOS7tw5b7mbmH8AQz1MWAfiHnF4Pwog6S9QEKj5ihIJ/4jtfL5y8lOrL+0LFZSGvpdU\n wAi7cSWLJCd2Tsj1G8lXspQFs71gWobEHclISoFMxOH6qn+O7oRPzLQEPslNBqPecZhK\n PzqvujW7yTJVeXWgCu21pvtS+F2yQeAiwxCrjwTncy82Yj2dVQzMYCuRlN03xCLq5C6U\n blWQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745592787; x=1746197587;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=dUNdomSLMAMAzzETVkOXhBvDhET6oTmnmbhrlDPxTkc=;\n b=pj05WZDbO4nakLCubVaqNHmL7c8LNOpHChX76HuzD1OyB08MKHIYeZ6lMGe9fdhU02\n 0Q+9k03PIkYuyvrB2eN/3qBqpjYSHjge6w8yszs72gE2fzxVz+rYpWMgUPx6H5+aod3Z\n NmlqtB4h+Q9RMuZvqIdsR4jBFsQn8pesvdmA1g0g9tYg+IXujQxOygTuSB3LccYG6kRU\n a5ISW+AxFExf0MS5o+mLywZI/ygC2isMgUNjjK5aUn16zyRDvBRyJYCZo5z6rD1R+TNL\n wT0Gl5p/d0gnmR9wdMv5GJhDQflRL3+Dp3B3ULqsNcC2fR+iMhBjPR5ria8L5HU/pVaL\n 8z/w==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUyYadRNCkOtkLGWgmmcU0sXv5tSUuFsTHjjUUon0ahzXw/HWUIx56lbh9AHtSIPZLoW4kX8cjysFAp@nongnu.org","X-Gm-Message-State":"AOJu0YwMeqYSdaxeMhjoC22n6VlnR632Mx3PX2+tsBDJdza0V1iUBN+d\n Fr/1DdPYxiI/WSAH61msjT81x+BRQ8LEdK4VBEu1B8Cj2x19XRgQpzI5QE6VmruJKxdHdKtex3m\n H","X-Gm-Gg":"ASbGncteyqk0D6VtCTnIc7eyrJlWMPSNi0vxmHov1uc5NhsOlE3A5+hIYrT11kgfoWF\n nwZ6OLV5gt55L4gVhqnBDSRPaRSHF6kRHCC/+MUZnkLAs/wJ5O7Kuk+eB5+quQjohjrnry1v23G\n uDM7XvPjk6fLztoXHz0xXVuQrUWTOJh72Pt7/vYKnZZ7RDye//qnGPVaSbrRiLx9t45Soy1LagC\n kGxoH/lL2vS947tuz2w0xENQlJpHjRZZ3YdbK/jQJPSatyETgwwVgodxIOiSwuAFQTEX53FVYKk\n U3iFjfYY/GavvOjW4Lmw9eWHjLkI1EIbxowhdxb+108RjfVBz9ZWiXbm758/kiu2R9MEJvpG/3b\n 2FtDGyDyn","X-Google-Smtp-Source":"\n AGHT+IFACxj+c2eF1ItU+T531+Ds66WdauIfs8lhn5+qYkE3vP3oZJahvoUyRmW2pxXeO8K7N7aPdg==","X-Received":"by 2002:a05:600c:1547:b0:43c:fa24:873e with SMTP id\n 5b1f17b1804b1-440a65d8d6emr27324645e9.13.1745592787197;\n Fri, 25 Apr 2025 07:53:07 -0700 (PDT)","Message-ID":"<5b7afc3e-d5d3-4485-96ab-a1b212644607@linaro.org>","Date":"Fri, 25 Apr 2025 16:53:04 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 04/20] target/arm/helper.c: Fix type conflict of GLib\n function pointers","To":"Kohei Tokunaga , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Paolo Bonzini ,\n Alexandre Iooss , Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","References":"\n <01b21c849b459660453eb905d12ff0da4c65f53c.1745295397.git.ktokunaga.mail@gmail.com>","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"\n <01b21c849b459660453eb905d12ff0da4c65f53c.1745295397.git.ktokunaga.mail@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3502716,"web_url":"http://patchwork.ozlabs.org/comment/3502716/","msgid":"","list_archive_url":null,"date":"2025-04-26T06:38:47","subject":"Re: [PATCH v2 04/20] target/arm/helper.c: Fix type conflict of GLib\n function pointers","submitter":{"id":90637,"url":"http://patchwork.ozlabs.org/api/people/90637/","name":"Kohei Tokunaga","email":"ktokunaga.mail@gmail.com"},"content":"Hi Philippe,\n\n> Why not use a gpointer for @d like in other patches?\n\nThank you for the feedback. I'll fix this to use a gpointer in the next\nversion of the series.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=Uy+DFBUC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Zl0SD5Y23z1yMx\n\tfor ; Sat, 26 Apr 2025 16:39:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u8ZBp-0007HV-Kq; Sat, 26 Apr 2025 02:39:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1u8ZBn-0007Ft-8a; Sat, 26 Apr 2025 02:39:03 -0400","from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1u8ZBl-0008Dh-Jk; Sat, 26 Apr 2025 02:39:03 -0400","by mail-pf1-x42b.google.com with SMTP id\n d2e1a72fcca58-73bb647eb23so2623848b3a.0;\n Fri, 25 Apr 2025 23:38:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1745649538; x=1746254338; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=/T1LZKwySduyRo2h0IOtfFdSgYkIBmpQV9h3xYV3Y5s=;\n b=Uy+DFBUC4ZFiBKmjMxba0PB/7EgLeKm/O1lCXGD2RHNx8RSqhGkLeF0tmZv1uQTGxG\n 6UKIaVjMuEPVZaDrFWWG/DnVzPHxTAqpWzYtM9HqetMtWBwM3tngB5zPCsEARp/kDDxr\n eVfmRuo4rdFE75f3scB2DXhxRICUrmbWtfJLdUr5BFuyZEc0HohjBFPh53F159PmAQ1x\n Hdx6sm2ea82v2TlmsGXcXMuKeJoIIFCvLFsRaDpFr4ekdTQYoy45deiP4x/J+AeYAoil\n K6DM7kk4eB216pMzMpicdi8WVeoSpa3yeyVzUFqC25CibaBO/t6c/GLhP7f/hJtAylB7\n O+Qg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745649538; x=1746254338;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=/T1LZKwySduyRo2h0IOtfFdSgYkIBmpQV9h3xYV3Y5s=;\n b=fK3EM9UyeBmIgar54nZjUTPRAOJ5rp0xxTr768YX4dgH0hdiXC0Rs8/W8vC4xqJL2G\n 6B+brgDnzilTu9rJlqzUDVqPvodfzKBoZdmqHmpIgkr195bbBlUd5kuGnk78oRYvoIS0\n Sy8JGOtau021lNTO+WBH+i9hGOTtfZN9fYTg7XVhkF6rALaFkP/jp1gD/Okb9FZYCwuH\n MC5yaTxXMrs/O9D0+L+hw/qZ5P5JjvKqlrZC6LCZDmIcRA4jFVeysf9/swY6nCRaz0qf\n X9BddjeCy7rfZBtfM9gTqLwcCGkv06zu17oYhe5REjrtMgKKwhhG+Lc9p+ztvUYU/kIc\n B/7A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCU1lPlo8u58ubQ/nLj8qI8DXmBfUc6lONFSxbHsiuJixSctZ5i9F6tojpB5Yz/tiY5ckPRC5Le0J42ZuA==@nongnu.org,\n AJvYcCUzydWbhmJmu57iLAMY1x9bX1J8byeDJw2QI5ai+u1OpAfUXE8vrmJiTkNNzhWYo3dXH/NxWdeD3Q==@nongnu.org,\n AJvYcCVHWMv4wn+3EJMcYS1B0E3U5gAwmCg9fQy//Rbq9wUxzV/USXtfBNpJWfjqiMJh0ZQDNhrAH9Yb0Bp3uQ==@nongnu.org,\n AJvYcCW+4aY2ALYwO7e7GJ8ng8T5x2YrTueh4u3hu3oXzPAgh+qIyumAipMM0z5biryveTJJsRnmIxutj4g=@nongnu.org,\n AJvYcCXLmWAot+jtuAlL7fmnpkezN5Ru+mQUDSlq3mtUCjPJxL5qrLu4gt4lJkPxIYTdeEAKjBq4E12igiEGhg==@nongnu.org","X-Gm-Message-State":"AOJu0YywFLsKtZ3CL4nuGFDtXaM8HFqZylYq02p5A/IzY+iwNBHGDs/1\n +79EneH6jWAjmZX7pu+YVAuxq3g0f+AZVTLseKs6/bTmpwijuujUcmaYFgGWxj1asH7dBJYNyN/\n yzXhiKiC/fLreQ9BXeh5YLicAkj4=","X-Gm-Gg":"ASbGnct47M86xsUiLO8kldLWeOnISMUzhis8B7H2ILRVNPjGb043yclon3P+6v/KZMg\n RGoVIMaNuE4OxCCQ9zl4oYwLZjX+EwQe1nky0QFQNttHoyf1yiA+v6xUZsmLhv7iIYV8qqrgklc\n 9cbj/RNyP7uPaxluEi+ANcNnEb2/IWe8FBm/UrByAbTVwgzfVy/tbR","X-Google-Smtp-Source":"\n AGHT+IHPfSQkkpkcBFSfcIVQOJdr8vuupIRlsf58kYnTZTu9jfM8osjgQAZcyGwfjotTwU7n4se3juPAMjXfY/btnLg=","X-Received":"by 2002:a17:90b:3504:b0:2ee:f22a:61dd with SMTP id\n 98e67ed59e1d1-30a013bac35mr2692858a91.32.1745649538523; Fri, 25 Apr 2025\n 23:38:58 -0700 (PDT)","MIME-Version":"1.0","References":"\n <01b21c849b459660453eb905d12ff0da4c65f53c.1745295397.git.ktokunaga.mail@gmail.com>\n <5b7afc3e-d5d3-4485-96ab-a1b212644607@linaro.org>","In-Reply-To":"<5b7afc3e-d5d3-4485-96ab-a1b212644607@linaro.org>","From":"Kohei Tokunaga ","Date":"Sat, 26 Apr 2025 15:38:47 +0900","X-Gm-Features":"ATxdqUEudJEQciex8VkQsUG2VLwhDymMM4jg3D4EAR_WFlPPRlIFWXCgzUkbd-w","Message-ID":"\n ","Subject":"Re: [PATCH v2 04/20] target/arm/helper.c: Fix type conflict of GLib\n function pointers","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Paolo Bonzini ,\n Alexandre Iooss ,\n Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","Content-Type":"multipart/alternative; boundary=\"000000000000a567c50633a8b425\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::42b;\n envelope-from=ktokunaga.mail@gmail.com; helo=mail-pf1-x42b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]