[{"id":3502346,"web_url":"http://patchwork.ozlabs.org/comment/3502346/","msgid":"<554241c9-1bc7-4b05-8c1c-a80cd44d2ae9@linaro.org>","list_archive_url":null,"date":"2025-04-25T14:53:32","subject":"Re: [PATCH v2 02/20] qom/object.c: Fix type conflict of GLib function\n pointers","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 22/4/25 07:27, Kohei Tokunaga wrote:\n> On Emscripten, function pointer casts can result in runtime failures due to\n> strict function signature checks. This affects the use of g_list_sort and\n> g_slist_sort, which internally perform function pointer casts that are not\n> supported by Emscripten. To avoid these issues, g_list_sort_with_data and\n> g_slist_sort_with_data should be used instead, as they do not rely on\n> function pointer casting.\n> \n> Signed-off-by: Kohei Tokunaga \n> ---\n> qom/object.c | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=GHwsR1GE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZkbSw2xVPz1yMm\n\tfor ; Sat, 26 Apr 2025 00:53:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1u8KQw-0003l3-Li; Fri, 25 Apr 2025 10:53:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1u8KQs-0003eo-M9\n for qemu-devel@nongnu.org; Fri, 25 Apr 2025 10:53:39 -0400","from mail-wr1-x432.google.com ([2a00:1450:4864:20::432])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1u8KQq-0007q9-MU\n for qemu-devel@nongnu.org; Fri, 25 Apr 2025 10:53:38 -0400","by mail-wr1-x432.google.com with SMTP id\n ffacd0b85a97d-39ac8e7688aso1453246f8f.2\n for ; Fri, 25 Apr 2025 07:53:36 -0700 (PDT)","from [192.168.69.226] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3a073c8ca72sm2543614f8f.4.2025.04.25.07.53.33\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 25 Apr 2025 07:53:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1745592815; x=1746197615; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=wf9Oi6RXI8od/ky+2U6tBOV5Z9gdYLa8whtijbKV9xA=;\n b=GHwsR1GEpQUswl6NbZk26lB7J5yv/7j6XutmHFzF4RUmkeiLrXN+0jQn0M57lkAZ4y\n /u/rk3bM+sNhUVEtOu4yZe2HD6e/YTRGf4EULmubhU2fdTyw0ga+xeTC19ApnJQOPY28\n q/HGkyqCLPUDuogf59M/NVXXtctKjphiYeu6SR3iHtS5BFWWTgaGztRqzccOGtOs34LN\n ldv0IOMGAQPWVOzxIyv3T5ACA/KFaUpgpBS4TddXRalWd2wd84AfE++IjY+dXRm8jXJs\n ldbzMLLGO0OCYAYxfoeuOoxsow841mARf06+seBs6F1z+nv0+I7dQ3oKL66qelNe7hvA\n qzRw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1745592815; x=1746197615;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=wf9Oi6RXI8od/ky+2U6tBOV5Z9gdYLa8whtijbKV9xA=;\n b=ulx0TmCfVutQ8Yu8NGzy4BJWb5E9nuszqz0jDVUswiKJG2qhiTxGoNNuhnqwizS7L6\n /4oRexUQRTU5wIbVvt/Y+Xuu/FXXOZIQq9Ej1BaAgkGCigtcrtHCu5In0fzHuNaONe5M\n vTjhhcNxvcTA6jIKIynhShEXgs495zbaPiqROSraqES/iBFEllVoQV5ZO93IlpWe3YtX\n Iu8gPz9pI0q7Evj8mGbYZh/cKr57jpmL9aRgpcOtDfwY1NBLU+YDlohcO9AlQPZ3aoHA\n ORkDjMmsATUPidPR/E9ELZombprvaYo7wGedBVMz/EHoY1n7wzg2OM19CP2AYoznePB8\n rogA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVyqD4VbzL9hFwK2TzLg8OIO5q8jhkKklqC0j6JDEB1ixALyzCk2r4wdpVsVY9edxs6AURUy7BxCWRd@nongnu.org","X-Gm-Message-State":"AOJu0YwYx2ckDofaGljAbwFriGjj0ZU/pkUut6qZyoe7BNjQoNLVpDm2\n 5nSvRkU4tBk/Z3Stw8tftnEyrfBxNvkfRiGZDH5U5wSLgzHTZ/QyhUzChfPPhIs=","X-Gm-Gg":"ASbGncvMcSDakbDCuY8kGDBCN21GKu9FSOfkEoemtt683/0r8PHqTctwPzkTgi1bJPf\n JFwDG9kDRaZYAZeGSXlly8HpvE2jWItdESxfHAYcbixjiMkyuJuJdgOIY9IGRSf1kg6QU7GJmdr\n hMP3pVo86xkQBVgHJJEZv6rq8bWso0p9g9/P5cCFohXCGe95wKgOGwvkOU9jCljnBacQET7AshF\n p1L4cpSDYJfOEf/QANkZB1fjMNyRfQ541ZEqvXxuXPSqTIVgdxzNeiNkuLEj+b+M8KhfHABiyc2\n mAtCnXzPUuBru2AdABxNjNwaB3yW6RWMqI68DXX1EBTObiJdw+LSYpctrMGUMd9cW80XcMdyFca\n 0bjRJ7REz","X-Google-Smtp-Source":"\n AGHT+IHU6OdKhIhGldbUGA9NCxoGCkDJIm8moWgxc0hzHo+BeqQdWwtHxgbEmEbz6YCbQ41bwhW77A==","X-Received":"by 2002:a05:6000:4028:b0:39e:cbf3:2660 with SMTP id\n ffacd0b85a97d-3a074e0dea0mr1974523f8f.3.1745592815067;\n Fri, 25 Apr 2025 07:53:35 -0700 (PDT)","Message-ID":"<554241c9-1bc7-4b05-8c1c-a80cd44d2ae9@linaro.org>","Date":"Fri, 25 Apr 2025 16:53:32 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 02/20] qom/object.c: Fix type conflict of GLib function\n pointers","To":"Kohei Tokunaga , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Thomas Huth , Kevin Wolf ,\n Hanna Reitz , Paolo Bonzini ,\n Alexandre Iooss , Mahmoud Mandour ,\n Pierrick Bouvier ,\n Pavel Pisa ,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Eduardo Habkost , Peter Xu ,\n David Hildenbrand ,\n Peter Maydell , Zhao Liu ,\n Nicholas Piggin ,\n Daniel Henrique Barboza ,\n Richard Henderson ,\n Ilya Leoshkevich , Stefan Hajnoczi ,\n qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n qemu-s390x@nongnu.org","References":"\n <8ca13f4e2b9eba9d1f6030b0afb442a24330e463.1745295397.git.ktokunaga.mail@gmail.com>","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"\n <8ca13f4e2b9eba9d1f6030b0afb442a24330e463.1745295397.git.ktokunaga.mail@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::432;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]