[{"id":3476883,"web_url":"http://patchwork.ozlabs.org/comment/3476883/","msgid":"","list_archive_url":null,"date":"2025-03-11T15:05:58","subject":"Re: [PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 7/3/25 22:56, Pierrick Bouvier wrote:\n> Reviewed-by: Richard Henderson \n> Signed-off-by: Pierrick Bouvier \n> ---\n> include/hw/hyperv/hyperv.h | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/hw/hyperv/hyperv.h b/include/hw/hyperv/hyperv.h\n> index d717b4e13d4..63a8b65278f 100644\n> --- a/include/hw/hyperv/hyperv.h\n> +++ b/include/hw/hyperv/hyperv.h\n> @@ -10,7 +10,8 @@\n> #ifndef HW_HYPERV_HYPERV_H\n> #define HW_HYPERV_HYPERV_H\n> \n> -#include \"cpu-qom.h\"\n> +#include \"exec/hwaddr.h\"\n> +#include \"hw/core/cpu.h\"\n\nI don't see where \"hw/core/cpu.h\" is used.\n\n> #include \"hw/hyperv/hyperv-proto.h\"\n> \n> typedef struct HvSintRoute HvSintRoute;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=DeVHpiCZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZBxt05GDmz1yVR\n\tfor ; Wed, 12 Mar 2025 02:06:16 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1ts1BI-0000wl-OW; Tue, 11 Mar 2025 11:06:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1ts1BH-0000wQ-13\n for qemu-devel@nongnu.org; Tue, 11 Mar 2025 11:06:07 -0400","from mail-wr1-x436.google.com ([2a00:1450:4864:20::436])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1ts1BC-0001YG-5t\n for qemu-devel@nongnu.org; Tue, 11 Mar 2025 11:06:06 -0400","by mail-wr1-x436.google.com with SMTP id\n ffacd0b85a97d-39140bd6317so2141588f8f.1\n for ; Tue, 11 Mar 2025 08:06:01 -0700 (PDT)","from [192.168.69.199] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-3912bfdfddcsm18698919f8f.35.2025.03.11.08.05.59\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 11 Mar 2025 08:05:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1741705560; x=1742310360; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=V4xeRGjEFsgqkoiQZNkXJzWrqF+c0kZU5Qa9D4av9Nk=;\n b=DeVHpiCZ9jBR/oLNYK4ydWxKi1GGnFi+GjivW/43j9Oo6E+jmbyCRE0eDupUnwMvP5\n eBI98cExR2rrerwMT3kpIXmcTUNuDMz92Tok+TaPgxAFq0/Wcfnjl184gMEsSN/tKpeP\n N4athfPdYBCjLUMdA+bRGosuJw15KFfiQZ/Ztan+FW/C0myx/ykQia9VJffwtmiS3BTh\n Z/TE/Htf+F+7BVek0f+Kb8dIFnjjTZY79slb2LwKGQHRhnXlFtws7brLzc+28+jt7vrP\n LfMXjOfZL2uHDfljFGIWNcKtqhz+iAmWYp3DIZw5ZHxh3Yp4BzAOdOIaf29yoeZ5Mqgr\n A/ig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1741705560; x=1742310360;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=V4xeRGjEFsgqkoiQZNkXJzWrqF+c0kZU5Qa9D4av9Nk=;\n b=QqlAj1ggmI5SH9qbZZtMxAHs9fBIVGQ+sappJ8207h0HxdcSGsf9itqzsx2VJEQ/z4\n 4cyh7VFMjaSxfEzMSzdEqgsRuuLTAH5OUEXnBTr07CcBLb9FsjMID2/2AOCvsTSQOq5w\n NrJPTIPiIBP4WlZ7Vc8jrnwfuI1A1gaS+7M3DyNFz67atykZKq2FVRk/mQtkUDg1c09I\n r0wFWpOKZmfzNr+ZJuZNHlYsDMfgOmXv1sjbaThSIIdOFEu2XXwSj+FUd3vyHJKpiE8k\n JMk/RCOFpOHd8k3JhYix5S1ZZ1ieczEl5eoG4dh029pqIMBd0oXkAm7odTBSjBNLF+Cq\n qzvw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX/tDtpJg80o4J7SDHJOejxUd35xb5bzuiukHcUDLq/7SAZ0yz22gBPYQq4O+zi1m/8xRQOHgcykU6O@nongnu.org","X-Gm-Message-State":"AOJu0YwWVG3rKRTsqaKDkzsmt+Bv1imcHMVnKFcAa7W9c6N5NgTBX/9G\n Ab6uqP9xpALPGeErratvJS7Wm19euXfStrxfayU4xmmLwGvZ5PxnGymMjnK1sNI3Ts3gNGfynjw\n 2zug=","X-Gm-Gg":"ASbGncsqwvhELilXz1Xsy8IlIU226iIFhH8HjpKE9NBdYwvMNIdrqP+HaOVsIViUNT+\n jjUV6h7/IYr3q6h/Uz0K1Bvdci09GDTQNomXlikY8tgGVIAxhxjtcEcW83sIkDisLIFZYXNGOXm\n MJjld9tWu2Ph5SHx4T69hqm8+sTwKTAS9kxfKTuNqFW5al+E9MN9QhQHw/j8DvcjdN3mPtKsU0Q\n vy1UrVAygOLBU0u20DQ8HjoN2Ih3YWqe+9RDwTiyP0ka1OF1IZo5LX/oK4J+f3EBZq+5jXRnHtm\n 3J7dvq9y2DF7qxSS+aJiO1V+4LiyO53vc/jVDUrfz9f3X/jMFSk0URRtGbrr1YsD5H62Gi58COm\n AMdNKsuqc13+2","X-Google-Smtp-Source":"\n AGHT+IHNa12kI+fH6zt93B5q2a+mSQlQFSOW0J7tJkApAruJh0mlb9pffNZtz++Hv9gwk+saVPYaZA==","X-Received":"by 2002:a5d:64ce:0:b0:391:3bba:7f18 with SMTP id\n ffacd0b85a97d-3913bba8128mr7841333f8f.12.1741705560054;\n Tue, 11 Mar 2025 08:06:00 -0700 (PDT)","Message-ID":"","Date":"Tue, 11 Mar 2025 16:05:58 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Paolo Bonzini , kvm@vger.kernel.org,\n alex.bennee@linaro.org, Marcelo Tosatti ,\n \"Maciej S. Szmigiero\" ,\n richard.henderson@linaro.org, manos.pitsidianakis@linaro.org","References":"<20250307215623.524987-1-pierrick.bouvier@linaro.org>\n <20250307215623.524987-3-pierrick.bouvier@linaro.org>","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20250307215623.524987-3-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::436;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3476897,"web_url":"http://patchwork.ozlabs.org/comment/3476897/","msgid":"","list_archive_url":null,"date":"2025-03-11T15:14:36","subject":"Re: [PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 11/3/25 16:05, Philippe Mathieu-Daudé wrote:\n> On 7/3/25 22:56, Pierrick Bouvier wrote:\n>> Reviewed-by: Richard Henderson \n>> Signed-off-by: Pierrick Bouvier \n>> ---\n>>   include/hw/hyperv/hyperv.h | 3 ++-\n>>   1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/include/hw/hyperv/hyperv.h b/include/hw/hyperv/hyperv.h\n>> index d717b4e13d4..63a8b65278f 100644\n>> --- a/include/hw/hyperv/hyperv.h\n>> +++ b/include/hw/hyperv/hyperv.h\n>> @@ -10,7 +10,8 @@\n>>   #ifndef HW_HYPERV_HYPERV_H\n>>   #define HW_HYPERV_HYPERV_H\n>> -#include \"cpu-qom.h\"\n>> +#include \"exec/hwaddr.h\"\n>> +#include \"hw/core/cpu.h\"\n> \n> I don't see where \"hw/core/cpu.h\" is used.\n\nOK found it:\n\nstatic inline uint32_t hyperv_vp_index(CPUState *cs)\n{\n return cs->cpu_index;\n}\n\nFirst, bringing this huge header for this single use is way overkill,\nthen I doubt this method deserves to be inlined, third @cpu_index is\nan accelerator specific field, often incorrectly used. Maybe in this\ncase it is OK although, since IIUC we only support HyperV with KVM,\nright?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sYvCkXB/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZBy4B4bn7z1yVM\n\tfor ; Wed, 12 Mar 2025 02:15:06 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1ts1Jg-0000v0-6I; Tue, 11 Mar 2025 11:14:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1ts1Jc-0000rM-Ry\n for qemu-devel@nongnu.org; Tue, 11 Mar 2025 11:14:44 -0400","from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1ts1Ja-0004nL-Ev\n for qemu-devel@nongnu.org; Tue, 11 Mar 2025 11:14:44 -0400","by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-391342fc148so2738815f8f.2\n for ; Tue, 11 Mar 2025 08:14:39 -0700 (PDT)","from [192.168.69.199] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-43d032afc2esm15042685e9.2.2025.03.11.08.14.36\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 11 Mar 2025 08:14:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1741706078; x=1742310878; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n :cc:subject:date:message-id:reply-to;\n bh=nRRe0V6hTnTEa/ywDXDKo4kqBN5ZydvlC5M+vqDkq1c=;\n b=sYvCkXB/yvjkriFQsUeZVqbJPRAmf/bsMuMNo7GsD7lo5S41Hk6Amn0IvLy/x8aQfH\n h0BAC7mPl5rMqmr9LvwhjRDB3upYoiXZ5U6iiG8G10VYviuerEBnYVTc0cdafzHdwxQY\n zIuuKVhBPsVnRz+F4ujKCZW7xwTi03hvB5q56ubSeQqXHu6jbiQ/duEAp2zKaCfO3nd5\n uI/a0paFae3EETAPQiSUU2M97q0XkOGcfJZPsfuIXEIPv6i77nFjJgRfFqDN4xL0806n\n EVfZipqtoH7K4PizYFQ/+kt6HsN1VCjVDhEIYox2IaSv06mACtjxjs2s+9TfsqpNspQG\n Rm0Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1741706078; x=1742310878;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=nRRe0V6hTnTEa/ywDXDKo4kqBN5ZydvlC5M+vqDkq1c=;\n b=FMtliFi5yWbPuBolg6QICVM22mrcaXJi0LZq6WJq99N5IyKIGHRIUv9tZ25y+aofoO\n wlA5O6TAbM9cuiAMA+BEVqHjH6nYzIWz+A50fFd7Z8Kv5A24ZYmy0nUmVvUlgr4MIxHr\n pyFy+/f5anE63x9BMpdNBlGTq2mSmIpMAQ2p4iSHodIchUkVkSt5BaEZfHbZjK+EeIHI\n 6kAOlrAEveMITS071mGDPPp1P1ub6g6QRiWluDXBU+wKXZoYXojzY8H5JQRwr2FDv5EI\n C5tlzDCkcHPBaCKMTYmz/EakJS8J2q2MU5Io8ZPBGrQ59T1tBnFFQO34aO2lBgQ9nQtJ\n 3Phg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX6vZGuI6ID+DH/LeV9W00JIrwELdTg6ct0yJP8hxvmN4cUeUNMNH9d8oOCwGIb9AQrSK6LoQFT9VmF@nongnu.org","X-Gm-Message-State":"AOJu0YxMbIW2gM4XHJ7zY8EqgwA823JNW42OICogGng5/lGelDnLl6Tf\n 6aQ+DziOvWxtyf94lF9W5ZPD8jRwYho48FxRYIkhYmMB41ESmJzncFP2u9qz8Oc=","X-Gm-Gg":"ASbGncvpTr5bdfH2/AfOPOi8G1/LzzR/dfhhsGikXO2m87K2MdfgZ0hWcoeqauu5YuR\n zl2F3Mf+j0wluI8o33bL5193Dul8TiKqCrDG2a5LEjRVeqWNs4ob6vlb1KbnpTP1DhVn0wXhvXg\n iHHNOYuPDqK5WIwTkQmZ2mHk3xz49jO9t9QAdZETgY1DfwqMuEZXRQRUxdny2TlFHgq1ROlw1ke\n nt37xJRJ76dfzwxZxM6CkyzfXYk4uC22KBQPO65AxXlRhrTo/g2JIea6GUTzatqUsI8O5eNKGpk\n aVfwxjN7Ns80Ix8OhGZfWvy58N3NeSOgrF/pF/RRJgyhmS0vdN34z6QfNZlaDiTw42rDc53kZIg\n fLyLvbEgPvnxN","X-Google-Smtp-Source":"\n AGHT+IGMZq9Zv5IrDzGNXyfZard2uq17hlvG5nfa9qRcDr6dl5yVlBL8PHub5h9dwcelWjylk5GmVQ==","X-Received":"by 2002:a05:6000:18a5:b0:391:13ef:1b1b with SMTP id\n ffacd0b85a97d-3926469486emr5385934f8f.30.1741706077939;\n Tue, 11 Mar 2025 08:14:37 -0700 (PDT)","Message-ID":"","Date":"Tue, 11 Mar 2025 16:14:36 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Paolo Bonzini , kvm@vger.kernel.org,\n alex.bennee@linaro.org, Marcelo Tosatti ,\n \"Maciej S. Szmigiero\" ,\n richard.henderson@linaro.org, manos.pitsidianakis@linaro.org","References":"<20250307215623.524987-1-pierrick.bouvier@linaro.org>\n <20250307215623.524987-3-pierrick.bouvier@linaro.org>\n ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::435;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]