[{"id":470014,"web_url":"http://patchwork.ozlabs.org/comment/470014/","msgid":"<50C823B6.2040301@marvell.com>","list_archive_url":null,"date":"2012-12-12T06:27:02","subject":"[rtc-linux] Re: [PATCH 4/4] rtc: 88pm80x: update irq base","submitter":{"id":19693,"url":"http://patchwork.ozlabs.org/api/people/19693/","name":"Qing Xu","email":"qingx@marvell.com"},"content":"On 12/03/2012 01:43 PM, Qing Xu wrote:\n> From: Qing Xu \n>\n> irq base is stored in 88pm80x's drv data, we need to add irq\n> base to get the correct irq num\n>\n> Signed-off-by: Qiao Zhou \n> Signed-off-by: Qing Xu \n> ---\n> drivers/rtc/rtc-88pm80x.c | 7 ++++---\n> 1 files changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c\n> index 6367984..7c3a264 100644\n> --- a/drivers/rtc/rtc-88pm80x.c\n> +++ b/drivers/rtc/rtc-88pm80x.c\n> @@ -256,7 +256,7 @@ static int __devinit pm80x_rtc_probe(struct platform_device *pdev)\n> \tstruct pm80x_rtc_info *info;\n> \tstruct rtc_time tm;\n> \tunsigned long ticks = 0;\n> -\tint ret;\n> +\tint irq, ret;\n> \n> \tpdata = pdev->dev.platform_data;\n> \tif (pdata == NULL)\n> @@ -266,12 +266,13 @@ static int __devinit pm80x_rtc_probe(struct platform_device *pdev)\n> \t devm_kzalloc(&pdev->dev, sizeof(struct pm80x_rtc_info), GFP_KERNEL);\n> \tif (!info)\n> \t\treturn -ENOMEM;\n> -\tinfo->irq = platform_get_irq(pdev, 0);\n> -\tif (info->irq < 0) {\n> +\tirq = platform_get_irq(pdev, 0);\n> +\tif (irq < 0) {\n> \t\tdev_err(&pdev->dev, \"No IRQ resource!\\n\");\n> \t\tret = -EINVAL;\n> \t\tgoto out;\n> \t}\n> +\tinfo->irq = irq + chip->irq_base;\n> \n> \tinfo->chip = chip;\n> \tinfo->map = chip->regmap;\n\n\nSamuel,\n\nCould you help to review my patch? Thanks a lot!\n\nQing","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from mail-qc0-f190.google.com (mail-qc0-f190.google.com\n\t[209.85.216.190])\n\t(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))\n\t(Client CN \"smtp.gmail.com\",\n\tIssuer \"Google Internet Authority\" (not verified))\n\tby ozlabs.org (Postfix) with ESMTPS id E44792C00A4\n\tfor ;\n\tWed, 12 Dec 2012 17:27:19 +1100 (EST)","by mail-qc0-f190.google.com with SMTP id d10sf221608qca.17\n\tfor ;\n\tTue, 11 Dec 2012 22:27:17 -0800 (PST)","by 10.50.106.193 with SMTP id gw1mr4934738igb.2.1355293636741;\n\tTue, 11 Dec 2012 22:27:16 -0800 (PST)","by 10.50.151.210 with SMTP id us18ls1049504igb.21.gmail;\n\tTue, 11 Dec 2012 22:27:15 -0800 (PST)","by 10.66.86.6 with SMTP id l6mr238454paz.11.1355293635836;\n\tTue, 11 Dec 2012 22:27:15 -0800 (PST)","by 10.66.86.6 with SMTP id l6mr238453paz.11.1355293635826;\n\tTue, 11 Dec 2012 22:27:15 -0800 (PST)","from na3sys009aog132.obsmtp.com (na3sys009aog132.obsmtp.com\n\t[74.125.149.250])\n\tby gmr-mx.google.com with SMTP id e1si63344paz.0.2012.12.11.22.27.06\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 11 Dec 2012 22:27:15 -0800 (PST)","from MSI-MTA.marvell.com ([65.219.4.132]) (using TLSv1) by\n\tna3sys009aob132.postini.com ([74.125.148.12]) with SMTP\n\tID DSNKUMgjulHyqwTKcbp4geCLy7KfjXbA/hjZ@postini.com;\n\tTue, 11 Dec 2012 22:27:15 PST","from maili.marvell.com ([10.68.76.210]) by MSI-MTA.marvell.com\n\twith Microsoft SMTPSVC(6.0.3790.3959); \n\tTue, 11 Dec 2012 22:26:39 -0800","from [10.38.36.185] (unknown [10.38.36.185])\n\tby maili.marvell.com (Postfix) with ESMTP id 13C094E510;\n\tTue, 11 Dec 2012 22:26:37 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=x-beenthere:received-spf:message-id:date:from:user-agent\n\t:mime-version:to:cc:subject:references:in-reply-to\n\t:x-originalarrivaltime:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-google-group-id:list-post:list-help:list-archive:sender\n\t:list-subscribe:list-unsubscribe:content-type;\n\tbh=iN5eA/5FVY/wCDDB+V4oMMWX5Wa2dApQh8wykQhqlyk=;\n\tb=GbVvpxdu8GMyUuf9HHnZnxdW0UYFsvdI6NVRma8Seg3l2TWavceRcAXkhpmk+RGouz\n\tAM384HrN6eDMBnYqxFmh9tIUTndiAw9yhXA5TGIJnbMlUXj0N6xNFAYG1lPO7W4py9JJ\n\th0zxjMihYivB9YoITqfIgaT/vxeROqTZODqEOz0F5gCzC/aiwYgLAecS5cHh8BRUEPd+\n\tMepjMLXIgtVuEWr+q2zJaDDYSthKEB4jkVlB85bNgYa+APHptUC2udQIvSrkjUdUkkYC\n\tJcGXrt0SgCI6M4Wxc65uJ3kvVPT7nMqUJaj/5ZCJXUdO5ZhQ4AQBtsT3MJ7fcXwLW9i2\n\tyThQ==","X-BeenThere":"rtc-linux@googlegroups.com","Received-SPF":"neutral (google.com: 74.125.149.250 is neither permitted nor\n\tdenied by best guess record for domain of qingx@marvell.com)\n\tclient-ip=74.125.149.250; ","Message-ID":"<50C823B6.2040301@marvell.com>","Date":"Wed, 12 Dec 2012 14:27:02 +0800","From":"Qing Xu ","User-Agent":"Mozilla/5.0 (X11; Linux i686;\n\trv:14.0) Gecko/20120714 Thunderbird/14.0","MIME-Version":"1.0","To":"Qing Xu ","Cc":"\"a.zummo@towertech.it\" ,\n\tQiao Zhou ,\n\t\"sameo@linux.intel.com\" ,\n\tChao Xie ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"rtc-linux@googlegroups.com\" ","Subject":"[rtc-linux] Re: [PATCH 4/4] rtc: 88pm80x: update irq base","References":"<1354513427-21266-1-git-send-email-qingx@marvell.com>","In-Reply-To":"<1354513427-21266-1-git-send-email-qingx@marvell.com>","X-OriginalArrivalTime":"12 Dec 2012 06:26:39.0188 (UTC)\n\tFILETIME=[A4B42940:01CDD831]","X-Original-Sender":"qingx@marvell.com","X-Original-Authentication-Results":"gmr-mx.google.com;\n\tspf=neutral (google.com:\n\t74.125.149.250 is neither permitted nor denied by best guess record\n\tfor\n\tdomain of qingx@marvell.com) smtp.mail=qingx@marvell.com","Reply-To":"rtc-linux@googlegroups.com","Precedence":"list","Mailing-list":"list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com","List-ID":"","X-Google-Group-Id":"712029733259","List-Post":",\n\t","List-Help":",\n\t","List-Archive":"","Sender":"rtc-linux@googlegroups.com","List-Subscribe":",\n\t","List-Unsubscribe":",\n\t","Content-Type":"text/plain; charset=ISO-8859-1; format=flowed"}}]