[{"id":3418058,"web_url":"http://patchwork.ozlabs.org/comment/3418058/","msgid":"<6986a8a8-e20f-46d6-935a-724f8480d785@redhat.com>","list_archive_url":null,"date":"2024-11-21T19:01:46","subject":"Re: [PATCH v2 11/18] tests/functional: enable debug logging for\n QEMUMachine","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 21/11/2024 16.42, Daniel P. Berrangé wrote:\n> Set the 'qemu.machine' logger to 'DEBUG' level, to ensure we see log\n> messages related to the QEMUMachine class. Most importantly this\n> ensures we capture the full QEMU command line args for instances we\n> spawn.\n> \n> Signed-off-by: Daniel P. Berrangé \n> ---\n> tests/functional/qemu_test/testcase.py | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py\n> index f9c9de1166..e2a329c3e5 100644\n> --- a/tests/functional/qemu_test/testcase.py\n> +++ b/tests/functional/qemu_test/testcase.py\n> @@ -57,9 +57,15 @@ def setUp(self, bin_prefix):\n> self._log_fh.setFormatter(fileFormatter)\n> self.log.addHandler(self._log_fh)\n> \n> + # Capture QEMUMachine logging\n> + self.machinelog = logging.getLogger('qemu.machine')\n> + self.machinelog.setLevel(logging.DEBUG)\n> + self.machinelog.addHandler(self._log_fh)\n> +\n> def tearDown(self):\n> if \"QEMU_TEST_KEEP_SCRATCH\" not in os.environ:\n> shutil.rmtree(self.workdir)\n> + self.machinelog.removeHandler(self._log_fh)\n> self.log.removeHandler(self._log_fh)\n> \n> def main():\n\nTested-by: Thomas Huth \nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=gbEx9BHQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XvSKl29thz1yCX\n\tfor ; Fri, 22 Nov 2024 06:02:47 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1tECRM-00044h-Pr; Thu, 21 Nov 2024 14:02:09 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1tECRD-0003y3-Ma\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 14:02:00 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1tECRB-0006YL-0g\n for qemu-devel@nongnu.org; Thu, 21 Nov 2024 14:01:59 -0500","from mail-lj1-f200.google.com (mail-lj1-f200.google.com\n [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-376-DqC8RoRhNpaeZiB25EhQBQ-1; Thu, 21 Nov 2024 14:01:51 -0500","by mail-lj1-f200.google.com with SMTP id\n 38308e7fff4ca-2fb4c35f728so11280461fa.2\n for ; Thu, 21 Nov 2024 11:01:51 -0800 (PST)","from [192.168.0.7] (ip-109-42-51-70.web.vodafone.de. [109.42.51.70])\n by smtp.gmail.com with ESMTPSA id\n a640c23a62f3a-aa50b28dd8fsm4466566b.39.2024.11.21.11.01.48\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 21 Nov 2024 11:01:48 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1732215715;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=+zzY6TnuRDKolmTw3u4P7UCZ/d0RIcOlcorVAx6u3kQ=;\n b=gbEx9BHQ7vXKdxvohQXwSeebf8RAZMr3iNnriOnv2ltUQ2y3mTzCqJP7csgSGk8Qj4OKwS\n TMomJEGEdO341EvhGEDAHhRlq+D3nONiSuUa38EMVGWvYfZm6vAY0XBeQIMuxzVhFfj+fw\n WwR2CHIXAZes19ahtXjBdIE5sHRei5E=","X-MC-Unique":"DqC8RoRhNpaeZiB25EhQBQ-1","X-Mimecast-MFC-AGG-ID":"DqC8RoRhNpaeZiB25EhQBQ","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1732215710; x=1732820510;\n h=content-transfer-encoding:in-reply-to:autocrypt:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=+zzY6TnuRDKolmTw3u4P7UCZ/d0RIcOlcorVAx6u3kQ=;\n b=fPI+SvB0mr0cBVE4ttiec+0jY7+kykXdzz7ByFhhGz0yI+QQBGR5QxW/gjZjkjoZ1g\n UrMqkMVmATTHIvcxUF41Lgaw6bYFCAtUJErBlBB8sHi+XfmJeMVC1hNZ6N7ojcjQtB+m\n n0ELFLBavOn5eu7DADf8PxXzoeRi9miap+vKIZ5obyE6zMwUKmIRid3ZW9lTmQwSVYb1\n oi4NMgq0jYCVDuF9k97TBIHRwB3rAHB5y4S2qGii87CDLAYkyY1et0++TjVlFx31/YN3\n kdNnAZAlY0ZyNYkozF+CtzwAvKKGpScZmg8/8df7tiLbp2tOMSQURF3FESpkgfXsFCV2\n 6rSQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVJxCKmg24ctmtKHb30dPME6ZfOt/s4Kqc+BDppV/9oy/gU9zl/g/wnyBOc9Y8BQtCHs4ucAAtRvtMk@nongnu.org","X-Gm-Message-State":"AOJu0YyuD8XL/IAsQ/+ZjJXwum9hMOqsr8GZY+x0QQlSAUBod6AJFhTt\n frkTI+QXhtrm+JPRA+Pabw18+MsxOg+xKQN23SDemu8X3//MwG6DD/xDU3SetDGhlNXXjkZ+3Pl\n 0HYTE3EA9F7QIef1Xi3vLOvN+jHo6WEqBWB1xj6DEeM2UEbz85RDR","X-Gm-Gg":"ASbGncsLCiY13M9HZiJepZzXHsZ4cMzkPjrsWJgx1VtVwVHNGR8fNm6tXETE3/fHiia\n s5qg75hDKkixWWGNVPprda7nY4Abeq/ktMUnvVoC4Lhkvry8E4mtlMszgmDVvEv/ZKTyQCARW8C\n v1gYr3IEwn5fJl92ASImndmHYZw8B24Zm9T7/45niU1CfGlyGnr9htedLFijUgzKv4rLDbrG4SU\n Ehut5WBNSxuXPPFPHmg9fY+NLcw4Zyyo22AONSRVqQl9Kg6nD8EJEu5Z9WQbjgBJqcWIrbvTFgl\n OBc=","X-Received":["by 2002:a05:651c:509:b0:2fb:3960:9667 with SMTP id\n 38308e7fff4ca-2ff8db3068fmr77114511fa.14.1732215709624;\n Thu, 21 Nov 2024 11:01:49 -0800 (PST)","by 2002:a05:651c:509:b0:2fb:3960:9667 with SMTP id\n 38308e7fff4ca-2ff8db3068fmr77113931fa.14.1732215709047;\n Thu, 21 Nov 2024 11:01:49 -0800 (PST)"],"X-Google-Smtp-Source":"\n AGHT+IGMPA6LDaLZSAp26ic1kWPQAJJIXL5CzE6W1QfA9CmsDEAWx+zb4dLaQQPC8RzyLyRUzy7VFQ==","Message-ID":"<6986a8a8-e20f-46d6-935a-724f8480d785@redhat.com>","Date":"Thu, 21 Nov 2024 20:01:46 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 11/18] tests/functional: enable debug logging for\n QEMUMachine","To":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Ani Sinha ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ","References":"<20241121154218.1423005-1-berrange@redhat.com>\n <20241121154218.1423005-12-berrange@redhat.com>","Content-Language":"en-US","From":"Thomas Huth ","Autocrypt":"addr=thuth@redhat.com; keydata=\n xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU\n yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2\n 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW\n tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O\n 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81\n O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW\n 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH\n gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr\n 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ\n zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0\n aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW\n AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK\n QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX\n EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV\n 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD\n eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k\n ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq\n zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG\n tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6\n WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7\n UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN\n BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4\n 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa\n +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH\n 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K\n gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/\n WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ\n VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq\n knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV\n cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB\n X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM\n AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn\n ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k\n fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS\n 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK\n cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV\n ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17\n Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD\n oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs\n IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a\n yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn","In-Reply-To":"<20241121154218.1423005-12-berrange@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-21","X-Spam_score":"-2.2","X-Spam_bar":"--","X-Spam_report":"(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.14,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]