[{"id":3399771,"web_url":"http://patchwork.ozlabs.org/comment/3399771/","msgid":"","list_archive_url":null,"date":"2024-10-22T17:00:25","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On Tue, 22 Oct 2024 at 08:06, Jan Kiszka wrote:\n>\n> From: Jan Kiszka \n>\n> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n> be first used by the IOT2050 boards.\n>\n> Based on original patch by Li Hua Qian.\n>\n> Signed-off-by: Jan Kiszka \n> ---\n> include/sysinfo.h | 1 +\n> lib/smbios.c | 4 ++++\n> 2 files changed, 5 insertions(+)\n\nReviewed-by: Simon Glass \n\nWhat is this used for? Would you mind adding a comment for it? Should\nmention that it is a struct uuid\n\n>\n> diff --git a/include/sysinfo.h b/include/sysinfo.h\n> index 8a77ef44856..1c5008b5f23 100644\n> --- a/include/sysinfo.h\n> +++ b/include/sysinfo.h\n> @@ -49,6 +49,7 @@ enum sysinfo_id {\n> SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n> SYSINFO_ID_SMBIOS_SYSTEM_SKU,\n> SYSINFO_ID_SMBIOS_SYSTEM_FAMILY,\n> + SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n> SYSINFO_ID_SMBIOS_BASEBOARD_MANUFACTURER,\n> SYSINFO_ID_SMBIOS_BASEBOARD_PRODUCT,\n> SYSINFO_ID_SMBIOS_BASEBOARD_VERSION,\n> diff --git a/lib/smbios.c b/lib/smbios.c\n> index 7c24ea129eb..1441fa4cde6 100644\n> --- a/lib/smbios.c\n> +++ b/lib/smbios.c\n> @@ -387,6 +387,7 @@ static int smbios_write_type1(ulong *current, int handle,\n> struct smbios_type1 *t;\n> int len = sizeof(struct smbios_type1);\n> char *serial_str = env_get(\"serial#\");\n> + char uuid[sizeof(t->uuid)];\n>\n> t = map_sysmem(*current, len);\n> memset(t, 0, sizeof(struct smbios_type1));\n> @@ -409,6 +410,9 @@ static int smbios_write_type1(ulong *current, int handle,\n> SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n> NULL);\n> }\n> + if (!sysinfo_get_str(ctx->dev, SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n> + sizeof(uuid), uuid))\n> + strncpy((char *)t->uuid, uuid, sizeof(t->uuid));\n> t->wakeup_type = SMBIOS_WAKEUP_TYPE_UNKNOWN;\n> t->sku_number = smbios_add_prop_si(ctx, \"sku\",\n> SYSINFO_ID_SMBIOS_SYSTEM_SKU, NULL);\n> --\n> 2.43.0\n>\n\nRegards,\nSImon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=J4UZCJyL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"J4UZCJyL\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XXz2l6gTgz1xtp\n\tfor ; Wed, 23 Oct 2024 04:00:47 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id BCACC88FA7;\n\tTue, 22 Oct 2024 19:00:43 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id C2E3388ECB; Tue, 22 Oct 2024 19:00:42 +0200 (CEST)","from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com\n [IPv6:2607:f8b0:4864:20::42f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8C24F80245\n for ; Tue, 22 Oct 2024 19:00:40 +0200 (CEST)","by mail-pf1-x42f.google.com with SMTP id\n d2e1a72fcca58-71f5208217dso536441b3a.2\n for ; Tue, 22 Oct 2024 10:00:40 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1729616439; x=1730221239; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=rdUR5zvxKrrtU9sVY+rkq7UaYEDGwlGnrD62pYTsRXA=;\n b=J4UZCJyLd1BHfvcT3zfQOv1LpqQN5fb1WxJ0oYr+G1riAzhefG+gcqNtreqZTG/IZt\n LOg/NrG8BBJ6+MEqiDj9EeV0KrUxhom2UF4ErCfQ4cdpbW1f1vf0h30Gm0qpDtgUb+7E\n lgAceYbbxahM7Ph/pys35LKFludOIzSMmzzyE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1729616439; x=1730221239;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=rdUR5zvxKrrtU9sVY+rkq7UaYEDGwlGnrD62pYTsRXA=;\n b=vUFOEyHePKD5OabomrFam9bNQePT7uPD8OvhoeU6xEbScUcE+DMpHKId95ystwL4PS\n PFLX0AcRyUw6Q0Ji/MWGXKFXwvQqcCm0tS2RrxAdyQexcNFG5oF7oiFhPB4l1100gozD\n ByDZYxYPXjgJbJdDNbn7ZtIqCsGZIdbNf56FS3LItP0+UvHVPmvRb0qoMdC5f68FrXjl\n JUsLLAFQVS/RnkcqXiNa/uVKnTfzxUo+ZavcjqRdg8joPF+LFP64FzPpp0LroWViRA8x\n 7npGr6yg+TyPtZfzakmHRcIOvoARok1I73e3YQ/wTsIDZed0wtfuLZwd4DVI2KUqIYmM\n eOpg==","X-Gm-Message-State":"AOJu0YzFJsiU1+ZKQgRKImZWxNgl4PQ647tDD5QGBEirj6Z0rfhZYjNo\n Is+zvB3adPlF2Wi6qGU3+VDFcq/x5T5YD+sGZgMnVyG7pChKjSdWuh2iJ+fMEJJwMmBKFJYRCez\n oLngr0030t44BnSV1BYHHjuGPdoEofmWESXgFMeY5HZlNqtGQIK3gQdY=","X-Google-Smtp-Source":"\n AGHT+IFQ6YTwng/Bycd1mRlDRR2qTBsrdcI3sOdGC2PBcG2bkQ063gfXeCZ5EniGR+6gnC1P+e60nYhGOYXvnvTYV2I=","X-Received":"by 2002:aa7:8888:0:b0:71e:6e4a:507a with SMTP id\n d2e1a72fcca58-71ea31924eamr22853117b3a.3.1729616439048; Tue, 22 Oct 2024\n 10:00:39 -0700 (PDT)","MIME-Version":"1.0","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>","In-Reply-To":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>","From":"Simon Glass ","Date":"Tue, 22 Oct 2024 19:00:25 +0200","Message-ID":"\n ","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","To":"Jan Kiszka ","Cc":"U-Boot Mailing List , Bryan Brattlof ,\n Nishanth Menon ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3399871,"web_url":"http://patchwork.ozlabs.org/comment/3399871/","msgid":"","list_archive_url":null,"date":"2024-10-22T19:41:07","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":710,"url":"http://patchwork.ozlabs.org/api/people/710/","name":"Jan Kiszka","email":"jan.kiszka@siemens.com"},"content":"On 22.10.24 19:00, Simon Glass wrote:\n> On Tue, 22 Oct 2024 at 08:06, Jan Kiszka wrote:\n>>\n>> From: Jan Kiszka \n>>\n>> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n>> be first used by the IOT2050 boards.\n>>\n>> Based on original patch by Li Hua Qian.\n>>\n>> Signed-off-by: Jan Kiszka \n>> ---\n>> include/sysinfo.h | 1 +\n>> lib/smbios.c | 4 ++++\n>> 2 files changed, 5 insertions(+)\n> \n> Reviewed-by: Simon Glass \n> \n> What is this used for? Would you mind adding a comment for it? Should\n> mention that it is a struct uuid\n> \n\nWhat exactly is unclear here? The System UUID is a part of the SMBIOS\nspec that U-Boot just ignored so far.\n\nJan\n\n>>\n>> diff --git a/include/sysinfo.h b/include/sysinfo.h\n>> index 8a77ef44856..1c5008b5f23 100644\n>> --- a/include/sysinfo.h\n>> +++ b/include/sysinfo.h\n>> @@ -49,6 +49,7 @@ enum sysinfo_id {\n>> SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n>> SYSINFO_ID_SMBIOS_SYSTEM_SKU,\n>> SYSINFO_ID_SMBIOS_SYSTEM_FAMILY,\n>> + SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n>> SYSINFO_ID_SMBIOS_BASEBOARD_MANUFACTURER,\n>> SYSINFO_ID_SMBIOS_BASEBOARD_PRODUCT,\n>> SYSINFO_ID_SMBIOS_BASEBOARD_VERSION,\n>> diff --git a/lib/smbios.c b/lib/smbios.c\n>> index 7c24ea129eb..1441fa4cde6 100644\n>> --- a/lib/smbios.c\n>> +++ b/lib/smbios.c\n>> @@ -387,6 +387,7 @@ static int smbios_write_type1(ulong *current, int handle,\n>> struct smbios_type1 *t;\n>> int len = sizeof(struct smbios_type1);\n>> char *serial_str = env_get(\"serial#\");\n>> + char uuid[sizeof(t->uuid)];\n>>\n>> t = map_sysmem(*current, len);\n>> memset(t, 0, sizeof(struct smbios_type1));\n>> @@ -409,6 +410,9 @@ static int smbios_write_type1(ulong *current, int handle,\n>> SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n>> NULL);\n>> }\n>> + if (!sysinfo_get_str(ctx->dev, SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n>> + sizeof(uuid), uuid))\n>> + strncpy((char *)t->uuid, uuid, sizeof(t->uuid));\n>> t->wakeup_type = SMBIOS_WAKEUP_TYPE_UNKNOWN;\n>> t->sku_number = smbios_add_prop_si(ctx, \"sku\",\n>> SYSINFO_ID_SMBIOS_SYSTEM_SKU, NULL);\n>> --\n>> 2.43.0\n>>\n> \n> Regards,\n> SImon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.a=rsa-sha256\n header.s=selector2 header.b=wQFi+4H6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.b=\"wQFi+4H6\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=jan.kiszka@siemens.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=siemens.com;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XY2c16sgZz1xw3\n\tfor ; Wed, 23 Oct 2024 06:41:21 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1DB878904B;\n\tTue, 22 Oct 2024 21:41:13 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 8BE8889024; Tue, 22 Oct 2024 21:41:12 +0200 (CEST)","from EUR03-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur03on2061d.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:260c::61d])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 806BE87042\n for ; Tue, 22 Oct 2024 21:41:10 +0200 (CEST)","from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19)\n by AS2PR10MB8033.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:558::8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.16; Tue, 22 Oct\n 2024 19:41:09 +0000","from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::8fe1:7e71:cf4a:7408]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::8fe1:7e71:cf4a:7408%3]) with mapi id 15.20.8093.014; Tue, 22 Oct 2024\n 19:41:09 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=KSQthnSPbIF6I9NwMVrqybMKLWK+sgvHj5ab+bt7Uem8m8s74aJSoHHAa3YTfEEF2PEWj8bYT0/nLQUrY/Y+ZC617SCOV02b7rjJGEkeuhewfxjQVfMzC0E8n1+xNtRjFKFTJbA0o9Ac2dppz7JY3p3bkxEaokyZh9QHNPhvhN7uNHs7S4tkHdhj6HQ62QKHt4jzyMVOch/XfwNkl6yv/Hx5167AncIpFIm0KHacVFdbZo3Qsxf0T/tYnhoQX7kR0/Svwt/8D9cVIYTl71NFvrMd7eEsvnEtk1oGOin2hQCqqz0N1F3MsmYfsX4POCzb4fQ7QqYlflvAYH6i88NzAg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=HE6cP9mkkSdxtHnEVSoZK3wwwnlZVbner+AdDfgj0Oo=;\n b=QIjavDLTbDz9WK4oNh5A+CyKFOLDjXYoEt3+SRQWTLg0KQ7aEOl86/aqhoI59UqGs5/B5R8Lbiy5LGtgcmBKNmZAdqb7QQFa0ithYfTB/fNCr7tICp96Tt+czq78FZd8jEbsW3BiD+JUTdsTrW4sV7ZKlOaGKr0YUPSfTeaY+Q/YkfcW8ur9n45Wa4tFOpHfT7kKxVXHCcrHkil62TsLQxpbqyZbP355OZc2YJp4jd9Pcz+QSFqqq2ToZE4xNaz6VeIjEEnnwTiYqkK38UkMJtKTC7eNg7/sJbQHDShapFU0sOripE0tPg4NChRgfPVVqVFDBHi5G3aB2m+8SEbj7Q==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com;\n dkim=pass header.d=siemens.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HE6cP9mkkSdxtHnEVSoZK3wwwnlZVbner+AdDfgj0Oo=;\n b=wQFi+4H65wQlxloZwXxyQ8fti2jbRlyJ4CK2bDye6SCa0IjV9CRtDybPRaOmOJumlzTf+ta3lMhCAbxZMPS+LvuTsGlhHS3AnvLJXzrmsw/fltP7oIwsJ2kEFMJyevi4U6VAi4IBvRBWBNLGf2lXF5jeJnOty3owDdKHa0KXL5yIDNj5kovygMI/oLIYPaSi0sLrctoID53Qs0S0IQVhU4V/tuXba6N5j+mFs0pt5fsfdQidDUtcqFKydKWewrrIx2/DOEc96K+6pVUCdK4Wk2TB4vyvFOedcogTJLQ9Ip7uZz1J5zyxUYEMILWYJGm8lNbGggwHyuQ0fBpaB1Ez4g==","Message-ID":"","Date":"Tue, 22 Oct 2024 21:41:07 +0200","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","To":"Simon Glass ","Cc":"U-Boot Mailing List , Bryan Brattlof ,\n Nishanth Menon ","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>\n ","From":"Jan Kiszka ","Content-Language":"en-US","Autocrypt":"addr=jan.kiszka@siemens.com; keydata=\n xsFNBGZY+hkBEACkdtFD81AUVtTVX+UEiUFs7ZQPQsdFpzVmr6R3D059f+lzr4Mlg6KKAcNZ\n uNUqthIkgLGWzKugodvkcCK8Wbyw+1vxcl4Lw56WezLsOTfu7oi7Z0vp1XkrLcM0tofTbClW\n xMA964mgUlBT2m/J/ybZd945D0wU57k/smGzDAxkpJgHBrYE/iJWcu46jkGZaLjK4xcMoBWB\n I6hW9Njxx3Ek0fpLO3876bszc8KjcHOulKreK+ezyJ01Hvbx85s68XWN6N2ulLGtk7E/sXlb\n 79hylHy5QuU9mZdsRjjRGJb0H9Buzfuz0XrcwOTMJq7e7fbN0QakjivAXsmXim+s5dlKlZjr\n L3ILWte4ah7cGgqc06nFb5jOhnGnZwnKJlpuod3pc/BFaFGtVHvyoRgxJ9tmDZnjzMfu8YrA\n +MVv6muwbHnEAeh/f8e9O+oeouqTBzgcaWTq81IyS56/UD6U5GHet9Pz1MB15nnzVcyZXIoC\n roIhgCUkcl+5m2Z9G56bkiUcFq0IcACzjcRPWvwA09ZbRHXAK/ao/+vPAIMnU6OTx3ejsbHn\n oh6VpHD3tucIt+xA4/l3LlkZMt5FZjFdkZUuAVU6kBAwElNBCYcrrLYZBRkSGPGDGYZmXAW/\n VkNUVTJkRg6MGIeqZmpeoaV2xaIGHBSTDX8+b0c0hT/Bgzjv8QARAQABzSNKYW4gS2lzemth\n IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPsLBlAQTAQoAPhYhBABMZH11cs99cr20+2mdhQqf\n QXvYBQJmWPvXAhsDBQkFo5qABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGmdhQqfQXvY\n zPAP/jGiVJ2VgPcRWt2P8FbByfrJJAPCsos+SZpncRi7tl9yTEpS+t57h7myEKPdB3L+kxzg\n K3dt1UhYp4FeIHA3jpJYaFvD7kNZJZ1cU55QXrJI3xu/xfB6VhCs+VAUlt7XhOsOmTQqCpH7\n pRcZ5juxZCOxXG2fTQTQo0gfF5+PQwQYUp0NdTbVox5PTx5RK3KfPqmAJsBKdwEaIkuY9FbM\n 9lGg8XBNzD2R/13cCd4hRrZDtyegrtocpBAruVqOZhsMb/h7Wd0TGoJ/zJr3w3WnDM08c+RA\n 5LHMbiA29MXq1KxlnsYDfWB8ts3HIJ3ROBvagA20mbOm26ddeFjLdGcBTrzbHbzCReEtN++s\n gZneKsYiueFDTxXjUOJgp8JDdVPM+++axSMo2js8TwVefTfCYt0oWMEqlQqSqgQwIuzpRO6I\n ik7HAFq8fssy2cY8Imofbj77uKz0BNZC/1nGG1OI9cU2jHrqsn1i95KaS6fPu4EN6XP/Gi/O\n 0DxND+HEyzVqhUJkvXUhTsOzgzWAvW9BlkKRiVizKM6PLsVm/XmeapGs4ir/U8OzKI+SM3R8\n VMW8eovWgXNUQ9F2vS1dHO8eRn2UqDKBZSo+qCRWLRtsqNzmU4N0zuGqZSaDCvkMwF6kIRkD\n ZkDjjYQtoftPGchLBTUzeUa2gfOr1T4xSQUHhPL8zsFNBGZY+hkBEADb5quW4M0eaWPIjqY6\n aC/vHCmpELmS/HMa5zlA0dWlxCPEjkchN8W4PB+NMOXFEJuKLLFs6+s5/KlNok/kGKg4fITf\n Vcd+BQd/YRks3qFifckU+kxoXpTc2bksTtLuiPkcyFmjBph/BGms35mvOA0OaEO6fQbauiHa\n QnYrgUQM+YD4uFoQOLnWTPmBjccoPuiJDafzLxwj4r+JH4fA/4zzDa5OFbfVq3ieYGqiBrtj\n tBFv5epVvGK1zoQ+Rc+h5+dCWPwC2i3cXTUVf0woepF8mUXFcNhY+Eh8vvh1lxfD35z2CJeY\n txMcA44Lp06kArpWDjGJddd+OTmUkFWeYtAdaCpj/GItuJcQZkaaTeiHqPPrbvXM361rtvaw\n XFUzUlvoW1Sb7/SeE/BtWoxkeZOgsqouXPTjlFLapvLu5g9MPNimjkYqukASq/+e8MMKP+EE\n v3BAFVFGvNE3UlNRh+ppBqBUZiqkzg4q2hfeTjnivgChzXlvfTx9M6BJmuDnYAho4BA6vRh4\n Dr7LYTLIwGjguIuuQcP2ENN+l32nidy154zCEp5/Rv4K8SYdVegrQ7rWiULgDz9VQWo2zAjo\n TgFKg3AE3ujDy4V2VndtkMRYpwwuilCDQ+Bpb5ixfbFyZ4oVGs6F3jhtWN5Uu43FhHSCqUv8\n FCzl44AyGulVYU7hTQARAQABwsF8BBgBCgAmFiEEAExkfXVyz31yvbT7aZ2FCp9Be9gFAmZY\n +hkCGwwFCQWjmoAACgkQaZ2FCp9Be9hN3g/8CdNqlOfBZGCFNZ8Kf4tpRpeN3TGmekGRpohU\n bBMvHYiWW8SvmCgEuBokS+Lx3pyPJQCYZDXLCq47gsLdnhVcQ2ZKNCrr9yhrj6kHxe1Sqv1S\n MhxD8dBqW6CFe/mbiK9wEMDIqys7L0Xy/lgCFxZswlBW3eU2Zacdo0fDzLiJm9I0C9iPZzkJ\n gITjoqsiIi/5c3eCY2s2OENL9VPXiH1GPQfHZ23ouiMf+ojVZ7kycLjz+nFr5A14w/B7uHjz\n uL6tnA+AtGCredDne66LSK3HD0vC7569sZ/j8kGKjlUtC+zm0j03iPI6gi8YeCn9b4F8sLpB\n lBdlqo9BB+uqoM6F8zMfIfDsqjB0r/q7WeJaI8NKfFwNOGPuo93N+WUyBi2yYCXMOgBUifm0\n T6Hbf3SHQpbA56wcKPWJqAC2iFaxNDowcJij9LtEqOlToCMtDBekDwchRvqrWN1mDXLg+av8\n qH4kDzsqKX8zzTzfAWFxrkXA/kFpR3JsMzNmvextkN2kOLCCHkym0zz5Y3vxaYtbXG2wTrqJ\n 8WpkWIE8STUhQa9AkezgucXN7r6uSrzW8IQXxBInZwFIyBgM0f/fzyNqzThFT15QMrYUqhhW\n ZffO4PeNJOUYfXdH13A6rbU0y6xE7Okuoa01EqNi9yqyLA8gPgg/DhOpGtK8KokCsdYsTbk=","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR2P281CA0178.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:9f::7) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:588::19)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS4PR10MB6181:EE_|AS2PR10MB8033:EE_","X-MS-Office365-Filtering-Correlation-Id":"956a683a-0efc-40e1-ff45-08dcf2d17a13","X-MS-Exchange-AtpMessageProperties":"SA","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;ARA:13230040|1800799024|376014|366016;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?o9VvgZ9nPSsC7AJcY1vmVCrQS89KCfA?=\n\t=?utf-8?q?G1E11Z/qgiZ7+9jXYRAzlAqWwUmjkRvN0bc7w8IYnG07FzEp2nbTLOmlWW1n9NyiS?=\n\t=?utf-8?q?Ig0MHj3t4NmbepfGlQMMWyvhwwiNXsQFJijiABdtf3gyBvsh5ij4z4ojFGD0OyoGw?=\n\t=?utf-8?q?okkaz0R8G4W8NMVuO1ijrHIIkYBgBMzTayoR0TfoHTgd4WUaKHCIiR//hFztftem5?=\n\t=?utf-8?q?DCGv5K/z1HkiMjYaLJ3pAYqYs3btsuf2rQeMkQ1Zg0pWhHayh2VJCLsWPxrXk9xxC?=\n\t=?utf-8?q?l+icHr0LRDVvKOAC6/2wfiRbQePdeTU7LlMoTXrQA7hxnQxUiOBy1nWZ8JoPheqVp?=\n\t=?utf-8?q?yuJx0VTuXjzIziLzvWXFFsw7gM3b0p8szp+MOEFZ1d/vkOoprmCa3NV5QyvEzcptc?=\n\t=?utf-8?q?q0TepoJMDqq4TgWqF+xi4w2DdnH92uJIG7SJEmmctNwPs6xZP6Hhv6bfEVVlghBJt?=\n\t=?utf-8?q?+YbW03pCxGLIzyPZsuLn2E048BBPVouTCTjJPlOwRheEu4TIqH74fF3jyBVU1Cqc/?=\n\t=?utf-8?q?lQhs9FSaJNFd5mT0SaRgCrKSkyRXBe3PBxfx2RRVb8r8Cd8NTX2TQgqN63pAuZDB5?=\n\t=?utf-8?q?i4FTa+FvionPPAE06tJMkVdycKZdEmU7ordEnOW+IvrKu4WZGGQw9tOrITez1gwt2?=\n\t=?utf-8?q?AXTBJG3COVkSTmpFReQI8wQRfvq/6dSauEGsirO6Wa5tKplurOrHc4dOf2aWmQxgq?=\n\t=?utf-8?q?hrp/8tGtyVOdGh2Imyp0ADF4QVrI2mYyXQ9nQqRd5QdipCx6v3ebq3tRdjh6Niu8Y?=\n\t=?utf-8?q?V3/YVOl3iNJL63XxW7sTL0sNdI0uu5+eSvTcDbIkuTL1zw1VN+Ll1a3/WwPQayP5d?=\n\t=?utf-8?q?hhqvvkcSYmq8xr8dzXnbGUtiemMXdKiCsIUTO2dL7uiSc9xjVRmbtiiWG7VGl482z?=\n\t=?utf-8?q?XMpn/tbnxv1zqKWr0s2jHvqH0qw2tSqIJlpXJrNoQWODjYEZoxJ1wZmrySBl093q5?=\n\t=?utf-8?q?j+A8QHwiaTTpmav5pssGcZhtGvbwgLmNcCfegPxru8K7KOKGEPqNCUxMbJZTHRTTd?=\n\t=?utf-8?q?vTpspOi7FWAd9l/aCp2Uv9vt6/d0bfrRrmgCDPs9+sO817AijqdWnDuTSEp8bo8Vf?=\n\t=?utf-8?q?r4OOsfZQT7490q8Ry1JWLMIVIm2fWTiITDllOgeisemqtQ3ZvaEDEPN5JHfF+oMN1?=\n\t=?utf-8?q?s+9MA4Yy+WFYWKHyNsXFMNDXZ/pa0Io69zU2Fvl8P7s69XzRVgBDaxZxvz2JMZN0I?=\n\t=?utf-8?q?2NDldiW4XzZ9d3oVJmXqfja5j2fbPmxtpQj3UWai5y2+2k56T+6lZLI+3uFiBxW9m?=\n\t=?utf-8?q?QV5k48P558uLK?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?5pAYrGhJqXzYQBYFHT9/VhllatQZ?=\n\t=?utf-8?q?QrlQrRyGRWKpL92VTjgeirywxU/W71JdHBK45eWiJtHYpaHjP9JcWGv/1EMKXhJ/r?=\n\t=?utf-8?q?OIFOCvHA++Mtd3GLC8DcJbQzzeYKnXxoFBec9wlm5/URkDJyuinOeseEHhaQWA+1K?=\n\t=?utf-8?q?2BzM6ouPuBKvsLCe7kTdlWULCo+7caBvfzTW+dy5JCHizk/cbPqxYrH60oJOr4SKw?=\n\t=?utf-8?q?FrbKAZPNlbQ21L4WXcM4m63ZpEL7ea0Zankj1S9bTLj1HTBE3X+hB2vZJncPqMrSx?=\n\t=?utf-8?q?9Xm8fyfpncs4KAZy7TRKrz2IKRPkLs5muGJ6RTnfXrqIu316FgpTNkKOjxPH5IjiL?=\n\t=?utf-8?q?6/YdeZlRtVH0/IBaZU/gf/yKAPfk7Ky4PK7DwykD+Lc9WFO+k0U1e7hhPOmxeo2O6?=\n\t=?utf-8?q?FIgfEcNiQ/U63NMS2+ClzpQDLhq4XG7BdR9rL+6mgpCnE2lOSuZSPMgxn4ynfUT8j?=\n\t=?utf-8?q?ujx1dmBu+e8Xmvaul5/4BPyvJCvQQJ2l1Vdbzte139dxT/MkizICg99gK0HBtkalz?=\n\t=?utf-8?q?yIysHiLwInxmNTYONUurvvnJ6ZpLmZQwZBLlLE/IkOFrVc/GmScFpyAgg4yyrGlTc?=\n\t=?utf-8?q?C7baBgDN5yOO6eLEjSNPQ8OKGS+RcXoh0T4zyYuWLzFYRZuEIY8vSJf2e+1tfOryn?=\n\t=?utf-8?q?fESuhu5sdc2IsskuhT2CfnIdMlAA6uNLV+0rkSDtTB8GxKYWFUiqz4btKS2IN+CGo?=\n\t=?utf-8?q?M99NN9HyINHO0mKIzZxDWH7gqtHl8V/vQQvdP22WPx7qDSw3rfUOI/CrToebRXIvO?=\n\t=?utf-8?q?32pD90uep+83trX4NAiIsdtpczZN4SY4CAS6sglutp4ttNclygmyaDl8l+wVt2K1A?=\n\t=?utf-8?q?Nxevw3iUbHEjz2MP5MaVxTmw4RvmcVztc8uJTMB7jGlmDOiKkeLoMoIphnBuiMUPK?=\n\t=?utf-8?q?yCZRPMV92fPPgaWb5S9nkfNqbgYWAEzfscVC8Y8a7zzjLbvw12HBR94XYHrwQZR6e?=\n\t=?utf-8?q?OOQ74HenwgPPJdjNCP5qEj4igbThfBSrvu6azoqNQQ27Fm0kvn8kJYyKhtfoUAY0R?=\n\t=?utf-8?q?MAjHNqyzzYAHSN0eoJyuljSK8Ka/eSKniFDe53L9aP2ZytYp+BRYKsAPn90GmOHBu?=\n\t=?utf-8?q?5fhg0QvZLhD+/w1A7YbOqJwdQbzhJoO/uWb2dcXBVHmOO1O7PEm3XMTWtYeozRbOM?=\n\t=?utf-8?q?lHKNboCVq4mhaRAmfgjame43UTNSOkiDFvk67y1AGAjWqKJtAdLU8lABRdzRu4R88?=\n\t=?utf-8?q?jb4OLCjy+zdMjF/93LoOWELTiWmcekpOqqNroBuB+uSBVHVJj5ctoFqpRvfcJXhu5?=\n\t=?utf-8?q?K99//cHKc5LXcLAe8IFa9ltRQ3AEip7gerRwnQIME2KmVe9xK8/3djN7UGALXZ3/j?=\n\t=?utf-8?q?mzf12haETDpUA6w7IUVVr5cmlzkbfRbmvcttLNKB3qbD9rgBa6WIlDpJuPzmATUJu?=\n\t=?utf-8?q?FnFJYtUTJr8oRICE/DqWQEZz/ZHr37YYc00/hDIiubhNK0Kw1gtUJck3JvTxP3Lq4?=\n\t=?utf-8?q?t/x4Soh/znJwuN4ZKKuO/IfYX0BD+0emM3zPt5TjJ6nLC98Vp7aBvL7nJavzxTemr?=\n\t=?utf-8?q?VargqfjJcVMqKB8qZzimZZagbXEFUziscQ=3D=3D?=","X-OriginatorOrg":"siemens.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 956a683a-0efc-40e1-ff45-08dcf2d17a13","X-MS-Exchange-CrossTenant-AuthSource":"AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Oct 2024 19:41:09.0995 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"38ae3bcd-9579-4fd4-adda-b42e1495d55a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n RUpt7R3R9UsU3AAJE3dTR39akD4c1QupPX20K79bF0/zyumelHL+lsFYP9knlo8ZeYWOhmXUqGBKihzFQKZuJw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS2PR10MB8033","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3400070,"web_url":"http://patchwork.ozlabs.org/comment/3400070/","msgid":"","list_archive_url":null,"date":"2024-10-23T03:39:08","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Jan,\n\nOn Tue, 22 Oct 2024 at 21:41, Jan Kiszka wrote:\n>\n> On 22.10.24 19:00, Simon Glass wrote:\n> > On Tue, 22 Oct 2024 at 08:06, Jan Kiszka wrote:\n> >>\n> >> From: Jan Kiszka \n> >>\n> >> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n> >> be first used by the IOT2050 boards.\n> >>\n> >> Based on original patch by Li Hua Qian.\n> >>\n> >> Signed-off-by: Jan Kiszka \n> >> ---\n> >> include/sysinfo.h | 1 +\n> >> lib/smbios.c | 4 ++++\n> >> 2 files changed, 5 insertions(+)\n> >\n> > Reviewed-by: Simon Glass \n> >\n> > What is this used for? Would you mind adding a comment for it? Should\n> > mention that it is a struct uuid\n> >\n>\n> What exactly is unclear here? The System UUID is a part of the SMBIOS\n> spec that U-Boot just ignored so far.\n\nOK, well that just mention that, along with the data type.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=A/EcHM9K;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"A/EcHM9K\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=fail smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XYFCz56gtz1xwf\n\tfor ; Wed, 23 Oct 2024 14:39:43 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A4FD3892E0;\n\tWed, 23 Oct 2024 05:39:29 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 672E0892DE; Wed, 23 Oct 2024 05:39:27 +0200 (CEST)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n [IPv6:2a00:1450:4864:20::629])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 134F98919D\n for ; Wed, 23 Oct 2024 05:39:22 +0200 (CEST)","by mail-ej1-x629.google.com with SMTP id\n a640c23a62f3a-a9a26a5d6bfso905756666b.1\n for ; Tue, 22 Oct 2024 20:39:22 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,\n DKIM_SIGNED,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1729654761; x=1730259561; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=IcHgdf8UZ7z43o4luS3WXOEPHcGFFvAzTzV84WqNqgc=;\n b=A/EcHM9KWr8MxFBfSppbrTM1wVKHnL5dAPoJ8WqxeVbrbGLdh0xGvoiaY9kLCosFri\n acmFHe5vqpjY2iNV3N/TUJi1ZdkPhQRvm12gNbUTQbtGPNu5LjYIUjpkwUj4Drcr8ah8\n vd0mjPCHU4f7Jfs8yZCE7e8i6EvUahQQO9dMY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1729654761; x=1730259561;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=IcHgdf8UZ7z43o4luS3WXOEPHcGFFvAzTzV84WqNqgc=;\n b=c3r8EEsRe+aVJlFMl8ibEJG0xWTLh+HxWmB6ZhGsRLcR39kqC42X2IbWdhanS7V2L4\n 6QeSyCoTbEtFHWV0S4/lhL3ra9rsTC4VvMajyeLqoGHSKnWJfuMMzK6Ywoj6Z74tpWky\n +FV8GNvJQdHTUh0ZDcl7TlOacUzQ1nBVS2GFOKFLwEJQO3n0Lzt40v6Sm4c10dF3SLFf\n B/Tu8sVvpQ6P72WmxhItg2PTBimzd9JhFtFXMZZthc+u4j/L84z9xaA4biEqv66X+9L8\n NMu0FyLyf09eZCKUNMgDUgz6f2JwlDg5zjgs2Sql2cOboGO/i5eDa0WruMzIPpq/XG8I\n Cgvw==","X-Gm-Message-State":"AOJu0YzhSjZop3U4LUeRZ9e2GkfDmvkxz7DtONJx01X7G5j5y83aASdz\n tMB091qNK1t0y/p0rGaw3T1tcS9O1qjL+M76cKUwJD4dfRuO83eD4mOSZwLYNpR3IOxcE4dAmZF\n wPIlz27JS3TttPa5kkUDDqoJwQjb6VJDXtLME","X-Google-Smtp-Source":"\n AGHT+IHJ7M/bKgpUHkn8Bc8GtnpvB+u8mzkDrUIrSLwuYV4L1ffeX9iQEktLPv8Av4efZ/wyzhMuccj09s0OcgQWrGs=","X-Received":"by 2002:a17:906:dc8f:b0:a99:e1a1:473f with SMTP id\n a640c23a62f3a-a9abf96d0e2mr89593766b.57.1729654761525; Tue, 22 Oct 2024\n 20:39:21 -0700 (PDT)","MIME-Version":"1.0","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>\n \n ","In-Reply-To":"","From":"Simon Glass ","Date":"Wed, 23 Oct 2024 05:39:08 +0200","Message-ID":"\n ","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","To":"Jan Kiszka ","Cc":"U-Boot Mailing List , Bryan Brattlof ,\n Nishanth Menon ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3400080,"web_url":"http://patchwork.ozlabs.org/comment/3400080/","msgid":"<6bdd212e-2a70-4c32-a463-c83cbf7bd0c7@siemens.com>","list_archive_url":null,"date":"2024-10-23T04:14:00","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":710,"url":"http://patchwork.ozlabs.org/api/people/710/","name":"Jan Kiszka","email":"jan.kiszka@siemens.com"},"content":"On 23.10.24 05:39, Simon Glass wrote:\n> Hi Jan,\n> \n> On Tue, 22 Oct 2024 at 21:41, Jan Kiszka wrote:\n>>\n>> On 22.10.24 19:00, Simon Glass wrote:\n>>> On Tue, 22 Oct 2024 at 08:06, Jan Kiszka wrote:\n>>>>\n>>>> From: Jan Kiszka \n>>>>\n>>>> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n>>>> be first used by the IOT2050 boards.\n>>>>\n>>>> Based on original patch by Li Hua Qian.\n>>>>\n>>>> Signed-off-by: Jan Kiszka \n>>>> ---\n>>>> include/sysinfo.h | 1 +\n>>>> lib/smbios.c | 4 ++++\n>>>> 2 files changed, 5 insertions(+)\n>>>\n>>> Reviewed-by: Simon Glass \n>>>\n>>> What is this used for? Would you mind adding a comment for it? Should\n>>> mention that it is a struct uuid\n>>>\n>>\n>> What exactly is unclear here? The System UUID is a part of the SMBIOS\n>> spec that U-Boot just ignored so far.\n> \n> OK, well that just mention that, along with the data type.\n> \n\nNow that I look at your data type comment again: It's actually not ok to\nmisuse sysinfo_get_str for transporting this. The UUID is not converted\ninto a string by the driver, it is rather returned raw and may even\nterminate prematurely if containing some zero. We need a new\nsysinfo_get_bin or raw op.\n\nJan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.a=rsa-sha256\n header.s=selector2 header.b=0BOottL+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.b=\"0BOottL+\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=fail smtp.mailfrom=jan.kiszka@siemens.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=siemens.com;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XYFzw4Nn0z1xwr\n\tfor ; Wed, 23 Oct 2024 15:14:20 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5603D892B8;\n\tWed, 23 Oct 2024 06:14:09 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id CC7E8892DB; Wed, 23 Oct 2024 06:14:07 +0200 (CEST)","from EUR02-DB5-obe.outbound.protection.outlook.com\n (mail-db5eur02on20607.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:2608::607])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C314188A4C\n for ; Wed, 23 Oct 2024 06:14:03 +0200 (CEST)","from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19)\n by AS1PR10MB7959.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:471::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.16; Wed, 23 Oct\n 2024 04:14:02 +0000","from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::8fe1:7e71:cf4a:7408]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::8fe1:7e71:cf4a:7408%3]) with mapi id 15.20.8093.014; Wed, 23 Oct 2024\n 04:14:02 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=E9+D+J+WdviXIzyI9lJDThW7eJ9aQxRPFx0PLx/tOMauYMMUutEDcyczi2E/zedX4hYitcwP8w8VhcjBipGQpHOIIfRops+NI8vsQpi7kgjijdgcIdpCE6I18kkKYL4HFjGTyYWH1VIHxq67trE3Xb1xVi3dXkS3mtfS3/0XJZh8Zi21VkdpofKBdKVzQBlCrIleM5kaOEytdTIvMvcd1qJMLT4VILPEzBiCSnXAI99GUEMrh0QXb1kZvqHl3dmefwMqu/nifPi08bJFd6cwRbW2KpnCSKjpSGhzSerUtJLns9lLLOM8PALrs9EjRPpVzU3+L3neDk2R0k7eiEsqMQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=h8VtQ9WrxOV03vYQZteDBJsb8TDTepYrcMJUXyuXYBs=;\n b=hgVF//l0hhF+QYy0xOLWEE+CnlhRzb7draThzSb8x3vKJ4PF7nLVdsRGE/mWiwyQxwzDljOmUwHInK+AjJarq3S7QESE9T3yYSyGzYRJwEWVp/t4zIU4ZbE95hWlJXEkKbl32aE843ugST4YFuacWvtU+EYptdpVw0g5ouRm2LEGZXOGNa5bDSFTD2CfNGkNqoUZov/e/EQx0MMlYS4ORG91ttXn9UOllo6UhmsCv0/lEuiy/GifEwEIUdugnpy1NSwTo+vmDhLcFL7pe1ymhQYxliPcL4UQdhlQQaLa1Lo+8YJhLjFQC8/MKOR2/0ANVpio9NV5sMBjKnZuBfR2Gw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com;\n dkim=pass header.d=siemens.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=h8VtQ9WrxOV03vYQZteDBJsb8TDTepYrcMJUXyuXYBs=;\n b=0BOottL+m/V4VlhdcxWsp+VD928BRsAuczIzxAMdrAhZGx3t51UvT6PJboTMcyg79U/736IiqgZgJo7lOWELSz7rpkCWLYZVQc1eAR0vD5Z2158IiUUHxzMdMP0oZ5UT4fX1arL/0pOD8PJg+q6vRa62jpdaoQy356uxRg4Mv3J6fi00aMdP5dDk5yuxLfQYJDU90L7bRfBpSrnOrUDXUZ6/fgh+K52CxcJdXtnF4jxXJvFsbIlekiP6pkXqfSa+ON6yHoSZFTdO4WKgSNHTP439n0whmKwXlMY5uTNyNn/H/Yri8t+Wl4hqZUofyV9GFahq5ezYa9Z77M+O8uLQ0A==","Message-ID":"<6bdd212e-2a70-4c32-a463-c83cbf7bd0c7@siemens.com>","Date":"Wed, 23 Oct 2024 06:14:00 +0200","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","To":"Simon Glass ","Cc":"U-Boot Mailing List , Bryan Brattlof ,\n Nishanth Menon ,\n \"Li, Hua Qian (DI FA CTR IPC CN PRC4)\" ","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>\n \n \n ","From":"Jan Kiszka ","Content-Language":"en-US","Autocrypt":"addr=jan.kiszka@siemens.com; keydata=\n xsFNBGZY+hkBEACkdtFD81AUVtTVX+UEiUFs7ZQPQsdFpzVmr6R3D059f+lzr4Mlg6KKAcNZ\n uNUqthIkgLGWzKugodvkcCK8Wbyw+1vxcl4Lw56WezLsOTfu7oi7Z0vp1XkrLcM0tofTbClW\n xMA964mgUlBT2m/J/ybZd945D0wU57k/smGzDAxkpJgHBrYE/iJWcu46jkGZaLjK4xcMoBWB\n I6hW9Njxx3Ek0fpLO3876bszc8KjcHOulKreK+ezyJ01Hvbx85s68XWN6N2ulLGtk7E/sXlb\n 79hylHy5QuU9mZdsRjjRGJb0H9Buzfuz0XrcwOTMJq7e7fbN0QakjivAXsmXim+s5dlKlZjr\n L3ILWte4ah7cGgqc06nFb5jOhnGnZwnKJlpuod3pc/BFaFGtVHvyoRgxJ9tmDZnjzMfu8YrA\n +MVv6muwbHnEAeh/f8e9O+oeouqTBzgcaWTq81IyS56/UD6U5GHet9Pz1MB15nnzVcyZXIoC\n roIhgCUkcl+5m2Z9G56bkiUcFq0IcACzjcRPWvwA09ZbRHXAK/ao/+vPAIMnU6OTx3ejsbHn\n oh6VpHD3tucIt+xA4/l3LlkZMt5FZjFdkZUuAVU6kBAwElNBCYcrrLYZBRkSGPGDGYZmXAW/\n VkNUVTJkRg6MGIeqZmpeoaV2xaIGHBSTDX8+b0c0hT/Bgzjv8QARAQABzSNKYW4gS2lzemth\n IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPsLBlAQTAQoAPhYhBABMZH11cs99cr20+2mdhQqf\n QXvYBQJmWPvXAhsDBQkFo5qABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGmdhQqfQXvY\n zPAP/jGiVJ2VgPcRWt2P8FbByfrJJAPCsos+SZpncRi7tl9yTEpS+t57h7myEKPdB3L+kxzg\n K3dt1UhYp4FeIHA3jpJYaFvD7kNZJZ1cU55QXrJI3xu/xfB6VhCs+VAUlt7XhOsOmTQqCpH7\n pRcZ5juxZCOxXG2fTQTQo0gfF5+PQwQYUp0NdTbVox5PTx5RK3KfPqmAJsBKdwEaIkuY9FbM\n 9lGg8XBNzD2R/13cCd4hRrZDtyegrtocpBAruVqOZhsMb/h7Wd0TGoJ/zJr3w3WnDM08c+RA\n 5LHMbiA29MXq1KxlnsYDfWB8ts3HIJ3ROBvagA20mbOm26ddeFjLdGcBTrzbHbzCReEtN++s\n gZneKsYiueFDTxXjUOJgp8JDdVPM+++axSMo2js8TwVefTfCYt0oWMEqlQqSqgQwIuzpRO6I\n ik7HAFq8fssy2cY8Imofbj77uKz0BNZC/1nGG1OI9cU2jHrqsn1i95KaS6fPu4EN6XP/Gi/O\n 0DxND+HEyzVqhUJkvXUhTsOzgzWAvW9BlkKRiVizKM6PLsVm/XmeapGs4ir/U8OzKI+SM3R8\n VMW8eovWgXNUQ9F2vS1dHO8eRn2UqDKBZSo+qCRWLRtsqNzmU4N0zuGqZSaDCvkMwF6kIRkD\n ZkDjjYQtoftPGchLBTUzeUa2gfOr1T4xSQUHhPL8zsFNBGZY+hkBEADb5quW4M0eaWPIjqY6\n aC/vHCmpELmS/HMa5zlA0dWlxCPEjkchN8W4PB+NMOXFEJuKLLFs6+s5/KlNok/kGKg4fITf\n Vcd+BQd/YRks3qFifckU+kxoXpTc2bksTtLuiPkcyFmjBph/BGms35mvOA0OaEO6fQbauiHa\n QnYrgUQM+YD4uFoQOLnWTPmBjccoPuiJDafzLxwj4r+JH4fA/4zzDa5OFbfVq3ieYGqiBrtj\n tBFv5epVvGK1zoQ+Rc+h5+dCWPwC2i3cXTUVf0woepF8mUXFcNhY+Eh8vvh1lxfD35z2CJeY\n txMcA44Lp06kArpWDjGJddd+OTmUkFWeYtAdaCpj/GItuJcQZkaaTeiHqPPrbvXM361rtvaw\n XFUzUlvoW1Sb7/SeE/BtWoxkeZOgsqouXPTjlFLapvLu5g9MPNimjkYqukASq/+e8MMKP+EE\n v3BAFVFGvNE3UlNRh+ppBqBUZiqkzg4q2hfeTjnivgChzXlvfTx9M6BJmuDnYAho4BA6vRh4\n Dr7LYTLIwGjguIuuQcP2ENN+l32nidy154zCEp5/Rv4K8SYdVegrQ7rWiULgDz9VQWo2zAjo\n TgFKg3AE3ujDy4V2VndtkMRYpwwuilCDQ+Bpb5ixfbFyZ4oVGs6F3jhtWN5Uu43FhHSCqUv8\n FCzl44AyGulVYU7hTQARAQABwsF8BBgBCgAmFiEEAExkfXVyz31yvbT7aZ2FCp9Be9gFAmZY\n +hkCGwwFCQWjmoAACgkQaZ2FCp9Be9hN3g/8CdNqlOfBZGCFNZ8Kf4tpRpeN3TGmekGRpohU\n bBMvHYiWW8SvmCgEuBokS+Lx3pyPJQCYZDXLCq47gsLdnhVcQ2ZKNCrr9yhrj6kHxe1Sqv1S\n MhxD8dBqW6CFe/mbiK9wEMDIqys7L0Xy/lgCFxZswlBW3eU2Zacdo0fDzLiJm9I0C9iPZzkJ\n gITjoqsiIi/5c3eCY2s2OENL9VPXiH1GPQfHZ23ouiMf+ojVZ7kycLjz+nFr5A14w/B7uHjz\n uL6tnA+AtGCredDne66LSK3HD0vC7569sZ/j8kGKjlUtC+zm0j03iPI6gi8YeCn9b4F8sLpB\n lBdlqo9BB+uqoM6F8zMfIfDsqjB0r/q7WeJaI8NKfFwNOGPuo93N+WUyBi2yYCXMOgBUifm0\n T6Hbf3SHQpbA56wcKPWJqAC2iFaxNDowcJij9LtEqOlToCMtDBekDwchRvqrWN1mDXLg+av8\n qH4kDzsqKX8zzTzfAWFxrkXA/kFpR3JsMzNmvextkN2kOLCCHkym0zz5Y3vxaYtbXG2wTrqJ\n 8WpkWIE8STUhQa9AkezgucXN7r6uSrzW8IQXxBInZwFIyBgM0f/fzyNqzThFT15QMrYUqhhW\n ZffO4PeNJOUYfXdH13A6rbU0y6xE7Okuoa01EqNi9yqyLA8gPgg/DhOpGtK8KokCsdYsTbk=","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR5P281CA0030.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:f1::6) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:588::19)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS4PR10MB6181:EE_|AS1PR10MB7959:EE_","X-MS-Office365-Filtering-Correlation-Id":"688daf06-af75-40f1-3264-08dcf319202b","X-MS-Exchange-AtpMessageProperties":"SA","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;ARA:13230040|1800799024|376014|366016;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?gDKHGa6DpCoNZ9LRgQVStz0KmVZdNgW?=\n\t=?utf-8?q?mYe0dO+fl+u3JwCkGRUXmmNXbJ+aas2Pt3FovSd7PXTWjTizrfGAiGfRF5AUJz4UX?=\n\t=?utf-8?q?eoW2Q+gdgtS79e1xBY3Yg3W3EJoYOgh9rwv8Dmf3hvGXQvABxiI8G27TNwBKfEvQ9?=\n\t=?utf-8?q?W6DeMsHMgw1tEXbNCINknV0n68kq5iRoCnMhWp9o23rRfSibf0QbXZrwyWgVqPrYG?=\n\t=?utf-8?q?p0stB+dxM4qe8tqROhJG9u9vLvvJsN6UuuyNvqqffwIoZNGMtZCOvGKIRhBfa6Y1T?=\n\t=?utf-8?q?TJt6DbfAI6xoi9BG0+x5fUYfx/V4qtrhEOYI5zAEQenrIWFZnsliBhrk38Yl06cun?=\n\t=?utf-8?q?i0CHCyVpC9gTLhioIv0Yk72En77TRDk7RVAYuOc6jjYqC+RxlAMuzy6Pclfp2f8ho?=\n\t=?utf-8?q?p4Bg4yhvZQbb9+4Z3H3WIffewyKRBcV2XNRLH3vqUQEB7gY6gYtOfLjtLzaHyYSkv?=\n\t=?utf-8?q?vbqGAqpHzsjgPBM/WyVEpfexsYSveESxFLKfBhaa9IVYTJcne2zO48v5e6vAAYUK3?=\n\t=?utf-8?q?m6jQ10WTS92o+f9wjIxG84U8f1QqNEd+rLgWM/6pjJZEOzjZ7Om6vUsXx+NjPuXz8?=\n\t=?utf-8?q?r4SBjQmUZ2N473dxICCKDnjnFOM72e+Kaa5PlkKxN/Gm8fgMgRQHQiSY9+JZqasgg?=\n\t=?utf-8?q?W8Aov+cZGoKWFge5zpWh/WbNopGPzWMIDvHLOeaCAIoKRhH/0qf/chCyNBzMaD+sM?=\n\t=?utf-8?q?8eHk6w5w6WwSVKfGlOaQwc+p/xEh3AeD9YceJgnu43l03KaHu9PVGThKu1mwPes8V?=\n\t=?utf-8?q?UL5kSzRLQiuuNLapCkb59XlhuAHJSOqb/6YahCUb1RrfOF6ESJLiqWAOsJK4zEBU8?=\n\t=?utf-8?q?sLAKhE6R05Fzk2qrvuewqPMH4+1zEs03FdRGJgZdHT52nKBH2LK3k2e4dv8TBDEPL?=\n\t=?utf-8?q?Mv2L6qaP9g70wEqYoCKXlj0NhAIE/8Y9np2Kn+dF/rGH/M5fZbvcyzsS+1tg1K+Dt?=\n\t=?utf-8?q?TbjcAbT45UoNHCDf37FQMrwqlEZvz8V77ZCDJuwgljnMAihKuGHe9Htdn9x4Urxx1?=\n\t=?utf-8?q?0yij/VgmzxmNhWBb3QLq2gbq5nqeqA8RrcJ2pyrQk6ULSFuVEKtAEMKUK/rrZ7gcd?=\n\t=?utf-8?q?uVSEyLbOk0GuPYAWXM9e0FjpRxidU9xNewUXjnkzR7yWYf1yJMd2H8YBCaau24X3Y?=\n\t=?utf-8?q?UxcI/L51M18gBZNajZMDfU/rPIkz2jRIphUbGp0ZIfCfmN+hqRcClGdhH4wVvoznk?=\n\t=?utf-8?q?ZoHZleo7LNYo7gDd3cTMBjs4sKGuNJl6fC/i1wgC0pvkUgvpcxdy/ohuOex5rheji?=\n\t=?utf-8?q?o3CNB4jjhdpQf?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?qqWREEnODnTbY1jv51gPdZhJ9fcl?=\n\t=?utf-8?q?5bPri6KirZ1ZXcvOJnTpcm9yIsrn8wH13+/XYXUHOQ4H01/XQqS2qfmFeyW0Y5jVu?=\n\t=?utf-8?q?/hvv9A+Bf78FlaYUMHU4+IvE29MCwSlcaNnbukJvavvXGsz1oNqH7u3KSWfesl9dS?=\n\t=?utf-8?q?LiXdlwDppp9Gc3YYWwPBuzk30JnFUZxdwWKLl7FrCZnaX1GTPEui7JMYFXNJvEgEl?=\n\t=?utf-8?q?Sa8naMwawkA568gV0WenANe2TLUYhLuCpYTCoGvQjXU0YMJnXr62YZkjVrqdw8moY?=\n\t=?utf-8?q?FTxyMD6ZilNxRrGJUsz953937U1UN7oRApSKozBP8OCtF0g+rFxL9GezV3yUCfST7?=\n\t=?utf-8?q?n9AKrNlWFP+KRozvvGaDqvucQaW5G7DQn9yqnr+zxk2tEyNOypeWWnH9QDT3/Gh50?=\n\t=?utf-8?q?zXg2qD3m5XB7BgR+MoYdTeTIcdGyNtAzuw4UI9MbZLfxp2v4EcCAsy5VO/M7g7A53?=\n\t=?utf-8?q?HR1a852nkNtNbzCgEzPU8HJbQ8JzGpDv0uqQgNiYxyuJalRnQKVq0pShJwB5aIxr+?=\n\t=?utf-8?q?k//laObbGj14Mww0u2DTc6cns9guKBXGftyvX94VVLOEzpDbW3DYK/DuX9Ggx4dgg?=\n\t=?utf-8?q?vZmEQsA4jatDg/bapmqjgd4Tg+QaufIO2D5HYnBhy7v1PAbTDMLoG+knZ04nXFara?=\n\t=?utf-8?q?Riq/CilbSLLUH1sizQ6Aif3Ita8qlon+Lfi0kSSleR01K/U6SGlIa9VzM9sYT0Oym?=\n\t=?utf-8?q?OLFqNftUEUKFrIl+01+6GNUtCW98EeHlghNOnQdIDoQxbGASx8j78UoUl7Zh5FUCV?=\n\t=?utf-8?q?0C2tqlTP3NfOyyuNruiqFhzNMFN2K8EG4LYH4v0RSpoVg0/cf363hZGG35i95S2Xb?=\n\t=?utf-8?q?MYlQPmaJNe2NoGNh1Eq13cIcvZk27a/dQe9LpMrv5UvHZVx2GcZpx8fAPWApUTQ9R?=\n\t=?utf-8?q?6luf0l+w/Ql0FgZXSc2AWBl7Zlnei8+Re6auvmOjA4rrrcWFAR9iX6aGmft7vgEiN?=\n\t=?utf-8?q?toPoSwmrZRkB1WeNvMgPZ8Qi3UALYw9JqQzR0ot4csd3UsWxUgDJPxBxij7tczf4t?=\n\t=?utf-8?q?bT1xtZObkRgkz4J9UlmAl2bXs6xGopDIY5wsUjIXJemBD1EIZa9KAXV393/kxvawZ?=\n\t=?utf-8?q?9jfuRHHGPm2aBDOmUmpdeq8v3+le2OorHcgInQ8Bc0ZTHjCXGszYEf0xrJpZ60Ltj?=\n\t=?utf-8?q?9KwcRjLTLTdFvM0bTPmEuYehaaZ4VDvAxqIASSy3jY6xZC8x8++eCbPFEs/Z+HRva?=\n\t=?utf-8?q?vwcsR2SeEDu85hmiDzGzs9dr8R4U8p5Lv+60QYKzJN2FLplnTv+vwe6F6p5eYOn9s?=\n\t=?utf-8?q?z0yQ4+ZG8pgLuG7Nmhc8saoWlg0C5iA/eF4X9d3tCpDuaqMxShiOzkFtnv5ccgAhS?=\n\t=?utf-8?q?XdTbbkd+MyvKBoEu+1JPrzc2TW5jrafk6VEzseCEwNPTZ8gZLhhEScclF1GXoyRti?=\n\t=?utf-8?q?pHSe1WopNdePXyw6sInkXMeYhTr6QwEwMG8zgCnlRPFYLPYOr9kTCagVOhelVq95M?=\n\t=?utf-8?q?wTYSUnH6dvUYZN8SYwrDV6vyH+WD0LbCV+laIvWsr6KvqEhA9DZqYFwarCxnYlqlW?=\n\t=?utf-8?q?NvYkJb7CX4TA?=","X-OriginatorOrg":"siemens.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 688daf06-af75-40f1-3264-08dcf319202b","X-MS-Exchange-CrossTenant-AuthSource":"AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"23 Oct 2024 04:14:02.0371 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"38ae3bcd-9579-4fd4-adda-b42e1495d55a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n znCg8NPBUO+xqAEfp9tY7TkufId7I7I/HueMT9kjAzlc7hwIUZgwXDYApIs1o557h6dAXaysEnTBGrcT3QhoTQ==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS1PR10MB7959","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3401686,"web_url":"http://patchwork.ozlabs.org/comment/3401686/","msgid":"<20241025010854.GX4959@bill-the-cat>","list_archive_url":null,"date":"2024-10-25T01:08:54","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, Oct 22, 2024 at 08:04:28AM +0200, Jan Kiszka wrote:\n\n> From: Jan Kiszka \n> \n> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n> be first used by the IOT2050 boards.\n> \n> Based on original patch by Li Hua Qian.\n> \n> Signed-off-by: Jan Kiszka \n> Reviewed-by: Simon Glass \n> ---\n> include/sysinfo.h | 1 +\n> lib/smbios.c | 4 ++++\n> 2 files changed, 5 insertions(+)\n> \n> diff --git a/include/sysinfo.h b/include/sysinfo.h\n> index 8a77ef44856..1c5008b5f23 100644\n> --- a/include/sysinfo.h\n> +++ b/include/sysinfo.h\n> @@ -49,6 +49,7 @@ enum sysinfo_id {\n> \tSYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n> \tSYSINFO_ID_SMBIOS_SYSTEM_SKU,\n> \tSYSINFO_ID_SMBIOS_SYSTEM_FAMILY,\n> +\tSYSINFO_ID_SMBIOS_SYSTEM_UUID,\n> \tSYSINFO_ID_SMBIOS_BASEBOARD_MANUFACTURER,\n> \tSYSINFO_ID_SMBIOS_BASEBOARD_PRODUCT,\n> \tSYSINFO_ID_SMBIOS_BASEBOARD_VERSION,\n> diff --git a/lib/smbios.c b/lib/smbios.c\n> index 7c24ea129eb..1441fa4cde6 100644\n> --- a/lib/smbios.c\n> +++ b/lib/smbios.c\n> @@ -387,6 +387,7 @@ static int smbios_write_type1(ulong *current, int handle,\n> \tstruct smbios_type1 *t;\n> \tint len = sizeof(struct smbios_type1);\n> \tchar *serial_str = env_get(\"serial#\");\n> +\tchar uuid[sizeof(t->uuid)];\n> \n> \tt = map_sysmem(*current, len);\n> \tmemset(t, 0, sizeof(struct smbios_type1));\n> @@ -409,6 +410,9 @@ static int smbios_write_type1(ulong *current, int handle,\n> \t\t\t\t\t\t SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n> \t\t\t\t\t\t NULL);\n> \t}\n> +\tif (!sysinfo_get_str(ctx->dev, SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n> +\t\t\t sizeof(uuid), uuid))\n> +\t\tstrncpy((char *)t->uuid, uuid, sizeof(t->uuid));\n> \tt->wakeup_type = SMBIOS_WAKEUP_TYPE_UNKNOWN;\n> \tt->sku_number = smbios_add_prop_si(ctx, \"sku\",\n> \t\t\t\t\t SYSINFO_ID_SMBIOS_SYSTEM_SKU, NULL);\n\nThis commit leads to sandbox (and sandbox with clang) failing a ton of\ntests:\nhttps://source.denx.de/u-boot/u-boot/-/jobs/929474\n\nWithout this commit in the series, iot2050 fails to build.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=cgs0VcMB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"cgs0VcMB\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XZPnJ154Kz1xw0\n\tfor ; Fri, 25 Oct 2024 12:09:08 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id EDAD088FAF;\n\tFri, 25 Oct 2024 03:09:05 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 17C7F88FBA; Fri, 25 Oct 2024 03:09:04 +0200 (CEST)","from mail-qk1-x736.google.com (mail-qk1-x736.google.com\n [IPv6:2607:f8b0:4864:20::736])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 66D5388FB7\n for ; Fri, 25 Oct 2024 03:08:59 +0200 (CEST)","by mail-qk1-x736.google.com with SMTP id\n af79cd13be357-7b18da94ba9so2685985a.0\n for ; Thu, 24 Oct 2024 18:08:59 -0700 (PDT)","from bill-the-cat ([187.144.104.2]) by smtp.gmail.com with ESMTPSA\n id\n af79cd13be357-7b18d359743sm7433285a.135.2024.10.24.18.08.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 24 Oct 2024 18:08:57 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1729818538; x=1730423338; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=FMlKIuTRxGKl9aZm58SvckeeJ5+QNcx1dn+lE/FbevQ=;\n b=cgs0VcMBKAjI9YJUDmbJdNoa6hAuzE0AIdTPSat/C7y6YSsWLSqQcOnNTwLfSYN0dT\n ay8oaRzwzaksTpAZYdOc0TVm7q98LNlSn7GHh8zO1cpRCX2ZSWMDZ/3J7KO/VISlEln5\n jhV2EDvCIA46P+ncS7wR3tkKPix+J3RqX9D44=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1729818538; x=1730423338;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FMlKIuTRxGKl9aZm58SvckeeJ5+QNcx1dn+lE/FbevQ=;\n b=aoxBFBnOZyhMZoNuXz8tYXqbaausmhb4FRfBdTVh5MTckaOHsobVzCZRPFqAU5WgXq\n wmUTh0bsZvpUcaE68dEEAPhjfwI9lnrmhUasavlIG75UBqctHsiFCrnUKmL+t7U1MJJ+\n c+C642WJKOdkMuEGsnmFt6DR+YkGXyAxwbhG8+azHPCiI8EDIr0zhveH+UPbyNng0rix\n fF6D+NbUi3DvXZfjgbWOQ0BKI0Mozf3p8oA4llhBFzGqIUIMHmCw0oWvq5s1oDC78Doq\n OvozutiWkPPf+d+GF682kkYLLi7xLtIfooE5iziMYU8wc9Osb+bjf5gxwoHfMju/IL/n\n SQdQ==","X-Gm-Message-State":"AOJu0YyPUGlKZ5odjWnkz6o0IciXUnH2FONbC970UzhrX+QpI9z5iEJi\n nYRoG4sfuq+QpwUQdGJyX85OvLXXzUaixQzH3iwUnpIf24tncnVSwCWf+INQQ0Y=","X-Google-Smtp-Source":"\n AGHT+IFeMCFnQCmc0h3oT+1Kq3TeofxN5kZXNfSnGOYLHZfl5y6D0jZ2QlyxVYwgledaehGAipX5sA==","X-Received":"by 2002:a05:620a:198a:b0:7b1:4783:aa2 with SMTP id\n af79cd13be357-7b1865c79bemr577156585a.7.1729818538256;\n Thu, 24 Oct 2024 18:08:58 -0700 (PDT)","Date":"Thu, 24 Oct 2024 19:08:54 -0600","From":"Tom Rini ","To":"Jan Kiszka , Simon Glass ","Cc":"U-Boot Mailing List , Bryan Brattlof ,\n Nishanth Menon ","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","Message-ID":"<20241025010854.GX4959@bill-the-cat>","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"9MW74U9pkx4j9HNO\"","Content-Disposition":"inline","In-Reply-To":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>","X-Clacks-Overhead":"GNU Terry Pratchett","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3403073,"web_url":"http://patchwork.ozlabs.org/comment/3403073/","msgid":"","list_archive_url":null,"date":"2024-10-27T14:56:26","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Jan,\n\nOn Wed, 23 Oct 2024 at 06:14, Jan Kiszka wrote:\n>\n> On 23.10.24 05:39, Simon Glass wrote:\n> > Hi Jan,\n> >\n> > On Tue, 22 Oct 2024 at 21:41, Jan Kiszka wrote:\n> >>\n> >> On 22.10.24 19:00, Simon Glass wrote:\n> >>> On Tue, 22 Oct 2024 at 08:06, Jan Kiszka wrote:\n> >>>>\n> >>>> From: Jan Kiszka \n> >>>>\n> >>>> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n> >>>> be first used by the IOT2050 boards.\n> >>>>\n> >>>> Based on original patch by Li Hua Qian.\n> >>>>\n> >>>> Signed-off-by: Jan Kiszka \n> >>>> ---\n> >>>> include/sysinfo.h | 1 +\n> >>>> lib/smbios.c | 4 ++++\n> >>>> 2 files changed, 5 insertions(+)\n> >>>\n> >>> Reviewed-by: Simon Glass \n> >>>\n> >>> What is this used for? Would you mind adding a comment for it? Should\n> >>> mention that it is a struct uuid\n> >>>\n> >>\n> >> What exactly is unclear here? The System UUID is a part of the SMBIOS\n> >> spec that U-Boot just ignored so far.\n> >\n> > OK, well that just mention that, along with the data type.\n> >\n>\n> Now that I look at your data type comment again: It's actually not ok to\n> misuse sysinfo_get_str for transporting this. The UUID is not converted\n> into a string by the driver, it is rather returned raw and may even\n> terminate prematurely if containing some zero. We need a new\n> sysinfo_get_bin or raw op.\n\nYes, perhaps just sysinfo_get() to read binary info?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=JHQgqOVK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"JHQgqOVK\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Xc0493nJyz1xw0\n\tfor ; Mon, 28 Oct 2024 01:57:29 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 30D8D8897F;\n\tSun, 27 Oct 2024 15:57:22 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id D2F4A88DCC; Sun, 27 Oct 2024 15:57:21 +0100 (CET)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n [IPv6:2a00:1450:4864:20::634])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8DFDA8857C\n for ; Sun, 27 Oct 2024 15:57:16 +0100 (CET)","by mail-ej1-x634.google.com with SMTP id\n a640c23a62f3a-a9a68480164so479115566b.3\n for ; Sun, 27 Oct 2024 07:57:16 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1730041036; x=1730645836; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=c2vhfkR7NuVaJpqs376NMZ55ExERvkI4Ey2KGpL2ESk=;\n b=JHQgqOVKrH/9BKjT31x0rBqZ7SUnPDjxswAqD9lDwIUQSb2HeFFcHSGQhDguvnmq28\n KBPUeRiM54v+Z9c0TKpK7mqW69qPfAgR7f+5ST8I3KAgkYoD2qMjFpc9/YzFxWwrtjDG\n 45OxRgsayk5yhTdOmca1F9TABCuH1R+Hl5KZk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1730041036; x=1730645836;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=c2vhfkR7NuVaJpqs376NMZ55ExERvkI4Ey2KGpL2ESk=;\n b=gmcwDb4SZ9rB5AybB5CkVoD4vPKwdx8fmxQA3zLktEIlmVLl+34fVRvHD6pOFdLPz7\n vzWWrZ9bob+X16F4x24Qgc8Y3H/HUf2zVj4Hqbacic1vYVBRYPzl+e2i+oN/AX0ldcpm\n W93d2KU1/WZ85yozz0lUhvO2BTa7H2XNxm6ehd7zb4vBIV/bTLYdUKno/GqwVfYbNiqo\n ok6xaI14EIDT5TEGjw0eqf3n8wkQQwMoRcqfUbpxrHjZcr4/WcN9epIdhM+JscUpt/jh\n SQjbsopGB1tu31jOXlLZHX4c7NFo3mLVmH6lH33AqubsyOLoPf3Hc/Yao347A/gVe71M\n f7jw==","X-Gm-Message-State":"AOJu0Ywwi0H/QJ8wNpX9y6fzm/XBb5d1BJip6CYWBBshlEUXzKx2UQlW\n UciADCMnhKLPN1afIlU/Oi70bLbzb0tYYN5BCHgYhN0aEbfmq/xkVuJtEqn0P3+//ar7dHwAGFz\n rq5dVoqaaxs0P2EhH/C5mC3/5nCQ9u44ZOKnR","X-Google-Smtp-Source":"\n AGHT+IEfOmnvD0dJnhH4caWXtOlfwp+iLW1Q0hqmBRPK8xIfA9J68Si6giYtAvl+uekGvZVSe8c3Nr/KU1T48g2tx9U=","X-Received":"by 2002:a17:907:7f13:b0:a99:5f2a:444d with SMTP id\n a640c23a62f3a-a9de61a0feemr457008166b.56.1730041036045; Sun, 27 Oct 2024\n 07:57:16 -0700 (PDT)","MIME-Version":"1.0","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>\n \n \n \n <6bdd212e-2a70-4c32-a463-c83cbf7bd0c7@siemens.com>","In-Reply-To":"<6bdd212e-2a70-4c32-a463-c83cbf7bd0c7@siemens.com>","From":"Simon Glass ","Date":"Sun, 27 Oct 2024 15:56:26 +0100","Message-ID":"\n ","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","To":"Jan Kiszka ","Cc":"U-Boot Mailing List , Bryan Brattlof ,\n Nishanth Menon ,\n \"Li, Hua Qian (DI FA CTR IPC CN PRC4)\" ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3403337,"web_url":"http://patchwork.ozlabs.org/comment/3403337/","msgid":"<9403aab1-7d2a-4fa0-b2e0-974fba21e749@siemens.com>","list_archive_url":null,"date":"2024-10-28T05:57:01","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":710,"url":"http://patchwork.ozlabs.org/api/people/710/","name":"Jan Kiszka","email":"jan.kiszka@siemens.com"},"content":"On 27.10.24 15:56, Simon Glass wrote:\n> Hi Jan,\n> \n> On Wed, 23 Oct 2024 at 06:14, Jan Kiszka wrote:\n>>\n>> On 23.10.24 05:39, Simon Glass wrote:\n>>> Hi Jan,\n>>>\n>>> On Tue, 22 Oct 2024 at 21:41, Jan Kiszka wrote:\n>>>>\n>>>> On 22.10.24 19:00, Simon Glass wrote:\n>>>>> On Tue, 22 Oct 2024 at 08:06, Jan Kiszka wrote:\n>>>>>>\n>>>>>> From: Jan Kiszka \n>>>>>>\n>>>>>> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n>>>>>> be first used by the IOT2050 boards.\n>>>>>>\n>>>>>> Based on original patch by Li Hua Qian.\n>>>>>>\n>>>>>> Signed-off-by: Jan Kiszka \n>>>>>> ---\n>>>>>> include/sysinfo.h | 1 +\n>>>>>> lib/smbios.c | 4 ++++\n>>>>>> 2 files changed, 5 insertions(+)\n>>>>>\n>>>>> Reviewed-by: Simon Glass \n>>>>>\n>>>>> What is this used for? Would you mind adding a comment for it? Should\n>>>>> mention that it is a struct uuid\n>>>>>\n>>>>\n>>>> What exactly is unclear here? The System UUID is a part of the SMBIOS\n>>>> spec that U-Boot just ignored so far.\n>>>\n>>> OK, well that just mention that, along with the data type.\n>>>\n>>\n>> Now that I look at your data type comment again: It's actually not ok to\n>> misuse sysinfo_get_str for transporting this. The UUID is not converted\n>> into a string by the driver, it is rather returned raw and may even\n>> terminate prematurely if containing some zero. We need a new\n>> sysinfo_get_bin or raw op.\n> \n> Yes, perhaps just sysinfo_get() to read binary info?\n> \n\n-EEXIST: \"Return the sysinfo device for the sysinfo in question\"\n\nJan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.a=rsa-sha256\n header.s=selector2 header.b=McUqQOS1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.b=\"McUqQOS1\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=jan.kiszka@siemens.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=siemens.com;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XcN2Q0fK9z1xwF\n\tfor ; Mon, 28 Oct 2024 16:57:18 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 49F5E881FD;\n\tMon, 28 Oct 2024 06:57:10 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id C678E88F71; Mon, 28 Oct 2024 06:57:08 +0100 (CET)","from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on20604.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:2612::604])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C63388811C\n for ; Mon, 28 Oct 2024 06:57:03 +0100 (CET)","from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19)\n by AS2PR10MB7802.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:64d::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.17; Mon, 28 Oct\n 2024 05:57:02 +0000","from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::8fe1:7e71:cf4a:7408]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::8fe1:7e71:cf4a:7408%3]) with mapi id 15.20.8114.007; Mon, 28 Oct 2024\n 05:57:02 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=I+gqXqxD91jN8lD5fSWcN8BOrnwxbGZa40I6QFrPIER+HhKO9GFHPLaj+g6tu9Kw3cH1GwWkoZeSXEkAknQtrm3VM9jOJX2nDddY3E5ImcWNsOxbPJwbT4K99qvxJ/0pvtWD5dN//NDPihkJlG0Zm+XP5w/3FJCBgQmn4jrZ86xxhFLVVgTSz4TkuaeeNldLoTTnxTmdAdeltDPOgudJ7YhC7IPhicBDiu6j1bjgw9o74ze8ULn9fiPOLiTqYpxmkoBUFwgATFgTMxgeKIUA3CWKBfCuDBgK8e2FTINbuTti2xgbOdVkHBDfwhFLqtUSOg5LNefjR1of1exGB9LOsA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=AYKmjv1AeoD3hMfe48qg5A7GRRnRR/nCIFW5KTn8U7o=;\n b=NEgsiHXwOyvgiCqDp06hWp0c+H4mFg+T4jZjuMWKIbZ1p0Ennd+H+WMmUB1AEb/s+gxBOQAfqRcf9hd+xg8yo3iHrQMozsqNgWrUY20bcbk+UQZ1SN0cQvZrxnJej/H9ceDTUGuwT3F4iUCLvEWm2BIOQWqRQQzyER6bHH4Sok+7phB98W4sqDnLrN5gZn9eDRhWEZCBMdnXWpuACtN6rwJ/0Gcugvb0OPaHt5enTEpqO+pCJIsatmaX7BTk57cnSov6Wmtv/BUg8Xa6wxuApH65onjW/RDl1dG4+gKNdTF9r14/0lMCXlHY+m8rMRewY2OpEG5ObxpVJ0UPxrNCiQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com;\n dkim=pass header.d=siemens.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AYKmjv1AeoD3hMfe48qg5A7GRRnRR/nCIFW5KTn8U7o=;\n b=McUqQOS1vQTMoS+cmaMSxybart2Y3osxJYCpK8noBgI3LoMnLF0bNZ+6SuGJqmEFHF1hxmvujWd8JEILDbDy/ZPFNpDAJ9Zhc6IKZGlvKeL/ve7Ts0xgCxMq2oip3a+8dOmDwHSfHswsKiZvYWG8HT25Dc/QLJhHkV1jTCXuEX0DZ6kanHBrpErqMAMRJSz22DMC1w5dbuQNMr3sY/BEZTFPgJ6KA2wYKJSNV5K4rgfE7YitYLpKXCzup1KixhV9+bUqKj40Efr47BmEMillZVNS2uTP766kayUwo/EGA4m4tHlP+fodsjlgd01PPE0xWtpDEvCvebD1IPQsVCFqrQ==","Message-ID":"<9403aab1-7d2a-4fa0-b2e0-974fba21e749@siemens.com>","Date":"Mon, 28 Oct 2024 06:57:01 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","To":"Simon Glass ","Cc":"U-Boot Mailing List , Bryan Brattlof ,\n Nishanth Menon ,\n \"Li, Hua Qian (DI FA CTR IPC CN PRC4)\" ","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>\n \n \n \n <6bdd212e-2a70-4c32-a463-c83cbf7bd0c7@siemens.com>\n ","Content-Language":"en-US","From":"Jan Kiszka ","Autocrypt":"addr=jan.kiszka@siemens.com; keydata=\n xsFNBGZY+hkBEACkdtFD81AUVtTVX+UEiUFs7ZQPQsdFpzVmr6R3D059f+lzr4Mlg6KKAcNZ\n uNUqthIkgLGWzKugodvkcCK8Wbyw+1vxcl4Lw56WezLsOTfu7oi7Z0vp1XkrLcM0tofTbClW\n xMA964mgUlBT2m/J/ybZd945D0wU57k/smGzDAxkpJgHBrYE/iJWcu46jkGZaLjK4xcMoBWB\n I6hW9Njxx3Ek0fpLO3876bszc8KjcHOulKreK+ezyJ01Hvbx85s68XWN6N2ulLGtk7E/sXlb\n 79hylHy5QuU9mZdsRjjRGJb0H9Buzfuz0XrcwOTMJq7e7fbN0QakjivAXsmXim+s5dlKlZjr\n L3ILWte4ah7cGgqc06nFb5jOhnGnZwnKJlpuod3pc/BFaFGtVHvyoRgxJ9tmDZnjzMfu8YrA\n +MVv6muwbHnEAeh/f8e9O+oeouqTBzgcaWTq81IyS56/UD6U5GHet9Pz1MB15nnzVcyZXIoC\n roIhgCUkcl+5m2Z9G56bkiUcFq0IcACzjcRPWvwA09ZbRHXAK/ao/+vPAIMnU6OTx3ejsbHn\n oh6VpHD3tucIt+xA4/l3LlkZMt5FZjFdkZUuAVU6kBAwElNBCYcrrLYZBRkSGPGDGYZmXAW/\n VkNUVTJkRg6MGIeqZmpeoaV2xaIGHBSTDX8+b0c0hT/Bgzjv8QARAQABzSNKYW4gS2lzemth\n IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPsLBlAQTAQoAPhYhBABMZH11cs99cr20+2mdhQqf\n QXvYBQJmWPvXAhsDBQkFo5qABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGmdhQqfQXvY\n zPAP/jGiVJ2VgPcRWt2P8FbByfrJJAPCsos+SZpncRi7tl9yTEpS+t57h7myEKPdB3L+kxzg\n K3dt1UhYp4FeIHA3jpJYaFvD7kNZJZ1cU55QXrJI3xu/xfB6VhCs+VAUlt7XhOsOmTQqCpH7\n pRcZ5juxZCOxXG2fTQTQo0gfF5+PQwQYUp0NdTbVox5PTx5RK3KfPqmAJsBKdwEaIkuY9FbM\n 9lGg8XBNzD2R/13cCd4hRrZDtyegrtocpBAruVqOZhsMb/h7Wd0TGoJ/zJr3w3WnDM08c+RA\n 5LHMbiA29MXq1KxlnsYDfWB8ts3HIJ3ROBvagA20mbOm26ddeFjLdGcBTrzbHbzCReEtN++s\n gZneKsYiueFDTxXjUOJgp8JDdVPM+++axSMo2js8TwVefTfCYt0oWMEqlQqSqgQwIuzpRO6I\n ik7HAFq8fssy2cY8Imofbj77uKz0BNZC/1nGG1OI9cU2jHrqsn1i95KaS6fPu4EN6XP/Gi/O\n 0DxND+HEyzVqhUJkvXUhTsOzgzWAvW9BlkKRiVizKM6PLsVm/XmeapGs4ir/U8OzKI+SM3R8\n VMW8eovWgXNUQ9F2vS1dHO8eRn2UqDKBZSo+qCRWLRtsqNzmU4N0zuGqZSaDCvkMwF6kIRkD\n ZkDjjYQtoftPGchLBTUzeUa2gfOr1T4xSQUHhPL8zsFNBGZY+hkBEADb5quW4M0eaWPIjqY6\n aC/vHCmpELmS/HMa5zlA0dWlxCPEjkchN8W4PB+NMOXFEJuKLLFs6+s5/KlNok/kGKg4fITf\n Vcd+BQd/YRks3qFifckU+kxoXpTc2bksTtLuiPkcyFmjBph/BGms35mvOA0OaEO6fQbauiHa\n QnYrgUQM+YD4uFoQOLnWTPmBjccoPuiJDafzLxwj4r+JH4fA/4zzDa5OFbfVq3ieYGqiBrtj\n tBFv5epVvGK1zoQ+Rc+h5+dCWPwC2i3cXTUVf0woepF8mUXFcNhY+Eh8vvh1lxfD35z2CJeY\n txMcA44Lp06kArpWDjGJddd+OTmUkFWeYtAdaCpj/GItuJcQZkaaTeiHqPPrbvXM361rtvaw\n XFUzUlvoW1Sb7/SeE/BtWoxkeZOgsqouXPTjlFLapvLu5g9MPNimjkYqukASq/+e8MMKP+EE\n v3BAFVFGvNE3UlNRh+ppBqBUZiqkzg4q2hfeTjnivgChzXlvfTx9M6BJmuDnYAho4BA6vRh4\n Dr7LYTLIwGjguIuuQcP2ENN+l32nidy154zCEp5/Rv4K8SYdVegrQ7rWiULgDz9VQWo2zAjo\n TgFKg3AE3ujDy4V2VndtkMRYpwwuilCDQ+Bpb5ixfbFyZ4oVGs6F3jhtWN5Uu43FhHSCqUv8\n FCzl44AyGulVYU7hTQARAQABwsF8BBgBCgAmFiEEAExkfXVyz31yvbT7aZ2FCp9Be9gFAmZY\n +hkCGwwFCQWjmoAACgkQaZ2FCp9Be9hN3g/8CdNqlOfBZGCFNZ8Kf4tpRpeN3TGmekGRpohU\n bBMvHYiWW8SvmCgEuBokS+Lx3pyPJQCYZDXLCq47gsLdnhVcQ2ZKNCrr9yhrj6kHxe1Sqv1S\n MhxD8dBqW6CFe/mbiK9wEMDIqys7L0Xy/lgCFxZswlBW3eU2Zacdo0fDzLiJm9I0C9iPZzkJ\n gITjoqsiIi/5c3eCY2s2OENL9VPXiH1GPQfHZ23ouiMf+ojVZ7kycLjz+nFr5A14w/B7uHjz\n uL6tnA+AtGCredDne66LSK3HD0vC7569sZ/j8kGKjlUtC+zm0j03iPI6gi8YeCn9b4F8sLpB\n lBdlqo9BB+uqoM6F8zMfIfDsqjB0r/q7WeJaI8NKfFwNOGPuo93N+WUyBi2yYCXMOgBUifm0\n T6Hbf3SHQpbA56wcKPWJqAC2iFaxNDowcJij9LtEqOlToCMtDBekDwchRvqrWN1mDXLg+av8\n qH4kDzsqKX8zzTzfAWFxrkXA/kFpR3JsMzNmvextkN2kOLCCHkym0zz5Y3vxaYtbXG2wTrqJ\n 8WpkWIE8STUhQa9AkezgucXN7r6uSrzW8IQXxBInZwFIyBgM0f/fzyNqzThFT15QMrYUqhhW\n ZffO4PeNJOUYfXdH13A6rbU0y6xE7Okuoa01EqNi9yqyLA8gPgg/DhOpGtK8KokCsdYsTbk=","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR2P281CA0155.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:98::15) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:588::19)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS4PR10MB6181:EE_|AS2PR10MB7802:EE_","X-MS-Office365-Filtering-Correlation-Id":"ccf765e5-187f-4cc8-06b0-08dcf7155820","X-MS-Exchange-AtpMessageProperties":"SA","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;ARA:13230040|1800799024|366016|376014;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?Sy9S92nkCJElFp0eLg0RuFomhof/iVE?=\n\t=?utf-8?q?fBpOcUdgc3dFzDaCGTF+PhAbWJa45n3nMqdzvT5auzoPmbI40fV5lDCzigr0e03Dh?=\n\t=?utf-8?q?68Hg0M9iC+b9jskXKv5cqWn+4kd3F9lslbi7sF4aCKnTsIXWRBzzj/1RWc0jsaBus?=\n\t=?utf-8?q?Jhm/oEKvsTgxvr0tr1IOrwDFWgCNTlpS7GuvoIQTlxzclAIp26dKZQHuvPS19wG/C?=\n\t=?utf-8?q?JNfVyvWtnCoiOTCKVuZRjLlFsJyk2TGunMYU0H+rPy0Ni1ovZSnyALzO/PXlmBNXx?=\n\t=?utf-8?q?M59r87O6qAHCc3cYPyhJpXKyDSrAfTg4Skkghw4K/eXbthe75Qm+7gy90fkPXjd7n?=\n\t=?utf-8?q?AR36j9xPv9Nko0pngHoIDjhidbF2DqbDHCNAOgFx0gtTMoo9PXE1D3pD7OKwjVueJ?=\n\t=?utf-8?q?NUGu5NoOC5NI4aV/6qKNvI1Vb3FX3AOx9VRPepWWcNSpqB4PkhlQ5zkfzkj9QTGV+?=\n\t=?utf-8?q?Ly7l0Y/RQhAqYnVIvnlO7K63qgzL5kI+N6jkQqXzHiTVuTWqI6l9/WYEw5ydfrtO+?=\n\t=?utf-8?q?3yAAm2kpR5I8VplC5JwzlmUPge7VgGqyVTvJWVv2zTjkua/OL4onsS53tsOVGzVBE?=\n\t=?utf-8?q?+KFRECpWBxuKXqV7mBG3Qi6iK6FEz17j+JCp7Qt8LgIQX5vj3pWmxwwaCxo7pfgl0?=\n\t=?utf-8?q?O+pIk4AyKvYp3rfljtwjJW1YUrQZ21aqM7XZgHtHA8sVJepBg/6Qm2rhZFUgMDrQ7?=\n\t=?utf-8?q?/huVDJ21AtPG0W5xBZC5mOK/TQwS5tN72BtXZBcnN32Pgq3mHwAWXuU9EOD2/cAoI?=\n\t=?utf-8?q?YckPeOssabOAFtOa8izqKM/9YdNCNNoMtFOhAY0wT5QODgSxcrbMquBBEGCjXk2N/?=\n\t=?utf-8?q?erpenrBhaDjMAMlzf9oEQFa/eMwvYujDFeUbcYQ2b/f0yg6tUzNiVCcAXt1wmmaKN?=\n\t=?utf-8?q?V13ZRQrwxl2bPo8C+TYs3rOa2F0iabqSkiD6cjP3bwxxdE/m7iKiLba1wpwQD6nDB?=\n\t=?utf-8?q?n2U+TVOiWM+fB+dylpAGVp/4QTpgdgG2JOUHOFTXetjIDiXZ7YUXX+m6RLjUXJXOz?=\n\t=?utf-8?q?GvFzB76dG8uBIn9kagambpchcvqyJJrYM4vB2cH8TyxqN7LejnKiQi7EZvtO8OR19?=\n\t=?utf-8?q?EnOgeilAMtuiEPOZNPmdA/RE3OMsrdasvWqkbzS9sthK2oTdpG1k+wJBAIum5Lyty?=\n\t=?utf-8?q?jTxkFK2X50VauKFjMMIkd72sT4r2dnqDXVCrq76JnKqaLoGZnmiY4J66SkJ4GXlF5?=\n\t=?utf-8?q?v2BoqUx13y+LibpbgoR0Bm811pS5xLY5LMdwsCE1kxeprWZzkq/aRR3tBsT94V/ME?=\n\t=?utf-8?q?NCH3UYRxJaKEk?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?bvgHdXBfObyfunuty7GwPEhI16bs?=\n\t=?utf-8?q?ONIUVxaVm1NhFQmMUXCElwKZSiulqRptTwTPr3/ijkNQQHPwzU55lf9htnGHCpO0R?=\n\t=?utf-8?q?sC+JS46CGwweIFug6I0YLFbOLmtr5oRrK2DDLMB6up4tSOFoqkqKPE7smWY6yYiNg?=\n\t=?utf-8?q?Up2xmcAXwfjiDR7/tjIJGHSwT4iJB5azfM6ipOmTgKTId4IX7k4s8WADZZX7R/GV6?=\n\t=?utf-8?q?K2kv14bh+Rt7UcZBJ+B3t+0Sbo8qUZmIAPaath3oGKHP7j51NXS2RLx+Z11NJ9vtg?=\n\t=?utf-8?q?bpvSSgmvTepXjCesZuBrPmQ1Ig6Z+Ry5AWl2PbrESaGeNwNbRu8Hx4hNA8Ifd2VVZ?=\n\t=?utf-8?q?OAt2txzjgbrGmpcDWjw4TMMEGg+XdUa/gwNHVkQIhYAB+2t2IAltGbOOFErUYaB4/?=\n\t=?utf-8?q?ZGFsW7vG1YrpTOHn+V46bKs1q698IQT88V367p6u7C+RhkpXkEn47A/IWaHykUvdF?=\n\t=?utf-8?q?qtWXO7fLXhzgHrBArHzIDLyvQ7y3pY9t+pzZs5QDN6lhNMbkDHYt4yGdfNE/HcbIA?=\n\t=?utf-8?q?dIXuAS81BXzQ2Fe3Ym+S0Lglcbq6xO9bP7r5rMY5kI1g1eEe7NAd2smYrg4jdkNCU?=\n\t=?utf-8?q?0ef1dvnncjDJYahllYQCWef1XLdH9st28DiOExnkp/8nS3NW9WfRH3y6FvMogNvmy?=\n\t=?utf-8?q?v8yFGd6C4pQeo+wzhV+qcOJq3zt6aBUcvbr16f7WFJXXAWNRd1hRKcE3spvfuW9VE?=\n\t=?utf-8?q?/9EIZS/C7FntTV6Ne1co8jzeKhnXrJIU+2t8X31W6Le20k8Rc6dGkQcrSJi3/7fg/?=\n\t=?utf-8?q?sXMX53TwVq4SeT2EU1YbHBSOLvtqxFQQI9hcVXBzGUDsEb8veXGCUoluLjEzWF/eZ?=\n\t=?utf-8?q?UH5K5gDtrP/hcqlPAyXfpl0V3EQxBeKt4g93INGlPCdV8oT5Syl3GgpbXkacBSvS5?=\n\t=?utf-8?q?H0NDfnljq3pOI7P7U8lENVY4RsiIgPL2GnKB4qbofbRk+G9GDgH7dCpZieryxPGzj?=\n\t=?utf-8?q?IPP6M86sIvsv+qB8bg1kl+jAWl3MWgC8kMXs+YEBOocXCgkEVV7/4Cu14yDh4tPEZ?=\n\t=?utf-8?q?QnjQp+qlaAUktQQMwF4bAGJXtf7TyW0RhZ0GolmtvmqJWDn8DmhLOolgQgTde/uDa?=\n\t=?utf-8?q?N9f8ugwIWVFukGvzlAHehyA2Mmk0nvGRFRr3BmSa2SL1dfq0vu2XYogu8vRi5oTI1?=\n\t=?utf-8?q?w09pPDxZYBdkf3C6VvqIt56Pht0bX+x6POsuzMuzIS4MlN9YZdtSKlr4X/64nzVoM?=\n\t=?utf-8?q?k7ghWxFvPnnBWB/1Aq4xPWFhUjcFg8ztALigIrBc6k5uVJCG0Zc3+j9DbXuSnO8ZI?=\n\t=?utf-8?q?AmyBsXOxrdvBlOY4FxyMUnFjXZE4aOhLg2h6+MXqpxT6Noarbwqqe6EucIBUmGeYz?=\n\t=?utf-8?q?Bkpih1pwJ/CCn+GSRDPA+LooCHIBefOv2fBTGPB5UOC++atTzKS1Z1/9mQ+fyNEOK?=\n\t=?utf-8?q?/g2kueIIrP1disGcItd5aggwzBz435jIwMGwfv6aAW5f5Nn/Y+Fhq6sOdgV3LPACE?=\n\t=?utf-8?q?hTT6nw8OvPaSJ61hXZGMlHQzVGoHgB6avBkc54tUcq5mQVBm40PYOf1l+BQaW99Tc?=\n\t=?utf-8?q?17kYvChgF0rH?=","X-OriginatorOrg":"siemens.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n ccf765e5-187f-4cc8-06b0-08dcf7155820","X-MS-Exchange-CrossTenant-AuthSource":"AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"28 Oct 2024 05:57:02.5756 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"38ae3bcd-9579-4fd4-adda-b42e1495d55a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n fRAUON3GwV5vg4+7GkBw6Kpw4yjYB2gg2pub8Zv9wE4owG8nw02vHznLve18nGSad3N2jYfc22KYevERMEIpig==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS2PR10MB7802","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3403349,"web_url":"http://patchwork.ozlabs.org/comment/3403349/","msgid":"","list_archive_url":null,"date":"2024-10-28T06:12:46","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":710,"url":"http://patchwork.ozlabs.org/api/people/710/","name":"Jan Kiszka","email":"jan.kiszka@siemens.com"},"content":"On 25.10.24 03:08, Tom Rini wrote:\n> On Tue, Oct 22, 2024 at 08:04:28AM +0200, Jan Kiszka wrote:\n> \n>> From: Jan Kiszka \n>>\n>> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n>> be first used by the IOT2050 boards.\n>>\n>> Based on original patch by Li Hua Qian.\n>>\n>> Signed-off-by: Jan Kiszka \n>> Reviewed-by: Simon Glass \n>> ---\n>> include/sysinfo.h | 1 +\n>> lib/smbios.c | 4 ++++\n>> 2 files changed, 5 insertions(+)\n>>\n>> diff --git a/include/sysinfo.h b/include/sysinfo.h\n>> index 8a77ef44856..1c5008b5f23 100644\n>> --- a/include/sysinfo.h\n>> +++ b/include/sysinfo.h\n>> @@ -49,6 +49,7 @@ enum sysinfo_id {\n>> \tSYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n>> \tSYSINFO_ID_SMBIOS_SYSTEM_SKU,\n>> \tSYSINFO_ID_SMBIOS_SYSTEM_FAMILY,\n>> +\tSYSINFO_ID_SMBIOS_SYSTEM_UUID,\n>> \tSYSINFO_ID_SMBIOS_BASEBOARD_MANUFACTURER,\n>> \tSYSINFO_ID_SMBIOS_BASEBOARD_PRODUCT,\n>> \tSYSINFO_ID_SMBIOS_BASEBOARD_VERSION,\n>> diff --git a/lib/smbios.c b/lib/smbios.c\n>> index 7c24ea129eb..1441fa4cde6 100644\n>> --- a/lib/smbios.c\n>> +++ b/lib/smbios.c\n>> @@ -387,6 +387,7 @@ static int smbios_write_type1(ulong *current, int handle,\n>> \tstruct smbios_type1 *t;\n>> \tint len = sizeof(struct smbios_type1);\n>> \tchar *serial_str = env_get(\"serial#\");\n>> +\tchar uuid[sizeof(t->uuid)];\n>> \n>> \tt = map_sysmem(*current, len);\n>> \tmemset(t, 0, sizeof(struct smbios_type1));\n>> @@ -409,6 +410,9 @@ static int smbios_write_type1(ulong *current, int handle,\n>> \t\t\t\t\t\t SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n>> \t\t\t\t\t\t NULL);\n>> \t}\n>> +\tif (!sysinfo_get_str(ctx->dev, SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n>> +\t\t\t sizeof(uuid), uuid))\n>> +\t\tstrncpy((char *)t->uuid, uuid, sizeof(t->uuid));\n>> \tt->wakeup_type = SMBIOS_WAKEUP_TYPE_UNKNOWN;\n>> \tt->sku_number = smbios_add_prop_si(ctx, \"sku\",\n>> \t\t\t\t\t SYSINFO_ID_SMBIOS_SYSTEM_SKU, NULL);\n> \n> This commit leads to sandbox (and sandbox with clang) failing a ton of\n> tests:\n> https://source.denx.de/u-boot/u-boot/-/jobs/929474\n> \n> Without this commit in the series, iot2050 fails to build.\n> \n\nStrange on first sight - we will look into this. As this patch and the\nfollowing 2 are only adding a feature, maybe you could already merge the\nfirst 10 patches? Would make v3 shorter for us.\n\nThanks,\nJan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.a=rsa-sha256\n header.s=selector2 header.b=eIFG+JNL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.b=\"eIFG+JNL\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=jan.kiszka@siemens.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=siemens.com;"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XcNNS63C5z1xwF\n\tfor ; Mon, 28 Oct 2024 17:12:56 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7DF3788FE8;\n\tMon, 28 Oct 2024 07:12:54 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 8A0B488FE3; Mon, 28 Oct 2024 07:12:53 +0100 (CET)","from EUR03-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur03on20621.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:260c::621])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4CBF4885F5\n for ; Mon, 28 Oct 2024 07:12:49 +0100 (CET)","from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19)\n by DB4PR10MB6165.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:38a::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.16; Mon, 28 Oct\n 2024 06:12:47 +0000","from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::8fe1:7e71:cf4a:7408]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::8fe1:7e71:cf4a:7408%3]) with mapi id 15.20.8114.007; Mon, 28 Oct 2024\n 06:12:47 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Ywc4usap4RHNw8ZXq6bL7gag23N0FJUwDkAMB4L4b8g9VhrVaCPuJsIoach+lQotojSEqJZQRNHaxP2BPdxN2b1x2+dVMhb0g5lw5VuClZ9zK9XPk0gyL+A9ZV8bjPvECiOd9Xzn5pV/5tFnmcuDuQfBDAE2o6tKk3rdYx04pUPtTCf4xZqtIzMUo8FiGLCKgzr6R1EbEH299DH4bstabm2uEOrhvg4Gnv1aGR7Wc53jTJTb1JCBzhMcqsK0O+M/yfPIilPAh0xoKDrEEoYFEEXJ1iVpXBB8qomUoJ8gX9la8h4N1ODPRyAp2BCHV3XXyE1qEY0XDBvbi0vuE0ysxg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=p2Xc6xBcPSRo6fgEy7PPRO35CZMcHDagPlf0qPU9nNs=;\n b=JC+mmZaLjcDYJUw8ReGP/aB3nLZKSJC2BRzr0JlUt/BQpc7ZH8qPv7snoxDyOnQjlyoP2WFMLxaJVg3sAodNRnyZanuzRRnFkgDD9mKgcxmcuw36TqpgbrDsq9+ogEok2+sceNv0MpXoLhyI5Sqv5ACaoHo25SoR+6MlCtZPim4Op6SjTz60iFvx3F4QySC5bNftQSCpeYp3lTFNROADxVx9kavI6CIqW5xDlajl6ZYveAuxAlr92bg673aIKXDTv9j+8JDhRRRcw8maMbgH1VohS9+eATvJP3Qp1DJkaUGL7noCP5hw0HXqbCyM21EDkq7AZJnVDREaWeEwD7Vo0Q==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com;\n dkim=pass header.d=siemens.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=p2Xc6xBcPSRo6fgEy7PPRO35CZMcHDagPlf0qPU9nNs=;\n b=eIFG+JNLcuxpv65toXsvHoi1pA4S50PvQ5iPtWtYIO25jvyXYYqgmc28k3ooeNhQTlZWUW0l+z83hsOeGybjTxE+0YAxb6dagmuvaa0mlWFAhjRAtguVv274/V3Mu677ey1QfHBzNoYGfB0DK9QFYKq4BnL+1cjHCUSVvigCjS0J9qzX/DVBWCzJF4CD8DgCb81GmLhwNLIrZ0YMTspoPM0WUKNZuyYD8wJZoEdwywsz1P5oN4EL67AxPRHk9h24qXN33E6zVjprjpy6wy+dB/e8rRfZOunlRX0lNA3MqkUxbBHduy/Gg7qPJs7hFQWmL3uqEaSNQ/MtR2fHuoultQ==","Message-ID":"","Date":"Mon, 28 Oct 2024 07:12:46 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","To":"Tom Rini , Simon Glass ","Cc":"U-Boot Mailing List , Bryan Brattlof ,\n Nishanth Menon ","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>\n <20241025010854.GX4959@bill-the-cat>","From":"Jan Kiszka ","Content-Language":"en-US","Autocrypt":"addr=jan.kiszka@siemens.com; keydata=\n xsFNBGZY+hkBEACkdtFD81AUVtTVX+UEiUFs7ZQPQsdFpzVmr6R3D059f+lzr4Mlg6KKAcNZ\n uNUqthIkgLGWzKugodvkcCK8Wbyw+1vxcl4Lw56WezLsOTfu7oi7Z0vp1XkrLcM0tofTbClW\n xMA964mgUlBT2m/J/ybZd945D0wU57k/smGzDAxkpJgHBrYE/iJWcu46jkGZaLjK4xcMoBWB\n I6hW9Njxx3Ek0fpLO3876bszc8KjcHOulKreK+ezyJ01Hvbx85s68XWN6N2ulLGtk7E/sXlb\n 79hylHy5QuU9mZdsRjjRGJb0H9Buzfuz0XrcwOTMJq7e7fbN0QakjivAXsmXim+s5dlKlZjr\n L3ILWte4ah7cGgqc06nFb5jOhnGnZwnKJlpuod3pc/BFaFGtVHvyoRgxJ9tmDZnjzMfu8YrA\n +MVv6muwbHnEAeh/f8e9O+oeouqTBzgcaWTq81IyS56/UD6U5GHet9Pz1MB15nnzVcyZXIoC\n roIhgCUkcl+5m2Z9G56bkiUcFq0IcACzjcRPWvwA09ZbRHXAK/ao/+vPAIMnU6OTx3ejsbHn\n oh6VpHD3tucIt+xA4/l3LlkZMt5FZjFdkZUuAVU6kBAwElNBCYcrrLYZBRkSGPGDGYZmXAW/\n VkNUVTJkRg6MGIeqZmpeoaV2xaIGHBSTDX8+b0c0hT/Bgzjv8QARAQABzSNKYW4gS2lzemth\n IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPsLBlAQTAQoAPhYhBABMZH11cs99cr20+2mdhQqf\n QXvYBQJmWPvXAhsDBQkFo5qABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGmdhQqfQXvY\n zPAP/jGiVJ2VgPcRWt2P8FbByfrJJAPCsos+SZpncRi7tl9yTEpS+t57h7myEKPdB3L+kxzg\n K3dt1UhYp4FeIHA3jpJYaFvD7kNZJZ1cU55QXrJI3xu/xfB6VhCs+VAUlt7XhOsOmTQqCpH7\n pRcZ5juxZCOxXG2fTQTQo0gfF5+PQwQYUp0NdTbVox5PTx5RK3KfPqmAJsBKdwEaIkuY9FbM\n 9lGg8XBNzD2R/13cCd4hRrZDtyegrtocpBAruVqOZhsMb/h7Wd0TGoJ/zJr3w3WnDM08c+RA\n 5LHMbiA29MXq1KxlnsYDfWB8ts3HIJ3ROBvagA20mbOm26ddeFjLdGcBTrzbHbzCReEtN++s\n gZneKsYiueFDTxXjUOJgp8JDdVPM+++axSMo2js8TwVefTfCYt0oWMEqlQqSqgQwIuzpRO6I\n ik7HAFq8fssy2cY8Imofbj77uKz0BNZC/1nGG1OI9cU2jHrqsn1i95KaS6fPu4EN6XP/Gi/O\n 0DxND+HEyzVqhUJkvXUhTsOzgzWAvW9BlkKRiVizKM6PLsVm/XmeapGs4ir/U8OzKI+SM3R8\n VMW8eovWgXNUQ9F2vS1dHO8eRn2UqDKBZSo+qCRWLRtsqNzmU4N0zuGqZSaDCvkMwF6kIRkD\n ZkDjjYQtoftPGchLBTUzeUa2gfOr1T4xSQUHhPL8zsFNBGZY+hkBEADb5quW4M0eaWPIjqY6\n aC/vHCmpELmS/HMa5zlA0dWlxCPEjkchN8W4PB+NMOXFEJuKLLFs6+s5/KlNok/kGKg4fITf\n Vcd+BQd/YRks3qFifckU+kxoXpTc2bksTtLuiPkcyFmjBph/BGms35mvOA0OaEO6fQbauiHa\n QnYrgUQM+YD4uFoQOLnWTPmBjccoPuiJDafzLxwj4r+JH4fA/4zzDa5OFbfVq3ieYGqiBrtj\n tBFv5epVvGK1zoQ+Rc+h5+dCWPwC2i3cXTUVf0woepF8mUXFcNhY+Eh8vvh1lxfD35z2CJeY\n txMcA44Lp06kArpWDjGJddd+OTmUkFWeYtAdaCpj/GItuJcQZkaaTeiHqPPrbvXM361rtvaw\n XFUzUlvoW1Sb7/SeE/BtWoxkeZOgsqouXPTjlFLapvLu5g9MPNimjkYqukASq/+e8MMKP+EE\n v3BAFVFGvNE3UlNRh+ppBqBUZiqkzg4q2hfeTjnivgChzXlvfTx9M6BJmuDnYAho4BA6vRh4\n Dr7LYTLIwGjguIuuQcP2ENN+l32nidy154zCEp5/Rv4K8SYdVegrQ7rWiULgDz9VQWo2zAjo\n TgFKg3AE3ujDy4V2VndtkMRYpwwuilCDQ+Bpb5ixfbFyZ4oVGs6F3jhtWN5Uu43FhHSCqUv8\n FCzl44AyGulVYU7hTQARAQABwsF8BBgBCgAmFiEEAExkfXVyz31yvbT7aZ2FCp9Be9gFAmZY\n +hkCGwwFCQWjmoAACgkQaZ2FCp9Be9hN3g/8CdNqlOfBZGCFNZ8Kf4tpRpeN3TGmekGRpohU\n bBMvHYiWW8SvmCgEuBokS+Lx3pyPJQCYZDXLCq47gsLdnhVcQ2ZKNCrr9yhrj6kHxe1Sqv1S\n MhxD8dBqW6CFe/mbiK9wEMDIqys7L0Xy/lgCFxZswlBW3eU2Zacdo0fDzLiJm9I0C9iPZzkJ\n gITjoqsiIi/5c3eCY2s2OENL9VPXiH1GPQfHZ23ouiMf+ojVZ7kycLjz+nFr5A14w/B7uHjz\n uL6tnA+AtGCredDne66LSK3HD0vC7569sZ/j8kGKjlUtC+zm0j03iPI6gi8YeCn9b4F8sLpB\n lBdlqo9BB+uqoM6F8zMfIfDsqjB0r/q7WeJaI8NKfFwNOGPuo93N+WUyBi2yYCXMOgBUifm0\n T6Hbf3SHQpbA56wcKPWJqAC2iFaxNDowcJij9LtEqOlToCMtDBekDwchRvqrWN1mDXLg+av8\n qH4kDzsqKX8zzTzfAWFxrkXA/kFpR3JsMzNmvextkN2kOLCCHkym0zz5Y3vxaYtbXG2wTrqJ\n 8WpkWIE8STUhQa9AkezgucXN7r6uSrzW8IQXxBInZwFIyBgM0f/fzyNqzThFT15QMrYUqhhW\n ZffO4PeNJOUYfXdH13A6rbU0y6xE7Okuoa01EqNi9yqyLA8gPgg/DhOpGtK8KokCsdYsTbk=","In-Reply-To":"<20241025010854.GX4959@bill-the-cat>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR0P281CA0197.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:ad::20) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:588::19)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS4PR10MB6181:EE_|DB4PR10MB6165:EE_","X-MS-Office365-Filtering-Correlation-Id":"12301971-b2cb-4be2-3c20-08dcf7178b87","X-MS-Exchange-AtpMessageProperties":"SA","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;ARA:13230040|1800799024|366016|376014;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?8LwhaT8fVR2GOuLFv6RDn1pEe4rrmPZ?=\n\t=?utf-8?q?VTHKpxGLsyMoNp9bRDpIaoa7aQ2Ezw/SsYHZixNxds+tDe579esbxKM+XW6j4HRU0?=\n\t=?utf-8?q?dMIFWrB5MRXwOsvVWRkpAevdbkMuxelUeSKW9K8M+h0X81Ra6t82V3NLs8U7oXkZ3?=\n\t=?utf-8?q?hAUIzVVz4dAVcRB3fnZq7sEhCrqIFXJpYfiFlu8gkN08pvOpRqycP0VQ1Rqmpc7cn?=\n\t=?utf-8?q?aVtk5KMFyZzEhu5V9ExtgIG5Vrxm9HflvpMfUMqN8cicI47UfiNG9uxK2eZyxev9+?=\n\t=?utf-8?q?YM+gTNboPYy6ViT3mllwOg59YNLH9kUQ4jEPLUb/T7vsYwkW41ifu7wPKw4d1WVqL?=\n\t=?utf-8?q?E2xUhZacmwK34JoBDp4l0gCBhOaZB2G+BOWdY7Wlhp8QjKQC7d5RcCKd2GwKTKblx?=\n\t=?utf-8?q?nRzXbbmlA2HKAbBjTGUfPdA9s2bS59TG8lcWMukc2RuAjZiFSoak++iMT4+K58YNh?=\n\t=?utf-8?q?pEElBZ21H7McOJExcbv9u9Ag+tHZ4J9/aYBOpbT1rCSV4LE54tKcyd3ZTFydPpFzT?=\n\t=?utf-8?q?BUDBriXuscKeXSsJZNHNIzj1W9Y9vm62rLfZG7lzkfhi0LPVEEOqbDtkCVQduHnjj?=\n\t=?utf-8?q?JIncKTouU1nO0a3DVAqLGDXaVB3ThvSV6w9PmB67hIEw8HaocL4IwfrZO0RsM/Y9i?=\n\t=?utf-8?q?ioMVOb9EShf9dWBn1yIzWP/mVjqUrtvXTjJCUXAQHeoinEkgrOZGbcngxq+cnm9kW?=\n\t=?utf-8?q?reWJiPEOHWpUxydjr8G4OQ6HDldOv1nDvlHZkXjkfafpAoCUcPOVybKgV4TlYbboR?=\n\t=?utf-8?q?bUKAsp/itNxXpANDiyvn3ZseQd1njpOiG3GUIJ72qmCSK/1fGdfTfH6+4esIlaMzF?=\n\t=?utf-8?q?LtNCUzEsqdStQIKoilvfWC5esiDpvwft/u82MLlgABVC8qd4fKsZ4g0Wz1zSAwmBn?=\n\t=?utf-8?q?AuTFgRtZ3m782OXg7u3J10ba/6i+0SMQ07gq/r/X6rXugLTbNVG4raHTm5eLU5NmD?=\n\t=?utf-8?q?sO/rjYlI9xdd83Liw7yjeRm2QjWi9S0yeydflbui2ussfcu23dtrBFFmdCGiiWpAV?=\n\t=?utf-8?q?OBtjg8zlXVNFEY1zDzuyiOcB2tI3+oCV7g59Rxy67snx5N8ZUdV29AwXpnt1Edt4d?=\n\t=?utf-8?q?k882cR8P2j6cS3aJvIye6hvRVR9GmOKfB4+L6ipNL5vP88s/zPT5Ikbp+PQYj7Q0k?=\n\t=?utf-8?q?VSXdSRsTh43F6YNyoGt/gZr4nVJr4NXwYTDDWaYmzc2H3joc2B/jtG9Wi63czWmlm?=\n\t=?utf-8?q?ovstnmyyqHUvWM?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?fk7Otc3rAbnCLkg8KJb6UPpgTMD+?=\n\t=?utf-8?q?AFrk86Hss/rlmHW4xwG7hf/3+VlohpNcetlToYVwpNTwRvA6X+YbXD5RdFQQ8qEQW?=\n\t=?utf-8?q?1M3oCM6C8PyvoyaXnXOPr7fVZUcVc/jY1U/SqTexjzyeUGTc4KFTSeXyhaSGlX55C?=\n\t=?utf-8?q?mh3R1SRdtnAKxkjSjuynpeiGNdEC2GPxWyhLvuKpgCW0tJj8qHxRALcugT+sudlBz?=\n\t=?utf-8?q?wkIqPSoXxkzHYbDG9reYeST4RGwUjML8O5J8+0S9Ji4jBt6NjAZKdgCrlGizJRxpg?=\n\t=?utf-8?q?R3hwVDy91JQ+ldCX2mp1pUQ3dlO60Ghsksgvces3w/4fzafNzjVyOPSWJxlgeN0x1?=\n\t=?utf-8?q?Gg+GRA6iSdXbWnfRmqhbHd3sYCpQ+PpjUrQnOIkcvgZK5SxgVNo7YtKq0+GgysyQW?=\n\t=?utf-8?q?Ea1JOHC1hFBWw+cQApndRhsyOoC84kOqce49eBpiDbYnKcf+kmBGVytLRqVdyM3jW?=\n\t=?utf-8?q?ipQ/TR3yQC9hAmJ/kbhV0SHtcUp5YPbdzCo3F66pLfdiRBBnDaesdcrRvAfgxmGt9?=\n\t=?utf-8?q?lXQraC5hY522M2xdE3wDsPtrQE5EjYbQDVU8/F0d1+IYwoM0SSbXt8urxaxxmXQVf?=\n\t=?utf-8?q?PLGIX7B4/bzlTsFzexju5daMzxUoqaoNwgU/NWTOehHy0qjJj/L0lZYX55EKxoW6y?=\n\t=?utf-8?q?qQ73uRiMSUUUAmU5+lUXfTYRmz3lEGVeM4wj0ILvMzfww8rfQVvUVAJkx347Frjgh?=\n\t=?utf-8?q?v9hQzKIrzkqeg+x6bhS8zrn2MW3VY3Nr8N9edkP48vdYoRARX98VfEhA1oMF4H1cO?=\n\t=?utf-8?q?aE3BMoWmCShfDe6PtuSTnXgRv0T0Ch29Efjj4F62MJAqpib4qAidYLmYGYeQVdn/j?=\n\t=?utf-8?q?qBp7Wk2qJnL43MFccauds4SqeY0TDFG+kAuYmvrR8/szgaRkFJ0C4DsnjOoDZvyJ7?=\n\t=?utf-8?q?xsQeG69pB9IsPZaJjvxgrWgRzprNwKSWe67eHf6boJPhnRWvXWSWNLhz3DIYjyztk?=\n\t=?utf-8?q?8GEmgRsGu7S+rd1fnF1VNaNqMzBrag1EkgciHoyRrwkTTvgiSnkDgCcl1JUq0Z7Jh?=\n\t=?utf-8?q?7528gryOQU6FiNn2jyt2okVmx2r3RqYBZkJZ2saaHFA2umUFoToeDakbeeTFyhDGV?=\n\t=?utf-8?q?dY6JImQgaRkKMnqcQMvNg25hSy4NeHwGVHH5BVSgbud4UwtFq3rDfICVEEJSTKdB0?=\n\t=?utf-8?q?X+OMYWetSGx9c1+ThNZiLpUl9rfC3XxR3JmGh+0gMSfmrQLi2LBKZ7zbwt8equ/nQ?=\n\t=?utf-8?q?g44w4FzDp26m1PPrBC1pmwJh/L1HOm6rCGnaDxAFnZQ7rpuhteHYMGSNkxYezq0YE?=\n\t=?utf-8?q?SvNHMIS6nb2hqDkN5AgPoZnS+W2TYTE5sy7YJTEvfYjDInIR0SavtbmkA/ickFOhk?=\n\t=?utf-8?q?3Rk+Sf+zIhmrIEhBY//h9/ssIWEwcOrS7kCgFg49rgwSvV85UvGNOalpJvyZjE8Y1?=\n\t=?utf-8?q?/0qoSEetuqtsvYXDxGBsjaBL6Pmv3DJkX07vulubHE2GcNDroX3jegNzsAg//3Hj+?=\n\t=?utf-8?q?r6mH3KlgEJ+zz77FMB4k6d3/MYrORZ5drtgFX1mfvt4SjrV0w+LcP4w2dx/awwNcI?=\n\t=?utf-8?q?Sj6oqqi9IpmF?=","X-OriginatorOrg":"siemens.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 12301971-b2cb-4be2-3c20-08dcf7178b87","X-MS-Exchange-CrossTenant-AuthSource":"AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"28 Oct 2024 06:12:47.8116 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"38ae3bcd-9579-4fd4-adda-b42e1495d55a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n qxvVrizKn2klYSlXYUhoPRNY71CympRY85McSjNmcv2z3fkhPV7joPVlBwYoAL3A9vUtlV7LLAfViY+82gbbfg==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB4PR10MB6165","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3403854,"web_url":"http://patchwork.ozlabs.org/comment/3403854/","msgid":"","list_archive_url":null,"date":"2024-10-28T17:02:41","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Jan,\n\nOn Mon, 28 Oct 2024 at 07:12, Jan Kiszka wrote:\n>\n> On 25.10.24 03:08, Tom Rini wrote:\n> > On Tue, Oct 22, 2024 at 08:04:28AM +0200, Jan Kiszka wrote:\n> >\n> >> From: Jan Kiszka \n> >>\n> >> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n> >> be first used by the IOT2050 boards.\n> >>\n> >> Based on original patch by Li Hua Qian.\n> >>\n> >> Signed-off-by: Jan Kiszka \n> >> Reviewed-by: Simon Glass \n> >> ---\n> >> include/sysinfo.h | 1 +\n> >> lib/smbios.c | 4 ++++\n> >> 2 files changed, 5 insertions(+)\n> >>\n> >> diff --git a/include/sysinfo.h b/include/sysinfo.h\n> >> index 8a77ef44856..1c5008b5f23 100644\n> >> --- a/include/sysinfo.h\n> >> +++ b/include/sysinfo.h\n> >> @@ -49,6 +49,7 @@ enum sysinfo_id {\n> >> SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n> >> SYSINFO_ID_SMBIOS_SYSTEM_SKU,\n> >> SYSINFO_ID_SMBIOS_SYSTEM_FAMILY,\n> >> + SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n> >> SYSINFO_ID_SMBIOS_BASEBOARD_MANUFACTURER,\n> >> SYSINFO_ID_SMBIOS_BASEBOARD_PRODUCT,\n> >> SYSINFO_ID_SMBIOS_BASEBOARD_VERSION,\n> >> diff --git a/lib/smbios.c b/lib/smbios.c\n> >> index 7c24ea129eb..1441fa4cde6 100644\n> >> --- a/lib/smbios.c\n> >> +++ b/lib/smbios.c\n> >> @@ -387,6 +387,7 @@ static int smbios_write_type1(ulong *current, int\nhandle,\n> >> struct smbios_type1 *t;\n> >> int len = sizeof(struct smbios_type1);\n> >> char *serial_str = env_get(\"serial#\");\n> >> + char uuid[sizeof(t->uuid)];\n> >>\n> >> t = map_sysmem(*current, len);\n> >> memset(t, 0, sizeof(struct smbios_type1));\n> >> @@ -409,6 +410,9 @@ static int smbios_write_type1(ulong *current, int\nhandle,\n> >>\nSYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n> >> NULL);\n> >> }\n> >> + if (!sysinfo_get_str(ctx->dev, SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n> >> + sizeof(uuid), uuid))\n> >> + strncpy((char *)t->uuid, uuid, sizeof(t->uuid));\n> >> t->wakeup_type = SMBIOS_WAKEUP_TYPE_UNKNOWN;\n> >> t->sku_number = smbios_add_prop_si(ctx, \"sku\",\n> >> SYSINFO_ID_SMBIOS_SYSTEM_SKU,\nNULL);\n> >\n> > This commit leads to sandbox (and sandbox with clang) failing a ton of\n> > tests:\n> > https://source.denx.de/u-boot/u-boot/-/jobs/929474\n> >\n> > Without this commit in the series, iot2050 fails to build.\n> >\n>\n> Strange on first sight - we will look into this. As this patch and the\n> following 2 are only adding a feature, maybe you could already merge the\n> first 10 patches? Would make v3 shorter for us.\n\nI marked the first 10 patches as 'under review'. I'm not sure who is\npicking them up, probably Tom.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=n/lFcAzy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"n/lFcAzy\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XcfpW3Fcfz1xwF\n\tfor ; Tue, 29 Oct 2024 04:02:59 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3413B89100;\n\tMon, 28 Oct 2024 18:02:57 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id A3DB189100; Mon, 28 Oct 2024 18:02:55 +0100 (CET)","from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com\n [IPv6:2a00:1450:4864:20::52a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4D88089098\n for ; Mon, 28 Oct 2024 18:02:53 +0100 (CET)","by mail-ed1-x52a.google.com with SMTP id\n 4fb4d7f45d1cf-5c9362c26d8so9893514a12.1\n for ; Mon, 28 Oct 2024 10:02:53 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1730134973; x=1730739773; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=oLbVqB0BM0SGVnwcUqDXlQagWGOvjoywz1gUvWxTuLo=;\n b=n/lFcAzyxds+AsPL6Sp8ML0qrbOAGH4ogk6S3PjBzt85Ciycm1AXE98sa4YZVkx3nJ\n jZq42UkLRLJClmrGKBN3aUJ2nwKD982Qgd9mi4NINXX9n+MpvwZhfqA+CK6Raw6mytM/\n /VohEj+jDDU6MCfiQ3hhqJAOlkfTA0RpBiGRQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1730134973; x=1730739773;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=oLbVqB0BM0SGVnwcUqDXlQagWGOvjoywz1gUvWxTuLo=;\n b=YTy5OX/rqTxesWjNcJZ4gxmfWrCGLPedvaUO5I4YRKgtBNYbfFaVXIp/vSruCdVWBI\n SpP6DeWnhx+kMmExYGHhthJGc1SURN7jQFWIPyZOq+xHQ5oReErJNWHbZitG21PhYN5N\n xlbSG3TfU0foDaUFA2/0zIern64Y6tXV4WZJlCHeY3OdKsUv4y0+6RA5EFXn0f7xbuK1\n fDyukBjznmWEIbUGE+mAXzgB7mmU2w3b3NmhWBkDfr3xMvb0nXRGa7AcBobhNPuFJ5f8\n ZhIMm8dcUiUlzSsrZcbBwtalEFH5mi0BSwkJqwo87t5QNniIE04P/LMoTqq9vDRKIqpK\n NCyQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVENc3FXqCZbbp8H24FPD5lqWXoMlNvhtS7PbqHrBrLwAnGwDOZjOLJqCpujJ3kKThNr6O6uwQ=@lists.denx.de","X-Gm-Message-State":"AOJu0Yy2CnYa5IAeAMrUN1KOhfqzs/ljT9p1lX2VrCf/P9cwOrddtaUB\n 0qk1DXawpHv+Gvuj9v2D2fx+nqSuvlKtSkgJojiG800wNLrmvBF2iaIbiQPkJ0AGTkKB132oh3c\n +OGFGKty1CILzWRyDkDlPlbtopApQbGzKMMO8","X-Google-Smtp-Source":"\n AGHT+IFSmjiUiLzXNZn2flJxLd7BfRzPPubWI6LxWw7ZtcPi59vSC/658u1kBO7TPWfA1s/LHMvjc+6/gZfmJL/pHaM=","X-Received":"by 2002:a17:907:9808:b0:a99:f777:c6ef with SMTP id\n a640c23a62f3a-a9e2273e2f5mr26767366b.3.1730134972731; Mon, 28 Oct 2024\n 10:02:52 -0700 (PDT)","MIME-Version":"1.0","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>\n <20241025010854.GX4959@bill-the-cat>\n ","In-Reply-To":"","From":"Simon Glass ","Date":"Mon, 28 Oct 2024 18:02:41 +0100","Message-ID":"\n ","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","To":"Jan Kiszka ","Cc":"Tom Rini , U-Boot Mailing List ,\n Bryan Brattlof , Nishanth Menon ","Content-Type":"text/plain; charset=\"UTF-8\"","X-Content-Filtered-By":"Mailman/MimeDel 2.1.39","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3404071,"web_url":"http://patchwork.ozlabs.org/comment/3404071/","msgid":"<20241029000449.GY4959@bill-the-cat>","list_archive_url":null,"date":"2024-10-29T00:04:49","subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Mon, Oct 28, 2024 at 07:12:46AM +0100, Jan Kiszka wrote:\n> On 25.10.24 03:08, Tom Rini wrote:\n> > On Tue, Oct 22, 2024 at 08:04:28AM +0200, Jan Kiszka wrote:\n> > \n> >> From: Jan Kiszka \n> >>\n> >> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will\n> >> be first used by the IOT2050 boards.\n> >>\n> >> Based on original patch by Li Hua Qian.\n> >>\n> >> Signed-off-by: Jan Kiszka \n> >> Reviewed-by: Simon Glass \n> >> ---\n> >> include/sysinfo.h | 1 +\n> >> lib/smbios.c | 4 ++++\n> >> 2 files changed, 5 insertions(+)\n> >>\n> >> diff --git a/include/sysinfo.h b/include/sysinfo.h\n> >> index 8a77ef44856..1c5008b5f23 100644\n> >> --- a/include/sysinfo.h\n> >> +++ b/include/sysinfo.h\n> >> @@ -49,6 +49,7 @@ enum sysinfo_id {\n> >> \tSYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n> >> \tSYSINFO_ID_SMBIOS_SYSTEM_SKU,\n> >> \tSYSINFO_ID_SMBIOS_SYSTEM_FAMILY,\n> >> +\tSYSINFO_ID_SMBIOS_SYSTEM_UUID,\n> >> \tSYSINFO_ID_SMBIOS_BASEBOARD_MANUFACTURER,\n> >> \tSYSINFO_ID_SMBIOS_BASEBOARD_PRODUCT,\n> >> \tSYSINFO_ID_SMBIOS_BASEBOARD_VERSION,\n> >> diff --git a/lib/smbios.c b/lib/smbios.c\n> >> index 7c24ea129eb..1441fa4cde6 100644\n> >> --- a/lib/smbios.c\n> >> +++ b/lib/smbios.c\n> >> @@ -387,6 +387,7 @@ static int smbios_write_type1(ulong *current, int handle,\n> >> \tstruct smbios_type1 *t;\n> >> \tint len = sizeof(struct smbios_type1);\n> >> \tchar *serial_str = env_get(\"serial#\");\n> >> +\tchar uuid[sizeof(t->uuid)];\n> >> \n> >> \tt = map_sysmem(*current, len);\n> >> \tmemset(t, 0, sizeof(struct smbios_type1));\n> >> @@ -409,6 +410,9 @@ static int smbios_write_type1(ulong *current, int handle,\n> >> \t\t\t\t\t\t SYSINFO_ID_SMBIOS_SYSTEM_SERIAL,\n> >> \t\t\t\t\t\t NULL);\n> >> \t}\n> >> +\tif (!sysinfo_get_str(ctx->dev, SYSINFO_ID_SMBIOS_SYSTEM_UUID,\n> >> +\t\t\t sizeof(uuid), uuid))\n> >> +\t\tstrncpy((char *)t->uuid, uuid, sizeof(t->uuid));\n> >> \tt->wakeup_type = SMBIOS_WAKEUP_TYPE_UNKNOWN;\n> >> \tt->sku_number = smbios_add_prop_si(ctx, \"sku\",\n> >> \t\t\t\t\t SYSINFO_ID_SMBIOS_SYSTEM_SKU, NULL);\n> > \n> > This commit leads to sandbox (and sandbox with clang) failing a ton of\n> > tests:\n> > https://source.denx.de/u-boot/u-boot/-/jobs/929474\n> > \n> > Without this commit in the series, iot2050 fails to build.\n> > \n> \n> Strange on first sight - we will look into this. As this patch and the\n> following 2 are only adding a feature, maybe you could already merge the\n> first 10 patches? Would make v3 shorter for us.\n\nOK, I'll see how just the first 10 go shortly.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=ON/EIGUG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"ON/EIGUG\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Xcr9Y5nYfz1xwK\n\tfor ; Tue, 29 Oct 2024 11:05:05 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5E53389152;\n\tTue, 29 Oct 2024 01:04:59 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 493A88915C; Tue, 29 Oct 2024 01:04:58 +0100 (CET)","from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com\n [IPv6:2607:f8b0:4864:20::72a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BD35B8907E\n for ; Tue, 29 Oct 2024 01:04:55 +0100 (CET)","by mail-qk1-x72a.google.com with SMTP id\n af79cd13be357-7b161fa1c7bso362865885a.0\n for ; Mon, 28 Oct 2024 17:04:55 -0700 (PDT)","from bill-the-cat ([187.144.104.2]) by smtp.gmail.com with ESMTPSA\n id\n af79cd13be357-7b18d292c88sm370974385a.30.2024.10.28.17.04.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 28 Oct 2024 17:04:53 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1730160294; x=1730765094; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=KvFH7i+r5Q9bTsx5EQLI4pNHfFZ6RfI3982DgRTR1QQ=;\n b=ON/EIGUGK5HJNBsoNiu947+B0UfsBdwMOyUookK03/Tx8NlxfdgxKjFT+p/dB+AEUF\n krbrpEn0bUA5t9PYs+k+0eI3YZGynGjBneRyxxaoAAuinMcDUXlPfl6x5lFsG3ssjvED\n 0rPbkfOOtByqdYsI2N6MI6PLrTmhvvIpywpgU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1730160294; x=1730765094;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KvFH7i+r5Q9bTsx5EQLI4pNHfFZ6RfI3982DgRTR1QQ=;\n b=wza8Aah8fKPUoQ4ouJiEmrbiNT8s/GN+aLPgZfmSginZCQUc4Dn1EUULJ7BfmUn7nc\n 6aq8BwO66cBeEiLl0dEEB3hYozzbcAMUKDNNqNZIpLp3H3yE4VW5UY/e8l1i6LRa89aL\n IDuIMZSpJXhYRW0b27eHX8qJCtmPO51Cg/A/5ia8DsdHt1gY8GoHLsmlj/259yC1CcbN\n S77GfPx/+Rmrhcag+OC3wn5P29gSdxr1lzk5ebFxC40Eaz3S+LvQ1uDdN5N0CQXBNndq\n IpkVO3WRx3O3hB6WjEyrXqHI2Lv50flVOGEoRBqSKphI8L+g+Ow1IBgTb0edUGHCAbaX\n w8Kg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXFhvgWM61gCyn35UtwmDVlXouw+mmf69vdVEKQ7VI/VJNpOsTiivwezVzO4lgnVA2oQGb5cTE=@lists.denx.de","X-Gm-Message-State":"AOJu0YzEcQY4dNEqTswgnftmwMTUDoGe3+7VE0FOyrL99BzI/QjrNFS0\n hu/NWIdiHAZRhq4m8wBn8qPqLT8XVuPO65+GTf+p8mkYeKOYzgYxU3oDLqp67vo=","X-Google-Smtp-Source":"\n AGHT+IHFoBkboWLUn7P92DEzUDtgxfQsSjrt7USARs6Tqs7SCtfaa47ruqY9LRvTYAJFWulRFmjNeA==","X-Received":"by 2002:a05:620a:4502:b0:7a9:bd59:8de6 with SMTP id\n af79cd13be357-7b193efdeb5mr1445360085a.27.1730160294553;\n Mon, 28 Oct 2024 17:04:54 -0700 (PDT)","Date":"Mon, 28 Oct 2024 18:04:49 -0600","From":"Tom Rini ","To":"Jan Kiszka ","Cc":"Simon Glass ,\n U-Boot Mailing List ,\n Bryan Brattlof , Nishanth Menon ","Subject":"Re: [PATCH v2 11/13] smbios: Fill UUID from sysinfo when available","Message-ID":"<20241029000449.GY4959@bill-the-cat>","References":"\n <9e440edc2a6bdcb7d768d277dd6afb02ab941ecd.1729577070.git.jan.kiszka@siemens.com>\n <20241025010854.GX4959@bill-the-cat>\n ","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"ePwoRGiVn2ztwjMp\"","Content-Disposition":"inline","In-Reply-To":"","X-Clacks-Overhead":"GNU Terry Pratchett","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]