[{"id":3389163,"web_url":"http://patchwork.ozlabs.org/comment/3389163/","msgid":"","list_archive_url":null,"date":"2024-10-04T16:40:54","subject":"Re: [PATCH v2 17/25] hw/m68k: Use explicit big-endian LD/ST API","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 4/10/24 18:30, Philippe Mathieu-Daudé wrote:\n> The M68K architecture uses big endianness. Directly use\n> the big-endian LD/ST API.\n> \n> Mechanical change using:\n> \n> $ end=be; \\\n> for acc in uw w l q tul; do \\\n> sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n> -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n> $(git grep -wlE '(ld|st)t?u?[wlq]_p' hw/m68k/); \\\n> done\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n\nPer v1:\nReviewed-by: Thomas Huth \n\n> ---\n> hw/m68k/bootinfo.h | 28 ++++++++++++++--------------\n> hw/m68k/mcf5208.c | 2 +-\n> hw/m68k/next-cube.c | 2 +-\n> hw/m68k/q800.c | 4 ++--\n> 4 files changed, 18 insertions(+), 18 deletions(-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=UuVdwDrq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvTT6l3yz1xt7\n\tfor ; Sat, 5 Oct 2024 02:42:05 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swlMn-000871-4Y; Fri, 04 Oct 2024 12:41:21 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1swlMZ-0007hy-C4\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:41:08 -0400","from mail-lj1-x235.google.com ([2a00:1450:4864:20::235])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1swlMX-00079D-0c\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:41:06 -0400","by mail-lj1-x235.google.com with SMTP id\n 38308e7fff4ca-2fad5024b8dso28411071fa.1\n for ; Fri, 04 Oct 2024 09:41:04 -0700 (PDT)","from [192.168.132.175] ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 38308e7fff4ca-2faf9b32fe7sm217111fa.112.2024.10.04.09.40.57\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 04 Oct 2024 09:41:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728060063; x=1728664863; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=+y4+WYkreFGHAipSsNLpz/IDl/XzNgj129dRN6RJI1k=;\n b=UuVdwDrq9aG6QYzXZPe/EQStU5lpuvxeBB0gHFHnNpHsFbBFj0Cd4M9oXfgHF0huSc\n iVNG8Kpv8Z7rO71tkAaJycvf7OLVURFOTxygf6DsUqbXDw3nCrxcoadzwoO/akqWCRtQ\n Pdk02kkXmlFv0LldiPDV3Prx13h+5JOGgKX6LkBfgs2JcrG7tzZm7ZXpYv10tkKthXPT\n BDjemhE2rG61LScnSjN7cghNH6IlOR87AyFU0eiiurIFYw7uV2Y/lno+6e/bXLpQnG0o\n XEaBbxYWcz3rxbTLi4RL4v1ti36ngrLimDEogRuEkZYGxhspsjeG4zRMmDTzeCkiT/wD\n jnuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728060063; x=1728664863;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=+y4+WYkreFGHAipSsNLpz/IDl/XzNgj129dRN6RJI1k=;\n b=QJIc1NRGoiFZPbN5cpYZTFEHFNjKps7AQp3HzBTYZQliWA+tEAXzuklYv6H8uCVGEK\n dfHtPxQgjh3js6OpQQ0bFMBxt856yf09KZ7S1TlmYoWXPJ3jx2Xuhq/0I3ypdSqQYHJw\n cRl+aga6ZbGZODQbDhP/Gt4jKS4v4em/RsAcslls9ogEpbwXyH5/PFZQF/dWYZzA6pik\n cOLwVOHrWBQOmP0Ms/pYT77YyLUvavu64g6wSI6QNGinZRNkwCMDIvlDvsAppSe8Q4SA\n Oz6iA2KPlKpc0GSW2i++M5WAyalfsnvj5Iv3Ua/nLbrsODHzOX+prwMzv6fnUCgNzldT\n ej/A==","X-Gm-Message-State":"AOJu0YxXt+pJ1sLzhaXGwWeUUpOyAD7BF/a6K+8yggducwWa9ybQfvhV\n KMnR0bVq8a6KF0ZeZR+rDY9Vsb0+kQALkmUoF84NWcordFUebbNB6jhfOMcTBniQspDSLK2HKSL\n BZfY8rQ==","X-Google-Smtp-Source":"\n AGHT+IFd4mvKK538yi30/uW/twLyYYuPM0cLQRrdchENWoswQePkmv4W3XcwowF3ZKy231+PqqoBrw==","X-Received":"by 2002:a2e:4e12:0:b0:2f6:2b51:ee3e with SMTP id\n 38308e7fff4ca-2faf3d6e85emr15481781fa.41.1728060062665;\n Fri, 04 Oct 2024 09:41:02 -0700 (PDT)","Message-ID":"","Date":"Fri, 4 Oct 2024 13:40:54 -0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 17/25] hw/m68k: Use explicit big-endian LD/ST API","To":"qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org","References":"<20241004163042.85922-1-philmd@linaro.org>\n <20241004163042.85922-18-philmd@linaro.org>","Content-Language":"en-US","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20241004163042.85922-18-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::235;\n envelope-from=philmd@linaro.org; helo=mail-lj1-x235.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3389312,"web_url":"http://patchwork.ozlabs.org/comment/3389312/","msgid":"","list_archive_url":null,"date":"2024-10-05T01:29:11","subject":"Re: [PATCH v2 17/25] hw/m68k: Use explicit big-endian LD/ST API","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 10/4/24 09:30, Philippe Mathieu-Daudé wrote:\n> The M68K architecture uses big endianness. Directly use\n> the big-endian LD/ST API.\n> \n> Mechanical change using:\n> \n> $ end=be; \\\n> for acc in uw w l q tul; do \\\n> sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n> -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n> $(git grep -wlE '(ld|st)t?u?[wlq]_p' hw/m68k/); \\\n> done\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> hw/m68k/bootinfo.h | 28 ++++++++++++++--------------\n> hw/m68k/mcf5208.c | 2 +-\n> hw/m68k/next-cube.c | 2 +-\n> hw/m68k/q800.c | 4 ++--\n> 4 files changed, 18 insertions(+), 18 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IqtHhmOk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XL7Bh0wLYz1xv1\n\tfor ; Sat, 5 Oct 2024 11:30:04 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swtbi-0005Oi-RU; Fri, 04 Oct 2024 21:29:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1swtbh-0005Nv-Op\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 21:29:17 -0400","from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1swtbf-0006cr-Ba\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 21:29:17 -0400","by mail-pj1-x1036.google.com with SMTP id\n 98e67ed59e1d1-2e09d9f2021so1981296a91.0\n for ; Fri, 04 Oct 2024 18:29:14 -0700 (PDT)","from [192.168.0.4] (174-21-81-121.tukw.qwest.net. [174.21.81.121])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-2e1e8665833sm2353799a91.38.2024.10.04.18.29.12\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 04 Oct 2024 18:29:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728091754; x=1728696554; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=MYdCuhRdFeP/4oLJSAnE6LdLiXFG0bMoi7kIm8NsyEg=;\n b=IqtHhmOkv098iTcnkQ9iWmEWrB1wPdEg2e+mVs1+lLYng6p5//K/cI/RESLIluFE+c\n LmudGQFv3b/QTCI1duwzBz6hQvi04UltWPu9q4uLtZbDsq/WX+9P6bj7zqyWDyniJkdd\n rjrIxTaCgj0gYeoCn2qe8B5vIrah7gy/iLB4eRTWuKqBYWMznhuZ21Ui1hDRq4wPC3t8\n jywqX5aE8fPtoc55jqBM4YZgqHnWXhHTii6CXMkfMrYsWvJEjBx4n5/vMtfG0B8Q2rzy\n eiIkNqeSdojGZZ+nK7/THL78mQ3Ty90KtCfXgI2/y/LdXxk0PgX+B9G+uhuymG2lBsqL\n PJfQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728091754; x=1728696554;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=MYdCuhRdFeP/4oLJSAnE6LdLiXFG0bMoi7kIm8NsyEg=;\n b=UggpP6RQoXe11jW8dKsKMM1av3mwZJXE00QxEFum8PQmJfIpBR8wMCUqIeUWfEldBv\n bsVjAjmw3Fi9VrGi282k+gY/dgpGgx3HoiHggiltdlHvU8qwavxqnzf7xy+/DLa1ziog\n kGfzOiTyyfuc9vzqZqqrJridbi46I3X6fq+zANYZ4lffbzqP9Kju9YSq3z4girYhpCZw\n ZrMf/vlXZht1KcwAFaF46hxe3RWURQMo+CsZnzj17qbF9XB1pQxBacbrxWkJXFcEWx/k\n 05pPCKOTo4hvqioLnW/XQpUXbO3Tsq59j+SqFh+2Z21ZnFA6O5RU6mtq1X358dsBGGON\n S99A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCV7xMFWQuLJDIIvq7vpYlAdT6ROAUQ5a2F22PmHXVhq1JOo/pwHqq7OFN5FODkZ78T1YH7CdjjWKpx9@nongnu.org","X-Gm-Message-State":"AOJu0YxyIn+IQUFSdRHxh1XPGRg/XTaJaeIh1gZIL/Sx6kUqA0Cqzqrg\n PXoGaCgPjo+IemeG/2Hzd+pnUZsymx8cRiAsrTmtM4qdyQo0XmHVkAklB5AK5Vc=","X-Google-Smtp-Source":"\n AGHT+IG44kZRYTEMUkeTNvkbLPGjmMWO4bpZtvq35wKf0Gg2wsIxRhHIZTIv55PNAHqRGCH0Ax7wJw==","X-Received":"by 2002:a17:90a:658c:b0:2d8:898c:3e9b with SMTP id\n 98e67ed59e1d1-2e1e631ec64mr5459248a91.25.1728091753682;\n Fri, 04 Oct 2024 18:29:13 -0700 (PDT)","Message-ID":"","Date":"Fri, 4 Oct 2024 18:29:11 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 17/25] hw/m68k: Use explicit big-endian LD/ST API","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Pierrick Bouvier , qemu-ppc@nongnu.org","References":"<20241004163042.85922-1-philmd@linaro.org>\n <20241004163042.85922-18-philmd@linaro.org>","Content-Language":"en-US","From":"Richard Henderson ","In-Reply-To":"<20241004163042.85922-18-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1036;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1036.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]