[{"id":3389702,"web_url":"http://patchwork.ozlabs.org/comment/3389702/","msgid":"<11e48342-4155-4b28-89e6-758a4fb70408@redhat.com>","list_archive_url":null,"date":"2024-10-07T05:57:03","subject":"Re: [PATCH v2 23/25] target/s390x: Use explicit big-endian LD/ST API","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 04/10/2024 18.30, Philippe Mathieu-Daudé wrote:\n> The S390X architecture uses big endianness. Directly use\n> the big-endian LD/ST API.\n> \n> Mechanical change using:\n> \n> $ end=be; \\\n> for acc in uw w l q tul; do \\\n> sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n> -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n> $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/s390x/); \\\n> done\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/s390x/gdbstub.c | 34 +++++++++++++++++-----------------\n> target/s390x/ioinst.c | 2 +-\n> 2 files changed, 18 insertions(+), 18 deletions(-)\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Z8yLNMQS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XMT2Z3WN3z1xvB\n\tfor ; Mon, 7 Oct 2024 16:57:42 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1sxgk5-0001ff-GR; Mon, 07 Oct 2024 01:57:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1sxgk4-0001ee-2i\n for qemu-devel@nongnu.org; Mon, 07 Oct 2024 01:57:12 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1sxgk2-0003ba-EQ\n for qemu-devel@nongnu.org; Mon, 07 Oct 2024 01:57:11 -0400","from mail-ed1-f69.google.com (mail-ed1-f69.google.com\n [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-442-w-ocIG4VOea8W4MmAY3K8Q-1; Mon, 07 Oct 2024 01:57:08 -0400","by mail-ed1-f69.google.com with SMTP id\n 4fb4d7f45d1cf-5c8853e8451so3111909a12.1\n for ; Sun, 06 Oct 2024 22:57:08 -0700 (PDT)","from [192.168.0.7] (ip-109-42-49-143.web.vodafone.de.\n [109.42.49.143]) by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-5c8e05eb7f0sm2797680a12.72.2024.10.06.22.57.05\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 06 Oct 2024 22:57:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1728280629;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=yCmpp1XK7yOxLnDjxZttbZ9b0Mm5Ee3veKhwvL/b3U4=;\n b=Z8yLNMQSifxKw7NeBPmEVpHnf16gJgKOOTtDR42+5rXkxpWVJmrALdqascRh39fAi+5i8j\n s4MSJXgtXJXNWAjOQIX3xi5g5HmzPCako8YLPDyaJF2811weyzZ1vPKYgUP9vV6VuxUSZo\n 9LPiA2WpOzxWQdtgH1TyPeVPSC3O+wM=","X-MC-Unique":"w-ocIG4VOea8W4MmAY3K8Q-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728280627; x=1728885427;\n h=content-transfer-encoding:in-reply-to:autocrypt:content-language\n :from:references:cc:to:subject:user-agent:mime-version:date\n :message-id:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=yCmpp1XK7yOxLnDjxZttbZ9b0Mm5Ee3veKhwvL/b3U4=;\n b=Mjuc5sgh8sjlO7wkesTfBG5tg3awq9763VFarvNkKRgmTwRSof7xInmVnM4wagWca8\n MZ7OEj+khMb7emhvuFvSKmSovyi91QFqZmE62T6O2yvrpqQqlIBvRUoGCc00wC/Fw8jY\n bcdm/Fnt+Uvb2U2hSOPSzE18jdeTU+CuWcMCjtsj6aKsRALTgcWLfrTy/6fr8ymkUsTH\n vvSR+tOc32j34aYI40bS58aCseyZA2302/Vg9G5U3jg9tqnuOEmPtQq6uXfTn3QoHwZF\n W/gk0AASd11KzpjMQAErDmW/kZSNNWsCgrkybhu6/oIpckPgHRPbKJfXx017UzMOfDQf\n cSDg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVyomMeeKFzOAH4vsVAVz8YoC7Vad+DAATCl6MZ6uQTngwLzctxzdG5Q/F9Y63sJCDkihLovtbHIZS1@nongnu.org","X-Gm-Message-State":"AOJu0YzjK0GbSguP5IgIEWBvGm9XCm1MEJjxexQ1ZlPoec5KSqBGEnWD\n VJCtx+TWsirJVtDgclFY2jxh9ccULOMfII/BeeC04FAAG0bLMfQrJBRIuZ9XeVtbKeJmYhkYURr\n Rk1LquIsDB1LrMBKrxOgAtBJUfxURwiLQSpU+xVJ1mNNdeP+guOpP","X-Received":["by 2002:a05:6402:3889:b0:5c8:8c35:be9f with SMTP id\n 4fb4d7f45d1cf-5c8d2e15e74mr7982435a12.11.1728280627246;\n Sun, 06 Oct 2024 22:57:07 -0700 (PDT)","by 2002:a05:6402:3889:b0:5c8:8c35:be9f with SMTP id\n 4fb4d7f45d1cf-5c8d2e15e74mr7982422a12.11.1728280626831;\n Sun, 06 Oct 2024 22:57:06 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGHT+IElXWPwoRXAUCF4LyM2AJ/f9JdMLS7cjKH49nmfqqn8jzGcyKjwy0S2FXC9Y2ZzLhfJTWQEEw==","Message-ID":"<11e48342-4155-4b28-89e6-758a4fb70408@redhat.com>","Date":"Mon, 7 Oct 2024 07:57:03 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 23/25] target/s390x: Use explicit big-endian LD/ST API","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org","References":"<20241004163042.85922-1-philmd@linaro.org>\n <20241004163042.85922-24-philmd@linaro.org>","From":"Thomas Huth ","Content-Language":"en-US","Autocrypt":"addr=thuth@redhat.com; keydata=\n xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU\n yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2\n 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW\n tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O\n 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81\n O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW\n 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH\n gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr\n 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ\n zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0\n aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW\n AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK\n QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX\n EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV\n 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD\n eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k\n ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq\n zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG\n tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6\n WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7\n UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN\n BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4\n 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa\n +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH\n 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K\n gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/\n WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ\n VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq\n knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV\n cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB\n X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM\n AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn\n ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k\n fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS\n 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK\n cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV\n ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17\n Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD\n oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs\n IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a\n yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn","In-Reply-To":"<20241004163042.85922-24-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-22","X-Spam_score":"-2.3","X-Spam_bar":"--","X-Spam_report":"(-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.151,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]