[{"id":3389310,"web_url":"http://patchwork.ozlabs.org/comment/3389310/","msgid":"<0d80f1f4-a6bd-4f38-8f01-70273a52a67b@linaro.org>","list_archive_url":null,"date":"2024-10-05T01:24:47","subject":"Re: [PATCH v2 14/25] target/tricore: Use explicit little-endian LD/ST\n API","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 10/4/24 09:30, Philippe Mathieu-Daudé wrote:\n> The TriCore architecture uses little endianness. Directly use\n> the little-endian LD/ST API.\n> \n> Mechanical change using:\n> \n> $ end=le; \\\n> for acc in uw w l q tul; do \\\n> sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n> -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n> $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/tricore/); \\\n> done\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/tricore/gdbstub.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/target/tricore/gdbstub.c b/target/tricore/gdbstub.c\n> index 29a70051ffe..0b73b1280e0 100644\n> --- a/target/tricore/gdbstub.c\n> +++ b/target/tricore/gdbstub.c\n> @@ -124,7 +124,7 @@ int tricore_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n> CPUTriCoreState *env = cpu_env(cs);\n> uint32_t tmp;\n> \n> - tmp = ldl_p(mem_buf);\n> + tmp = ldl_le_p(mem_buf);\n> \n> if (n < 16) { /* data registers */\n> env->gpr_d[n] = tmp;\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=fXVCVc7F;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XL75N0kKqz1xv1\n\tfor ; Sat, 5 Oct 2024 11:25:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swtXT-0003hK-VJ; Fri, 04 Oct 2024 21:24:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1swtXS-0003gN-2J\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 21:24:54 -0400","from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1swtXP-00066u-Rx\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 21:24:53 -0400","by mail-pf1-x429.google.com with SMTP id\n d2e1a72fcca58-71def715ebdso591010b3a.2\n for ; Fri, 04 Oct 2024 18:24:51 -0700 (PDT)","from [192.168.0.4] (174-21-81-121.tukw.qwest.net. [174.21.81.121])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-71df0d6243asm506464b3a.151.2024.10.04.18.24.49\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 04 Oct 2024 18:24:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728091490; x=1728696290; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=c3C8AnkYs+qGMX7aDbM8uAjU99cDiEVXZhpALO/k3UM=;\n b=fXVCVc7FAVWQ5gwqnXHoT/RK1z/ETBKUXirm3Jc9ZkkcLQQ5ClWkbJdgZIHN/kNdS+\n 9INQ1g/jP3KFhe99AfQD5rBjjgAZbf/gxd4i9NtGgRFXJPJ0MY6yqjft3RKs1HdAkHIm\n O7+felSDW5gX1kpEG6qisKXFAGlz3MJ20lQSMMGMIobR5eBbQfB4mr4oVYBJyD0/gQbz\n SHhbqHo9hMb9C3Do6wh6azprtYPSW6PhZQtioqDhoCpaSZs1wptpq6EXv827hXDRX65H\n POZLI3webvm+daueKe27z8etOaqq7VpJE5Q8ZmH69RwS1o6Bo/ISKEIIKMMQOlNrxyFe\n cuDA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728091490; x=1728696290;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=c3C8AnkYs+qGMX7aDbM8uAjU99cDiEVXZhpALO/k3UM=;\n b=mzP6NVApgMCQE3UxXqp4lkvTnVUtprK7VInl56omdX5t9RjEB3UkWHHkv9ot6+wlUN\n pPRTgVIjWLVMt4mIAqF2+9gT9Rf04wfofdUjao9DUd8uzSj/+ahr9u4AWUoNCbarc/63\n 3Pw/Sn7mN610LR8kPXo4mnMu0NRkUvWJSD+8xHTrmLcm140OxE3PaGqVk2mbW37f2+RV\n TSyzBoVPExxuHL4dg01aCrH+7srfUEQvl31I8Y5sawdmu6RuWcCD4v8ZZiGTqXN21w8s\n t4icmXQ/mswUqplh2Is+GTZNlEGB9uIWCtxbn8LtAdQT+xx0gCVlJzp7W+SYE3b6UR9E\n 1BSw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCW5pnCuyOytQ9wqew2vZ6dppI9QK+FElVF0TlCZCJp7aCUrWIGY1RO66BJUsePFrwQOhXq0fXbcI3zX@nongnu.org","X-Gm-Message-State":"AOJu0YzAtDpqCL9HhgprwB4iCmtRg8EFa6y1R2K4sHSJQTqRhqBL93lu\n 9g31fnwPiuwvmeyjClikS9G1Cg903vuT+ojDAzE2eruCfjWol2uYWotzh5r7k/Q=","X-Google-Smtp-Source":"\n AGHT+IEmX1GCUwLgJ6TSIEUQS+3F5LCUmL+PgnRCFB61eHmB/30oohcCKsk2gonEp8GKDwsGrHQ7Ww==","X-Received":"by 2002:a05:6a20:4e21:b0:1d6:e609:790a with SMTP id\n adf61e73a8af0-1d6e609795fmr2032724637.5.1728091490090;\n Fri, 04 Oct 2024 18:24:50 -0700 (PDT)","Message-ID":"<0d80f1f4-a6bd-4f38-8f01-70273a52a67b@linaro.org>","Date":"Fri, 4 Oct 2024 18:24:47 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 14/25] target/tricore: Use explicit little-endian LD/ST\n API","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Pierrick Bouvier , qemu-ppc@nongnu.org","References":"<20241004163042.85922-1-philmd@linaro.org>\n <20241004163042.85922-15-philmd@linaro.org>","Content-Language":"en-US","From":"Richard Henderson ","In-Reply-To":"<20241004163042.85922-15-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::429;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]