[{"id":3389299,"web_url":"http://patchwork.ozlabs.org/comment/3389299/","msgid":"<85d9e3fe-67d3-4968-967f-0c7fb341f9f8@linaro.org>","list_archive_url":null,"date":"2024-10-05T01:17:37","subject":"Re: [PATCH v2 08/25] hw/i386: Use explicit little-endian LD/ST API","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 10/4/24 09:30, Philippe Mathieu-Daudé wrote:\n> The x86 architecture uses little endianness. Directly use\n> the little-endian LD/ST API.\n> \n> Mechanical change using:\n> \n> $ end=le; \\\n> for acc in uw w l q tul; do \\\n> sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n> -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n> $(git grep -wlE '(ld|st)t?u?[wlq]_p' hw/i386/); \\\n> done\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> hw/i386/multiboot.c | 36 ++++++++++++++++++------------------\n> hw/i386/x86-common.c | 26 +++++++++++++-------------\n> 2 files changed, 31 insertions(+), 31 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=We5RJngp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XL6wx0Vlfz1xtN\n\tfor ; Sat, 5 Oct 2024 11:18:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swtQg-0007Cw-Fm; Fri, 04 Oct 2024 21:17:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1swtQW-000727-OE\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 21:17:45 -0400","from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1swtQT-0005Dd-SI\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 21:17:44 -0400","by mail-pj1-x102c.google.com with SMTP id\n 98e67ed59e1d1-2e192a2fe6cso2071099a91.3\n for ; Fri, 04 Oct 2024 18:17:40 -0700 (PDT)","from [192.168.0.4] (174-21-81-121.tukw.qwest.net. [174.21.81.121])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-2e20b12adbcsm616688a91.53.2024.10.04.18.17.38\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 04 Oct 2024 18:17:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728091059; x=1728695859; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=rRrFbvTZ/HGEBsE1ELoQlg8dK/ihzfdXXCXZYjwC2d0=;\n b=We5RJngpP/ce4y2K7hyjUhJ30Bb7lB/Dp/cz/bc83LsMxZ9pojZhz5LO7M0F0py2j8\n Lli+nWxB2boFsl2ZZwgKKCQcuphft1sA0odmSJG6TU8WspzuOSUFNkaB1zH2p25fpI/o\n vgsz/+jnAuJDVsycOK5rDGmFiRwsW35qmnJON48bOXi/KwKzwmjnWBvOb9nNT/4D7KLi\n SmEQwTuHK41UOJcuuFpOEoQT6AVvVdxGXX4oRCiM12u8yU6ARal3j+YLChr6RQ3pn3Bj\n c79lAbua5HhkDSiWb9SiKrspck8ybSldzPmTeeeRfo3K1rCEzD6TeTM7M+XOTrOtfUAZ\n 82Dw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728091059; x=1728695859;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=rRrFbvTZ/HGEBsE1ELoQlg8dK/ihzfdXXCXZYjwC2d0=;\n b=kxCyKymHmltSetG1Mz9wk344GPqx8ItEeGD0iNqPq8+F2cYSsoR5KaJj+/OmgWYMxV\n OXBKxrMyNo7l9gY4qPLl+rTil2kdWE5xcnB48+TLtI4Hecazt6B5MWJ5k7MpqDiWAYoF\n wMImGLUFp/Dr2nfoX8dFTLp56Y8PzpfTSV30oi+UX/xChey2wwpzxYMog35YRt8VVwvq\n 9W2bZ11WVmgWuRW2liHBLQCcZlWE1t8yZqbcR+KzTk4GY4w5a7bXV0z/zit37GCcViI9\n pL2ZVhPYlVd3PQa0nieQXcBCzRCExEcYW0sopwGkR0S1XgPNPk+JcP6H94VsbU0en47B\n f5CQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCW+mpmvAm3ShHgBy4JLSKLDYrdLhcpwQALtAxH+jkTW3wn0CZvvB14DPTxb7jeEfKTNWMOX/COxlTL5@nongnu.org","X-Gm-Message-State":"AOJu0Yyo1LFD+LoLoJiVdg3Ycz7eQ3iKf9OVCKnu8ZUYPfbi2xpSXYQK\n xshrUFJR4XwNBAnfDYUNaKkAM8Lbr9dRp2OGmklvFp6cLrRwC1tMLIHxr3bHjZw=","X-Google-Smtp-Source":"\n AGHT+IHOEg+YflwqN+Fzoe0XYh2bmsHFo2Bplw5f13XN2yDzKVZpPovHcpCDtDvs4uZnHXUG3WQYIw==","X-Received":"by 2002:a17:90a:b015:b0:2e0:6cd4:973a with SMTP id\n 98e67ed59e1d1-2e1e6211a0emr6549726a91.5.1728091059187;\n Fri, 04 Oct 2024 18:17:39 -0700 (PDT)","Message-ID":"<85d9e3fe-67d3-4968-967f-0c7fb341f9f8@linaro.org>","Date":"Fri, 4 Oct 2024 18:17:37 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 08/25] hw/i386: Use explicit little-endian LD/ST API","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Pierrick Bouvier , qemu-ppc@nongnu.org","References":"<20241004163042.85922-1-philmd@linaro.org>\n <20241004163042.85922-9-philmd@linaro.org>","Content-Language":"en-US","From":"Richard Henderson ","In-Reply-To":"<20241004163042.85922-9-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102c;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]