[{"id":3389287,"web_url":"http://patchwork.ozlabs.org/comment/3389287/","msgid":"","list_archive_url":null,"date":"2024-10-05T01:10:05","subject":"Re: [PATCH v2 01/25] gdbstub/helpers: Have ldtul_p() definition use\n ldn_p()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 10/4/24 09:30, Philippe Mathieu-Daudé wrote:\n> Use ldn_p(TARGET_LONG_SIZE) instead of ldl_p() / ldq_p().\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/gdbstub/helpers.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h\n> index 26140ef1ac0..fd83e366a51 100644\n> --- a/include/gdbstub/helpers.h\n> +++ b/include/gdbstub/helpers.h\n> @@ -94,10 +94,10 @@ static inline uint8_t *gdb_get_reg_ptr(GByteArray *buf, int len)\n> \n> #if TARGET_LONG_BITS == 64\n> #define gdb_get_regl(buf, val) gdb_get_reg64(buf, val)\n> -#define ldtul_p(addr) ldq_p(addr)\n> #else\n> #define gdb_get_regl(buf, val) gdb_get_reg32(buf, val)\n> -#define ldtul_p(addr) ldl_p(addr)\n> #endif\n> \n> +#define ldtul_p(addr) ldn_p(addr, TARGET_LONG_SIZE)\n\nThis does not aid anything in the short term.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JtOH3kyD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XL6mT0YSxz1xv1\n\tfor ; Sat, 5 Oct 2024 11:10:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swtJI-0001tR-Jq; Fri, 04 Oct 2024 21:10:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1swtJE-0001pz-19\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 21:10:12 -0400","from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1swtJB-0004GH-Cu\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 21:10:11 -0400","by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-20b93887decso22975125ad.3\n for ; Fri, 04 Oct 2024 18:10:08 -0700 (PDT)","from [192.168.0.4] (174-21-81-121.tukw.qwest.net. [174.21.81.121])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-20c13934817sm4356415ad.158.2024.10.04.18.10.07\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 04 Oct 2024 18:10:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728090608; x=1728695408; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=LFAGykPUspbLZfYGbKb6dpy5Z5eZR/8JSd4o9GjPmkw=;\n b=JtOH3kyDWVTatnFh3D5si0TFdl5994NUUjqCUMGdpGt75EUU9KOIvSa/p/yeAdGaTJ\n zY6sjw+MOqyvCUn5wQ9mdjCIg2abqhGH8gQSPnrkiVbo528+AzcR2BngqbjYfGAl3MKm\n Pe79ukG8LiYcfC2VWze75AcGuJuviqpeeLGv5J4nI7w4kq5aTXysX7i8HzaxkkxQ5e+r\n /zkFl1q9aHAa5hTlrN02m1IG/bnUQWu9NkiCT8cWh6iqFzPCtkqKvBhuURj+Va7U9w0R\n z258It7ZJ6IMbm7TfbqUN7jTUuVtQhIBFLg+VzrmHNVG/2DrK1LG/ZFXxTEwg/Wbom/X\n 9Idg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728090608; x=1728695408;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=LFAGykPUspbLZfYGbKb6dpy5Z5eZR/8JSd4o9GjPmkw=;\n b=OyDD77xXMvWgtxRAYs16J0ioj2xq0kQsi4FnwWYgReAJgMwyJR93mCRjQktuOuWTnv\n ABeW10z1vmhgH4/SKUos/+R6bhBw/rNYLp7MGSjYDT/TKSZjwpjlP6+QX+lsZW+q/cXf\n STYwmlnhREYNsfFv7tl4J0EVljIqFQpQDu7ET12PxIwTQbenjEcKzLKgC2UDLU+stoWK\n KjeErBRsrdVyAEM9tFqp514JNG6F90HzIxaH1jbQSym11h5c7ssgGwLaOYL9C9VzRJA7\n fdIIFcbtMiUtrgyZ/hspclTOw2346W1UzAzo2/ZQBtnbZNJ8qc37DpmqmLc9iv7a+Mvk\n 3B0Q==","X-Forwarded-Encrypted":"i=1;\n AJvYcCURVFtC3uqXPuRSRfUjdwpvm5qx1wdEZxECVV3Ne0DwnXvfUSWjutTdoH2JXTNis6KjuIp2IiV+T7t6@nongnu.org","X-Gm-Message-State":"AOJu0YyQwM1N6A/D2bdEg3tyn3HOiz8IM4FWfQAeTkCvcLxPorTs/d8r\n McVia+TvrahQMos0HBHM/J/xj9sCfHWdX0Wj9CVI/9Wnf9gpuMgEeT5qXPTZbBfqmCZzeGznua4\n Y","X-Google-Smtp-Source":"\n AGHT+IEkrT6FHpvrNw8xx/VgUcm7P3Jt3kEeMB1St+Zs+x/0TBZpfI3NKBPTKD7TGuZ2uOhCUzxlcA==","X-Received":"by 2002:a17:902:d2d0:b0:20b:be06:f3d9 with SMTP id\n d9443c01a7336-20bfe1887c8mr65210395ad.24.1728090607819;\n Fri, 04 Oct 2024 18:10:07 -0700 (PDT)","Message-ID":"","Date":"Fri, 4 Oct 2024 18:10:05 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 01/25] gdbstub/helpers: Have ldtul_p() definition use\n ldn_p()","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Pierrick Bouvier , qemu-ppc@nongnu.org","References":"<20241004163042.85922-1-philmd@linaro.org>\n <20241004163042.85922-2-philmd@linaro.org>","Content-Language":"en-US","From":"Richard Henderson ","In-Reply-To":"<20241004163042.85922-2-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::632;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]