[{"id":3321516,"web_url":"http://patchwork.ozlabs.org/comment/3321516/","msgid":"<20240603155445.GA501876-robh@kernel.org>","list_archive_url":null,"date":"2024-06-03T15:54:45","subject":"Re: [DO NOT MERGE v8 19/36] dt-bindings: interrupt-controller:\n renesas,sh7751-irl-ext: Add json-schema","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, May 29, 2024 at 05:01:05PM +0900, Yoshinori Sato wrote:\n> Renesas SH7751 external interrupt encoder json-schema.\n> \n> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>\n> ---\n>  .../renesas,sh7751-irl-ext.yaml               | 57 +++++++++++++++++++\n>  1 file changed, 57 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-irl-ext.yaml\n> \n> diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-irl-ext.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-irl-ext.yaml\n> new file mode 100644\n> index 000000000000..ff70d57b86cd\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-irl-ext.yaml\n> @@ -0,0 +1,57 @@\n> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause\n> +%YAML 1.2\n> +---\n> +$id: http://devicetree.org/schemas/interrupt-controller/renesas,sh7751-irl-ext.yaml#\n> +$schema: http://devicetree.org/meta-schemas/core.yaml#\n> +\n> +title: Renesas SH7751 external interrupt encoder with enable regs.\n> +\n> +maintainers:\n> +  - Yoshinori Sato <ysato@users.sourceforge.jp>\n> +\n> +description:\n> +  This is the generally used external interrupt encoder on SH7751 based boards.\n> +\n> +properties:\n> +  compatible:\n> +    items:\n> +      - const: renesas,sh7751-irl-ext\n> +\n> +  reg: true\n\nNeeds to define how many and what they are.\n\n> +\n> +  interrupt-controller: true\n> +\n> +  '#interrupt-cells':\n> +    const: 2\n> +\n> +  '#address-cells':\n> +    const: 0\n> +\n> +  renesas,set-to-disable:\n> +    $ref: /schemas/types.yaml#/definitions/flag\n> +    description: Invert enable registers. Setting the bit to 0 enables interrupts.\n> +\n> +  renesas,enable-reg:\n> +    $ref: /schemas/types.yaml#/definitions/uint32-array\n> +    description: |\n\nDon't need '|'.\n\n> +      IRQ enable register bit mapping\n\nThis needs a better description and constraints? Number of entries in \nthe array or values of the entries.\n\n> +\n> +required:\n> +  - compatible\n> +  - reg\n> +  - interrupt-controller\n> +  - '#interrupt-cells'\n> +  - renesas,enable-reg\n> +\n> +additionalProperties: false\n> +\n> +examples:\n> +  - |\n> +    r2dintc: interrupt-controller@a4000000 {\n> +        compatible = \"renesas,sh7751-irl-ext\";\n> +        reg = <0xa4000000 0x02>;\n> +        interrupt-controller;\n> +        #address-cells = <0>;\n> +        #interrupt-cells = <2>;\n> +        renesas,enable-reg = <12 9 10 3 0 4 1 2 8 5 6 7 15 15 15 11>;\n> +    };\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"\n <linux-pci+bounces-8186-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=SKCKUK+6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org;\n envelope-from=linux-pci+bounces-8186-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"SKCKUK+6\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from ny.mirrors.kernel.org (ny.mirrors.kernel.org\n [IPv6:2604:1380:45d1:ec00::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4VtJG058jsz20PW\n\tfor <incoming@patchwork.ozlabs.org>; Tue,  4 Jun 2024 01:55:04 +1000 (AEST)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ny.mirrors.kernel.org (Postfix) with ESMTPS id CFEBD1C218C5\n\tfor <incoming@patchwork.ozlabs.org>; Mon,  3 Jun 2024 15:55:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 11AA0132127;\n\tMon,  3 Jun 2024 15:54:49 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BEC06131182;\n\tMon,  3 Jun 2024 15:54:48 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id C9B30C2BD10;\n\tMon,  3 Jun 2024 15:54:47 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1717430089; cv=none;\n b=d8idxIkEnsMeCpYHwkr7SrWAztcbcSHcl0PffJkyU5n7Nbri4kaDh7MvtE7MRTDHfXYT74oK35unDupsIQLfyNfPi3kbyRwKwXy9RNQdNP2T5TkY0rgsCXHuUcy9+b64Oa9LdquwuAKySyNaQTUN+ymFYDeIVALiXX0cfs3ILDM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1717430089; c=relaxed/simple;\n\tbh=/mqwg4w9jJOykMYUTyLRSt9g531pR70Ydsxqn4u/d+o=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=T0OGUMOEjNw+VmgXurlJuA7BDLIHJjGx+81Qaox/AB37XGuRu4IH7GxMQ/QkAFBbucC/DKNKZ6yirTLmNUgABknqC3ZNMq3621a3xWSqQdZjhtsBXoE3sJDboTNS9mxIJh7BJjVKX9mqxb7HQzhW+g6SYmv7XixV+oZpMKanF6Y=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=SKCKUK+6; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1717430088;\n\tbh=/mqwg4w9jJOykMYUTyLRSt9g531pR70Ydsxqn4u/d+o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SKCKUK+6SCKeWy0UyNbLs+BB50UwRzhJv4efMVYn6OgVCU8qKZOoOpikzAgyrDe1O\n\t c4yv7tSWwpos/H3uofzMHk3UaF+4OmLwFpp1u5SQZwX++JqcvFKzrN05AwuXi8pwiv\n\t l3OcNKpTom+E1RJSLQlmWM821dK+GFMnMb3xAiZ0CgSOXYuEjCMHNczULBEfDw6rFU\n\t 6gL3Bl5JsihcjAqCZXhoGKU3e8X27voOnp9v0TqxQX3FKdnFAthexAWnpBGY29zyKJ\n\t GBUKCdxh3msMwIIQB/IY/VIEyArSMLRvKmyPeHrKA3Nmh3jHArbXt61pSR6XGaMBej\n\t 70tQt7QWPZM7A==","Date":"Mon, 3 Jun 2024 10:54:45 -0500","From":"Rob Herring <robh@kernel.org>","To":"Yoshinori Sato <ysato@users.sourceforge.jp>","Cc":"linux-sh@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,\n Niklas Cassel <cassel@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,\n Conor Dooley <conor+dt@kernel.org>,\n Geert Uytterhoeven <geert+renesas@glider.be>,\n Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>,\n David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,\n Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,\n Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,\n Thomas Gleixner <tglx@linutronix.de>, Bjorn Helgaas <bhelgaas@google.com>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>, Krzysztof =?utf-8?q?Wilczy=C5=84?=\n\t=?utf-8?q?ski?= <kw@linux.com>,\n Greg Kroah-Hartman <gregkh@linuxfoundation.org>,\n Jiri Slaby <jirislaby@kernel.org>, Magnus Damm <magnus.damm@gmail.com>,\n Daniel Lezcano <daniel.lezcano@linaro.org>, Rich Felker <dalias@libc.org>,\n John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,\n Lee Jones <lee@kernel.org>, Helge Deller <deller@gmx.de>,\n Heiko Stuebner <heiko.stuebner@cherry.de>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Chris Morgan <macromorgan@hotmail.com>, Sebastian Reichel <sre@kernel.org>,\n Linus Walleij <linus.walleij@linaro.org>, Arnd Bergmann <arnd@arndb.de>,\n Masahiro Yamada <masahiroy@kernel.org>, Baoquan He <bhe@redhat.com>,\n Andrew Morton <akpm@linux-foundation.org>,\n Guenter Roeck <linux@roeck-us.net>, Kefeng Wang <wangkefeng.wang@huawei.com>,\n Stephen Rothwell <sfr@canb.auug.org.au>,\n Azeem Shaikh <azeemshaikh38@gmail.com>, Guo Ren <guoren@kernel.org>,\n Max Filippov <jcmvbkbc@gmail.com>, Jernej Skrabec <jernej.skrabec@gmail.com>,\n Herve Codina <herve.codina@bootlin.com>,\n Andy Shevchenko <andriy.shevchenko@linux.intel.com>,\n Anup Patel <apatel@ventanamicro.com>, Jacky Huang <ychuang3@nuvoton.com>,\n Hugo Villeneuve <hvilleneuve@dimonoff.com>, Jonathan Corbet <corbet@lwn.net>,\n Wolfram Sang <wsa+renesas@sang-engineering.com>, Uwe =?iso-8859-1?q?Kleine-?=\n\t=?iso-8859-1?q?K=F6nig?= <u.kleine-koenig@pengutronix.de>,\n Christophe JAILLET <christophe.jaillet@wanadoo.fr>,\n Sam Ravnborg <sam@ravnborg.org>,\n Javier Martinez Canillas <javierm@redhat.com>,\n Sergey Shtylyov <s.shtylyov@omp.ru>,\n Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,\n linux-ide@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,\n linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org,\n linux-pci@vger.kernel.org, linux-serial@vger.kernel.org,\n linux-fbdev@vger.kernel.org","Subject":"Re: [DO NOT MERGE v8 19/36] dt-bindings: interrupt-controller:\n renesas,sh7751-irl-ext: Add json-schema","Message-ID":"<20240603155445.GA501876-robh@kernel.org>","References":"<cover.1716965617.git.ysato@users.sourceforge.jp>\n <e35aa188e5176544c6884f2d1d7aa1b242a51acf.1716965617.git.ysato@users.sourceforge.jp>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <e35aa188e5176544c6884f2d1d7aa1b242a51acf.1716965617.git.ysato@users.sourceforge.jp>"}}]