[{"id":3318843,"web_url":"http://patchwork.ozlabs.org/comment/3318843/","msgid":"","list_archive_url":null,"date":"2024-05-29T12:55:53","subject":"Re: [DO NOT MERGE v8 08/36] clocksource: sh_tmu: CLOCKSOURCE support.","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Wed, May 29, 2024 at 05:00:54PM +0900, Yoshinori Sato wrote:\n> Allows initialization as CLOCKSOURCE.\n\n...\n\n> -\tdev_info(&ch->tmu->pdev->dev, \"ch%u: used for %s clock events\\n\",\n> -\t\t ch->index, periodic ? \"periodic\" : \"oneshot\");\n> +\tpr_info(\"%s ch%u: used for %s clock events\\n\",\n> +\t\tch->tmu->name, ch->index, periodic ? \"periodic\" : \"oneshot\");\n\nThis is a step back change. We should use dev_*() if we have a device\navailable. And I believe this is the case (at least for the previous boards),\nno?\n\n...\n\n> -\tch->irq = platform_get_irq(tmu->pdev, index);\n> +\tif (tmu->np)\n> +\t\tch->irq = of_irq_get(tmu->np, index);\n> +\telse if (tmu->pdev)\n> +\t\tch->irq = platform_get_irq(tmu->pdev, index);\n\nI found these changes counterproductive. Instead better to have up to three\nfiles to cover:\n- the common code (library)\n- the platform device support\n- the pure OF support.\n\n...\n\n> -\tres = platform_get_resource(tmu->pdev, IORESOURCE_MEM, 0);\n> -\tif (!res) {\n> -\t\tdev_err(&tmu->pdev->dev, \"failed to get I/O memory\\n\");\n> -\t\treturn -ENXIO;\n> +\tif (tmu->pdev) {\n> +\t\tres = platform_get_resource(tmu->pdev, IORESOURCE_MEM, 0);\n> +\t\tif (!res) {\n> +\t\t\tpr_err(\"sh_tmu failed to get I/O memory\\n\");\n> +\t\t\treturn -ENXIO;\n> +\t\t}\n> +\n> +\t\ttmu->mapbase = ioremap(res->start, resource_size(res));\n\ndevm_platform_ioremap_resource() should be good to have.\nAgain, consider proper splitting.\n\n> \t}\n> +\tif (tmu->np)\n> +\t\ttmu->mapbase = of_iomap(tmu->np, 0);\n\nSo, how many boards are non-OF compatible? Maybe makes sense to move them to OF\nand drop these platform code entirely from everywhere?\n\n...\n\n> +\ttmu->name = dev_name(&pdev->dev);\n> +\ttmu->clk = clk_get(&tmu->pdev->dev, \"fck\");\n\ndevm_ approach can help a lot in case of platform device code.\n\n> +\tif (IS_ERR(tmu->clk)) {\n> +\t\tdev_err(&tmu->pdev->dev, \"cannot get clock\\n\");\n> +\t\treturn PTR_ERR(tmu->clk);\n\n\t\treturn dev_err_probe() ?\n\n> +\t}","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=KVTQ3Yk8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=139.178.88.99; helo=sv.mirrors.kernel.org;\n envelope-from=linux-pci+bounces-8020-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"KVTQ3Yk8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.14","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=none smtp.mailfrom=linux.intel.com"],"Received":["from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Vq8XR2tvkz20Pb\n\tfor ; Wed, 29 May 2024 22:56:39 +1000 (AEST)","from smtp.subspace.kernel.org (wormhole.subspace.kernel.org\n [52.25.139.140])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby sv.mirrors.kernel.org (Postfix) with ESMTPS id C34432869B3\n\tfor ; Wed, 29 May 2024 12:56:37 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8C4156FC6;\n\tWed, 29 May 2024 12:56:16 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.14])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A3EA610A03;\n\tWed, 29 May 2024 12:56:14 +0000 (UTC)","from orviesa008.jf.intel.com ([10.64.159.148])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 May 2024 05:56:13 -0700","from smile.fi.intel.com ([10.237.72.54])\n by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 May 2024 05:56:00 -0700","from andy by smile.fi.intel.com with local (Exim 4.97)\n\t(envelope-from )\n\tid 1sCIqP-0000000BnVT-2SiK;\n\tWed, 29 May 2024 15:55:53 +0300"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1716987376; cv=none;\n b=q+8YcJ+cPGttXCf5trwTid44wvv3en2q3uxT1l1tR/iwsaH7assjczmQA+S5nTSF30X/G4lkTL8CEQ+63oOx+/YPVtKGENv9ZDZoNVMmffhplct1mpaNvzzoZ5RhX7IOZvwjbWwFsSX1XkkGHQOOQzK6vVt2hJenYO6euBROuJI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1716987376; c=relaxed/simple;\n\tbh=gz8z8N5bHTtjf1WXKP3VLR7zy+2ou75tSdQdUmX2Vx4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=DUb0B9xOXxoMuH01AVMLxEZlGBXuUrooLiiQuc3cCnPj37fNkeTH+RZ8w3JBtwsyy4aMfLmnvoqbQcEwAVREWF/YUiEcDl+QfZQTute1igQWYb9dfvT504BD/qHemH7O4xpcQ6EjybLqcAuA+FwHIX8kH7tFEZcRmxtOC9Kun5c=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=none smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=KVTQ3Yk8; arc=none smtp.client-ip=192.198.163.14","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1716987375; x=1748523375;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=gz8z8N5bHTtjf1WXKP3VLR7zy+2ou75tSdQdUmX2Vx4=;\n b=KVTQ3Yk8L6lLF0SlKKAnpEMyUVPKkDcnDzC9DQYWKx+Ee0D/j5wS8jWj\n aFE+70oEJD0vC9u1uUJTx/ampL9Tphh3THlJyyPS8Ukn4kn18vvVUsK8c\n 4s9mGPkKa1XoMOK/7X+qmVpTAseosXptqqlj7jbPtCoyc8I4jDU5KSXBV\n ZHmZgTGM5Q+ATf42JFns4GxYgQrNbEb9+5wFl2g4Q6y/E4ErrTyoJrPj7\n 8E8hN6wW4BQGj/jW3HIXeINSUo4GBUqncw1erGowPuuHp5DyryA0S1unS\n xhT7kAM7DoFzyHUDZK4LhEkHaj0jz1lqSUiNcammTvzyVDIKVtG8yVu1P\n g==;","X-CSE-ConnectionGUID":["BSG6Xos3Sp+uL1jtf0ROkw==","H5QcdFF9TbONM172UGdoGg=="],"X-CSE-MsgGUID":["M3losH2pRy2/1+utwYVpyw==","zqE6bIAkQpSvlFOcfBHkJw=="],"X-IronPort-AV":["E=McAfee;i=\"6600,9927,11087\"; a=\"13618479\"","E=Sophos;i=\"6.08,198,1712646000\";\n d=\"scan'208\";a=\"13618479\"","E=Sophos;i=\"6.08,198,1712646000\";\n d=\"scan'208\";a=\"35963852\""],"X-ExtLoop1":"1","Date":"Wed, 29 May 2024 15:55:53 +0300","From":"Andy Shevchenko ","To":"Yoshinori Sato ","Cc":"linux-sh@vger.kernel.org, Damien Le Moal ,\n Niklas Cassel , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley ,\n Geert Uytterhoeven ,\n Michael Turquette , Stephen Boyd ,\n David Airlie , Daniel Vetter ,\n Maarten Lankhorst ,\n Maxime Ripard , Thomas Zimmermann ,\n Thomas Gleixner , Bjorn Helgaas ,\n Lorenzo Pieralisi , Krzysztof =?utf-8?q?Wilczy=C5=84?=\n\t=?utf-8?q?ski?= ,\n Greg Kroah-Hartman ,\n Jiri Slaby , Magnus Damm ,\n Daniel Lezcano , Rich Felker ,\n John Paul Adrian Glaubitz ,\n Lee Jones , Helge Deller ,\n Heiko Stuebner ,\n Neil Armstrong ,\n Chris Morgan , Sebastian Reichel ,\n Linus Walleij , Arnd Bergmann ,\n Masahiro Yamada , Baoquan He ,\n Andrew Morton ,\n Guenter Roeck , Kefeng Wang ,\n Stephen Rothwell ,\n Azeem Shaikh , Guo Ren ,\n Max Filippov , Jernej Skrabec ,\n Herve Codina ,\n Anup Patel , Jacky Huang ,\n Hugo Villeneuve , Jonathan Corbet ,\n Wolfram Sang , Uwe =?iso-8859-1?q?Kleine-?=\n\t=?iso-8859-1?q?K=F6nig?= ,\n Christophe JAILLET ,\n Sam Ravnborg ,\n Javier Martinez Canillas ,\n Sergey Shtylyov ,\n Laurent Pinchart ,\n linux-ide@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,\n linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org,\n linux-pci@vger.kernel.org, linux-serial@vger.kernel.org,\n linux-fbdev@vger.kernel.org","Subject":"Re: [DO NOT MERGE v8 08/36] clocksource: sh_tmu: CLOCKSOURCE support.","Message-ID":"","References":"\n ","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n ","Organization":"Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo"}}]