[{"id":3241153,"web_url":"http://patchwork.ozlabs.org/comment/3241153/","msgid":"","list_archive_url":null,"date":"2024-01-03T17:47:17","subject":"Re: [PATCH v2 39/43] contrib/plugins: fix imatch","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 3/1/24 18:33, Alex Bennée wrote:\n> We can't directly save the ephemeral imatch from argv as that memory\n> will get recycled.\n> \n> Signed-off-by: Alex Bennée \n> ---\n> contrib/plugins/execlog.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c\n> index 82dc2f584e2..f262e5555eb 100644\n> --- a/contrib/plugins/execlog.c\n> +++ b/contrib/plugins/execlog.c\n> @@ -199,7 +199,7 @@ static void parse_insn_match(char *match)\n\nCould 'match' become const?\n\n> if (!imatches) {\n> imatches = g_ptr_array_new();\n> }\n> - g_ptr_array_add(imatches, match);\n> + g_ptr_array_add(imatches, g_strdup(match));\n> }\n> \n> static void parse_vaddr_match(char *match)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JEasv5dd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4T4xzr1wxzz1yQ5\n\tfor ; Thu, 4 Jan 2024 04:49:12 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1rL5LA-0001xz-Ri; Wed, 03 Jan 2024 12:47:40 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1rL5Ky-0001e1-52\n for qemu-devel@nongnu.org; Wed, 03 Jan 2024 12:47:30 -0500","from mail-wr1-x429.google.com ([2a00:1450:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1rL5Ku-0004CM-Dj\n for qemu-devel@nongnu.org; Wed, 03 Jan 2024 12:47:27 -0500","by mail-wr1-x429.google.com with SMTP id\n ffacd0b85a97d-3368ae75082so430013f8f.1\n for ; Wed, 03 Jan 2024 09:47:23 -0800 (PST)","from [192.168.69.100] (tre93-h02-176-184-7-144.dsl.sta.abo.bbox.fr.\n [176.184.7.144]) by smtp.gmail.com with ESMTPSA id\n t16-20020a05600c199000b0040d5fcaefcesm2946862wmq.19.2024.01.03.09.47.18\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 03 Jan 2024 09:47:21 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1704304042; x=1704908842; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=aZn5H3BibQIjCm6XCuZSPBoWZOto2pSlAUY4r4Wn5U8=;\n b=JEasv5ddiBg8uKEg4RD5uBp3kZEyFsiKnYSGWS42iXEzR3x5PaUrRfVEG/vHFPrktA\n hyQBe3ZiuKXRJFVDb83w4qHwXiw3oiiyI00Xw7c/3H9ONj/tkPGFqUvEABh6k+ulJOZW\n 5yCzTvFrsGzlk378KEWfx9rSPErOhiW37l/IJFHKLfJNSdsdT3wOZ0C0K/ON2PzwR57p\n AYwtupOSZen1aIijc7R+LA7gIuzv4hV1W4khc1dp3VwSKQZqeNzyOJi5jtZh6dSscFi+\n XfdIztcR0l7rMI8r2qJMBiXuB2g7Ycq+0DGB0Lg+7fPhB8Vg+AfDOyuQb9r9AyOqfzMy\n glDA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1704304042; x=1704908842;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=aZn5H3BibQIjCm6XCuZSPBoWZOto2pSlAUY4r4Wn5U8=;\n b=VQ2ac6p2lrvSHqBeGcGaUWcRGalYrqVnCAg5PIXH+UShW94EVCj2TqRdz+UtU2u2Ja\n QKU/BKoQkJFjL5bNr08FWV2jnLmaxdMUVC1oqoLF3X/Y+EVvgwf6y9q8aer3bk4jPS7X\n Yb6alkFWEdZMvpJjIGjVBazPDC5yrAwBi44anwEWuAVE4i8l/jF4CxOhr/N8o75xJt5k\n KZPlU/WDXXS5O+1+G++4xyNPQzGUyjh/MjiO7O9hgcDDMDtXOcX7wQq62N1Sru2uWd5O\n Gv1iScQqm0mgEKZVkLyIoXdb6XqDrTVfU/+0F66eLlfTdk/4bk3V2tY4lseCGhArFqkY\n goFA==","X-Gm-Message-State":"AOJu0Ywz39KJjHzt30f228In+hdWFgvr1ES4aE1gF3fXTi31TdDFHY8j\n ZGBOQUQNqT2gYpbK+HY/PlR+LKIGrrP/jQ==","X-Google-Smtp-Source":"\n AGHT+IEWSmwKYOBNA3zud+Rn8MIOuM7s/OmpOblX5Yr8XMRSMzRdlO4xFHDFR+JcT+JP+VwaTeY4Dw==","X-Received":"by 2002:a05:600c:4b27:b0:40d:81bd:9d12 with SMTP id\n i39-20020a05600c4b2700b0040d81bd9d12mr743994wmp.147.1704304042639;\n Wed, 03 Jan 2024 09:47:22 -0800 (PST)","Message-ID":"","Date":"Wed, 3 Jan 2024 18:47:17 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 39/43] contrib/plugins: fix imatch","Content-Language":"en-US","To":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n qemu-devel@nongnu.org","Cc":"qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,\n Richard Henderson ,\n Song Gao ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n David Hildenbrand , Aurelien Jarno ,\n Yoshinori Sato ,\n Yanan Wang , Bin Meng ,\n Laurent Vivier , Michael Rolnik ,\n Alexandre Iooss , David Woodhouse ,\n Laurent Vivier , Paolo Bonzini ,\n Brian Cain ,\n Daniel Henrique Barboza ,\n Beraldo Leal , Paul Durrant ,\n Mahmoud Mandour , Thomas Huth ,\n Liu Zhiwei , Cleber Rosa ,\n kvm@vger.kernel.org, Peter Maydell ,\n Wainer dos Santos Moschetta , qemu-arm@nongnu.org,\n Weiwei Li , John Snow ,\n Daniel Henrique Barboza ,\n Nicholas Piggin , Palmer Dabbelt ,\n Marcel Apfelbaum ,\n Ilya Leoshkevich ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n \"Edgar E. Iglesias\" ,\n Eduardo Habkost ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Alistair Francis ","References":"<20240103173349.398526-1-alex.bennee@linaro.org>\n <20240103173349.398526-40-alex.bennee@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20240103173349.398526-40-alex.bennee@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::429;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]