[{"id":3241150,"web_url":"http://patchwork.ozlabs.org/comment/3241150/","msgid":"<6826da51-3b97-4ecf-8517-9e5b5243e91f@linaro.org>","list_archive_url":null,"date":"2024-01-03T17:43:52","subject":"Re: [PATCH v2 10/43] qtest: bump pxe-test timeout to 10 minutes","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"Hi Daniel,\n\nOn 3/1/24 18:33, Alex Bennée wrote:\n> From: Daniel P. Berrangé \n> \n> The pxe-test uses the boot_sector_test() function, and that already\n> uses a timeout of 600 seconds. So adjust the timeout on the meson\n> side accordingly.\n\nIIRC few years ago you said tests running on CI ('Tier-1') should\nrespect a time limit. IMO 10min seems too much for CI, should this\ntest be skipped there?\n\n> Signed-off-by: Daniel P. Berrangé \n> [thuth: Bump timeout to 600s and adjust commit description]\n> Signed-off-by: Thomas Huth \n> Message-Id: <20231215070357.10888-7-thuth@redhat.com>\n> Signed-off-by: Alex Bennée \n> ---\n> tests/qtest/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build\n> index 7a4160df046..ec93d5a384f 100644\n> --- a/tests/qtest/meson.build\n> +++ b/tests/qtest/meson.build\n> @@ -4,6 +4,7 @@ slow_qtests = {\n> 'npcm7xx_pwm-test': 300,\n> 'qom-test' : 900,\n> 'test-hmp' : 240,\n> + 'pxe-test': 600,\n> }\n> \n> qtests_generic = [","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=SHg9izNT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4T4xyz6Xy3z1yQ5\n\tfor ; Thu, 4 Jan 2024 04:48:27 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1rL5He-0004VI-Mx; Wed, 03 Jan 2024 12:44:02 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1rL5Hc-0004Nx-MV\n for qemu-devel@nongnu.org; Wed, 03 Jan 2024 12:44:00 -0500","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1rL5Ha-00033y-To\n for qemu-devel@nongnu.org; Wed, 03 Jan 2024 12:44:00 -0500","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-40d76fefd6bso43490205e9.2\n for ; Wed, 03 Jan 2024 09:43:58 -0800 (PST)","from [192.168.69.100] (tre93-h02-176-184-7-144.dsl.sta.abo.bbox.fr.\n [176.184.7.144]) by smtp.gmail.com with ESMTPSA id\n p7-20020adfe607000000b00336843ae919sm30885254wrm.49.2024.01.03.09.43.53\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 03 Jan 2024 09:43:56 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1704303837; x=1704908637; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=V8US0ACJb4Hw/yRgDiojK+LPOeoUlnaAFyhJhDgbvbA=;\n b=SHg9izNTyV5bSUY3q8V4rD8z5klv8v9sJrKdDTX2cw+MNa+SEFsofmYXnX6z8M2Rkh\n plPUQ7TOieb4/gl3Ovu2Ltx1C1NBsKqPkPPgEsSt0uRKmgPBBWr3v9x3zJQ2/oSAqPKu\n fJxDABXEIWLQJ9t4tn5g0BOjNfBSf93d07Liy2EF86HT7Zn1kBdMH7nwl5cksHSO2Jcz\n WknSAOQ1EsbifWRoypGo9dj2aCr0OH+21tGt/hy+AhJkkenM7E5rjkuh2Vy/izmBKTWR\n Xhv7GkE6S0ARTJqh+i9l39VZAO/uK7sky/RKIqAWxtDfz91mMfpRAD7JjOZj+aRCtIWF\n I+BQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1704303837; x=1704908637;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=V8US0ACJb4Hw/yRgDiojK+LPOeoUlnaAFyhJhDgbvbA=;\n b=erIEkHozJNmVVbE3fOrTED/xM4DhXd6eqMR6zX8QVB/vysCpASfvUJv5MnPWRcywZO\n Ju2csDiUb6lGdPsQWO5ZHnGZfQ/UOgvU0TmNBDJZ7xPuNDZG4mezSdyWBECvdLhcKFEH\n 46w1ppZx4H32BiiaXuW66MgIxvRotbqw2Kb5yH+Mmz6bXWnXPyMK2/x0b969SzZ7XhF/\n 84MwMtPZ8+tPI/hKI20iGA8x6mvXb9i1R67BU/43brusBCVxvT5a7IGfS8Z7chZfRwoj\n KpLxMy9lyM0bwxBM+QyB3OstY/9GNTI1G9TzxaWE3oSRyQfoOv+n760eTabgioKRzh9a\n lL9g==","X-Gm-Message-State":"AOJu0Yzfwn80Gkua3ooDrEZQR1Ub4MXelN7c9qXLniqWD2j5gueD2haE\n 1OWjy5Ot+GV59JcuOXyhBcXzzAuhnQhPMQ==","X-Google-Smtp-Source":"\n AGHT+IG5G9mQ4BJ4FXQ/6LVXB48S3IsiORpTQTFyaxnxAOVk8KcHF9cASuMfoLN6MOOl0hYkw6H46w==","X-Received":"by 2002:a05:600c:3501:b0:40d:5a99:3bb6 with SMTP id\n h1-20020a05600c350100b0040d5a993bb6mr3579336wmq.41.1704303836866;\n Wed, 03 Jan 2024 09:43:56 -0800 (PST)","Message-ID":"<6826da51-3b97-4ecf-8517-9e5b5243e91f@linaro.org>","Date":"Wed, 3 Jan 2024 18:43:52 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 10/43] qtest: bump pxe-test timeout to 10 minutes","Content-Language":"en-US","To":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n qemu-devel@nongnu.org,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Cc":"qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,\n Richard Henderson ,\n Song Gao ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n David Hildenbrand , Aurelien Jarno ,\n Yoshinori Sato ,\n Yanan Wang , Bin Meng ,\n Laurent Vivier , Michael Rolnik ,\n Alexandre Iooss , David Woodhouse ,\n Laurent Vivier , Paolo Bonzini ,\n Brian Cain ,\n Daniel Henrique Barboza ,\n Beraldo Leal , Paul Durrant ,\n Mahmoud Mandour , Thomas Huth ,\n Liu Zhiwei , Cleber Rosa ,\n kvm@vger.kernel.org, Peter Maydell ,\n Wainer dos Santos Moschetta , qemu-arm@nongnu.org,\n Weiwei Li , John Snow ,\n Daniel Henrique Barboza ,\n Nicholas Piggin , Palmer Dabbelt ,\n Marcel Apfelbaum ,\n Ilya Leoshkevich ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n \"Edgar E. Iglesias\" ,\n Eduardo Habkost ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Alistair Francis ","References":"<20240103173349.398526-1-alex.bennee@linaro.org>\n <20240103173349.398526-11-alex.bennee@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20240103173349.398526-11-alex.bennee@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3241438,"web_url":"http://patchwork.ozlabs.org/comment/3241438/","msgid":"","list_archive_url":null,"date":"2024-01-04T09:31:35","subject":"Re: [PATCH v2 10/43] qtest: bump pxe-test timeout to 10 minutes","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Wed, Jan 03, 2024 at 06:43:52PM +0100, Philippe Mathieu-Daudé wrote:\n> Hi Daniel,\n> \n> On 3/1/24 18:33, Alex Bennée wrote:\n> > From: Daniel P. Berrangé \n> > \n> > The pxe-test uses the boot_sector_test() function, and that already\n> > uses a timeout of 600 seconds. So adjust the timeout on the meson\n> > side accordingly.\n> \n> IIRC few years ago you said tests running on CI ('Tier-1') should\n> respect a time limit. IMO 10min seems too much for CI, should this\n> test be skipped there?\n\nThis isn't going to take 10 minutes in reality. We're setting timeouts\nsuch that we avoid false-failures in the extreme worst case scenarios.\n\n> \n> > Signed-off-by: Daniel P. Berrangé \n> > [thuth: Bump timeout to 600s and adjust commit description]\n> > Signed-off-by: Thomas Huth \n> > Message-Id: <20231215070357.10888-7-thuth@redhat.com>\n> > Signed-off-by: Alex Bennée \n> > ---\n> > tests/qtest/meson.build | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build\n> > index 7a4160df046..ec93d5a384f 100644\n> > --- a/tests/qtest/meson.build\n> > +++ b/tests/qtest/meson.build\n> > @@ -4,6 +4,7 @@ slow_qtests = {\n> > 'npcm7xx_pwm-test': 300,\n> > 'qom-test' : 900,\n> > 'test-hmp' : 240,\n> > + 'pxe-test': 600,\n> > }\n> > qtests_generic = [\n> \n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PukynblA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4T5Lwf2wCsz1ydb\n\tfor ; Thu, 4 Jan 2024 20:32:50 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1rLK52-0008WS-HQ; Thu, 04 Jan 2024 04:32:00 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1rLK4x-0008Vj-SU\n for qemu-devel@nongnu.org; Thu, 04 Jan 2024 04:31:55 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1rLK4v-0008NQ-Ke\n for qemu-devel@nongnu.org; Thu, 04 Jan 2024 04:31:55 -0500","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-390-VfOJiDoeMgCX6uAq70exgQ-1; Thu, 04 Jan 2024 04:31:48 -0500","from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 288B3863B83;\n Thu, 4 Jan 2024 09:31:47 +0000 (UTC)","from redhat.com (unknown [10.42.28.113])\n by smtp.corp.redhat.com (Postfix) with ESMTPS id 821551121313;\n Thu, 4 Jan 2024 09:31:37 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1704360712;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=zIXKKMqhILxRblSeoztvZ34izwtCDG3gNl+mN+M3Jfw=;\n b=PukynblAw8rcHitjKMBiqqJPLa9+Sn+9WrZUUw/YzpRyP84rHhG1vX8sPKpOMkAcH7MgT7\n YvQv+LxAvrvri2lSIMAf6zChXBvUq4bjUm4xTLK0cXHux39+TE9jelwCpZNFLE40OuI1NG\n jjsw9Dgmh9zcbLDvDs6fAMzjwUzS5kg=","X-MC-Unique":"VfOJiDoeMgCX6uAq70exgQ-1","Date":"Thu, 4 Jan 2024 09:31:35 +0000","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ","Cc":"Alex =?utf-8?q?Benn=C3=A9e?= ,\n qemu-devel@nongnu.org, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,\n Richard Henderson ,\n Song Gao ,\n =?utf-8?q?Marc-Andr=C3=A9?= Lureau ,\n David Hildenbrand , Aurelien Jarno ,\n Yoshinori Sato ,\n Yanan Wang , Bin Meng ,\n Laurent Vivier , Michael Rolnik ,\n Alexandre Iooss , David Woodhouse ,\n Laurent Vivier , Paolo Bonzini ,\n Brian Cain ,\n Daniel Henrique Barboza ,\n Beraldo Leal , Paul Durrant ,\n Mahmoud Mandour , Thomas Huth ,\n Liu Zhiwei , Cleber Rosa ,\n kvm@vger.kernel.org, Peter Maydell ,\n Wainer dos Santos Moschetta , qemu-arm@nongnu.org,\n Weiwei Li , John Snow ,\n Daniel Henrique Barboza ,\n Nicholas Piggin , Palmer Dabbelt ,\n Marcel Apfelbaum ,\n Ilya Leoshkevich ,\n =?utf-8?q?C=C3=A9dric?= Le Goater ,\n \"Edgar E. Iglesias\" ,\n Eduardo Habkost ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Alistair Francis ","Subject":"Re: [PATCH v2 10/43] qtest: bump pxe-test timeout to 10 minutes","Message-ID":"","References":"<20240103173349.398526-1-alex.bennee@linaro.org>\n <20240103173349.398526-11-alex.bennee@linaro.org>\n <6826da51-3b97-4ecf-8517-9e5b5243e91f@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<6826da51-3b97-4ecf-8517-9e5b5243e91f@linaro.org>","User-Agent":"Mutt/2.2.10 (2023-03-25)","X-Scanned-By":"MIMEDefang 3.4.1 on 10.11.54.3","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-46","X-Spam_score":"-4.7","X-Spam_bar":"----","X-Spam_report":"(-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.601,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]