[{"id":3202673,"web_url":"http://patchwork.ozlabs.org/comment/3202673/","msgid":"","list_archive_url":null,"date":"2023-10-19T16:35:12","subject":"Re: [PULL 06/25] s390x/cpu topology: resetting the\n Topology-Change-Report","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Wed, 18 Oct 2023 at 06:09, Thomas Huth wrote:\n>\n> From: Pierre Morel \n>\n> During a subsystem reset the Topology-Change-Report is cleared\n> by the machine.\n> Let's ask KVM to clear the Modified Topology Change Report (MTCR)\n> bit of the SCA in the case of a subsystem reset.\n>\n> Signed-off-by: Pierre Morel \n> Reviewed-by: Thomas Huth \n> Reviewed-by: Nina Schoetterl-Glausch \n> Co-developed-by: Nina Schoetterl-Glausch \n> Signed-off-by: Nina Schoetterl-Glausch \n> Message-ID: <20231016183925.2384704-7-nsg@linux.ibm.com>\n> Signed-off-by: Thomas Huth \n> ---\n> include/hw/s390x/cpu-topology.h | 1 +\n> target/s390x/cpu.h | 1 +\n> target/s390x/kvm/kvm_s390x.h | 1 +\n> hw/s390x/cpu-topology.c | 11 +++++++++++\n> hw/s390x/s390-virtio-ccw.c | 3 +++\n> target/s390x/cpu-sysemu.c | 13 +++++++++++++\n> target/s390x/kvm/kvm.c | 17 +++++++++++++++++\n> 7 files changed, 47 insertions(+)\n>\n> diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h\n> index f95d26d37c..e33e7c66df 100644\n> --- a/include/hw/s390x/cpu-topology.h\n> +++ b/include/hw/s390x/cpu-topology.h\n> @@ -56,6 +56,7 @@ static inline void s390_topology_setup_cpu(MachineState *ms,\n> #endif\n>\n> extern S390Topology s390_topology;\n> +void s390_topology_reset(void);\n\nPlease take a look at the following CI failure:\n\n/usr/bin/ld: libqemu-s390x-softmmu.fa.p/hw_s390x_s390-virtio-ccw.c.o:\nin function `subsystem_reset':\n/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/../hw/s390x/s390-virtio-ccw.c:128:\nundefined reference to `s390_topology_reset'\n\nhttps://gitlab.com/qemu-project/qemu/-/jobs/5330218593\n\n>\n> static inline int s390_std_socket(int n, CpuTopology *smp)\n> {\n> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\n> index 09bff39fe4..40c5cedd0e 100644\n> --- a/target/s390x/cpu.h\n> +++ b/target/s390x/cpu.h\n> @@ -654,6 +654,7 @@ typedef struct SysIBCPUListEntry {\n> QEMU_BUILD_BUG_ON(sizeof(SysIBCPUListEntry) != 16);\n>\n> void insert_stsi_15_1_x(S390CPU *cpu, int sel2, uint64_t addr, uint8_t ar, uintptr_t ra);\n> +void s390_cpu_topology_set_changed(bool changed);\n>\n> /* MMU defines */\n> #define ASCE_ORIGIN (~0xfffULL) /* segment table origin */\n> diff --git a/target/s390x/kvm/kvm_s390x.h b/target/s390x/kvm/kvm_s390x.h\n> index f9785564d0..649dae5948 100644\n> --- a/target/s390x/kvm/kvm_s390x.h\n> +++ b/target/s390x/kvm/kvm_s390x.h\n> @@ -47,5 +47,6 @@ void kvm_s390_crypto_reset(void);\n> void kvm_s390_restart_interrupt(S390CPU *cpu);\n> void kvm_s390_stop_interrupt(S390CPU *cpu);\n> void kvm_s390_set_diag318(CPUState *cs, uint64_t diag318_info);\n> +int kvm_s390_topology_set_mtcr(uint64_t attr);\n>\n> #endif /* KVM_S390X_H */\n> diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-topology.c\n> index 13168341b6..7ec9319272 100644\n> --- a/hw/s390x/cpu-topology.c\n> +++ b/hw/s390x/cpu-topology.c\n> @@ -90,6 +90,17 @@ static void s390_topology_init(MachineState *ms)\n> smp->books * smp->drawers);\n> }\n>\n> +/**\n> + * s390_topology_reset:\n> + *\n> + * Generic reset for CPU topology, calls s390_topology_reset()\n> + * to reset the kernel Modified Topology Change Record.\n> + */\n> +void s390_topology_reset(void)\n> +{\n> + s390_cpu_topology_set_changed(false);\n> +}\n> +\n> /**\n> * s390_topology_cpu_default:\n> * @cpu: pointer to a S390CPU\n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index 7fe2bce20c..6012165d41 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -124,6 +124,9 @@ static void subsystem_reset(void)\n> device_cold_reset(dev);\n> }\n> }\n> + if (s390_has_topology()) {\n> + s390_topology_reset();\n> + }\n> }\n>\n> static int virtio_ccw_hcall_notify(const uint64_t *args)\n> diff --git a/target/s390x/cpu-sysemu.c b/target/s390x/cpu-sysemu.c\n> index 8112561e5e..1cd30c1d84 100644\n> --- a/target/s390x/cpu-sysemu.c\n> +++ b/target/s390x/cpu-sysemu.c\n> @@ -307,3 +307,16 @@ void s390_do_cpu_set_diag318(CPUState *cs, run_on_cpu_data arg)\n> kvm_s390_set_diag318(cs, arg.host_ulong);\n> }\n> }\n> +\n> +void s390_cpu_topology_set_changed(bool changed)\n> +{\n> + int ret;\n> +\n> + if (kvm_enabled()) {\n> + ret = kvm_s390_topology_set_mtcr(changed);\n> + if (ret) {\n> + error_report(\"Failed to set Modified Topology Change Report: %s\",\n> + strerror(-ret));\n> + }\n> + }\n> +}\n> diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c\n> index 53d6300809..d6bda3a2a8 100644\n> --- a/target/s390x/kvm/kvm.c\n> +++ b/target/s390x/kvm/kvm.c\n> @@ -2664,6 +2664,23 @@ int kvm_s390_get_zpci_op(void)\n> return cap_zpci_op;\n> }\n>\n> +int kvm_s390_topology_set_mtcr(uint64_t attr)\n> +{\n> + struct kvm_device_attr attribute = {\n> + .group = KVM_S390_VM_CPU_TOPOLOGY,\n> + .attr = attr,\n> + };\n> +\n> + if (!s390_has_feat(S390_FEAT_CONFIGURATION_TOPOLOGY)) {\n> + return 0;\n> + }\n> + if (!kvm_vm_check_attr(kvm_state, KVM_S390_VM_CPU_TOPOLOGY, attr)) {\n> + return -ENOTSUP;\n> + }\n> +\n> + return kvm_vm_ioctl(kvm_state, KVM_SET_DEVICE_ATTR, &attribute);\n> +}\n> +\n> void kvm_arch_accel_class_init(ObjectClass *oc)\n> {\n> }\n> --\n> 2.41.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=KCcZfZod;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SBCyW0xdgz20Zj\n\tfor ; Fri, 20 Oct 2023 03:36:03 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qtVzq-00061s-00; Thu, 19 Oct 2023 12:35:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qtVzd-00060B-4Q; Thu, 19 Oct 2023 12:35:34 -0400","from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1qtVzZ-0000sv-Oo; Thu, 19 Oct 2023 12:35:28 -0400","by mail-oo1-xc31.google.com with SMTP id\n 006d021491bc7-57bc2c2f13dso4595117eaf.2;\n Thu, 19 Oct 2023 09:35:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1697733324; x=1698338124; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=3raebs6EiNu4tLj/ikDhbtHjY7n1xUxZVwRvUY8oKTE=;\n b=KCcZfZodozjax6NamstI0iIxMpdMTjk5rLzgm15eHNdjf96KJwBafhWrdFaBBS/z9N\n Q2/m7AFMJqF+p5kNqgILKrQCoYqJdVot+6YdVIi20Xf2AXAUhubWJFgwAp1QsYLup1Sh\n +DfVkgckPZt3kfnQapTBAnYmPfIBC/xdQUQrE81qIkePGPQDlf+11hyWdE5QBktjsNKV\n Tmyf+3qhR/KEaIc7q06XGzONKLm3mRhkvO/sBzniul1Jztgra6ncbJn9bx60x3NSrVjt\n 6gNzzKBoPe2EboncfExDggBgN7sQ9AdggoaykU0DV4XUm73rZkd7QcmhAOIQ5/RJ0Tds\n UIrg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1697733324; x=1698338124;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=3raebs6EiNu4tLj/ikDhbtHjY7n1xUxZVwRvUY8oKTE=;\n b=r8oEYGQgkeDhgU4l/QDc2IUpE0FWOO2ovbzP6DKaNyfpFptUTCc4MsAPqJJVsrdFqZ\n g86KU89dCNlgC6NFqmEu4MOBmqi/ESaZ2MiQo8mx5qz7hiQQip0iwWzwtIJCp+cSlsxs\n w+Sunp8XDDS/clUZWmOjfOLfv68kUY7NQiTkgXgvcI6Xr9rt2D4tGoZzRmZucHP9ASlg\n AWqxa6kKFzbxLw2V3uLiFpvNR19nU/7W6ZyMyRVjlw/YPU4LYdoV8i3jN0inIEqSA+VF\n 8BYYtkNJ9CmTzpIrGqhWotw8lznroRQ+wBJ3Nn6pNoWPGojgPkubx/w7LrTBz3rCwLVd\n eDrw==","X-Gm-Message-State":"AOJu0YxwTdnoS2AwE/XTiuzmeWeLxjY783c8fdkI+vK+hhi2wbg2M8fA\n +MVBgTQJy7/U1+alaAG2T0jUu8F8fwBQpvE6u3Y=","X-Google-Smtp-Source":"\n AGHT+IEnaHNoMJgOs0w7UWcdtxVoK+3reW4hnwcht/anxyY/9NC2lW5VuOab80BqZZRf1/l18Kz/SdxSMGfF5TolEUw=","X-Received":"by 2002:a4a:a34d:0:b0:582:99ae:ca47 with SMTP id\n u13-20020a4aa34d000000b0058299aeca47mr2900266ool.3.1697733323948; Thu, 19 Oct\n 2023 09:35:23 -0700 (PDT)","MIME-Version":"1.0","References":"<20231018130716.286638-1-thuth@redhat.com>\n <20231018130716.286638-7-thuth@redhat.com>","In-Reply-To":"<20231018130716.286638-7-thuth@redhat.com>","From":"Stefan Hajnoczi ","Date":"Thu, 19 Oct 2023 09:35:12 -0700","Message-ID":"\n ","Subject":"Re: [PULL 06/25] s390x/cpu topology: resetting the\n Topology-Change-Report","To":"Thomas Huth , Pierre Morel ","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ,\n qemu-s390x@nongnu.org, Nina Schoetterl-Glausch ","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::c31;\n envelope-from=stefanha@gmail.com; helo=mail-oo1-xc31.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3202725,"web_url":"http://patchwork.ozlabs.org/comment/3202725/","msgid":"<991f3195f7e4e3989e43e45e9e1910cda410c444.camel@linux.ibm.com>","list_archive_url":null,"date":"2023-10-19T17:55:34","subject":"Re: [PULL 06/25] s390x/cpu topology: resetting the\n Topology-Change-Report","submitter":{"id":85377,"url":"http://patchwork.ozlabs.org/api/people/85377/","name":"Nina Schoetterl-Glausch","email":"nsg@linux.ibm.com"},"content":"On Thu, 2023-10-19 at 09:35 -0700, Stefan Hajnoczi wrote:\n> On Wed, 18 Oct 2023 at 06:09, Thomas Huth wrote:\n> > \n> > From: Pierre Morel \n> > \n> > During a subsystem reset the Topology-Change-Report is cleared\n> > by the machine.\n> > Let's ask KVM to clear the Modified Topology Change Report (MTCR)\n> > bit of the SCA in the case of a subsystem reset.\n> > \n> > Signed-off-by: Pierre Morel \n> > Reviewed-by: Thomas Huth \n> > Reviewed-by: Nina Schoetterl-Glausch \n> > Co-developed-by: Nina Schoetterl-Glausch \n> > Signed-off-by: Nina Schoetterl-Glausch \n> > Message-ID: <20231016183925.2384704-7-nsg@linux.ibm.com>\n> > Signed-off-by: Thomas Huth \n> > ---\n> > include/hw/s390x/cpu-topology.h | 1 +\n> > target/s390x/cpu.h | 1 +\n> > target/s390x/kvm/kvm_s390x.h | 1 +\n> > hw/s390x/cpu-topology.c | 11 +++++++++++\n> > hw/s390x/s390-virtio-ccw.c | 3 +++\n> > target/s390x/cpu-sysemu.c | 13 +++++++++++++\n> > target/s390x/kvm/kvm.c | 17 +++++++++++++++++\n> > 7 files changed, 47 insertions(+)\n> > \n> > diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h\n> > index f95d26d37c..e33e7c66df 100644\n> > --- a/include/hw/s390x/cpu-topology.h\n> > +++ b/include/hw/s390x/cpu-topology.h\n> > @@ -56,6 +56,7 @@ static inline void s390_topology_setup_cpu(MachineState *ms,\n> > #endif\n> > \n> > extern S390Topology s390_topology;\n> > +void s390_topology_reset(void);\n> \n> Please take a look at the following CI failure:\n> \n> /usr/bin/ld: libqemu-s390x-softmmu.fa.p/hw_s390x_s390-virtio-ccw.c.o:\n> in function `subsystem_reset':\n> /home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/../hw/s390x/s390-virtio-ccw.c:128:\n> undefined reference to `s390_topology_reset'\n> \n> https://gitlab.com/qemu-project/qemu/-/jobs/5330218593\n\nI can replicate this with --disable-kvm, tho I don't think that's what the CI does.\nFix looks something like this (copy pasted):\n\n--- a/include/hw/s390x/cpu-topology.h\n+++ b/include/hw/s390x/cpu-topology.h\n@@ -45,6 +45,7 @@ typedef QTAILQ_HEAD(, S390TopologyEntry) S390TopologyList;\n #ifdef CONFIG_KVM\n bool s390_has_topology(void);\n void s390_topology_setup_cpu(MachineState *ms, S390CPU *cpu, Error **errp);\n+void s390_topology_reset(void);\n #else\n static inline bool s390_has_topology(void)\n {\n@@ -53,10 +54,14 @@ static inline bool s390_has_topology(void)\n static inline void s390_topology_setup_cpu(MachineState *ms,\n S390CPU *cpu,\n Error **errp) {}\n+static inline void s390_topology_reset(void)\n+{\n+ /* Unreachable, CPU topology not implemented for TCG */\n+ assert(false);\n+}\n #endif\n\n extern S390Topology s390_topology;\n-void s390_topology_reset(void);\n\n static inline int s390_std_socket(int n, CpuTopology *smp)\n {","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=nMhHh0gC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SBFpT4TPJz23jP\n\tfor ; Fri, 20 Oct 2023 04:59:13 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qtXHt-0001IZ-DY; Thu, 19 Oct 2023 13:58:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qtXHr-00014Z-D4; Thu, 19 Oct 2023 13:58:23 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qtXHp-0001Rz-DY; Thu, 19 Oct 2023 13:58:23 -0400","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39JHlJSb022932; Thu, 19 Oct 2023 17:58:19 GMT","from pps.reinject (localhost [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tu95pre5u-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 19 Oct 2023 17:58:19 +0000","from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1])\n by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39JHlShB024173;\n Thu, 19 Oct 2023 17:58:16 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tu95prd5b-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 19 Oct 2023 17:58:15 +0000","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39JHIE38027154; Thu, 19 Oct 2023 17:55:37 GMT","from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3tr6tktbym-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 19 Oct 2023 17:55:37 +0000","from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com\n [10.20.54.103])\n by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 39JHtZfK41091506\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 19 Oct 2023 17:55:35 GMT","from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 481EA20043;\n Thu, 19 Oct 2023 17:55:35 +0000 (GMT)","from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id DC30520040;\n Thu, 19 Oct 2023 17:55:34 +0000 (GMT)","from li-978a334c-2cba-11b2-a85c-a0743a31b510.ibm.com (unknown\n [9.171.84.173]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 19 Oct 2023 17:55:34 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=message-id : subject :\n from : to : cc : date : in-reply-to : references : content-type :\n content-transfer-encoding : mime-version; s=pp1;\n bh=OwY9xZ266K8KxTGPeJc4XWdPqYn+uuxmjHU1GiVomqM=;\n b=nMhHh0gCDuEbk4LBkBoSESX7YuFO9iNZ43fLKLsS3y70qUgzTlAwPBPeGTP/aIXYKHj4\n dIFN8u8qFb9O6CqmsUg1Vi37fJHkMHemDYJTa6K2TupnlveZHFJihC8N9Nfgk+6q6h1E\n d+vtpa9c2fdreBa2V/fQr5QwS0A7TVPZDaGGV0uklPdJPXzEXoYfFe8ZDddZjUAlbHSZ\n nzR9Z6InvEFlZWcqQC5UHTpBPAwNEdVTf4gSCRC7L0fMCdwR3dM/Gm3uldEiukPj2EG7\n PebKtYorlkfMo+QBoXGpMrMq6zjbAvm0bXijDkA5Py83ejRyJ/t3e94qwDS4U6LAbWnH uQ==","Message-ID":"<991f3195f7e4e3989e43e45e9e1910cda410c444.camel@linux.ibm.com>","Subject":"Re: [PULL 06/25] s390x/cpu topology: resetting the\n Topology-Change-Report","From":"Nina Schoetterl-Glausch ","To":"Stefan Hajnoczi , Thomas Huth ,\n Pierre Morel ","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ,\n qemu-s390x@nongnu.org","Date":"Thu, 19 Oct 2023 19:55:34 +0200","In-Reply-To":"\n ","References":"<20231018130716.286638-1-thuth@redhat.com>\n <20231018130716.286638-7-thuth@redhat.com>\n ","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.48.4 (3.48.4-1.fc38) ","X-TM-AS-GCONF":"00","X-Proofpoint-GUID":"EzNC1ZJY2BMLh_D1rwigzjCyWAWcPcL9","X-Proofpoint-ORIG-GUID":"mgsmykuW2zvX5Rmmb_93wlXudEA_wQXH","Content-Transfer-Encoding":"quoted-printable","X-Proofpoint-UnRewURL":"0 URL was un-rewritten","MIME-Version":"1.0","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-19_17,2023-10-19_01,2023-05-22_02","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 mlxscore=0\n mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0\n priorityscore=1501 malwarescore=0 phishscore=0 suspectscore=0\n lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2309180000 definitions=main-2310190152","Received-SPF":"pass client-ip=148.163.156.1; envelope-from=nsg@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001,\n RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3202775,"web_url":"http://patchwork.ozlabs.org/comment/3202775/","msgid":"<1fb044ef-2d63-4101-bc65-80133e9f7c5a@redhat.com>","list_archive_url":null,"date":"2023-10-19T19:32:24","subject":"Re: [PULL 06/25] s390x/cpu topology: resetting the\n Topology-Change-Report","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 19/10/2023 19.55, Nina Schoetterl-Glausch wrote:\n> On Thu, 2023-10-19 at 09:35 -0700, Stefan Hajnoczi wrote:\n>> On Wed, 18 Oct 2023 at 06:09, Thomas Huth wrote:\n>>>\n>>> From: Pierre Morel \n>>>\n>>> During a subsystem reset the Topology-Change-Report is cleared\n>>> by the machine.\n>>> Let's ask KVM to clear the Modified Topology Change Report (MTCR)\n>>> bit of the SCA in the case of a subsystem reset.\n>>>\n>>> Signed-off-by: Pierre Morel \n>>> Reviewed-by: Thomas Huth \n>>> Reviewed-by: Nina Schoetterl-Glausch \n>>> Co-developed-by: Nina Schoetterl-Glausch \n>>> Signed-off-by: Nina Schoetterl-Glausch \n>>> Message-ID: <20231016183925.2384704-7-nsg@linux.ibm.com>\n>>> Signed-off-by: Thomas Huth \n>>> ---\n>>> include/hw/s390x/cpu-topology.h | 1 +\n>>> target/s390x/cpu.h | 1 +\n>>> target/s390x/kvm/kvm_s390x.h | 1 +\n>>> hw/s390x/cpu-topology.c | 11 +++++++++++\n>>> hw/s390x/s390-virtio-ccw.c | 3 +++\n>>> target/s390x/cpu-sysemu.c | 13 +++++++++++++\n>>> target/s390x/kvm/kvm.c | 17 +++++++++++++++++\n>>> 7 files changed, 47 insertions(+)\n>>>\n>>> diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h\n>>> index f95d26d37c..e33e7c66df 100644\n>>> --- a/include/hw/s390x/cpu-topology.h\n>>> +++ b/include/hw/s390x/cpu-topology.h\n>>> @@ -56,6 +56,7 @@ static inline void s390_topology_setup_cpu(MachineState *ms,\n>>> #endif\n>>>\n>>> extern S390Topology s390_topology;\n>>> +void s390_topology_reset(void);\n>>\n>> Please take a look at the following CI failure:\n>>\n>> /usr/bin/ld: libqemu-s390x-softmmu.fa.p/hw_s390x_s390-virtio-ccw.c.o:\n>> in function `subsystem_reset':\n>> /home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/../hw/s390x/s390-virtio-ccw.c:128:\n>> undefined reference to `s390_topology_reset'\n>>\n>> https://gitlab.com/qemu-project/qemu/-/jobs/5330218593\n> \n> I can replicate this with --disable-kvm, tho I don't think that's what the CI does.\n\nI think that was the wrong CI job that Stefan linked. It rather seemed to \nhappen here:\n\n https://gitlab.com/qemu-project/qemu/-/jobs/5329820093#L5564\n\nThat job uses --enable-debug which turns off optimization, i.e. that was \nlikely causing some code to be included that normally gets optimized away.\n\n> Fix looks something like this (copy pasted):\n> \n> --- a/include/hw/s390x/cpu-topology.h\n> +++ b/include/hw/s390x/cpu-topology.h\n> @@ -45,6 +45,7 @@ typedef QTAILQ_HEAD(, S390TopologyEntry) S390TopologyList;\n> #ifdef CONFIG_KVM\n> bool s390_has_topology(void);\n> void s390_topology_setup_cpu(MachineState *ms, S390CPU *cpu, Error **errp);\n> +void s390_topology_reset(void);\n> #else\n> static inline bool s390_has_topology(void)\n> {\n> @@ -53,10 +54,14 @@ static inline bool s390_has_topology(void)\n> static inline void s390_topology_setup_cpu(MachineState *ms,\n> S390CPU *cpu,\n> Error **errp) {}\n> +static inline void s390_topology_reset(void)\n> +{\n> + /* Unreachable, CPU topology not implemented for TCG */\n> + assert(false);\n> +}\n> #endif\n> \n> extern S390Topology s390_topology;\n> -void s390_topology_reset(void);\n> \n> static inline int s390_std_socket(int n, CpuTopology *smp)\n> {\n\nThanks, that seems to fix the issue with --enable-debug, too.\nI'll squash that into the related patch (also fixing the indentation in \ns390_has_topology()) and respin the pull request.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LRON59oG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SBHv22ZYcz20cx\n\tfor ; Fri, 20 Oct 2023 06:33:18 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qtYl9-0002n3-3t; Thu, 19 Oct 2023 15:32:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qtYl6-0002mU-TQ\n for qemu-devel@nongnu.org; Thu, 19 Oct 2023 15:32:40 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qtYl5-0006eP-9F\n for qemu-devel@nongnu.org; Thu, 19 Oct 2023 15:32:40 -0400","from mail-ed1-f72.google.com (mail-ed1-f72.google.com\n [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-269-8rMUAIPEPLeFM5pMxepOeA-1; Thu, 19 Oct 2023 15:32:27 -0400","by mail-ed1-f72.google.com with SMTP id\n 4fb4d7f45d1cf-53e305a5a1bso5419286a12.1\n for ; Thu, 19 Oct 2023 12:32:27 -0700 (PDT)","from [192.168.0.5] (ip-109-43-176-141.web.vodafone.de.\n [109.43.176.141]) by smtp.gmail.com with ESMTPSA id\n 22-20020a508756000000b00532eba07773sm126594edv.25.2023.10.19.12.32.25\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 19 Oct 2023 12:32:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1697743958;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=Kl8dxuwJBJ3fF2zsQTuHM2/0TzJILVq7Whboy9VRfdU=;\n b=LRON59oG+mfPMNh9nqY4fn5lDRwIIWmVzLFcI23frhBP6DyqaHwj0XZa+8s4DvQDWdLRrd\n 22tWaEdR9TDNJ995QDYe9s8LNzvhVHS2qCdEW4iwoebO9NPVDdwlGQF+E37iBN6ntqdb/y\n PdGQm1Elc7RxBT1YmS4Bh9RNQ8YWzYk=","X-MC-Unique":"8rMUAIPEPLeFM5pMxepOeA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1697743946; x=1698348746;\n h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc\n :to:content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=Kl8dxuwJBJ3fF2zsQTuHM2/0TzJILVq7Whboy9VRfdU=;\n b=l8nfnHDhxgNjzYarW8NhEY6BjnZAps1uDClulzcLT0Xv6tQD9NG8FIGU9TfzYLRQeJ\n P1nkGOIZS9CEmzhrZyaaXI/1d4DPYtpjDRgyTf0hTzyRfnhnIhI/DemKBOlrhWnfPx/D\n IdPDeHL3QZIWHlZTqCRV/mBYXyaJ1hhrBColb5we7nWrG21QU8/iowxXwxo5VvxZDYr+\n H1M8AyLHqtiQUFRmD9jKscCnYf+Wftn1SFyg/SBqrytOh99wp2TrC1mxEyiQ7NSOiW3F\n fZkBPDTEEyeQmM/G0bVUn4EydtAPrgMU4r7K1NZpoWRYxxtmNhcYyR9yCvjL4O3Uwp+v\n huoA==","X-Gm-Message-State":"AOJu0YyqC4uqD3B92wv8Fusz54MSmueD6/rCsPSyYSU8DRSNUgt9MHhm\n +CQX9NNe8P2sQe3H660dKi421aXT/6PsgIzQOLZr475KpRQPSeI/gIc7g75HQ7xLF2hZmACNg5N\n yGXSilig3sFC0JfU=","X-Received":["by 2002:a50:9ec4:0:b0:53e:332e:3e03 with SMTP id\n a62-20020a509ec4000000b0053e332e3e03mr2269904edf.4.1697743946217;\n Thu, 19 Oct 2023 12:32:26 -0700 (PDT)","by 2002:a50:9ec4:0:b0:53e:332e:3e03 with SMTP id\n a62-20020a509ec4000000b0053e332e3e03mr2269887edf.4.1697743945824;\n Thu, 19 Oct 2023 12:32:25 -0700 (PDT)"],"X-Google-Smtp-Source":"\n AGHT+IEMfCtGLToZbB/EvUW9VIgN3BLet/yJfDMSMyUFfIF+KTfV2Dtl7C/ku6IkHf3FmXOFu1OEcg==","Message-ID":"<1fb044ef-2d63-4101-bc65-80133e9f7c5a@redhat.com>","Date":"Thu, 19 Oct 2023 21:32:24 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PULL 06/25] s390x/cpu topology: resetting the\n Topology-Change-Report","Content-Language":"en-US","To":"Nina Schoetterl-Glausch ,\n Stefan Hajnoczi ,\n Pierre Morel ","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ,\n qemu-s390x@nongnu.org","References":"<20231018130716.286638-1-thuth@redhat.com>\n <20231018130716.286638-7-thuth@redhat.com>\n \n <991f3195f7e4e3989e43e45e9e1910cda410c444.camel@linux.ibm.com>","From":"Thomas Huth ","Autocrypt":"addr=thuth@redhat.com; keydata=\n xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU\n yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2\n 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW\n tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O\n 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81\n O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW\n 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH\n gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr\n 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ\n zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0\n aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW\n AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK\n QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX\n EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV\n 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD\n eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k\n ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq\n zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG\n tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6\n WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7\n UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN\n BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4\n 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa\n +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH\n 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K\n gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/\n WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ\n VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq\n knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV\n cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB\n X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM\n AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn\n ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k\n fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS\n 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK\n cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV\n ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17\n Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD\n oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs\n IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a\n yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn","In-Reply-To":"<991f3195f7e4e3989e43e45e9e1910cda410c444.camel@linux.ibm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3203088,"web_url":"http://patchwork.ozlabs.org/comment/3203088/","msgid":"<5408668c13072f4afbfeeee05b7a340a0077e533.camel@linux.ibm.com>","list_archive_url":null,"date":"2023-10-20T09:26:24","subject":"Re: [PULL 06/25] s390x/cpu topology: resetting the\n Topology-Change-Report","submitter":{"id":85377,"url":"http://patchwork.ozlabs.org/api/people/85377/","name":"Nina Schoetterl-Glausch","email":"nsg@linux.ibm.com"},"content":"On Thu, 2023-10-19 at 21:32 +0200, Thomas Huth wrote:\n\n[...]\n\n> Thanks, that seems to fix the issue with --enable-debug, too.\n> I'll squash that into the related patch (also fixing the indentation in \n> s390_has_topology()) and respin the pull request.\n> \n> Thomas\n> \n\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=NyRHOUfC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4SBfP65HN0z23jM\n\tfor ; Fri, 20 Oct 2023 20:27:06 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qtlm9-0006TG-2A; Fri, 20 Oct 2023 05:26:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qtlm5-0006Sm-Nu; Fri, 20 Oct 2023 05:26:33 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qtlm4-0003wY-10; Fri, 20 Oct 2023 05:26:33 -0400","from pps.filterd (m0353722.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39K99ZwL016137; Fri, 20 Oct 2023 09:26:30 GMT","from pps.reinject (localhost [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tupnxrm78-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 20 Oct 2023 09:26:29 +0000","from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1])\n by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39K99s1L017868;\n Fri, 20 Oct 2023 09:26:29 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tupnxrm54-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 20 Oct 2023 09:26:28 +0000","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39K94ERI002779; Fri, 20 Oct 2023 09:26:27 GMT","from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3tuc44bkut-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 20 Oct 2023 09:26:27 +0000","from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com\n [10.20.54.105])\n by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 39K9QPn719595844\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Fri, 20 Oct 2023 09:26:25 GMT","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 5F04E20049;\n Fri, 20 Oct 2023 09:26:25 +0000 (GMT)","from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id E5EAB20040;\n Fri, 20 Oct 2023 09:26:24 +0000 (GMT)","from li-978a334c-2cba-11b2-a85c-a0743a31b510.ibm.com (unknown\n [9.171.19.184]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Fri, 20 Oct 2023 09:26:24 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=message-id : subject :\n from : to : cc : date : in-reply-to : references : content-type :\n content-transfer-encoding : mime-version; s=pp1;\n bh=3neMqrzf1wcm9TGYy6TmSjTOqZuUwgOb/cxUJHyKhm8=;\n b=NyRHOUfCJjCVnRgTuThb9HPLwIwWe+hUgcObKlINsrh8a4Jlt+Lw8qYhziaxI26whGzM\n TYIjJw5RFajzs7qnKGfeEt9AyvAUeJm26gDu7/MUbAB6wYaJvLwzUKO2WU4JYWTso2tg\n wHwRtOHNN0dp9p5J/4UqAdONaHgeIN2G/OrCn9NOGTb8VVo7ndDOiCEhcmC8nq7Yz2Nn\n Un54djHzDVVxiolY4a7LsjBiC3FcHdLwc//RxE5fnJt6HY/+ZA0KxFdH0askw/iCjiHn\n Usb6UGellXnJnoXwMnRpoSlXYpBEzinO8hMSR3TnSVAIpwN4OtM6YU27B2/vCRyxQMoK 3A==","Message-ID":"<5408668c13072f4afbfeeee05b7a340a0077e533.camel@linux.ibm.com>","Subject":"Re: [PULL 06/25] s390x/cpu topology: resetting the\n Topology-Change-Report","From":"Nina Schoetterl-Glausch ","To":"Thomas Huth , Stefan Hajnoczi ,\n Pierre Morel ","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ,\n qemu-s390x@nongnu.org","Date":"Fri, 20 Oct 2023 11:26:24 +0200","In-Reply-To":"<1fb044ef-2d63-4101-bc65-80133e9f7c5a@redhat.com>","References":"<20231018130716.286638-1-thuth@redhat.com>\n <20231018130716.286638-7-thuth@redhat.com>\n \n <991f3195f7e4e3989e43e45e9e1910cda410c444.camel@linux.ibm.com>\n <1fb044ef-2d63-4101-bc65-80133e9f7c5a@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.48.4 (3.48.4-1.fc38) ","MIME-Version":"1.0","X-TM-AS-GCONF":"00","X-Proofpoint-GUID":"l6Dj7q7ldmoc6X1LrYZ6hggw6BC3Zwh5","X-Proofpoint-ORIG-GUID":"Z7dqSd2h025clWwoZ2OU1U2wxwQWFWZr","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-20_07,2023-10-19_01,2023-05-22_02","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0\n priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0\n mlxlogscore=873 suspectscore=0 phishscore=0 bulkscore=0 mlxscore=0\n spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx\n scancount=1 engine=8.12.0-2310170001 definitions=main-2310200077","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=nsg@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001,\n RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]