[{"id":3188577,"web_url":"http://patchwork.ozlabs.org/comment/3188577/","msgid":"","list_archive_url":null,"date":"2023-09-27T09:21:53","subject":"Re: [PATCH] maint: Tweak comment in mailmap to sound friendlier","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 26 Sept 2023 at 21:41, wrote:\n>\n> From: Eric Blake \n>\n> Documenting that we should not add new lines to work around SPF\n> rewrites sounds foreboding; the intent is instead that new lines here\n> are okay, but indicate a second problem elsewhere in our build process\n> that we should also consider fixing at the same time, to keep the\n> section from growing without bounds.\n>\n> Mentioning DMARC alongside SPF may also help people grep for this\n> scenario, as well as documenting the 'git config' workaround that can\n> be used by submitters to avoid the munging issue in the first place.\n>\n> Fixes: 3bd2608d (\"maint: Add .mailmap entries for patches claiming list authorship\")\n> CC: Andrey Drobyshev \n> Cc: Peter Maydell \n> Signed-off-by: Eric Blake \n> ---\n>\n> I'm sending this email with a temporary 'git config sendemail.from\n> eblake@redhat.com', to see if the added advice actually adds the extra\n> line. It did not show up in my editor window, though, so this patch\n> may need further tweaking to get the instructions right. Since I\n> don't normally suffer from SPF/DMARC munging, I may not be the best\n> person to test the right workaround. Or maybe 'git config' does not\n> yet have the right workaround already available as a turnkey solution\n> we can suggest.\n\nWell, the From: line appeared in my copy of the email, so I guess it works.\n\nReviewed-by: Peter Maydell \n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=eizqogNC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwWNf4sRZz1ypJ\n\tfor ; Wed, 27 Sep 2023 19:22:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlQkK-0005kP-Fx; Wed, 27 Sep 2023 05:22:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlQkJ-0005kC-Ch\n for qemu-devel@nongnu.org; Wed, 27 Sep 2023 05:22:15 -0400","from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1qlQkH-0002wu-Np\n for qemu-devel@nongnu.org; Wed, 27 Sep 2023 05:22:15 -0400","by mail-ed1-x52e.google.com with SMTP id\n 4fb4d7f45d1cf-5344d996bedso5295174a12.3\n for ; Wed, 27 Sep 2023 02:22:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1695806532; x=1696411332; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=CjmV6Vw36svKzJfO8ubl2chHHm5/JkDvWApKWCdx6hY=;\n b=eizqogNCM+bu3pgx5s1d4W3nEyKQfRABRYqdIsW+PGbiyasesfG58B97dJVHdaeyed\n IVsz+ps18rOiSy5G4vr/N5Qg/AD9p8V2GWdEROI6pj2iKzeIAmo5dqnzbCAICUbDlEtT\n C+hetKYvjub3BysHrT6vp/OVy+r/OspmBMe0Mu0IQSaeGox/92jntuLaflo99L08Xufy\n W6Ny79PTOo/Q9c5oEBgIxi68rIIALH7wrZCc36rQjM1tfR2PEWGC+7fnxh1SHzXJ45Fp\n 42kz4Zg/aGMYJg0AMLc4XOOSgctrloHPfhBP5qUYFb4FMuV1AM0INquVQyd8lKvw7Quz\n z4vA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1695806532; x=1696411332;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=CjmV6Vw36svKzJfO8ubl2chHHm5/JkDvWApKWCdx6hY=;\n b=iG3FCPyv1Abo99ZDVa3wLAw9yqC3v6PEPOULwh8kCJ03nHVeMQrHCmiAU2rtAFj7ET\n vce492IcKfqcnrl2rmwNTfmluVav5SNfxJqiF6bw9S1GCksbxWKkY2N5xx+vx7/twTc/\n NnbaZhv/pAd/ifXpNEamSxLYV1QP2GCL0DuIjZBGQq6OIYKyjeUoOQAPe8N4/jmQqXzX\n Kp7i/LxwSfXyy9tCSeDJL64iNUOYySgM5VKElDW2U6rCLJUbgl8Yhs/Fzzpes4xKhe2e\n 7mYwEZakU6oSExUY7wwWJI4LURWigLdl8U9LxdMdc2HxLExfyuP5/ildWaq0YbkaQe+v\n DacQ==","X-Gm-Message-State":"AOJu0YwYPF6QZ9nmevkjkJYZ1pEgGZPwkQkPBUCLkIQPenzums3Hi/lM\n FwN+jGosIAyUz6ARWI24fmTQSd7gx4kTer4TO21hPlsMfzCnHlvN","X-Google-Smtp-Source":"\n AGHT+IFdKiYkfuL35X/2c+fEn6jF9hj9YErAmeFVlVo+qpcVmSwut59Sm2hXjWuYTEHgEbVxLTsQBmq9p4grkp2Ai3U=","X-Received":"by 2002:a05:6402:3d7:b0:532:b5cb:114a with SMTP id\n t23-20020a05640203d700b00532b5cb114amr1533743edw.23.1695806531900; Wed, 27\n Sep 2023 02:22:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20230926203946.3303600-2-eblake@redhat.com>","In-Reply-To":"<20230926203946.3303600-2-eblake@redhat.com>","From":"Peter Maydell ","Date":"Wed, 27 Sep 2023 10:21:53 +0100","Message-ID":"\n ","Subject":"Re: [PATCH] maint: Tweak comment in mailmap to sound friendlier","To":"eblake@redhat.com","Cc":"qemu-devel@nongnu.org, Andrey Drobyshev ","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::52e;\n envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3188634,"web_url":"http://patchwork.ozlabs.org/comment/3188634/","msgid":"","list_archive_url":null,"date":"2023-09-27T10:34:40","subject":"Re: [PATCH] maint: Tweak comment in mailmap to sound friendlier","submitter":{"id":87272,"url":"http://patchwork.ozlabs.org/api/people/87272/","name":"Andrey Drobyshev","email":"andrey.drobyshev@virtuozzo.com"},"content":"On 9/26/23 23:39, eblake@redhat.com wrote:\n> From: Eric Blake \n> \n> Documenting that we should not add new lines to work around SPF\n> rewrites sounds foreboding; the intent is instead that new lines here\n> are okay, but indicate a second problem elsewhere in our build process\n> that we should also consider fixing at the same time, to keep the\n> section from growing without bounds.\n> \n> Mentioning DMARC alongside SPF may also help people grep for this\n> scenario, as well as documenting the 'git config' workaround that can\n> be used by submitters to avoid the munging issue in the first place.\n> \n> Fixes: 3bd2608d (\"maint: Add .mailmap entries for patches claiming list authorship\")\n> CC: Andrey Drobyshev \n> Cc: Peter Maydell \n> Signed-off-by: Eric Blake \n> ---\n> \n> I'm sending this email with a temporary 'git config sendemail.from\n> eblake@redhat.com', to see if the added advice actually adds the extra\n> line. It did not show up in my editor window, though, so this patch\n> may need further tweaking to get the instructions right. Since I\n> don't normally suffer from SPF/DMARC munging, I may not be the best\n> person to test the right workaround. Or maybe 'git config' does not\n> yet have the right workaround already available as a turnkey solution\n> we can suggest.\n> \n\nThe only drawback of this approach is that mail clients, as well as\ntools like patchew.org now only show your \"\" in From/Author\nfield. You can see it here:\n\nhttps://patchew.org/search?q=project%3AQEMU+from%3ABlake\n\nIn your email there're 2 \"From:\" fields now:\n\n> Headers...\n> From: eblake@redhat.com\n> More headers...\n> From: Eric Blake \n> Actual patch\n\nApparently, mail clients prefer to pay attention on the very first\n\"From:\" entry, while tools like \"git am\" -- on the last. If we managed\nto make those entries both be in the format \"name \" -- that'd be\nideal. However, as I pointed out in another thread, if we set\nsendemail.from to \"name \", the 2nd entry doesn't get added since\nthey're now identical. So you figure out the way to get 2 identical\n\"From:\" entries -- please let us know.\n\nHaving all that said, it would still be nice to have additional checks\nfor \"qemu-block@nongnu.org\" authorship, as Peter mentioned in the\nprevious thread.\n\nAndrey","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=virtuozzo.com header.i=@virtuozzo.com\n header.a=rsa-sha256 header.s=selector2 header.b=sx+W7qBW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=virtuozzo.com;"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwY3249Sxz1ynX\n\tfor ; Wed, 27 Sep 2023 20:37:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlRuw-0006tM-Vv; Wed, 27 Sep 2023 06:37:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlRuu-0006tC-B3\n for qemu-devel@nongnu.org; Wed, 27 Sep 2023 06:37:16 -0400","from mail-he1eur04on2115.outbound.protection.outlook.com\n ([40.107.7.115] helo=EUR04-HE1-obe.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlRur-0007vV-JC\n for qemu-devel@nongnu.org; Wed, 27 Sep 2023 06:37:16 -0400","from HE1PR0802MB2331.eurprd08.prod.outlook.com (2603:10a6:3:c1::13)\n by AM8PR08MB6386.eurprd08.prod.outlook.com (2603:10a6:20b:362::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Wed, 27 Sep\n 2023 10:32:05 +0000","from HE1PR0802MB2331.eurprd08.prod.outlook.com\n ([fe80::4190:cf8e:abd7:68c8]) by HE1PR0802MB2331.eurprd08.prod.outlook.com\n ([fe80::4190:cf8e:abd7:68c8%11]) with mapi id 15.20.6838.016; Wed, 27 Sep\n 2023 10:32:05 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=gmzcLLy44G6gLMBx7ZlgTAdDIDrm3l26Qc7n8+acD0eguX8lj7jfC16ijrYGvNsfusDXJCwtxIwXlwo4T8LJTHTKItyB/exIeX4SihmTPuw4SKcqYOSKI8z6ymQoVUKcbxXpUnnga9J+W0bmYwe2qZkhZutToq+LFdhxb+PpF/LEQJhXPiTjKFdHTUmYufUMYy50Z7by6gLGagp9C2gyZMyjp1+1DYy2fDIo1Pn8zl1dnUTWmYDxJVSGB7AK/t2Z9VVC0ST0BG0HAVZFb22BXI5p0keNC0YkVn1FPJXY37w34019wtEB+VRStaie1gvAGOVKEeOIwULl5e5wZdS6KA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=X4B1df9Ig5BApzHAoZXkipA8Rwn6UBhb9XtPgFUuPTs=;\n b=CAWPDHYWzgQofHtvEq6T7KnCenvcLS3agaDBRldzB8U4bke26QHqS8cuBej/wUeZMP/40fSVgrrTKOwQnubmyx7MdWffgaLUVNDmFQh9V/d46WIPjECJMJzWnyG4YCrR6DXEHTID26TFqydGKwTYBMiCpLXn42MZYKf/KFHSHrc8fculcqzEHsT8lVkez+49X7Rqs3bLiCsE1ZmeInocY/MSUPAcYEtJbOygeXu2WUeXdp+LLYAwRiOVFkcSsMezeyrLowf/aUbuTY8ShXvWj0z3eotUdTokE2hs5zES4La/LeKfMu8WWsT1ZuiigvDrYqfrYwvUd8pUBwes5uylJA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=virtuozzo.com; dmarc=pass action=none\n header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=X4B1df9Ig5BApzHAoZXkipA8Rwn6UBhb9XtPgFUuPTs=;\n b=sx+W7qBWSLz+bTqBSsOdyHzi5iKiVaeNwus37O1+ZJuXrKVu9okOtV507Scvcqz84j7WVPGblqmGzmjm6m9DinWkOfK1n+G878IHIZdzKpghhjmvAsAHX3H3DBHTzrmnsC33hA8M1HpYb8NMuzNgTUeZTjsnDMDXOtrtNddalEdY1OMskxA+YzS6w+e40wsiUPEyvctikRfA8ZkaTps+A52hANWdOvXS40EeL/PXmXXnvZQ2FhUCxNjpn0jjw7oqnTmNUVwsKUFTjk3bE8wjV7CNcbVxvOVwb82+T/0aMwkmC+irXozNfhgWhqOwd3pPvAJ7RZQ/N6Uxb3ODqBRhAw==","Message-ID":"","Date":"Wed, 27 Sep 2023 13:34:40 +0300","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] maint: Tweak comment in mailmap to sound friendlier","Content-Language":"en-US","To":"eblake@redhat.com, qemu-devel@nongnu.org","Cc":"Peter Maydell ","References":"<20230926203946.3303600-2-eblake@redhat.com>","From":"Andrey Drobyshev ","In-Reply-To":"<20230926203946.3303600-2-eblake@redhat.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR4P281CA0069.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:ce::9) To HE1PR0802MB2331.eurprd08.prod.outlook.com\n (2603:10a6:3:c1::13)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"HE1PR0802MB2331:EE_|AM8PR08MB6386:EE_","X-MS-Office365-Filtering-Correlation-Id":"02773b6a-995c-4f55-6f8c-08dbbf44fe3c","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"\n ijtC6yxIJbyrvho1xOl1TNAfojvK17ZjV+GvflI7BT+GPVyZeYirhWjBw5by8ml1FK4SmZ33QpHRjJPe2Xg0n1zsYDFWEPgJPlaPFwlN3hnZx6lriyoKF7vPq//c24Z3cvUhd7sTvAT0u9aysZz8kFryGXFYPNU4oUAR1NakN3dE5ND0iXAsjo5qi/Y1J9k5WW/n6bLzQ36m6AEww8T23EvOfUhT1kHXu2Eru3mSgnw6hEZVlmvC137alhT8/p6HH4P6OSB4PNB6DVnNumXupbh44co8pc8AcYT8ls49I0Twz0ZAeMw2/FGNZ/T+jBnYlvDTErdw9HbhKmT65azMebTrrm6v6hk1aR4CARYXYeyVH29oI+pbCHfwjFMrW9+yOmF9pbYuZnJAV7MOV6Qb8mAGSGC5vCzXPKDriyW/J6ofKyB35nskzhwP4fwreCLQB71CmMr5STCVtdyeiwRIbw8y/uFr2LtG76jWrqy1jNfB2X6t6UCw/6/kjUiLeT+DaF1mXczEMDAVKR8rneWMmftn/Iq/JF+OuEyYDTkOpgTGq2bXrb7J4okT2NBmQQW56UuCp1IN2TWiZMiFBaCqK0QgSleyXpopzahrlhYVk70u+bMIdHTgFwSIseiDsmAWilm4yik1QEqITeCOVVXBAA==","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:HE1PR0802MB2331.eurprd08.prod.outlook.com; PTR:;\n CAT:NONE;\n SFS:(13230031)(366004)(346002)(39850400004)(376002)(136003)(396003)(230922051799003)(451199024)(1800799009)(186009)(316002)(41300700001)(26005)(2906002)(8676002)(5660300002)(478600001)(66556008)(966005)(8936002)(66476007)(44832011)(66946007)(4326008)(31686004)(6486002)(53546011)(66899024)(6666004)(6506007)(6512007)(2616005)(36756003)(83380400001)(31696002)(38100700002)(86362001)(45980500001)(43740500002);\n DIR:OUT; SFP:1102;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?YBGY0F5MU9Yd3Aby8WD3FvgY9MhN?=\n\t=?utf-8?q?reXP2G6jENPhITCsb2VZo8wPTW1PAJy2Yh2XLjBx2MhIQG/uRa9yJI6y3neuDYu6Q?=\n\t=?utf-8?q?LOXWRLYJsx5xWCYLe4in7+n7wFZV9wJRrrm1qYB+tYYmIDvpSQwOmMboHyVvVybRJ?=\n\t=?utf-8?q?BY0UpNku8VrO6aa/ZSNaTIa7Xg4vzHOqP3pg3gadP8LfYZAm7z+oiP0EV32EzV6OB?=\n\t=?utf-8?q?3flS46Ibsy9nH3Hs7K/w93GVluqdL8xvW90N3Pa83+539ncrNoXtnvBgS8xsV5z12?=\n\t=?utf-8?q?VNSMhW3c1dW9swLRLt8KzkNGzypJ3HYsOD7cHqbgxDns5byqwGYZZ2Fkg0UokeisE?=\n\t=?utf-8?q?V+tWmxObo1dpSN0tdCvk0yPG80ik/cYtYxQGW8Q17CTRwnCfN5fWkI2aPfcGg7PK4?=\n\t=?utf-8?q?pztG/tdj21gn/x8kvAZCJnrqW2scW4MkeJN3TgcdMIASRASEPsVHgV8C4HQfOWC2P?=\n\t=?utf-8?q?iSGJKVd0BF8TQD0Itex5QV2SgQMhbZ0C4q5Mzo12HqubuDxC1gRGGER/7pVc/8L+f?=\n\t=?utf-8?q?tjmWcDgMTViI1z+AZMnvRToBDa1lbAcNaZrhYKNaMbf4WxTdc4kzfqYImRFWF3v2E?=\n\t=?utf-8?q?Y60446F2L5CB7vCkVQBr7oT0OB2WIBpy95szY4SmAtLxGSoXpV+iHpwgb+c+uRVjv?=\n\t=?utf-8?q?6OCGomv0zw+5dUZZjkWCqhJ7dVZ+vZPSasKcfDa46un0ycVSBYwtf3EUq3aODAcUE?=\n\t=?utf-8?q?re6S+xW+E+XfcQ4COgZ/XYwROUcZUOwS426w80Ve5jmfE1GF2dJgSPzYpxFKZ19kr?=\n\t=?utf-8?q?q7LbyTeceXrAV8iBnkJ2bJvSAzqyJw/P+UKIriBiRu28e4auYIRrXAEdOoxXkhZVj?=\n\t=?utf-8?q?yyflz1+9ZZsvnKTN3V5YvOkdaed7JOHoXUqjOSXY2cJd7/cr6Ncg1HEMwlsLUqJqa?=\n\t=?utf-8?q?xyH4lswNU2jZsWSBURKCCsSN8HsHuotNrWjyOMLZ3mc6358zvHeZQslGULdDml8rV?=\n\t=?utf-8?q?GXJjCO++79f6lp+BY0oCbtUwaPETrZxqR5XGC++BV5XxKZuotCg3CU9Esk8qR8xwQ?=\n\t=?utf-8?q?Qvq2RaStYl/tU5vHgXtZ+rFB8nQWe/5Pq7mP67Y3b389121NZQfbX3+DK68w7uZha?=\n\t=?utf-8?q?QVy+KSepSBHZnarpcfAet3Y4HxxvGfnv6MVRMPdL90YTo0YZczTLFhQ4rB6/z1v0L?=\n\t=?utf-8?q?aTj5z7o2OHOp4/PaOs+z4Q6C6twC/z999N/TBNtXlYNQb6kzgNfF3tHUWVo1fszxA?=\n\t=?utf-8?q?/R2eoxXmT2vycv1KsfYlL/VnBwj4CfkODrtVrjHLiLJAN65/Ip4FDy22Hqjgri0xJ?=\n\t=?utf-8?q?0pNtG88wi8+bF+srG+g/5cDr9LXd4Lh6lGCHyyU1LNLQKg6fEEKUGjjuc59HZaPvf?=\n\t=?utf-8?q?XrdkSL7MRY6mhquccdK3geMsWZs+Djmb/y2idybLel7ypsF26jmVj6WIS0MOs+mdF?=\n\t=?utf-8?q?EkQHX6sTfCaQ/k8pp/Rei4taJjG3hGWZpj8PgZaVeeecI0txzuK12GH/ax9scEdHg?=\n\t=?utf-8?q?Nt3bs9kSskGwPEYs2Dl/HqQZI2OcsKEyB2LKgryq/RizG30Zkxe9ihX27BDJynpzB?=\n\t=?utf-8?q?MPZBypE1OJRWRtaQmhjXJQq9TQb9Nj15f983OBIQ25nuBGJ0Zd0A+PM=3D?=","X-OriginatorOrg":"virtuozzo.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 02773b6a-995c-4f55-6f8c-08dbbf44fe3c","X-MS-Exchange-CrossTenant-AuthSource":"\n HE1PR0802MB2331.eurprd08.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"27 Sep 2023 10:32:04.8964 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"0bc7f26d-0264-416e-a6fc-8352af79c58f","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 1eKO76zjdTSdmVOHKhmLDRZc7+mWQ2xjKoCgG5aUyWRQCWYhvcBA50Snuf1RFZqzaZGXAwX05Fbuft1RNvpM+sITWrqvVTcdfQzaY8GQYVY=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM8PR08MB6386","Received-SPF":"pass client-ip=40.107.7.115;\n envelope-from=andrey.drobyshev@virtuozzo.com;\n helo=EUR04-HE1-obe.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3188829,"web_url":"http://patchwork.ozlabs.org/comment/3188829/","msgid":"","list_archive_url":null,"date":"2023-09-27T14:06:45","subject":"Re: [PATCH] maint: Tweak comment in mailmap to sound friendlier","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On Wed, Sep 27, 2023 at 01:34:40PM +0300, Andrey Drobyshev wrote:\n> On 9/26/23 23:39, eblake@redhat.com wrote:\n> > From: Eric Blake \n> > \n> > Documenting that we should not add new lines to work around SPF\n> > rewrites sounds foreboding; the intent is instead that new lines here\n> > are okay, but indicate a second problem elsewhere in our build process\n> > that we should also consider fixing at the same time, to keep the\n> > section from growing without bounds.\n> > \n> > Mentioning DMARC alongside SPF may also help people grep for this\n> > scenario, as well as documenting the 'git config' workaround that can\n> > be used by submitters to avoid the munging issue in the first place.\n> > \n> > Fixes: 3bd2608d (\"maint: Add .mailmap entries for patches claiming list authorship\")\n> > CC: Andrey Drobyshev \n> > Cc: Peter Maydell \n> > Signed-off-by: Eric Blake \n> > ---\n> > \n> > I'm sending this email with a temporary 'git config sendemail.from\n> > eblake@redhat.com', to see if the added advice actually adds the extra\n> > line. It did not show up in my editor window, though, so this patch\n> > may need further tweaking to get the instructions right. Since I\n> > don't normally suffer from SPF/DMARC munging, I may not be the best\n> > person to test the right workaround. Or maybe 'git config' does not\n> > yet have the right workaround already available as a turnkey solution\n> > we can suggest.\n> > \n> \n> The only drawback of this approach is that mail clients, as well as\n> tools like patchew.org now only show your \"\" in From/Author\n> field. You can see it here:\n> \n> https://patchew.org/search?q=project%3AQEMU+from%3ABlake\n\nIndeed. But I think I know more now, so I'll try something slightly\ndifferent in v2.\n\n> \n> In your email there're 2 \"From:\" fields now:\n> \n> > Headers...\n> > From: eblake@redhat.com\n> > More headers...\n> > From: Eric Blake \n> > Actual patch\n\nNot quite - if you read the raw email, notice the blank line, which\nseparate true headers from the body. That is, the headers are:\n\n| From: eblake@redhat.com\n| More headers...\n| Subject:\n\nwhile the body starts:\n\n| From: Eric Blake \n| \n| rest of actual patch\n\n'git am' is already smart enough to prioritize the body's From: line\nover mail headers when re-creating authorship for a patch being\nimported into a maintainer's tree. But patchew currently favors the\nemail headers in its attributions.\n\n> \n> Apparently, mail clients prefer to pay attention on the very first\n> \"From:\" entry, while tools like \"git am\" -- on the last. If we managed\n> to make those entries both be in the format \"name \" -- that'd be\n> ideal. However, as I pointed out in another thread, if we set\n> sendemail.from to \"name \", the 2nd entry doesn't get added since\n> they're now identical. So you figure out the way to get 2 identical\n> \"From:\" entries -- please let us know.\n\nMy current working theory (to be tested in my upcoming v2 posting) is\nthat git compares two values: the author attribution (composed from\n'git config user.name' and 'git config user.email'), and the sendemail\nattribution (directly from 'git config sendemail.from'). If the two\ndiffer, then git format-email produces the one-liner 'From: real\nauthor ' based on commit authorship info as the first line\nin the body of the message; if they are the same (including when\nsendemail.from is missing, so git assumes you are sending your own\npatch and that your MUA will supply the same name), the body line is\nomitted. Meanwhile, when git feeds a file into sendemail, it omits a\nFrom: header by default (relying on your MUA to supply one - and your\nMUA probably picks the same spelling as your authorship), but includes\na From: header (which generally overrides your MUA's default) verbatim\nfrom sendemail.from if that was set, regardless of commit authorship\ninfo.\n\nThat would explain whey when you set sendemail.from to list your full\nname and email, you didn't get a body From: line. And when you omit\nthe real name in sendemail.from, the two definitely differ, so git\nincludes the body From: (I just demonstrated that when I posted this\nv1). But it may still be possible to force author attribution to be\nslightly different to sendemail.from, but still having a name in the\nFrom: line, so that patchew doesn't see a bare email without a name,\nall by intentionally spelling things differently. So my attempt for\nmy v2 patch, my settings will be:\n\n[user]\n name = Eric Blake\n email = eblake@redhat.com\n[sendemail]\n from = \"Eric Blake\" \n\nwith the hope that the addition of quotes (a semantic no-op from\nemail's point of view, but a different spelling from git's point of\nview) would be enough to cause git send-email to include a body From:\nline. Fingers crossed while I test it...\n\n> \n> Having all that said, it would still be nice to have additional checks\n> for \"qemu-block@nongnu.org\" authorship, as Peter mentioned in the\n> previous thread.\n\nYes, Peter found the spot, and mentioned his fix in the other thread.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fGpzMqKQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwdjD3gHnz1ynX\n\tfor ; Thu, 28 Sep 2023 00:07:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlVBr-0004pM-30; Wed, 27 Sep 2023 10:06:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qlVBp-0004ou-Ck\n for qemu-devel@nongnu.org; Wed, 27 Sep 2023 10:06:57 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qlVBn-0002kh-2u\n for qemu-devel@nongnu.org; Wed, 27 Sep 2023 10:06:57 -0400","from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-252-5iIs8nqLOnGr7GpZS6dd0Q-1; Wed, 27 Sep 2023 10:06:48 -0400","from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com\n [10.11.54.5])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 16E493C1F141;\n Wed, 27 Sep 2023 14:06:48 +0000 (UTC)","from redhat.com (unknown [10.2.16.59])\n by smtp.corp.redhat.com (Postfix) with ESMTPS id DADEC1678B;\n Wed, 27 Sep 2023 14:06:46 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695823613;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=HPGNQvknATW/BdBcZ/iMBceyfdKznF1WEfYvwP1SxM4=;\n b=fGpzMqKQZCAI8CwEfVBZV/gIG02QWmUr5sHa9QwyX2fUfUVvHKP/jQLBEPt8nRZ4H7Vttr\n HgLAnx5EE8KptUnSDIuVWVHhBriuASVKT/unzVnqxDRBE0guFVvudZiTyioMqC01p01Q9S\n KQ7scEHMin1gwUfYyEEv/Zhs5mS3ofw=","X-MC-Unique":"5iIs8nqLOnGr7GpZS6dd0Q-1","Date":"Wed, 27 Sep 2023 09:06:45 -0500","From":"Eric Blake ","To":"Andrey Drobyshev ","Cc":"qemu-devel@nongnu.org, Peter Maydell ","Subject":"Re: [PATCH] maint: Tweak comment in mailmap to sound friendlier","Message-ID":"","References":"<20230926203946.3303600-2-eblake@redhat.com>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20230517-449-a10573","X-Scanned-By":"MIMEDefang 3.1 on 10.11.54.5","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]