[{"id":3188193,"web_url":"http://patchwork.ozlabs.org/comment/3188193/","msgid":"","list_archive_url":null,"date":"2023-09-26T20:25:39","subject":"Re: [PATCH v2 2/8] util/filemonitor-inotify:\n qemu_file_monitor_watch(): assert no overflow","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 26 Sept 2023 at 21:15, Vladimir Sementsov-Ogievskiy\n wrote:\n>\n> Prefer clear assertions instead of [im]possible array overflow.\n>\n> Signed-off-by: Vladimir Sementsov-Ogievskiy \n> --\n\nReviewed-by: Peter Maydell \n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=qO5ntlKm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwB8c4LqDz1ynX\n\tfor ; Wed, 27 Sep 2023 06:26:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlEd8-0007oW-4N; Tue, 26 Sep 2023 16:26:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlEd6-0007mj-UF\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:26:00 -0400","from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1qlEd5-0005gg-3Y\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:26:00 -0400","by mail-lf1-x12a.google.com with SMTP id\n 2adb3069b0e04-5031ccf004cso15682897e87.2\n for ; Tue, 26 Sep 2023 13:25:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1695759957; x=1696364757; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=3D7SBdeuAjDBnPI4ZKbUT3u/gZaxJVcL2w+MISamGvg=;\n b=qO5ntlKm9aj6eSJ3LrVKeK9F6PK5pBdcBC5hojBsUe+4boX7ib0W2y8Dx3BdwP1tIR\n XreSageZKfGuvvS3s5vkN6IiZpk5DGQV89Mppb8E/JCQxhJ+dzBD9tdtP6Vl8ORySX36\n uSXX9dFF38YEH6b2JjnDG1CrQi7VNL12YPardTgX9KjM6uxyR3lSKWd641eBATokopk3\n XS728JCc5JYY3MA7aDs250iwUwwUkaT4GX+6cROarcExzEK3AEgFhpuXbC/qoVAduwKR\n +s29sOKAY99ifvogFYuEQeYh+AVNUWpKFMIcIKuoiuombGHYXJUjIejvzA1vkDdLgJFJ\n qD6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1695759957; x=1696364757;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=3D7SBdeuAjDBnPI4ZKbUT3u/gZaxJVcL2w+MISamGvg=;\n b=uImxU038ikxf3U+83dyIFaHcbwFQ0yqYfvzY+kjp7XwhQbtNVOTpwmPHY1DbwkpBaB\n BO/4H/kVU87r3IPPQfZLYSDoBGvCSKjT6Pk+zA+OMEpZp2BHGcTTAq3WHdjadapNaw9n\n nM1n9f0n27aQTuM2y6hXkdwVIsb5lGhZAjwDzhBwKv0HFyphizX0PtyS8bZ2/BU+FKoQ\n FbSwHVk42792CF+Zzg9VjUKx9E12aCj4j5fmfXtsBBMRQu4CVoZ4CVVn2jeIZO9MRb79\n wpmt2iNtiO9pmvA5K26QNT/JgYIpH/CHOeBaPQM4FV2kS4Wita/NB/sHZmkQ0MFu9MLm\n jwZQ==","X-Gm-Message-State":"AOJu0Yyy4kS7aH1KepciPOqywjUOuoUjLxQxods6LWhCMDt1YfFK7EyY\n XZvlvNugjgIQ7NBaCcndrQIHVFqhqDZikSrNjOZrnQ==","X-Google-Smtp-Source":"\n AGHT+IFSgPXK9B2mi9RrMTiwoS1MfTct8B1TBtRKBuOLogGAH7HPstgwxVG69CjVKVy34X7rB/DIYUlAED5YvBrRsKQ=","X-Received":"by 2002:a05:6512:1282:b0:503:38c1:c848 with SMTP id\n u2-20020a056512128200b0050338c1c848mr11673805lfs.50.1695759957330; Tue, 26\n Sep 2023 13:25:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20230926201532.221152-1-vsementsov@yandex-team.ru>\n <20230926201532.221152-3-vsementsov@yandex-team.ru>","In-Reply-To":"<20230926201532.221152-3-vsementsov@yandex-team.ru>","From":"Peter Maydell ","Date":"Tue, 26 Sep 2023 21:25:39 +0100","Message-ID":"\n ","Subject":"Re: [PATCH v2 2/8] util/filemonitor-inotify:\n qemu_file_monitor_watch(): assert no overflow","To":"Vladimir Sementsov-Ogievskiy ","Cc":"qemu-devel@nongnu.org, pbonzini@redhat.com, yc-core@yandex-team.ru,\n davydov-max@yandex-team.ru,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::12a;\n envelope-from=peter.maydell@linaro.org; helo=mail-lf1-x12a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]