[{"id":3188192,"web_url":"http://patchwork.ozlabs.org/comment/3188192/","msgid":"","list_archive_url":null,"date":"2023-09-26T20:24:53","subject":"Re: [PATCH v2 1/8] hw/i386/intel_iommu: vtd_slpte_nonzero_rsvd():\n assert no overflow","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Tue, 26 Sept 2023 at 21:15, Vladimir Sementsov-Ogievskiy\n wrote:\n>\n> We support only 3- and 4-level page-tables, which is firstly checked in\n> vtd_decide_config(), then setup in vtd_init(). Than level fields are\n> checked by vtd_is_level_supported().\n>\n> So here we can't have level out from 1..4 inclusive range. Let's assert\n> it. That also explains Coverity that we are not going to overflow the\n> array.\n>\n> CID: 1487158, 1487186\n> Signed-off-by: Vladimir Sementsov-Ogievskiy \n> ---\n> hw/i386/intel_iommu.c | 23 ++++++++++++++++++++---\n> 1 file changed, 20 insertions(+), 3 deletions(-)\n\nReviewed-by: Peter Maydell \n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=elNbeTW9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4RwB7z0hdrz1ynX\n\tfor ; Wed, 27 Sep 2023 06:25:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlEcP-00075D-U0; Tue, 26 Sep 2023 16:25:17 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlEcO-000754-DJ\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:25:16 -0400","from mail-ed1-x529.google.com ([2a00:1450:4864:20::529])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1qlEcL-00054q-Rg\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:25:16 -0400","by mail-ed1-x529.google.com with SMTP id\n 4fb4d7f45d1cf-5346b64f17aso2345356a12.2\n for ; Tue, 26 Sep 2023 13:25:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1695759912; x=1696364712; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=th8qkzl/daAbQjQQ/cL3C0gpNypwTjBWkqsSFTd2ews=;\n b=elNbeTW9JUDso2puj+f3rmiq3R8j9TDoWd+IpHznFwkD7HUTQgfrHalxJ0QmWHXU2j\n Mucra3DrPKQWqXP75pgzzB+5lyr71BwwWXXlwt6oyXptr/GXODUX8Pd6RfD9ZytjdPTg\n awWz13e0M8ML6htyJvuvJLXIXwizfr02ftxPxtfol6bZWXHlxSr5mr0z+nvueJONEX/t\n dTmzbVtnKOpDTqTXf1Zzx4W2IOr5TezDqPG7Y1pEX9OiEzINjrv4c/ilozlOvE5FuW3G\n 2cuUfDntCgvKMsgNvg3lxqdcqfMLQ8f+IQNJJaC24QylcJmMRgFdrR2PRlafBn012hAK\n r8og==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1695759912; x=1696364712;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=th8qkzl/daAbQjQQ/cL3C0gpNypwTjBWkqsSFTd2ews=;\n b=PoH/7VECVGcFUWZoTQjFPOK+ImBlj/DWmT7p3nkXiJQo8Tl4dV89+EbTfp4joGEfoQ\n vI2lRZQPW0+zYHYqGcxOgh2w4OVYEilSL11sbMJGuNQFQMCakt/HMlDqUMr1/jJmimA4\n h57k7ZmTszzpGmdlzQeFM5WcX4eJ57Maq0tYJp1P+AmzvTQcgAFJoFll1V/4mKQTdyS4\n YYgXZjgGHL+l5MB98NeIO3yigvH1tRl3Jt1XzHjCoOE7c7AfEzq/oyEcbkuTSMMdTbk/\n ySlggFmA5wpO93PZaJPGXRyUODWGjbc3quZkk653YzGPBETkPRJqLLO8YQWwpSwWuWot\n swDw==","X-Gm-Message-State":"AOJu0YyHjkG+f0KTOlWE0+sitHF1GWyjkbwd7sGa9Ls6GT7Csw3lf5XU\n 1FJRSmLe/OlDLhNKqLrm2a/xH2e/E4vLbkLRp/WlZA==","X-Google-Smtp-Source":"\n AGHT+IFqJPFR+jjUoX8RzzPzULYEoIu8P5ZpryyyaumBdzGT431RCvIdmZzKSfFJV6l4lNmNhvTPnvyuoJYamRA+fGM=","X-Received":"by 2002:a05:6402:6d6:b0:523:4acb:7f41 with SMTP id\n n22-20020a05640206d600b005234acb7f41mr121214edy.14.1695759912033; Tue, 26 Sep\n 2023 13:25:12 -0700 (PDT)","MIME-Version":"1.0","References":"<20230926201532.221152-1-vsementsov@yandex-team.ru>\n <20230926201532.221152-2-vsementsov@yandex-team.ru>","In-Reply-To":"<20230926201532.221152-2-vsementsov@yandex-team.ru>","From":"Peter Maydell ","Date":"Tue, 26 Sep 2023 21:24:53 +0100","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/8] hw/i386/intel_iommu: vtd_slpte_nonzero_rsvd():\n assert no overflow","To":"Vladimir Sementsov-Ogievskiy ","Cc":"qemu-devel@nongnu.org, pbonzini@redhat.com, yc-core@yandex-team.ru,\n davydov-max@yandex-team.ru, \"Michael S. Tsirkin\" ,\n Peter Xu ,\n Jason Wang ,\n Marcel Apfelbaum ,\n Richard Henderson ,\n Eduardo Habkost ","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2a00:1450:4864:20::529;\n envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x529.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]